[Bug go/79443] libgo/math test fails on s390x (undefined symbols cosh, sinh, tanh, hasVX)

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79443

Ian Lance Taylor  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Ian Lance Taylor  ---
Fix committed to mainline.

[Bug go/79443] libgo/math test fails on s390x (undefined symbols cosh, sinh, tanh, hasVX)

[ian at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79443

--- Comment #5 from ian at gcc dot gnu.org  ---
Author: ian
Date: Mon Feb 13 17:37:02 2017
New Revision: 245397

URL: https://gcc.gnu.org/viewcvs?rev=245397=gcc=rev
Log:
PR go/79443
libgo: fix some s390x tests

Add `+build ignore` to ignore tests that rely on s390x assembly code
not yet implemented for gccgo.

Fixes GCC PR 79443.

Reviewed-on: https://go-review.googlesource.com/36909

Modified:
trunk/gcc/go/gofrontend/MERGE
trunk/libgo/go/crypto/sha256/fallback_test.go
trunk/libgo/go/math/export_s390x_test.go

[Bug go/79443] libgo/math test fails on s390x (undefined symbols cosh, sinh, tanh, hasVX)

[vogt at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79443

--- Comment #4 from Dominik Vogt  ---
No more than that, and the fix works.

(Except for the issue with cplx2.go that has been there from the start
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60181).

[Bug go/79443] libgo/math test fails on s390x (undefined symbols cosh, sinh, tanh, hasVX)

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79443

--- Comment #3 from Ian Lance Taylor  ---
Created attachment 40708
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40708=edit
crypto patch

This patch may fix the crypto/sha256 problem.

Any other problems?  `make check-target-libgo` should show all of them.

No need to open separate bugs for each one.

[Bug go/79443] libgo/math test fails on s390x (undefined symbols cosh, sinh, tanh, hasVX)

[vogt at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79443

--- Comment #2 from Dominik Vogt  ---
Yes, that fixes it.  Now there's another one in crypto/sha256.  Do you want me
to open another bug report for that?

--
fallback_test.go:19:5: error: reference to undefined name 'useAsm'
  if useAsm == false {
 ^
fallback_test.go:22:2: error: reference to undefined name 'useAsm'
  useAsm = false
  ^
fallback_test.go:23:17: error: reference to undefined name 'useAsm'
  defer func() { useAsm = true }()
 ^
FAIL: crypto/sha256
--

[Bug go/79443] libgo/math test fails on s390x (undefined symbols cosh, sinh, tanh, hasVX)

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79443

--- Comment #1 from Ian Lance Taylor  ---
Created attachment 40707
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40707=edit
Possible patch

Can you check whether this patch fixes the problem?  Thanks.