[Bug ipa/111571] [13/14 Regression] ICE in modify_call, at ipa-param-manipulation.cc:656
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111571 --- Comment #5 from GCC Commits --- The master branch has been updated by Martin Jambor : https://gcc.gnu.org/g:ca56b43105fc09021ec445f1978a17cd85ae5e0c commit r14-9794-gca56b43105fc09021ec445f1978a17cd85ae5e0c Author: Martin Jambor Date: Thu Apr 4 22:46:16 2024 +0200 ipa: Avoid duplicate replacements in IPA-SRA transformation phase When the analysis part of IPA-SRA figures out that it would split out a scalar part of an aggregate which is known by IPA-CP to contain a known constant, it skips it knowing that the transformation part looks at IPA-CP aggregate results too and does the right thing (which can include doing the propagation in GIMPLE because that is the last moment the parameter exists). However, when IPA-SRA wants to split out a smaller aggregate out of an aggregate, which happens to be of the same size as a known scalar constant at the same offset, the transformation bit fails to recognize the situation, tries to do both splitting and constant propagation and in PR 111571 testcase creates a nonsensical call statement on which the call redirection then ICEs. Fixed by making sure we don't try to do two replacements of the same part of the same parameter. The look-up among replacements requires these are sorted and this patch just sorts them if they are not already sorted before each new look-up. The worst number of sortings that can happen is number of parameters which are both split and have aggregate constants times param_ipa_max_agg_items (default 16). I don't think complicating the source code to optimize for this unlikely case is worth it but if need be, it can of course be done. gcc/ChangeLog: 2024-03-15 Martin Jambor PR ipa/111571 * ipa-param-manipulation.cc (ipa_param_body_adjustments::common_initialization): Avoid creating duplicate replacement entries. gcc/testsuite/ChangeLog: 2024-03-15 Martin Jambor PR ipa/111571 * gcc.dg/ipa/pr111571.c: New test.
[Bug ipa/111571] [13/14 Regression] ICE in modify_call, at ipa-param-manipulation.cc:656
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111571 --- Comment #4 from Martin Jambor --- I have proposed a fix on the mailing list: https://inbox.sourceware.org/gcc-patches/ri6r0gbwf7l@virgil.suse.cz/T/#u
[Bug ipa/111571] [13/14 Regression] ICE in modify_call, at ipa-param-manipulation.cc:656
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111571
Jakub Jelinek changed:
What|Removed |Added
CC||jakub at gcc dot gnu.org
Priority|P1 |P2
--- Comment #3 from Jakub Jelinek ---
GCC 13.{1,2} has been released with this bug, so P2.
[Bug ipa/111571] [13/14 Regression] ICE in modify_call, at ipa-param-manipulation.cc:656
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111571 Jeffrey A. Law changed: What|Removed |Added CC||law at gcc dot gnu.org Priority|P3 |P1
[Bug ipa/111571] [13/14 Regression] ICE in modify_call, at ipa-param-manipulation.cc:656
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111571
Noam Lewis changed:
What|Removed |Added
CC||noamlewis at google dot com
--- Comment #2 from Noam Lewis ---
Not sure if same bug or different, we encountered this:
gcc (Debian 13.2.0-4) 13.2.0
$ cat /tmp/example.c
typedef struct {
} a;
struct b {
short c
};
struct d e;
struct d {
struct {
struct b f
}
} inline g(struct b h) {
i();
fn3();
e.f = h;
return e;
}
typedef struct {
int n;
int j;
struct b k;
a l
} m;
static o(m h) {
p(h.n, h.l, 1);
g(h.k);
}
q() {
struct b r = {};
o((m){.2, .1, r, {}});
}
$ gcc-13 /tmp/example.c -O2 -c -w -freport-bug
during IPA pass: inline
/tmp/example.c: In function ‘q’:
/tmp/example.c:29:3: internal compiler error: in modify_call, at
ipa-param-manipulation.cc:656
29 | o((m){.2, .1, r, {}});
| ^
0x7fb9b73666c9 __libc_start_call_main
../sysdeps/nptl/libc_start_call_main.h:58
0x7fb9b7366784 __libc_start_main_impl
../csu/libc-start.c:360
Please submit a full bug report, with preprocessed source.
Please include the complete backtrace with any bug report.
See for instructions.
The bug is not reproducible, so it is likely a hardware or OS problem.
[Bug ipa/111571] [13/14 Regression] ICE in modify_call, at ipa-param-manipulation.cc:656
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111571 Andrew Pinski changed: What|Removed |Added Keywords||ice-on-valid-code Target Milestone|--- |13.3
