[Bug ipa/92971] Suspicious code in cgraph_edge_brings_all_agg_vals_for_node(), ipa-cp.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92971 --- Comment #7 from Martin Jambor --- Author: jamborm Date: Fri Jan 10 22:46:46 2020 New Revision: 280151 URL: https://gcc.gnu.org/viewcvs?rev=280151=gcc=rev Log: IPA-CP: Remove bogus static keyword (PR 92971) 2020-01-10 Martin Jambor Backport from mainline 2019-12-17 Martin Jambor PR ipa/92971 * ipa-cp.c (cgraph_edge_brings_all_agg_vals_for_node): Fix definition of values, release memory on exit. testsuite/ * gcc.dg/ipa/ipcp-agg-12.c: New test. Added: branches/gcc-8-branch/gcc/testsuite/gcc.dg/ipa/ipcp-agg-12.c Modified: branches/gcc-8-branch/gcc/ChangeLog branches/gcc-8-branch/gcc/ipa-cp.c branches/gcc-8-branch/gcc/testsuite/ChangeLog
[Bug ipa/92971] Suspicious code in cgraph_edge_brings_all_agg_vals_for_node(), ipa-cp.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92971 --- Comment #6 from Martin Jambor --- Author: jamborm Date: Fri Jan 10 19:30:56 2020 New Revision: 280131 URL: https://gcc.gnu.org/viewcvs?rev=280131=gcc=rev Log: IPA-CP: Remove bogus static keyword (PR 92971) 2020-01-10 Martin Jambor Backport from mainline 2019-12-17 Martin Jambor PR ipa/92971 * Ipa-cp.c (cgraph_edge_brings_all_agg_vals_for_node): Fix definition of values, release memory on exit. testsuite/ * gcc.dg/ipa/ipcp-agg-12.c: New test. Added: branches/gcc-9-branch/gcc/testsuite/gcc.dg/ipa/ipcp-agg-12.c Modified: branches/gcc-9-branch/gcc/ChangeLog branches/gcc-9-branch/gcc/ipa-cp.c branches/gcc-9-branch/gcc/testsuite/ChangeLog
[Bug ipa/92971] Suspicious code in cgraph_edge_brings_all_agg_vals_for_node(), ipa-cp.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92971 Martin Jambor changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #5 from Martin Jambor --- Fixed.
[Bug ipa/92971] Suspicious code in cgraph_edge_brings_all_agg_vals_for_node(), ipa-cp.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92971 --- Comment #4 from Martin Jambor --- Author: jamborm Date: Wed Dec 18 16:08:09 2019 New Revision: 279525 URL: https://gcc.gnu.org/viewcvs?rev=279525=gcc=rev Log: IPA-CP: Remove bogus static keyword (PR 92971) 2019-12-18 Martin Jambor PR ipa/92971 * ipa-cp.c (cgraph_edge_brings_all_agg_vals_for_node): Fix definition of values, release memory on exit. testsuite/ * gcc.dg/ipa/ipcp-agg-12.c: New test. Added: trunk/gcc/testsuite/gcc.dg/ipa/ipcp-agg-12.c Modified: trunk/gcc/ChangeLog trunk/gcc/ipa-cp.c trunk/gcc/testsuite/ChangeLog
[Bug ipa/92971] Suspicious code in cgraph_edge_brings_all_agg_vals_for_node(), ipa-cp.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92971 Martin Jambor changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed||2019-12-17 Assignee|unassigned at gcc dot gnu.org |jamborm at gcc dot gnu.org Ever confirmed|0 |1 --- Comment #3 from Martin Jambor --- I'll remove it with https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01186.html
[Bug ipa/92971] Suspicious code in cgraph_edge_brings_all_agg_vals_for_node(), ipa-cp.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92971
--- Comment #2 from Martin Jambor ---
(In reply to fxue from comment #0)
> The variable "values" is defined as static, which makes a questionable side
> effect. History calls will impact result of current call!
>
> for (i = 0; i < count; i++)
> {
> static vec values = vNULL;
> class ipcp_param_lattices *plats;
Ugh, fortunately it is always assigned before the first use but it definitely
should not be a static variable, that is some sort of pasto. I'll prepare an
obvious patch. Thanks for spotting it.
[Bug ipa/92971] Suspicious code in cgraph_edge_brings_all_agg_vals_for_node(), ipa-cp.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92971 Jakub Jelinek changed: What|Removed |Added CC||jakub at gcc dot gnu.org, ||jamborm at gcc dot gnu.org --- Comment #1 from Jakub Jelinek --- This has been added in r193700, CCing author.
