[Bug libffi/102874] [12 regression] src/x86/win64.S doesn't assemble with Solaris as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874 Rainer Orth changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #11 from Rainer Orth --- Fixed for GCC 12.
[Bug libffi/102874] [12 regression] src/x86/win64.S doesn't assemble with Solaris as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874 --- Comment #10 from CVS Commits --- The master branch has been updated by Rainer Orth : https://gcc.gnu.org/g:a91f844ef449d0dd1cf2e0e47b0ade0d8a6304e1 commit r12-5262-ga91f844ef449d0dd1cf2e0e47b0ade0d8a6304e1 Author: Rainer Orth Date: Mon Nov 15 10:24:27 2021 +0100 libffi: Use #define instead of .macro in src/x86/win64.S [PR102874] The libffi 3.4.2 import badly broke Solaris/x86 bootstrap with the native assembler: Assembler: "/vol/gcc/src/hg/master/local/libffi/src/x86/win64.S", line 88 : Illegal mnemonic Near line: ".macro epilogue" "/vol/gcc/src/hg/master/local/libffi/src/x86/win64.S", line 88 : Syntax error Near line: ".macro epilogue" "/vol/gcc/src/hg/master/local/libffi/src/x86/win64.S", line 95 : Illegal mnemonic Near line: ".endm" "/vol/gcc/src/hg/master/local/libffi/src/x86/win64.S", line 95 : Syntax error Near line: ".endm" "/vol/gcc/src/hg/master/local/libffi/src/x86/win64.S", line 100 : Illegal mnemonic Near line: " epilogue" "/vol/gcc/src/hg/master/local/libffi/src/x86/win64.S", line 100 : Syntax error Near line: "epilogue" Solaris as doesn't support .macro/.endm. Fixed by using #define instead of the unportable .macro. Tested on i386-pc-solaris2.11 and x86_64-pc-linux-gnu. The bug has been reported upstream (https://github.com/libffi/libffi/issues/665); a corresponding pull request is also pending (https://github.com/libffi/libffi/pull/669). 2021-10-21 Rainer Orth libffi: PR libffi/102874 * src/x86/win64.S (epilogue): Use #define instead of .macro.
[Bug libffi/102874] [12 regression] src/x86/win64.S doesn't assemble with Solaris as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874 Rainer Orth changed: What|Removed |Added Status|NEW |ASSIGNED URL||https://gcc.gnu.org/piperma ||il/gcc-patches/2021-Novembe ||r/584438.html Assignee|unassigned at gcc dot gnu.org |ro at gcc dot gnu.org --- Comment #9 from Rainer Orth --- Mine, patch posted.
[Bug libffi/102874] [12 regression] src/x86/win64.S doesn't assemble with Solaris as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874 --- Comment #8 from H.J. Lu --- The proposed fix should be submitted to GCC and put it in libffi/LOCAL_PATCHES after it is checked in.
[Bug libffi/102874] [12 regression] src/x86/win64.S doesn't assemble with Solaris as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874 Hans-Peter Nilsson changed: What|Removed |Added CC||hp at gcc dot gnu.org --- Comment #7 from Hans-Peter Nilsson --- (In reply to H.J. Lu from comment #6) > (In reply to Richard Biener from comment #5) > > Upstream bug was filed and fix proposed. IMHO we don't need to wait and can > > pull this fix temporarily. > > Is there a pull request to fix it in upstream? I'll help: there -> https://github.com/libffi/libffi/pull/669
[Bug libffi/102874] [12 regression] src/x86/win64.S doesn't assemble with Solaris as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874 --- Comment #6 from H.J. Lu --- (In reply to Richard Biener from comment #5) > Upstream bug was filed and fix proposed. IMHO we don't need to wait and can > pull this fix temporarily. Is there a pull request to fix it in upstream?
[Bug libffi/102874] [12 regression] src/x86/win64.S doesn't assemble with Solaris as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874 Richard Biener changed: What|Removed |Added Keywords||build Status|WAITING |NEW Priority|P3 |P1 --- Comment #5 from Richard Biener --- Upstream bug was filed and fix proposed. IMHO we don't need to wait and can pull this fix temporarily.
[Bug libffi/102874] [12 regression] src/x86/win64.S doesn't assemble with Solaris as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874 --- Comment #4 from H.J. Lu --- (In reply to r...@cebitec.uni-bielefeld.de from comment #3) > > --- Comment #2 from H.J. Lu --- > > Does libffi 3.4.2 work on Solaris? If yes, why doesn't it work in gcc? > > It does when gcc is configured with gas, but doesn't when configured > with /bin/as. > > > If no, please fix the upstream and backport the fix. > > Done: https://github.com/libffi/libffi/issues/665. > > Depending on how this goes upstream, we may need a local fix: leaving > gcc master broken on Solaris/x86 isn't an option! The goal is to fix libffi in both upstream and GCC. Please do 1. Create a pull request to fix libffi upstream. 2. Submit the proposed fix to GCC. 3. After the proposed is checked into GCC, add it to libffi/LOCAL_PATCHES so that we keep it in GCC until it is fixed in upstream and synced. If libffi upstream is fixed before the proposed fix is checked into GCC, you can cherry-pick the fix from libffi upstream without touching libffi/LOCAL_PATCHES.
[Bug libffi/102874] [12 regression] src/x86/win64.S doesn't assemble with Solaris as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874 --- Comment #3 from ro at CeBiTec dot Uni-Bielefeld.DE --- > --- Comment #2 from H.J. Lu --- > Does libffi 3.4.2 work on Solaris? If yes, why doesn't it work in gcc? It does when gcc is configured with gas, but doesn't when configured with /bin/as. > If no, please fix the upstream and backport the fix. Done: https://github.com/libffi/libffi/issues/665. Depending on how this goes upstream, we may need a local fix: leaving gcc master broken on Solaris/x86 isn't an option!
[Bug libffi/102874] [12 regression] src/x86/win64.S doesn't assemble with Solaris as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874 H.J. Lu changed: What|Removed |Added Last reconfirmed||2021-10-21 Ever confirmed|0 |1 Status|UNCONFIRMED |WAITING --- Comment #2 from H.J. Lu --- Does libffi 3.4.2 work on Solaris? If yes, why doesn't it work in gcc? If no, please fix the upstream and backport the fix.
[Bug libffi/102874] [12 regression] src/x86/win64.S doesn't assemble with Solaris as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874 Rainer Orth changed: What|Removed |Added Target Milestone|--- |12.0
[Bug libffi/102874] [12 regression] src/x86/win64.S doesn't assemble with Solaris as
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874 --- Comment #1 from Rainer Orth --- Created attachment 51642 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51642=edit proposed patch
