https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
Richard Biener rguenth at gcc dot gnu.org changed:
What|Removed |Added
Keywords||build
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #17 from Kai Tietz ktietz at gcc dot gnu.org ---
Author: ktietz
Date: Wed Mar 25 15:05:02 2015
New Revision: 221665
URL: https://gcc.gnu.org/viewcvs?rev=221665root=gccview=rev
Log:
PR libgomp/64972
* oacc-parallel.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
Kai Tietz ktietz at gcc dot gnu.org changed:
What|Removed |Added
Status|NEW |RESOLVED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #6 from Jakub Jelinek jakub at gcc dot gnu.org ---
(In reply to Rainer Emrich from comment #5)
(In reply to Jakub Jelinek from comment #4)
And the suggested fix is just to cast to unsigned long and use %ld or %lx
instead of %zd
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #5 from Rainer Emrich rai...@emrich-ebersheim.de ---
(In reply to Jakub Jelinek from comment #4)
And the suggested fix is just to cast to unsigned long and use %ld or %lx
instead of %zd and %zx. I can't test it on these targets, so
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #8 from Rainer Emrich rai...@emrich-ebersheim.de ---
I'm testing the following on x86_64-w64-mingw32 at the moment.
Index: oacc-parallel.c
===
--- oacc-parallel.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #7 from Rainer Emrich rai...@emrich-ebersheim.de ---
Ok, here's the additional issue in oacc-parallel.c.
libtool: compile:
/opt/devel/SCRATCH/tmp.UotBZukqBt/gcc-5.0.0/gcc-5.0.0/./gcc/xgcc
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #11 from Jakub Jelinek jakub at gcc dot gnu.org ---
I wouldn't call %zd gnu-style, as it is POSIX.
Anyway, libgomp already uses inttypes.h, but only conditionally:
#ifdef HAVE_INTTYPES_H
fprintf (stderr, GOMP_SPINCOUNT =
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #9 from Mikael Pettersson mikpelinux at gmail dot com ---
Please note that sizeof(long) == 4 while sizeof(size_t) == sizeof(void*) == 8
on x86_64-w64-mingw32, so your patch changes the behaviour of the code.
Perhaps the change is
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #10 from Kai Tietz ktietz at gcc dot gnu.org ---
I agree that suggested patch changes here behavior on non LP64 targets.
Nevertheless it would be something to live by until we reach stage 1 to address
this more accurate.
To us
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
Thomas Schwinge tschwinge at gcc dot gnu.org changed:
What|Removed |Added
Keywords||openacc
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #14 from Jakub Jelinek jakub at gcc dot gnu.org ---
(In reply to Kai Tietz from comment #13)
Rainer: does following patch works for you?
Index: oacc-parallel.c
===
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #13 from Kai Tietz ktietz at gcc dot gnu.org ---
Rainer: does following patch works for you?
Index: oacc-parallel.c
===
--- oacc-parallel.c(Revision 221640)
+++
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #16 from Jakub Jelinek jakub at gcc dot gnu.org ---
(In reply to Kai Tietz from comment #15)
Ok, I am fine. So patch should be something like:
Patch preapproved for trunk with proper ChangeLog if it works on
i686-w64-mingw32,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #15 from Kai Tietz ktietz at gcc dot gnu.org ---
Ok, I am fine. So patch should be something like:
Index: oacc-parallel.c
===
--- oacc-parallel.c(Revision 221640)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
Kai Tietz ktietz at gcc dot gnu.org changed:
What|Removed |Added
Known to work||4.9.3
Known
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
--- Comment #4 from Jakub Jelinek jakub at gcc dot gnu.org ---
And the suggested fix is just to cast to unsigned long and use %ld or %lx
instead of %zd and %zx. I can't test it on these targets, so it is better if
somebody with M$ access writes
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64972
Kai Tietz ktietz at gcc dot gnu.org changed:
What|Removed |Added
Target Milestone|--- |5.0
18 matches
Mail list logo
