[Bug libobjc/78698] [7 regression] Using static PIC libgc fails when it has dependencies

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78698

Matthias Klose  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Matthias Klose  ---
fixed

[Bug libobjc/78698] [7 regression] Using static PIC libgc fails when it has dependencies

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78698

--- Comment #5 from Matthias Klose  ---
Author: doko
Date: Wed Jan 18 15:48:54 2017
New Revision: 244579

URL: https://gcc.gnu.org/viewcvs?rev=244579=gcc=rev
Log:
2017-01-18  Matthias Klose  

PR libobjc/78697
* configure.ac: Allow default for --with-target-bdw-gc-include.
* configure: Regenerate.

PR libobjc/78698
* configure.ac: Use the libgc.la file when available.
* configure: Regenerate.

2017-01-18  Matthias Klose  

   * doc/install.texi: Allow default for --with-target-bdw-gc-include.


Modified:
trunk/gcc/ChangeLog
trunk/gcc/doc/install.texi
trunk/libobjc/ChangeLog
trunk/libobjc/configure
trunk/libobjc/configure.ac

[Bug libobjc/78698] [7 regression] Using static PIC libgc fails when it has dependencies

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78698

--- Comment #4 from Matthias Klose  ---
patch posted at
https://gcc.gnu.org/ml/gcc-patches/2016-12/msg02004.html

[Bug libobjc/78698] [7 regression] Using static PIC libgc fails when it has dependencies

[doko at ubuntu dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78698

--- Comment #3 from Matthias Klose  ---
On 07.12.2016 17:06, egall at gwmail dot gwu.edu wrote:
> Note that some package managers automatically delete .la files as part of the
> installation process. I suppose it'd just fall through to the compile-and-link
> tests in that case, though, which might still work...

yes, it will. And I think it will still fail a --disable-shared build without
having a libgc.la.  The alternative would be to run the to-be-generated
LIBTOOL_COMPILE and LIBTOOL_LINK in the configure file. But I couldn't find any
references how that could be done.

[Bug libobjc/78698] [7 regression] Using static PIC libgc fails when it has dependencies

[egall at gwmail dot gwu.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78698

Eric Gallager  changed:

   What|Removed |Added

 CC||egall at gwmail dot gwu.edu

--- Comment #2 from Eric Gallager  ---
(In reply to Matthias Klose from comment #1)
> didn't check a configuration with --disable-shared :-/  What about checking
> for a $bdw_lib_dir/libgc.la and in that case setting BDW_GC_LIBS to
> $bdw_lib_dir/libgc.la and skipping the compile and link tests? I assume we
> could do a file check for the header file as well for this case.
> 
> --- configure.ac  (revision 243108)
> +++ configure.ac  (working copy)
> @@ -290,10 +293,19 @@
>AC_MSG_ERROR([no multilib path ($mldir) found in
> --with-target-bdw-gc-lib])
>  fi
>  BDW_GC_CFLAGS="-I$bdw_inc_dir"
> -BDW_GC_LIBS="-L$bdw_lib_dir -lgc"
> +if test -f $bdw_lib_dir/libgc.la; then
> +  BDW_GC_LIBS="$bdw_lib_dir/libgc.la"
> +else
> +  BDW_GC_LIBS="-L$bdw_lib_dir -lgc"
> +fi
>  AC_MSG_RESULT([found])
>fi
>  
> +  case "$BDW_GC_LIBS" in
> +  *libgc.la)
> +use_bdw_gc=yes
> +;;
> +  *)
>AC_MSG_CHECKING([for system boehm-gc])
>save_CFLAGS=$CFLAGS
>save_LIBS=$LIBS
> @@ -329,6 +341,7 @@
>  use_bdw_gc=yes
>  AC_MSG_RESULT([found])
>fi
> +  esac
>  esac
>  
>  if test "$use_bdw_gc" = no; then

Note that some package managers automatically delete .la files as part of the
installation process. I suppose it'd just fall through to the compile-and-link
tests in that case, though, which might still work...

[Bug libobjc/78698] [7 regression] Using static PIC libgc fails when it has dependencies

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78698

--- Comment #1 from Matthias Klose  ---
didn't check a configuration with --disable-shared :-/  What about checking for
a $bdw_lib_dir/libgc.la and in that case setting BDW_GC_LIBS to
$bdw_lib_dir/libgc.la and skipping the compile and link tests? I assume we
could do a file check for the header file as well for this case.

--- configure.ac(revision 243108)
+++ configure.ac(working copy)
@@ -290,10 +293,19 @@
   AC_MSG_ERROR([no multilib path ($mldir) found in
--with-target-bdw-gc-lib])
 fi
 BDW_GC_CFLAGS="-I$bdw_inc_dir"
-BDW_GC_LIBS="-L$bdw_lib_dir -lgc"
+if test -f $bdw_lib_dir/libgc.la; then
+  BDW_GC_LIBS="$bdw_lib_dir/libgc.la"
+else
+  BDW_GC_LIBS="-L$bdw_lib_dir -lgc"
+fi
 AC_MSG_RESULT([found])
   fi

+  case "$BDW_GC_LIBS" in
+  *libgc.la)
+use_bdw_gc=yes
+;;
+  *)
   AC_MSG_CHECKING([for system boehm-gc])
   save_CFLAGS=$CFLAGS
   save_LIBS=$LIBS
@@ -329,6 +341,7 @@
 use_bdw_gc=yes
 AC_MSG_RESULT([found])
   fi
+  esac
 esac

 if test "$use_bdw_gc" = no; then

[Bug libobjc/78698] [7 regression] Using static PIC libgc fails when it has dependencies

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78698

Jakub Jelinek  changed:

   What|Removed |Added

   Priority|P3  |P4
 CC||jakub at gcc dot gnu.org

[Bug libobjc/78698] [7 regression] Using static PIC libgc fails when it has dependencies

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78698

Richard Biener  changed:

   What|Removed |Added

   Target Milestone|--- |7.0