[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2009-01-12 Thread bkoz at gcc dot gnu dot org
--- Comment #18 from bkoz at gcc dot gnu dot org 2009-01-12 21:36 --- fixed for 4.4.x/4.3.x -- bkoz at gcc dot gnu dot org changed: What|Removed |Added Statu

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2009-01-12 Thread bkoz at gcc dot gnu dot org
--- Comment #17 from bkoz at gcc dot gnu dot org 2009-01-12 21:32 --- Subject: Bug 36801 Author: bkoz Date: Mon Jan 12 21:32:19 2009 New Revision: 143310 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143310 Log: 2009-01-12 Benjamin Kosnik Jonathan Larmour

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2009-01-12 Thread bkoz at gcc dot gnu dot org
--- Comment #16 from bkoz at gcc dot gnu dot org 2009-01-12 20:57 --- Created an attachment (id=17080) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17080&action=view) for gcc-4_3-branch -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36801

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2009-01-07 Thread bkoz at gcc dot gnu dot org
--- Comment #15 from bkoz at gcc dot gnu dot org 2009-01-08 03:15 --- Subject: Bug 36801 Author: bkoz Date: Thu Jan 8 03:14:24 2009 New Revision: 143182 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143182 Log: 2009-01-07 Benjamin Kosnik Jonathan Larmour

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2009-01-07 Thread paolo dot carlini at oracle dot com
--- Comment #14 from paolo dot carlini at oracle dot com 2009-01-07 18:17 --- (In reply to comment #13) > Note that my original patch also included a trivial fix for concurrence.h > where > __GTHREAD_MUTEX_INIT_FUNCTION was called when it should have been > __GTHREAD_COND_INIT_FUNCTION

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2009-01-07 Thread jifl-bugzilla at jifvik dot org
--- Comment #13 from jifl-bugzilla at jifvik dot org 2009-01-07 18:03 --- The patch seems to be ok from my cursory checking, thanks! Note that my original patch also included a trivial fix for concurrence.h where __GTHREAD_MUTEX_INIT_FUNCTION was called when it should have been __GTHRE

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2009-01-07 Thread bkoz at gcc dot gnu dot org
--- Comment #12 from bkoz at gcc dot gnu dot org 2009-01-07 09:18 --- Created an attachment (id=17043) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17043&action=view) plus mt_allocator fixes This fixes these longstanding fails on darwin: FAIL: ext/mt_allocator/deallocate_local_

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2009-01-06 Thread bkoz at gcc dot gnu dot org
--- Comment #11 from bkoz at gcc dot gnu dot org 2009-01-07 03:56 --- Created an attachment (id=17042) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17042&action=view) patch version 2 Hey! Sorry about the delay on this. Please try the attached patch, and let me know if it works f

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2009-01-06 Thread bkoz at gcc dot gnu dot org
--- Comment #10 from bkoz at gcc dot gnu dot org 2009-01-07 03:40 --- Mine. -- bkoz at gcc dot gnu dot org changed: What|Removed |Added AssignedTo|unassigned at g

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2008-12-17 Thread paolo dot carlini at oracle dot com
--- Comment #9 from paolo dot carlini at oracle dot com 2008-12-17 17:21 --- Benjamin, any feedback on this? Thanks! -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36801

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2008-10-30 Thread jifl-bugzilla at jifvik dot org
--- Comment #8 from jifl-bugzilla at jifvik dot org 2008-10-30 13:10 --- Hi Benjamin, the copyright assignment is definitely sorted, and can be seen on copyright.list on fencepost.gnu.org now. Any reason for this not to go in (although I don't have commit perms)? Would it better for me

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2008-10-03 Thread jifl-bugzilla at jifvik dot org
--- Comment #7 from jifl-bugzilla at jifvik dot org 2008-10-04 02:54 --- To avoid any uncertainty, I arranged a copyright assignment. Unfortunately the FSF's copyright clerk left and there was a gap before the replacement started, but it just so happens that today he confirmed the assig

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2008-10-03 Thread paolo dot carlini at oracle dot com
--- Comment #6 from paolo dot carlini at oracle dot com 2008-10-03 22:42 --- Benjamin, any feedback on this? Thanks! -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36801

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2008-07-14 Thread jifl-bugzilla at jifvik dot org
--- Comment #5 from jifl-bugzilla at jifvik dot org 2008-07-15 01:19 --- Created an attachment (id=15909) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15909&action=view) Patch against 4.3.1 using a once variable to ensure safe initialisation Here's a patch, let me know what you

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2008-07-11 Thread jifl-bugzilla at jifvik dot org
--- Comment #4 from jifl-bugzilla at jifvik dot org 2008-07-12 01:53 --- I can't really work out how to provide a testcase as such. To reproduce it all I'm doing is: #include #include int main(int argc, char *argv[]) { std::cout << "Hello world" << std::endl; return 0; } The

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2008-07-11 Thread bkoz at gcc dot gnu dot org
--- Comment #3 from bkoz at gcc dot gnu dot org 2008-07-11 20:53 --- Hey Jonathan. It would be most helpful if you could come up with a test case. I know, it will be a pain and difficult, etc etc etc yadda yadda yadda, but really this would be enormously helpful. Instead of putting t

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2008-07-11 Thread paolo dot carlini at oracle dot com
--- Comment #2 from paolo dot carlini at oracle dot com 2008-07-11 13:36 --- CCing Benjamin... By the way, if the patch would be very short, the full Assignment would not be needed... -- paolo dot carlini at oracle dot com changed: What|Removed |

[Bug libstdc++/36801] config/cpu/generic/atomicity_mutex/atomicity.h incorrectly relies on global constructor ordering

2008-07-11 Thread jifl-bugzilla at jifvik dot org
--- Comment #1 from jifl-bugzilla at jifvik dot org 2008-07-11 13:03 --- On thinking about this a bit more, I think this would be a regression for the case where __GTHREAD_MUTEX_INIT is used. In the case of __GTHREAD_MUTEX_INIT_FUNCTION, I believe the previous implementation was also su