[Bug libstdc++/59161] GDB pretty printers: iterator->reference not printed

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59161

Jonathan Wakely  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Target Milestone|--- |5.5

--- Comment #15 from Jonathan Wakely  ---
Fixed for 5.5

[Bug libstdc++/59161] GDB pretty printers: iterator->reference not printed

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59161

--- Comment #14 from Jonathan Wakely  ---
Author: redi
Date: Thu May 18 09:23:38 2017
New Revision: 248182

URL: https://gcc.gnu.org/viewcvs?rev=248182=gcc=rev
Log:
PR59161 make pretty printers always return strings

Backport from mainline
2016-12-15  Jonathan Wakely  

PR libstdc++/59161
* python/libstdcxx/v6/printers.py (StdListIteratorPrinter.to_string)
(StdSlistIteratorPrinter.to_string, StdVectorIteratorPrinter.to_string)
(StdRbtreeIteratorPrinter.to_string, StdDequeIteratorPrinter.to_string)
(StdDebugIteratorPrinter.to_string): Return string instead of
gdb.Value.
* testsuite/libstdc++-prettyprinters/59161.cc: New test.

Added:
   
branches/gcc-5-branch/libstdc++-v3/testsuite/libstdc++-prettyprinters/59161.cc
Modified:
branches/gcc-5-branch/libstdc++-v3/ChangeLog
branches/gcc-5-branch/libstdc++-v3/python/libstdcxx/v6/printers.py

[Bug libstdc++/59161] GDB pretty printers: iterator->reference not printed

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59161

--- Comment #13 from Jonathan Wakely  ---
Author: redi
Date: Wed Feb 15 13:38:42 2017
New Revision: 245480

URL: https://gcc.gnu.org/viewcvs?rev=245480=gcc=rev
Log:
PR59161 make pretty printers always return strings

Backport from mainline
2016-12-15  Jonathan Wakely  

PR libstdc++/59161
* python/libstdcxx/v6/printers.py (StdListIteratorPrinter.to_string)
(StdSlistIteratorPrinter.to_string, StdVectorIteratorPrinter.to_string)
(StdRbtreeIteratorPrinter.to_string, StdDequeIteratorPrinter.to_string)
(StdDebugIteratorPrinter.to_string): Return string instead of
gdb.Value.
* testsuite/libstdc++-prettyprinters/59161.cc: New test.

Added:
   
branches/gcc-6-branch/libstdc++-v3/testsuite/libstdc++-prettyprinters/59161.cc
Modified:
branches/gcc-6-branch/libstdc++-v3/ChangeLog
branches/gcc-6-branch/libstdc++-v3/python/libstdcxx/v6/printers.py

[Bug libstdc++/59161] GDB pretty printers: iterator->reference not printed

[palves at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59161

--- Comment #12 from Pedro Alves  ---
> So I think the libstdc++ part is fixed, 

Thanks.  TBC, given the pointer example in comment #9, I think GDB's implicit
use of options.addressprint=off for pretty printers is a clear GDB bug.  I
think GDB should change here, somehow.

> do we want a GDB bug to consider 
> changing how reference members are displayed? (I think printing the value as 
> well as the address makes sense).

Given we don't auto-deref pointers in structs either, I'm a bit undecided.
But filing a bug might be good, to see if others have opinions.  I'll take care
of it.

[Bug libstdc++/59161] GDB pretty printers: iterator-reference not printed

[jan.kratochvil at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59161

--- Comment #2 from Jan Kratochvil jan.kratochvil at redhat dot com ---
valid for: gcc-5.1.1-1.fc23.x86_64

[Bug libstdc++/59161] GDB pretty printers: iterator-reference not printed

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59161

Jonathan Wakely redi at gcc dot gnu.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2015-05-06
 Ever confirmed|0   |1

[Bug libstdc++/59161] GDB pretty printers: iterator-reference not printed

[jan.kratochvil at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59161

--- Comment #1 from Jan Kratochvil jan.kratochvil at redhat dot com ---
Tested with:
GNU gdb (GDB) 7.6.50.20131109-cvs
libstdcxx/v6/printers.py from GCC r201888 (=with PR libstdc++/53477 fix)