[Bug libstdc++/88170] [9 Regression] pretty printer FAILs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88170 --- Comment #7 from Will Wray --- Thanks for the fix - apologies again for the break. Works for me. I'd lost the trail but see now that pp_c_flag_gnu_v3 is set in error.c calls decl_as_dwarf_string lang_decl_dwarf_name in turn called from cp-lang.c cxx_dwarf_name and set up as a language hook lang_hooks::dwarf_name
[Bug libstdc++/88170] [9 Regression] pretty printer FAILs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88170 Jakub Jelinek changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Jakub Jelinek --- Fixed.
[Bug libstdc++/88170] [9 Regression] pretty printer FAILs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88170 --- Comment #5 from Jakub Jelinek --- Author: jakub Date: Thu Jan 31 07:37:34 2019 New Revision: 268413 URL: https://gcc.gnu.org/viewcvs?rev=268413=gcc=rev Log: PR libstdc++/88170 * c-pretty-print.c (pp_c_enumeration_constant): Print always as a C cast in pp_c_flag_gnu_v3 mode. * cxx-pretty-print.c (pp_cxx_enumeration_constant): Print always as a C cast in pp_c_flag_gnu_v3 mode. Modified: trunk/gcc/c-family/ChangeLog trunk/gcc/c-family/c-pretty-print.c trunk/gcc/cp/ChangeLog trunk/gcc/cp/cxx-pretty-print.c
[Bug libstdc++/88170] [9 Regression] pretty printer FAILs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88170 Jakub Jelinek changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org --- Comment #4 from Jakub Jelinek --- Created attachment 45569 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=45569=edit gcc9-pr88170.patch Untested fix. This patch just reverts the PR87364 change for names in debug info, and keeps them for the user visible diagnostics. I believe the C cast convention is better for debug info purposes, it can be interpreted more easily without figuring out context, and information is lost in any case, if there are multiple enumerators with the same value, the compiler will not remember which one was used in the source.
[Bug libstdc++/88170] [9 Regression] pretty printer FAILs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88170 --- Comment #3 from Jonathan Wakely --- Looks like these warnings were mentioned in PR 87634 comment 4, but nobody noticed the resulting test failures.
[Bug libstdc++/88170] [9 Regression] pretty printer FAILs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88170 Jonathan Wakely changed: What|Removed |Added CC||wjwray at gmail dot com --- Comment #2 from Jonathan Wakely --- This was caused by the patch for PR 87364 (r265077 and r265078). Presumably GDB can no longer recognise the RTTI for shared_ptr because the demangled name no longer looks like (__gnu_cxx::_Lock_policy)2. The patch breaks existing functionality. Looks like it was not sufficiently tested.
[Bug libstdc++/88170] [9 Regression] pretty printer FAILs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88170 Richard Biener changed: What|Removed |Added Priority|P3 |P1
[Bug libstdc++/88170] [9 Regression] pretty printer FAILs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88170 Richard Biener changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2018-11-26 Version|unknown |9.0 Target Milestone|--- |9.0 Summary|pretty printer FAILs|[9 Regression] pretty ||printer FAILs Ever confirmed|0 |1 --- Comment #1 from Richard Biener --- Confirmed.
