[Bug libstdc++/89825] Jump table for variant visitation could be shortened for never empty variants

2019-03-27 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89825

Ville Voutilainen  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Ville Voutilainen  ---
Fixed.

[Bug libstdc++/89825] Jump table for variant visitation could be shortened for never empty variants

2019-03-26 Thread ville at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89825

--- Comment #5 from ville at gcc dot gnu.org ---
Author: ville
Date: Tue Mar 26 15:00:05 2019
New Revision: 269947

URL: https://gcc.gnu.org/viewcvs?rev=269947=gcc=rev
Log:
PR libstdc++/89825

Fix based on a suggestion by Antony Polukhin.
* include/std/variant (_Extra_visit_slot_needed): New.
(_Multi_array): Use it.
(_S_apply_all_alts): Likewise.

Modified:
trunk/libstdc++-v3/ChangeLog
trunk/libstdc++-v3/include/std/variant

[Bug libstdc++/89825] Jump table for variant visitation could be shortened for never empty variants

2019-03-26 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89825

Ville Voutilainen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ville.voutilainen at gmail dot 
com
   Assignee|unassigned at gcc dot gnu.org  |ville.voutilainen at 
gmail dot com

[Bug libstdc++/89825] Jump table for variant visitation could be shortened for never empty variants

2019-03-26 Thread antoshkka at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89825

--- Comment #4 from Antony Polukhin  ---
> Would you be willing to complete a copyright assignment for contributions to
> GCC?

Yes, I can do that. Please send the instructions to my email.

[Bug libstdc++/89825] Jump table for variant visitation could be shortened for never empty variants

2019-03-26 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89825

--- Comment #3 from Jonathan Wakely  ---
(In reply to Jonathan Wakely from comment #2)
> Would you be willing to complete a copyright assignment for contributions to
> GCC?

And then ideally, make lots more contributions :-)

[Bug libstdc++/89825] Jump table for variant visitation could be shortened for never empty variants

2019-03-26 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89825

Jonathan Wakely  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2019-03-26
 Ever confirmed|0   |1

--- Comment #2 from Jonathan Wakely  ---
N.B. we can't use this patch without a copyright assignment for GCC:
https://gcc.gnu.org/contribute.html

Posting patches we can't use is actually more harmful than helpful, because to
ensure we don't infringe your copyright we either have to avoid even reading
the patch, or try to solve the problem differently. Describing a suggeasted
solution without an actual patch is fine.

Would you be willing to complete a copyright assignment for contributions to
GCC?

[Bug libstdc++/89825] Jump table for variant visitation could be shortened for never empty variants

2019-03-26 Thread antoshkka at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89825

--- Comment #1 from Antony Polukhin  ---
There's a typo in proposed solution: it should be `&& !_Never_empty` in
`_Multi_array`.