[Bug libstdc++/96803] std::tuple chooses wrong constructor for uses-allocator construction
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96803 Jonathan Wakely changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Target Milestone|--- |8.5 --- Comment #9 from Jonathan Wakely --- Fixed for 8.5, 9.4 and 10.3
[Bug libstdc++/96803] std::tuple chooses wrong constructor for uses-allocator construction
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96803 --- Comment #7 from CVS Commits --- The releases/gcc-9 branch has been updated by Jonathan Wakely : https://gcc.gnu.org/g:132ddcc78c118a6ab52063193462bf2a6dbdae32 commit r9-8931-g132ddcc78c118a6ab52063193462bf2a6dbdae32 Author: Jonathan Wakely Date: Tue Sep 22 08:42:18 2020 +0100 libstdc++: Use correct argument type for __use_alloc, again [PR 96803] While backporting 5494edae83ad33c769bd1ebc98f0c492453a6417 I noticed that it's still not correct. I made the allocator-extended constructor use the right type for the uses-allocator construction detection, but I used an rvalue when it should be a const lvalue. This should fix it properly this time. libstdc++-v3/ChangeLog: PR libstdc++/96803 * include/std/tuple (_Tuple_impl(allocator_arg_t, Alloc, const _Tuple_impl&)): Use correct value category in __use_alloc call. * testsuite/20_util/tuple/cons/96803.cc: Check with constructors that require correct value category to be used. (cherry picked from commit 7825399092d572ce8ea82c4aa8dfeb65076b0e52)
[Bug libstdc++/96803] std::tuple chooses wrong constructor for uses-allocator construction
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96803 --- Comment #8 from CVS Commits --- The releases/gcc-8 branch has been updated by Jonathan Wakely : https://gcc.gnu.org/g:6e86f0926f8de014cb0b0218442812e9f3ea8e95 commit r8-10525-g6e86f0926f8de014cb0b0218442812e9f3ea8e95 Author: Jonathan Wakely Date: Tue Sep 22 09:39:33 2020 +0100 libstdc++: Use correct argument type for __use_alloc [PR 96803] The _Tuple_impl constructor for allocator-extended construction from a different tuple type uses the _Tuple_impl's own _Head type in the __use_alloc test. That is incorrect, because the argument tuple could have a different type. Using the wrong type might select the leading-allocator convention when it should use the trailing-allocator convention, or vice versa. This backport includes the value category fix from r11-3348. libstdc++-v3/ChangeLog: PR libstdc++/96803 * include/std/tuple (_Tuple_impl(allocator_arg_t, Alloc, const _Tuple_impl&)): Replace parameter pack with a type parameter and a pack and pass the first type to __use_alloc. * testsuite/20_util/tuple/cons/96803.cc: New test. (cherry picked from commit 5494edae83ad33c769bd1ebc98f0c492453a6417)
[Bug libstdc++/96803] std::tuple chooses wrong constructor for uses-allocator construction
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96803 --- Comment #6 from CVS Commits --- The releases/gcc-10 branch has been updated by Jonathan Wakely : https://gcc.gnu.org/g:5a981195bd80ad64475bbc24b7a4d222a6a6eff5 commit r10-8787-g5a981195bd80ad64475bbc24b7a4d222a6a6eff5 Author: Jonathan Wakely Date: Tue Sep 22 08:42:18 2020 +0100 libstdc++: Use correct argument type for __use_alloc, again [PR 96803] While backporting 5494edae83ad33c769bd1ebc98f0c492453a6417 I noticed that it's still not correct. I made the allocator-extended constructor use the right type for the uses-allocator construction detection, but I used an rvalue when it should be a const lvalue. This should fix it properly this time. libstdc++-v3/ChangeLog: PR libstdc++/96803 * include/std/tuple (_Tuple_impl(allocator_arg_t, Alloc, const _Tuple_impl&)): Use correct value category in __use_alloc call. * testsuite/20_util/tuple/cons/96803.cc: Check with constructors that require correct value category to be used. (cherry picked from commit 7825399092d572ce8ea82c4aa8dfeb65076b0e52)
[Bug libstdc++/96803] std::tuple chooses wrong constructor for uses-allocator construction
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96803 --- Comment #5 from CVS Commits --- The master branch has been updated by Jonathan Wakely : https://gcc.gnu.org/g:7825399092d572ce8ea82c4aa8dfeb65076b0e52 commit r11-3348-g7825399092d572ce8ea82c4aa8dfeb65076b0e52 Author: Jonathan Wakely Date: Tue Sep 22 08:42:18 2020 +0100 libstdc++: Use correct argument type for __use_alloc, again [PR 96803] While backporting 5494edae83ad33c769bd1ebc98f0c492453a6417 I noticed that it's still not correct. I made the allocator-extended constructor use the right type for the uses-allocator construction detection, but I used an rvalue when it should be a const lvalue. This should fix it properly this time. libstdc++-v3/ChangeLog: PR libstdc++/96803 * include/std/tuple (_Tuple_impl(allocator_arg_t, Alloc, const _Tuple_impl&)): Use correct value category in __use_alloc call. * testsuite/20_util/tuple/cons/96803.cc: Check with constructors that require correct value category to be used.
[Bug libstdc++/96803] std::tuple chooses wrong constructor for uses-allocator construction
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96803 --- Comment #4 from CVS Commits --- The releases/gcc-9 branch has been updated by Jonathan Wakely : https://gcc.gnu.org/g:4be18e2f16bccad652c7deddf04284804d7be530 commit r9-8930-g4be18e2f16bccad652c7deddf04284804d7be530 Author: Jonathan Wakely Date: Wed Aug 26 19:32:30 2020 +0100 libstdc++: Use correct argument type for __use_alloc [PR 96803] The _Tuple_impl constructor for allocator-extended construction from a different tuple type uses the _Tuple_impl's own _Head type in the __use_alloc test. That is incorrect, because the argument tuple could have a different type. Using the wrong type might select the leading-allocator convention when it should use the trailing-allocator convention, or vice versa. libstdc++-v3/ChangeLog: PR libstdc++/96803 * include/std/tuple (_Tuple_impl(allocator_arg_t, Alloc, const _Tuple_impl&)): Replace parameter pack with a type parameter and a pack and pass the first type to __use_alloc. * testsuite/20_util/tuple/cons/96803.cc: New test. (cherry picked from commit 5494edae83ad33c769bd1ebc98f0c492453a6417)
[Bug libstdc++/96803] std::tuple chooses wrong constructor for uses-allocator construction
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96803 --- Comment #3 from CVS Commits --- The releases/gcc-10 branch has been updated by Jonathan Wakely : https://gcc.gnu.org/g:248cca20c763bdb43af0628fb04e131868493cd2 commit r10-8786-g248cca20c763bdb43af0628fb04e131868493cd2 Author: Jonathan Wakely Date: Wed Aug 26 19:32:30 2020 +0100 libstdc++: Use correct argument type for __use_alloc [PR 96803] The _Tuple_impl constructor for allocator-extended construction from a different tuple type uses the _Tuple_impl's own _Head type in the __use_alloc test. That is incorrect, because the argument tuple could have a different type. Using the wrong type might select the leading-allocator convention when it should use the trailing-allocator convention, or vice versa. libstdc++-v3/ChangeLog: PR libstdc++/96803 * include/std/tuple (_Tuple_impl(allocator_arg_t, Alloc, const _Tuple_impl&)): Replace parameter pack with a type parameter and a pack and pass the first type to __use_alloc. * testsuite/20_util/tuple/cons/96803.cc: New test. (cherry picked from commit 5494edae83ad33c769bd1ebc98f0c492453a6417)
[Bug libstdc++/96803] std::tuple chooses wrong constructor for uses-allocator construction
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96803 --- Comment #2 from CVS Commits --- The master branch has been updated by Jonathan Wakely : https://gcc.gnu.org/g:5494edae83ad33c769bd1ebc98f0c492453a6417 commit r11-2887-g5494edae83ad33c769bd1ebc98f0c492453a6417 Author: Jonathan Wakely Date: Wed Aug 26 19:32:30 2020 +0100 libstdc++: Use correct argument type for __use_alloc [PR 96803] The _Tuple_impl constructor for allocator-extended construction from a different tuple type uses the _Tuple_impl's own _Head type in the __use_alloc test. That is incorrect, because the argument tuple could have a different type. Using the wrong type might select the leading-allocator convention when it should use the trailing-allocator convention, or vice versa. libstdc++-v3/ChangeLog: PR libstdc++/96803 * include/std/tuple (_Tuple_impl(allocator_arg_t, Alloc, const _Tuple_impl&)): Replace parameter pack with a type parameter and a pack and pass the first type to __use_alloc. * testsuite/20_util/tuple/cons/96803.cc: New test.
[Bug libstdc++/96803] std::tuple chooses wrong constructor for uses-allocator construction
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96803 --- Comment #1 from Jonathan Wakely --- This is not a regression, it's been wrong since I added uses-allocator construction in r174443.
[Bug libstdc++/96803] std::tuple chooses wrong constructor for uses-allocator construction
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96803 Jonathan Wakely changed: What|Removed |Added Last reconfirmed||2020-08-26 Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED
