--- Comment #33 from howarth at nitro dot med dot uc dot edu 2010-09-03
23:36 ---
Fixed at r163811.
--
howarth at nitro dot med dot uc dot edu changed:
What|Removed |Added
---
--- Comment #32 from hubicka at gcc dot gnu dot org 2010-09-03 12:26
---
Subject: Bug 44812
Author: hubicka
Date: Fri Sep 3 12:26:24 2010
New Revision: 163811
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=163811
Log:
PR lto/44812
* lto-cgraph.c (intput_node,
--- Comment #31 from hubicka at ucw dot cz 2010-09-01 14:42 ---
Subject: Re: m32 lto produces non-relocatable subtraction
expression errors
> Original -m32 lto testsuite failures due to "non-relocatable subtraction
> expression" errors were made latent by the commit...
Hmm, th
> Original -m32 lto testsuite failures due to "non-relocatable subtraction
> expression" errors were made latent by the commit...
Hmm, this does not make much sense. What changed?
Honza
--- Comment #30 from howarth at nitro dot med dot uc dot edu 2010-09-01
14:38 ---
Original -m32 lto testsuite failures due to "non-relocatable subtraction
expression" errors were made latent by the commit...
Author: ak
Date: Tue Aug 31 16:58:46 2010
New Revision: 163680
URL: http://gc
--- Comment #29 from iains at gcc dot gnu dot org 2010-08-27 17:38 ---
(In reply to comment #12)
> Subject: Re: m32 lto produces non-relocatable subtraction
> expression errors
>
> Hmm, actually the symbol is not changed, since it is externally visible
> symbol.
> I guess the
--- Comment #28 from howarth at nitro dot med dot uc dot edu 2010-08-27
14:15 ---
(In reply to comment #27)
> Created an attachment (id=21578)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21578&action=view) [edit]
> corrected m32 darwin lto fix using external
>
My mistake. The
--- Comment #27 from howarth at nitro dot med dot uc dot edu 2010-08-27
14:13 ---
Created an attachment (id=21578)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21578&action=view)
corrected m32 darwin lto fix using external
--
howarth at nitro dot med dot uc dot edu changed:
--- Comment #26 from howarth at nitro dot med dot uc dot edu 2010-08-27
13:59 ---
(In reply to comment #25)
> Created an attachment (id=21577)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21577&action=view) [edit]
> m32 darwin lto fix using external
>
This version almost works.
--- Comment #25 from howarth at nitro dot med dot uc dot edu 2010-08-27
13:54 ---
Created an attachment (id=21577)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21577&action=view)
m32 darwin lto fix using external
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44812
--- Comment #24 from howarth at nitro dot med dot uc dot edu 2010-08-27
12:10 ---
Testsuite results for m32_to_fix2.diff at
http://gcc.gnu.org/ml/gcc-testresults/2010-08/msg02690.html.
This approach completely fixes the darwin-specific lto failures on
x86_64-apple-darwin10.
--
http
--- Comment #23 from dominiq at lps dot ens dot fr 2010-08-27 10:30 ---
With the patch in comment #21 I get for powerpc-apple-darwin9
Running target unix/-m32
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /sw/share/dejagnu/config/unix.exp as gen
--- Comment #22 from howarth at nitro dot med dot uc dot edu 2010-08-27
00:44 ---
The m32_lto_fix2.diff patch expands the usage of DECL_WEAK into
gcc/lto-cgraph.c and is sufficient to eliminate all of the darwin-specific lto
failures at -m32. The only remaining ones are...
FAIL: g++.d
--- Comment #21 from howarth at nitro dot med dot uc dot edu 2010-08-27
00:42 ---
Created an attachment (id=21575)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21575&action=view)
patch which completely eliminates -m32 darwin lto failures
--
http://gcc.gnu.org/bugzilla/show_b
--- Comment #20 from dominiq at lps dot ens dot fr 2010-08-27 00:09 ---
The patch in comment #18 works also on powerpc-apple-darwin9:
Running target unix/-m32
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /sw/share/dejagnu/config/unix.exp as gen
--- Comment #19 from dominiq at lps dot ens dot fr 2010-08-26 20:03 ---
With the patch in comment #18, with -m64 I see the following failure
FAIL: gcc.dg/lto/ipareference2 c_lto_ipareference2_0.o-c_lto_ipareference2_1.o
execute -O1 -fwhopr -fwhole-program
which was only present with -
--- Comment #18 from howarth at nitro dot med dot uc dot edu 2010-08-26
16:01 ---
Jan's alternative patch...
Index: lto-cgraph.c
===
--- lto-cgraph.c(revision 163494)
+++ lto-cgraph.c(working copy)
@@ -1109
--- Comment #17 from howarth at nitro dot med dot uc dot edu 2010-08-26
10:18 ---
Testresults with proposed patch at
http://gcc.gnu.org/ml/gcc-testresults/2010-08/msg02586.html.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44812
--- Comment #16 from howarth at nitro dot med dot uc dot edu 2010-08-26
01:55 ---
Marking the symbols in_other_partitions as weak eliminates almost all of the
failures. I still get...
Running target unix/-m32
FAIL: gcc.dg/lto/20090213 c_lto_20090213_0.o-c_lto_20090213_1.o link, -O2
-fw
--- Comment #15 from howarth at nitro dot med dot uc dot edu 2010-08-26
01:40 ---
Created an attachment (id=21567)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21567&action=view)
patch to effectively mark symbol as weak_import
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=4
--- Comment #14 from howarth at nitro dot med dot uc dot edu 2010-08-24
15:40 ---
What about Mike's suggestions from Comment 33 of PR43729 ...
"If one bundles all the code into the wpa file, one can preserve
_good_ codegen, which is the other way to fix this."
--
http://gcc.gnu.or
--- Comment #13 from iains at gcc dot gnu dot org 2010-08-24 15:17 ---
(In reply to comment #12)
> Subject: Re: m32 lto produces non-relocatable subtraction
> expression errors
>
> Hmm, actually the symbol is not changed, since it is externally visible
> symbol.
ah, OK.
> as
--- Comment #12 from hubicka at ucw dot cz 2010-08-24 15:04 ---
Subject: Re: m32 lto produces non-relocatable subtraction
expression errors
Hmm, actually the symbol is not changed, since it is externally visible symbol.
I guess the problem would be that the symbol is used by 2
Hmm, actually the symbol is not changed, since it is externally visible symbol.
I guess the problem would be that the symbol is used by 2 units, so both of
them gets the declaration, but both of them gets the declaration with
initializer (not extern). To avoid duplicate definitions, varpool.c is t
--- Comment #11 from iains at gcc dot gnu dot org 2010-08-24 14:37 ---
essentially to turn the last comment around:
IIUC, if whopr changes a symbol from "external" to "local" then it needs to
register that symbol with machopic_define_symbol () -- and ensure that (*
targetm.encode_sect
--- Comment #10 from iains at gcc dot gnu dot org 2010-08-24 14:11 ---
(In reply to comment #9)
> (In reply to comment #5)
> > Hmm, the problem seems to be that partitioning puts mumble into one
> > partition,
> > while in first partition it uses local (IP) relative way to access it:
>
--- Comment #9 from iains at gcc dot gnu dot org 2010-08-24 13:47 ---
(In reply to comment #5)
> Hmm, the problem seems to be that partitioning puts mumble into one partition,
> while in first partition it uses local (IP) relative way to access it:
> movl_mumble-L001$pb(%ebx)
--- Comment #8 from hubicka at gcc dot gnu dot org 2010-08-24 13:44 ---
the following testcase:
__attribute__((visibility ("hidden"))) extern int mumble;
extern void abort (void);
extern void exit (int);
int
main ()
{
if (++mumble != 42)
abort ();
exit (0);
}
should compile to
--- Comment #7 from howarth at nitro dot med dot uc dot edu 2010-08-24
13:44 ---
(In reply to comment #5)
> Hmm, the problem seems to be that partitioning puts mumble into one partition,
> while in first partition it uses local (IP) relative way to access it:
> movl_mumble-L
--- Comment #6 from dominiq at lps dot ens dot fr 2010-08-24 13:17 ---
The same errors appear on powerpc-apple-darwin9 with both -m32 and -m64 (see
http://gcc.gnu.org/ml/gcc-testresults/2010-08/msg00777.html ).
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44812
--- Comment #5 from hubicka at gcc dot gnu dot org 2010-08-24 13:01 ---
Hmm, the problem seems to be that partitioning puts mumble into one partition,
while in first partition it uses local (IP) relative way to access it:
movl_mumble-L001$pb(%ebx), %eax
and assembler refuse i
--- Comment #4 from howarth at nitro dot med dot uc dot edu 2010-07-15
13:19 ---
At -m32 on x86_64-apple-darwin10, the test cases which fail due to symbols
being optimized away include...
FAIL: g++.dg/lto/20081118-1 cp_lto_20081118-1_0.o-cp_lto_20081118-1_1.o link,
-O2 -fwhopr
FAIL: g+
--- Comment #3 from howarth at nitro dot med dot uc dot edu 2010-07-04
15:25 ---
Created an attachment (id=21085)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21085&action=view)
assembly file gcc-dg-lto-2008-01.ltrans0.s
/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/gcc/
--- Comment #2 from howarth at nitro dot med dot uc dot edu 2010-07-04
15:24 ---
Created an attachment (id=21084)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21084&action=view)
assembly file 2008_1.s
/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/gcc/xgcc
-B/sw/src/fink.
--- Comment #1 from howarth at nitro dot med dot uc dot edu 2010-07-04
15:23 ---
Created an attachment (id=21082)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21082&action=view)
assembly file 2008_0.s
/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/gcc/xgcc
-B/sw/src/fink.
35 matches
Mail list logo
