--- Comment #23 from iains at gcc dot gnu dot org 2010-05-24 14:36 ---
Subject: Bug 43602
Author: iains
Date: Mon May 24 14:36:32 2010
New Revision: 159781
URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=159781
Log:
2010-05-24 Iain Sandoe ia...@gcc.gnu.org
PR
--- Comment #22 from iains at gcc dot gnu dot org 2010-05-19 14:54 ---
I would imagine that this will ultimately affect all EMUTLS targets even tho
it's against darwin.
tree-profile.c is generating gimple directly for the inserted statements -
AFAICT it's assuming that these don't
--- Comment #21 from iains at gcc dot gnu dot org 2010-05-15 15:40 ---
updated:
http://gcc.gnu.org/ml/gcc-patches/2010-05/msg01119.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43602
--- Comment #20 from developer at sandoe-acoustics dot co dot uk
2010-04-05 08:32 ---
see:
http://gcc.gnu.org/ml/gcc-patches/2010-04/msg00129.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43602
--- Comment #14 from howarth at nitro dot med dot uc dot edu 2010-04-01
11:27 ---
Reverting back to...
TREE_PUBLIC (ic_void_ptr_var) = 0;
in the proposed patch results in the missing symbols again.
Can we just leave...
TREE_PUBLIC (ic_void_ptr_var) = 1;
and find some way to
--- Comment #15 from rguenth at gcc dot gnu dot org 2010-04-01 13:25
---
Subject: Bug 43602
Author: rguenth
Date: Thu Apr 1 13:24:58 2010
New Revision: 157907
URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=157907
Log:
2010-04-01 Richard Guenther rguent...@suse.de
PR
--- Comment #16 from rguenth at gcc dot gnu dot org 2010-04-01 13:26
---
Fixed.
--
rguenth at gcc dot gnu dot org changed:
What|Removed |Added
--- Comment #17 from bonzini at gnu dot org 2010-04-01 15:42 ---
Subject: Re: ___emutls_v.__gcov_indirect_call_[counters|callee]
undefined on *-*-darwin*
On 04/01/2010 01:27 PM, howarth at nitro dot med dot uc dot edu wrote:
--- Comment #14 from howarth at nitro dot med dot uc
--- Comment #18 from howarth at nitro dot med dot uc dot edu 2010-04-01
16:00 ---
Paolo,
Is there any other debug info I can provide (on gcc trunk pre-reversion)
to help debug this issue? Also could you switch an x86_64 linux build of gcc
trunk over to using emutls and try to
--- Comment #19 from bonzini at gnu dot org 2010-04-01 16:01 ---
No, I don't have time to debug this further, sorry.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43602
--- Comment #1 from howarth at nitro dot med dot uc dot edu 2010-03-31
13:29 ---
The commit of the patch to eliminate race conditions in indirect value
profiling (r157822) hasn't triggered the same profile related testsuite
failures in any other target. This leads to two questions...
--- Comment #2 from howarth at nitro dot med dot uc dot edu 2010-03-31
13:42 ---
Richard Guenther has suggested that these two unresolved symbols need to be
exported. I'll test that this evening.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43602
--- Comment #3 from howarth at nitro dot med dot uc dot edu 2010-03-31
14:53 ---
Does this change applied to libmudflap (which we don't build on darwin) provide
a template for what we might need to do?
Author: jiez
Date: Fri Jan 23 04:58:03 2009
New Revision: 143583
URL:
--- Comment #4 from howarth at nitro dot med dot uc dot edu 2010-03-31
15:19 ---
If I am reading gcc/configure.ac correctly, darwin shouldn't using TLS in that
part of the build. So perhaps we just need to add a wrapper like...
Index: gcc/tree-profile.c
--- Comment #5 from howarth at nitro dot med dot uc dot edu 2010-03-31
15:23 ---
Of course this does beg the question of why other instances of...
DECL_TLS_MODEL ()=decl_default_tls_model ();
...such as...
DECL_TLS_MODEL (v) = decl_default_tls_model (v);
...in gcc/c-parser.c and...
--- Comment #6 from howarth at nitro dot med dot uc dot edu 2010-03-31
20:21 ---
Untested patch...
Index: varasm.c
===
--- varasm.c(revision 157893)
+++ varasm.c(working copy)
@@ -332,6 +332,7 @@
--- Comment #7 from dominiq at lps dot ens dot fr 2010-03-31 20:40 ---
+ assert (!targetm.have_tls TREE_CODE (decl) == VAR_DECL
+ DECL_THREAD_LOCAL_P (decl));
s/assert/gcc_assert/
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43602
--- Comment #8 from dominiq at lps dot ens dot fr 2010-03-31 20:54 ---
With the patch in comment #6, I get:
[macbook] f90/bug% gcc45 -fprofile-generate -O3
/opt/gcc/work/gcc/testsuite/gcc.dg/matrix/transpose-1.c
gcc45: Internal error: Segmentation fault (program cc1)
Program received
--- Comment #9 from howarth at nitro dot med dot uc dot edu 2010-03-31
21:05 ---
What happens if you revert the section...
@@ -353,8 +354,8 @@
struct tree_map *h, in;
void **loc;
- if (targetm.have_tls || decl == NULL || decl == error_mark_node
- || TREE_CODE (decl) !=
--- Comment #10 from howarth at nitro dot med dot uc dot edu 2010-03-31
23:30 ---
Is it expected that the lines...
/* Add code:
static gcov* __gcov_indirect_call_counters; // pointer to actual counter
static void* __gcov_indirect_call_callee; // actual callee address
*/
are
--- Comment #11 from howarth at nitro dot med dot uc dot edu 2010-03-31
23:51 ---
Those add code comments are from the patch first proposed...
http://gcc.gnu.org/ml/gcc-patches/2006-12/msg00918.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43602
--- Comment #12 from howarth at nitro dot med dot uc dot edu 2010-04-01
05:11 ---
Proposed patch posted to
http://gcc.gnu.org/ml/gcc-patches/2010-04/msg5.html.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43602
--- Comment #13 from howarth at nitro dot med dot uc dot edu 2010-04-01
05:13 ---
Created an attachment (id=20268)
-- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20268action=view)
proposed patch to fix visibility issues on darwin
--
23 matches
Mail list logo
