https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
--- Comment #11 from Marek Polacek mpolacek at gcc dot gnu.org ---
Author: mpolacek
Date: Fri Mar 27 09:33:20 2015
New Revision: 221723
URL: https://gcc.gnu.org/viewcvs?rev=221723root=gccview=rev
Log:
PR sanitizer/65583
* ubsan.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
Marek Polacek mpolacek at gcc dot gnu.org changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
--- Comment #9 from Marek Polacek mpolacek at gcc dot gnu.org ---
(In reply to Jakub Jelinek from comment #8)
So, can you try to schedule another
NEXT_PASS (pass_rebuild_cgraph_edges);
right after ubsan pass if that fixes it?
And then move
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
--- Comment #10 from Jakub Jelinek jakub at gcc dot gnu.org ---
Or just teach ubsan pass to add cgraph edges for the calls it adds (I believe
it doesn't remove any calls, just adds them). Guess that should be cheaper
than scheduling another
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
Marek Polacek mpolacek at gcc dot gnu.org changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Last
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
--- Comment #5 from Richard Biener rguenth at gcc dot gnu.org ---
Does Honzas patch Discover nothorow functions before into_ssa fix it?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
--- Comment #7 from Marek Polacek mpolacek at gcc dot gnu.org ---
OK, that was clearly bogus. The Discover nothorow functions before into_ssa
doesn't fix it.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
--- Comment #2 from Marek Polacek mpolacek at gcc dot gnu.org ---
Started with r221660, the following seems to fix it:
--- a/gcc/passes.c
+++ b/gcc/passes.c
@@ -425,7 +425,7 @@ public:
virtual bool gate (function *)
{
/* Don't
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
--- Comment #4 from Jakub Jelinek jakub at gcc dot gnu.org ---
Well, running the chkp pass queue for the sanitization doesn't make any sense.
So, most likely the problem is that ubsan pass? doesn't update cgraph edges or
something similar and
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
--- Comment #3 from Richard Biener rguenth at gcc dot gnu.org ---
Doesn't make sense to me.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
--- Comment #6 from Richard Biener rguenth at gcc dot gnu.org ---
Well, pass_local_optimization_passes immediately runs
NEXT_PASS (pass_fixup_cfg);
NEXT_PASS (pass_rebuild_cgraph_edges);
which should be the only effect of
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
--- Comment #8 from Jakub Jelinek jakub at gcc dot gnu.org ---
So, can you try to schedule another
NEXT_PASS (pass_rebuild_cgraph_edges);
right after ubsan pass if that fixes it?
And then move that right before ubsan and see if it is broken
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65583
Marek Polacek mpolacek at gcc dot gnu.org changed:
What|Removed |Added
Status|NEW |ASSIGNED
13 matches
Mail list logo
