[Bug target/108787] [13 Regression] libsodium miscompilation on power9 starting with r13-2107

2023-02-15 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108787 Jakub Jelinek changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug target/108787] [13 Regression] libsodium miscompilation on power9 starting with r13-2107

2023-02-15 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108787 --- Comment #10 from CVS Commits --- The master branch has been updated by Jakub Jelinek : https://gcc.gnu.org/g:3f71b82596e992eb6e53fe9bbd70a4b52bc908e8 commit r13-5999-g3f71b82596e992eb6e53fe9bbd70a4b52bc908e8 Author: Jakub Jelinek Date:

[Bug target/108787] [13 Regression] libsodium miscompilation on power9 starting with r13-2107

2023-02-14 Thread segher at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108787 --- Comment #9 from Segher Boessenkool --- (In reply to Jakub Jelinek from comment #7) > Created attachment 54460 [details] > gcc13-pr108787.patch That patch is preapproved, but please add a comment (before umaddditi4) saying we do not want

[Bug target/108787] [13 Regression] libsodium miscompilation on power9 starting with r13-2107

2023-02-14 Thread segher at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108787 --- Comment #8 from Segher Boessenkool --- (In reply to Jakub Jelinek from comment #6) > we used to emit in GCC 12 4/4/4/5 instructions: > mulld 9,3,4 > mulhdu 4,3,4 > addc 3,9,5 > adde 4,4,6 > and >

[Bug target/108787] [13 Regression] libsodium miscompilation on power9 starting with r13-2107

2023-02-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108787 --- Comment #7 from Jakub Jelinek --- Created attachment 54460 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54460=edit gcc13-pr108787.patch Patch that kills maddditi4 in addition to fixing umaddditi4. As mentioned above, in the

[Bug target/108787] [13 Regression] libsodium miscompilation on power9 starting with r13-2107

2023-02-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108787 --- Comment #6 from Jakub Jelinek --- --- gcc/config/rs6000/rs6000.md.jj 2023-01-16 11:52:16.036734757 +0100 +++ gcc/config/rs6000/rs6000.md 2023-02-14 19:46:13.915782702 +0100 @@ -3231,20 +3231,38 @@ (plus:TI (mult:TI

[Bug target/108787] [13 Regression] libsodium miscompilation on power9 starting with r13-2107

2023-02-14 Thread segher at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108787 Segher Boessenkool changed: What|Removed |Added Last reconfirmed||2023-02-14 Ever confirmed|0

[Bug target/108787] [13 Regression] libsodium miscompilation on power9 starting with r13-2107

2023-02-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108787 Jakub Jelinek changed: What|Removed |Added CC||segher at gcc dot gnu.org --- Comment

[Bug target/108787] [13 Regression] libsodium miscompilation on power9 starting with r13-2107

2023-02-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108787 --- Comment #3 from Jakub Jelinek --- --- gcc/config/rs6000/rs6000.md.jj 2023-01-16 11:52:16.036734757 +0100 +++ gcc/config/rs6000/rs6000.md 2023-02-14 18:53:25.071014954 +0100 @@ -3231,20 +3231,26 @@ (plus:TI (mult:TI

[Bug target/108787] [13 Regression] libsodium miscompilation on power9 starting with r13-2107

2023-02-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108787 --- Comment #2 from Jakub Jelinek --- In *.optimized dump it looks correct: d_16 = h2_14(D) w* s1_15(D); _19 = WIDEN_MULT_PLUS_EXPR ; d0_17 = WIDEN_MULT_PLUS_EXPR ; where WIDEN_MULT_EXPR has 2 64-bit unsigned operands and 128-bit result,

[Bug target/108787] [13 Regression] libsodium miscompilation on power9 starting with r13-2107

2023-02-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108787 --- Comment #1 from Jakub Jelinek --- Correction, -fPIC isn't important. Even more reduced testcase: __attribute__((noipa)) unsigned __int128 foo (unsigned long long h0, unsigned long long h1, unsigned long long h2, unsigned long long r0,

[Bug target/108787] [13 Regression] libsodium miscompilation on power9 starting with r13-2107

2023-02-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108787 Jakub Jelinek changed: What|Removed |Added Target Milestone|--- |13.0 Priority|P3