[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #22 from dominiq at gcc dot gnu.org --- Author: dominiq Date: Sat Apr 5 12:25:37 2014 New Revision: 209152 URL: http://gcc.gnu.org/viewcvs?rev=209152root=gccview=rev Log: 2012-04-06 Dominique d'Humieres domi...@lps.ens.fr Jack Howarth howa...@bromo.med.uc.edu PR target/54407 * 30_threads/condition_variable/54185.cc: Skip for darwin 11. Modified: branches/gcc-4_8-branch/libstdc++-v3/ChangeLog branches/gcc-4_8-branch/libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #23 from dominiq at gcc dot gnu.org --- Author: dominiq Date: Sat Apr 5 12:29:27 2014 New Revision: 209153 URL: http://gcc.gnu.org/viewcvs?rev=209153root=gccview=rev Log: 2012-04-05 Dominique d'Humieres domi...@lps.ens.fr Jack Howarth howa...@bromo.med.uc.edu PR target/54407 * 30_threads/condition_variable/54185.cc: Skip for darwin 11. Modified: branches/gcc-4_7-branch/libstdc++-v3/ChangeLog branches/gcc-4_7-branch/libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 Dominique d'Humieres dominiq at lps dot ens.fr changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #24 from Dominique d'Humieres dominiq at lps dot ens.fr --- Finally fixed.
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #21 from dominiq at gcc dot gnu.org --- Author: dominiq Date: Wed Apr 2 08:44:40 2014 New Revision: 209017 URL: http://gcc.gnu.org/viewcvs?rev=209017root=gccview=rev Log: 2014-04-02 Dominique d'Humieres domi...@lps.ens.fr Jack Howarth howa...@bromo.med.uc.edu PR target/54407 * testsuite/30_threads/condition_variable/54185.cc: Skip for darwin 11. Modified: trunk/libstdc++-v3/ChangeLog trunk/libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 Dominique d'Humieres dominiq at lps dot ens.fr changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2013-06-29 Ever confirmed|0 |1 --- Comment #19 from Dominique d'Humieres dominiq at lps dot ens.fr --- I posted this patch back in Oct as... http://gcc.gnu.org/ml/libstdc++/2012-10/msg00111.html Mike wanted a comment about an associated radar which doesn't exist. As far as I know this bug was fixed in the pthread rewrites for darwin11 and later. Could someone commit the patch?
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #20 from Paolo Carlini paolo.carlini at oracle dot com --- Commit *what*? Please add a link to something actually OKed.
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #18 from Jack Howarth howarth at nitro dot med.uc.edu 2013-03-11 14:51:01 UTC --- (In reply to comment #17) Jack, I see at http://gcc.gnu.org/ml/gcc-testresults/2012-11/msg00331.html that you have tested a fix for this PR. I have tested that it skips the test on powerpc-apple-darwin9 and x86_64-apple-darwin10. Have you submitted it? I posted this patch back in Oct as... http://gcc.gnu.org/ml/libstdc++/2012-10/msg00111.html Mike wanted a comment about an associated radar which doesn't exist. As far as I know this bug was fixed in the pthread rewrites for darwin11 and later.
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #17 from Dominique d'Humieres dominiq at lps dot ens.fr 2013-03-10 17:58:17 UTC --- Jack, I see at http://gcc.gnu.org/ml/gcc-testresults/2012-11/msg00331.html that you have tested a fix for this PR. I have tested that it skips the test on powerpc-apple-darwin9 and x86_64-apple-darwin10. Have you submitted it?
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #16 from Jonathan Wakely redi at gcc dot gnu.org 2012-10-16 10:07:31 UTC --- Agreed, please just disable the test entirely on the targets where it fails
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407
--- Comment #4 from Dominique d'Humieres dominiq at lps dot ens.fr 2012-10-14
17:08:09 UTC ---
I don't know of any workaround so disabling the test seems like a good option
What about
--- libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc2012-08-17
14:14:36.0 +0200
+++ ../work/libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc
2012-10-14 18:52:22.0 +0200
@@ -1,4 +1,5 @@
-// { dg-do run { target *-*-freebsd* *-*-netbsd* *-*-linux* *-*-solaris*
*-*-cygwin *-*-darwin* powerpc-ibm-aix* } }
+// { dg-do run { target *-*-freebsd* *-*-netbsd* *-*-linux* *-*-solaris*
*-*-cygwin *-*-darwin1[1-9]* powerpc-ibm-aix* } }
+// { dg-do compile { target *-*-darwin[4-9]* *-*-darwin10* } }
// { dg-options -std=gnu++0x -pthread { target *-*-freebsd* *-*-netbsd*
*-*-linux* powerpc-ibm-aix* } }
// { dg-options -std=gnu++0x -pthreads { target *-*-solaris* } }
// { dg-options -std=gnu++0x { target *-*-cygwin *-*-darwin* } }
? Jack could you verify that the test actually run on darwin(11|12) after the
patch? TIA.
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407
Jack Howarth howarth at nitro dot med.uc.edu changed:
What|Removed |Added
CC||howarth at nitro dot
||med.uc.edu
--- Comment #5 from Jack Howarth howarth at nitro dot med.uc.edu 2012-10-14
18:35:19 UTC ---
The patch in comment 4 with...
make -k check
RUNTESTFLAGS=conformance.exp=30_threads/condition_variable/54185.cc
--target_board=unix'{-m32,-m64}'
produces...
Native configuration is x86_64-apple-darwin11.4.2
=== libstdc++ tests ===
Schedule of variations:
unix/-m32
unix/-m64
Running target unix/-m32
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /sw/share/dejagnu/config/unix.exp as generic interface file for target.
Using
/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121007/libstdc++-v3/testsuite/config/default.exp
as tool-and-target-specific interface file.
Running
/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121007/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp
...
=== libstdc++ Summary for unix/-m32 ===
# of expected passes1
Running target unix/-m64
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /sw/share/dejagnu/config/unix.exp as generic interface file for target.
Using
/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121007/libstdc++-v3/testsuite/config/default.exp
as tool-and-target-specific interface file.
Running
/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121007/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp
...
=== libstdc++ Summary for unix/-m64 ===
# of expected passes1
=== libstdc++ Summary ===
# of expected passes2
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407
--- Comment #6 from Dominique d'Humieres dominiq at lps dot ens.fr 2012-10-14
19:06:32 UTC ---
The patch in comment 4 with...
make -k check
RUNTESTFLAGS=conformance.exp=30_threads/condition_variable/54185.cc
--target_board=unix'{-m32,-m64}'
produces...
Could you check in the log file that the test is actually run?
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407
--- Comment #7 from Jack Howarth howarth at nitro dot med.uc.edu 2012-10-14
20:14:01 UTC ---
(In reply to comment #6)
The patch in comment 4 with...
make -k check
RUNTESTFLAGS=conformance.exp=30_threads/condition_variable/54185.cc
--target_board=unix'{-m32,-m64}'
produces...
Could you check in the log file that the test is actually run?
The dg-compile line oddly seems to suppress the running of the compiled test.
Dropping that line gives...
Native configuration is x86_64-apple-darwin11.4.2
=== libstdc++ tests ===
Schedule of variations:
unix/-m32
unix/-m64
Running target unix/-m32
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /sw/share/dejagnu/config/unix.exp as generic interface file for target.
Using
/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121007/libstdc++-v3/testsuite/config/default.exp
as tool-and-target-specific interface file.
Running
/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121007/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp
...
=== libstdc++ Summary for unix/-m32 ===
# of expected passes2
Running target unix/-m64
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /sw/share/dejagnu/config/unix.exp as generic interface file for target.
Using
/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121007/libstdc++-v3/testsuite/config/default.exp
as tool-and-target-specific interface file.
Running
/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121007/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp
...
=== libstdc++ Summary for unix/-m64 ===
# of expected passes2
=== libstdc++ Summary ===
# of expected passes4
Why you want to bother to compile the test are darwins which can't safely run
it anyway. That seems rather pointless.
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407
--- Comment #8 from Dominique d'Humieres dominiq at lps dot ens.fr 2012-10-14
20:48:21 UTC ---
The dg-compile line oddly seems to suppress the running of the compiled test.
...
What happens if you replace the line
// { dg-do compile { target *-*-darwin[4-9]* *-*-darwin10* } }
with
// { dg-do compile { target *-*-darwin9* *-*-darwin10* } }
?
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407
--- Comment #9 from Jack Howarth howarth at nitro dot med.uc.edu 2012-10-14
20:53:56 UTC ---
(In reply to comment #8)
The dg-compile line oddly seems to suppress the running of the compiled
test. ...
What happens if you replace the line
// { dg-do compile { target *-*-darwin[4-9]* *-*-darwin10* } }
with
// { dg-do compile { target *-*-darwin9* *-*-darwin10* } }
?
Still suppresses the execution of the test on x86_64-apple-darwin12. Are there
any examples in the FSF gcc testsuites of dg-run being used at the same time as
dg-compile? I suspect that is an unsupported combination.
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407
--- Comment #10 from Jack Howarth howarth at nitro dot med.uc.edu 2012-10-14
21:12:20 UTC ---
I think you need to use...
// { dg-xfail-if broken pthreads before darwin10 { *-*-darwin9* *-*-darwin10*
} { * } { } }
instead of dg-do-compile. From
http://gcc.gnu.org/onlinedocs/gcc-4.1.2/gccint/Test-Directives.html,
note...
If the directive includes the optional `{ xfail selector }' and the selector is
met then the test is expected to fail. For dg-do run, execution is expected to
fail but compilation is expected to pass.
since you already are passing dg-do-run a target selector, an additional
dg-xfail-if is required. This
combination works here on x86_64-apple-darwin12
Index: libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc
===
--- libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc(revision
192440)
+++ libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc(working
copy)
@@ -1,4 +1,5 @@
-// { dg-do run { target *-*-freebsd* *-*-netbsd* *-*-linux* *-*-solaris*
*-*-cygwin *-*-darwin* powerpc-ibm-aix* } }
+// { dg-do run { target *-*-freebsd* *-*-netbsd* *-*-linux* *-*-solaris*
*-*-cygwin *-*-darwin1[1-9]* powerpc-ibm-aix* } }
+// { dg-xfail-if broken pthreads before darwin10 { *-*-darwin9*
*-*-darwin10* } { * } { } }
// { dg-options -std=gnu++0x -pthread { target *-*-freebsd* *-*-netbsd*
*-*-linux* powerpc-ibm-aix* } }
// { dg-options -std=gnu++0x -pthreads { target *-*-solaris* } }
// { dg-options -std=gnu++0x { target *-*-cygwin *-*-darwin* } }
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #11 from Jack Howarth howarth at nitro dot med.uc.edu 2012-10-14 21:13:18 UTC --- The comment should be corrected to broken pthreads before darwin11.
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407
--- Comment #12 from Dominique d'Humieres dominiq at lps dot ens.fr
2012-10-14 21:17:47 UTC ---
Still suppresses the execution of the test on x86_64-apple-darwin12. Are there
any examples in the FSF gcc testsuites of dg-run being used at the same time
as
dg-compile?
Yes (I did not invent it, I tried it because I saw it):
gcc.dg/vect/vect-(82|83)_64.c for instance.
/* { dg-do run { target { { powerpc*-*-* lp64 } powerpc_altivec_ok } } }
*/
/* { dg-do compile { target { { powerpc*-*-* ilp32 } powerpc_altivec_ok }
} } */
/* { dg-options -O2 -ftree-vectorize -mpowerpc64 -fdump-tree-vect-stats
-maltivec } */
I suspect that is an unsupported combination.
Now you asked the question, the test is not run on powerpc-apple-darwin9 with
-m64.
Could you try to put the 'dg-do compile' line before the 'dg-do run' one?
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407
--- Comment #13 from Jack Howarth howarth at nitro dot med.uc.edu 2012-10-14
21:22:48 UTC ---
I would rather we use...
Index: libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc
===
--- libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc(revision
192440)
+++ libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc(working
copy)
@@ -1,4 +1,5 @@
-// { dg-do run { target *-*-freebsd* *-*-netbsd* *-*-linux* *-*-solaris*
*-*-cygwin *-*-darwin* powerpc-ibm-aix* } }
+// { dg-do run { target *-*-freebsd* *-*-netbsd* *-*-linux* *-*-solaris*
*-*-cygwin *-*-darwin1[1-9]* powerpc-ibm-aix* } }
+// { dg-xfail-if broken pthreads before darwin11 { *-*-darwin9*
*-*-darwin10* } { * } { } }
// { dg-options -std=gnu++0x -pthread { target *-*-freebsd* *-*-netbsd*
*-*-linux* powerpc-ibm-aix* } }
// { dg-options -std=gnu++0x -pthreads { target *-*-solaris* } }
// { dg-options -std=gnu++0x { target *-*-cygwin *-*-darwin* } }
The usage of dg-skip-if allows the test to be both compiled and executed on
darwin1 in concert with dg-do-run. If it is working as documented, the
dg-skip-if above to only compile on darwin9/10 but not try to execute the test
case.
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #14 from Dominique d'Humieres dominiq at lps dot ens.fr 2012-10-14 21:34:55 UTC --- I suspect that is an unsupported combination. Now you asked the question, the test is not run on powerpc-apple-darwin9 with -m64. Could you try to put the 'dg-do compile' line before the 'dg-do run' one? This does not work either, it seems that the last dg-do is used. Note that the test is not compiled with dg-skip-if. With dg-xfail-if as in comment #10, test is not compiled, but as in comment #13, I get a XPASS and the test is run.
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #15 from Jack Howarth howarth at nitro dot med.uc.edu 2012-10-14 22:17:07 UTC --- I still don't see the point of testing the compilation of a test which doesn't execute properly. I also suspect resorting to a non-standard approach in deja-gnu will never make it pass the review process.
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #1 from Jonathan Wakely redi at gcc dot gnu.org 2012-08-30 10:42:07 UTC --- (In reply to comment #0) On powerpc-apple-darwin9 and x86_64-apple-darwin10, the test 30_threads/condition_variable/54185.cc is timed out (from http://gcc.gnu.org/ml/gcc-testresults/2012-08/msg02572.html this does seem to occur on x86_64-apple-darwin12.2.0). Do you mean does *not* happen on darwin12? Sampling the run after ~40 minutes gives: There's no need to wait 40 mins, the process will be deadlocked after a few milliseconds. I can't look into this for a week, but it looks like notify_all only woke one of the nine threads waiting on the condition variable, which would be a darwin bug. That looks more likely if it doesn't happen on later versions.
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #2 from Dominique d'Humieres dominiq at lps dot ens.fr 2012-08-30 12:53:54 UTC --- (In reply to comment #1) Do you mean does *not* happen on darwin12? Well, I don't have access to darwin11 nor 12, so the only thing I am sure of is that the failure does not show up in the darwin12 logs. ... which would be a darwin bug. That looks more likely if it doesn't happen on later versions. I agree, but I doubt that apple will backport the fix. Does it exist a simple workaround? If not, the test should be skipped for darwin before 10 (maybe 11).
[Bug target/54407] FAIL: 30_threads/condition_variable/54185.cc execution test program timed out on powerpc-apple-darwin9 and x86_64-apple-darwin10
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54407 --- Comment #3 from Jonathan Wakely redi at gcc dot gnu.org 2012-08-30 16:40:48 UTC --- I don't know of any workaround so disabling the test seems like a good option
