https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
--- Comment #14 from David ---
I understand that stage 3 is now closed too. I don't have svn write access, so
I can't check this in myself.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
--- Comment #13 from David ---
Rumor has it that Phase 1 may be closing soon. Is there something else I need
to do here?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
David changed:
What|Removed |Added
Attachment #33302|0 |1
is obsolete|
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
--- Comment #11 from Kai Tietz ---
(In reply to David from comment #10)
> (In reply to Kai Tietz from comment #5)
> > This patch is clear stage 1 material.
>
> We're in stage 1. Is it time?
Sure, patch for it is welcome.
> The patch adds
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
--- Comment #10 from David ---
(In reply to Kai Tietz from comment #5)
> This patch is clear stage 1 material.
We're in stage 1. Is it time?
The patch adds the memory clobber, but I think the conclusion here was to
remove
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
--- Comment #9 from Kai Tietz ktietz at gcc dot gnu.org ---
(In reply to David from comment #8)
(In reply to Kai Tietz from comment #7)
The first code block in comment #6 is what is in the code now. As you can
see, it already has the #define
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
--- Comment #8 from David gccbugzilla at limegreensocks dot com ---
(In reply to Kai Tietz from comment #7)
The first code block in comment #6 is what is in the code now. As you can see,
it already has the #define you are describing. I don't
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
--- Comment #7 from Kai Tietz ktietz at gcc dot gnu.org ---
I agree that we change it to
#define __GTHR_W32_InterlockedCompareExchange InterlockedCompareExchange
not sure if we actually should error out here at all. We might want to remove
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
--- Comment #6 from David gccbugzilla at limegreensocks dot com ---
Actually, the code already uses InterlockedCompareExchange. UNLESS users
explicitly tell it not to:
#ifdef __GTHREAD_I486_INLINE_LOCK_PRIMITIVES
static inline long
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
Kai Tietz ktietz at gcc dot gnu.org changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Last
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
--- Comment #4 from David gccbugzilla at limegreensocks dot com ---
(In reply to Mikael Pettersson from comment #3)
Do you have a test case which fails without your patch?
I do not. But this is a by definition thing.
This instruction is
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
--- Comment #3 from Mikael Pettersson mikpelinux at gmail dot com ---
Do you have a test case which fails without your patch?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
--- Comment #2 from David gccbugzilla at limegreensocks dot com ---
Attaching a patch was just the clearest way I knew to show the problem.
My hope was that posting it here would allow someone who knew how to submit
patches to take this the rest
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109
Andrew Pinski pinskia at gcc dot gnu.org changed:
What|Removed |Added
Target||win32
---
14 matches
Mail list logo
