[Bug target/87835] nvptx offloading: libgomp.oacc-c-c++-common/asyncwait-1.c execution test intermittently fails at -O2
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87835 --- Comment #8 from Thomas Schwinge --- Author: tschwinge Date: Wed May 8 10:03:04 2019 New Revision: 271005 URL: https://gcc.gnu.org/viewcvs?rev=271005=gcc=rev Log: Address compiler diagnostics in libgomp.oacc-c-c++-common/pr87835.c source-gcc/libgomp/testsuite/libgomp.oacc-c-c++-common/pr87835.c: In function 'main': source-gcc/libgomp/testsuite/libgomp.oacc-c-c++-common/pr87835.c:45: warning: ignoring #pragma loop gang [-Wunknown-pragmas] 45 | #pragma loop gang | source-gcc/libgomp/testsuite/libgomp.oacc-c-c++-common/pr87835.c:19:7: warning: unused variable 'b' [-Wunused-variable] 19 | int b[n]; | ^ libgomp/ PR target/87835 * testsuite/libgomp.oacc-c-c++-common/pr87835.c: Update. trunk r271004 Modified: branches/gcc-9-branch/libgomp/ChangeLog branches/gcc-9-branch/libgomp/testsuite/libgomp.oacc-c-c++-common/pr87835.c
[Bug target/87835] nvptx offloading: libgomp.oacc-c-c++-common/asyncwait-1.c execution test intermittently fails at -O2
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87835 --- Comment #7 from Thomas Schwinge --- Author: tschwinge Date: Wed May 8 10:01:30 2019 New Revision: 271004 URL: https://gcc.gnu.org/viewcvs?rev=271004=gcc=rev Log: Address compiler diagnostics in libgomp.oacc-c-c++-common/pr87835.c source-gcc/libgomp/testsuite/libgomp.oacc-c-c++-common/pr87835.c: In function 'main': source-gcc/libgomp/testsuite/libgomp.oacc-c-c++-common/pr87835.c:45: warning: ignoring #pragma loop gang [-Wunknown-pragmas] 45 | #pragma loop gang | source-gcc/libgomp/testsuite/libgomp.oacc-c-c++-common/pr87835.c:19:7: warning: unused variable 'b' [-Wunused-variable] 19 | int b[n]; | ^ libgomp/ PR target/87835 * testsuite/libgomp.oacc-c-c++-common/pr87835.c: Update. Modified: trunk/libgomp/ChangeLog trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/pr87835.c
[Bug target/87835] nvptx offloading: libgomp.oacc-c-c++-common/asyncwait-1.c execution test intermittently fails at -O2
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87835 Tom de Vries changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Assignee|unassigned at gcc dot gnu.org |vries at gcc dot gnu.org Target Milestone|--- |9.0 --- Comment #6 from Tom de Vries --- Patch and test-case committed, marking resolved fixed.
[Bug target/87835] nvptx offloading: libgomp.oacc-c-c++-common/asyncwait-1.c execution test intermittently fails at -O2
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87835 --- Comment #5 from Tom de Vries --- Author: vries Date: Wed Jan 23 08:16:11 2019 New Revision: 268176 URL: https://gcc.gnu.org/viewcvs?rev=268176=gcc=rev Log: [nvptx, libgomp] Fix map_push The map field of a struct ptx_stream is a FIFO. The FIFO is implemented as a single linked list, with pop-from-the-front semantics. The function map_pop pops an element, either by: - deallocating the element, if there is more than one element - or marking the element inactive, if there's only one element The responsibility of map_push is to push an element to the back, as well as selecting the element to push, by: - allocating an element, or - reusing the element at the front if inactive and big enough, or - dropping the element at the front if inactive and not big enough, and allocating one that's big enough The current implemention gets at least the first and most basic scenario wrong: > map = cuda_map_create (size); We create an element, and assign it to map. > for (t = s->map; t->next != NULL; t = t->next) > ; We determine the last element in the fifo. > t->next = map; We append the new element. > s->map = map; But here, we throw away the rest of the FIFO, and declare the FIFO to be just the new element. This problem causes the test-case asyncwait-1.c to fail intermittently on some systems. The pr87835.c test-case added here is a a minimized and modified version of asyncwait-1.c (avoiding the kernel construct) that is more likely to fail. Fix this by rewriting map_pop more robustly, by: - seperating the function in two phases: select element, push element - when reusing or dropping an element, making sure that the element is cleanly popped from the queue - rewriting the push element part in such a way that it can handle all cases without needing if statements, such that each line is exercised for each of the three cases. 2019-01-23 Tom de Vries PR target/87835 * plugin/plugin-nvptx.c (map_push): Fix adding of allocated element. * testsuite/libgomp.oacc-c-c++-common/pr87835.c: New test. Added: trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/pr87835.c Modified: trunk/libgomp/ChangeLog trunk/libgomp/plugin/plugin-nvptx.c
