[Bug target/88188] ICE in print_operand, at config/rs6000/rs6000.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88188 Jakub Jelinek changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Jakub Jelinek --- Not worth backporting IMHO.
[Bug target/88188] ICE in print_operand, at config/rs6000/rs6000.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88188 --- Comment #5 from Jakub Jelinek --- Author: jakub Date: Tue Dec 4 19:41:52 2018 New Revision: 266794 URL: https://gcc.gnu.org/viewcvs?rev=266794&root=gcc&view=rev Log: PR target/88188 * config/rs6000/rs6000.c (ccr_bit): Return -1 instead of assertion failures. (print_operand): Use REG_P instead of GET_CODE == REG. : Also check CR_REGNO_P (REGNO (x)). : Likewise. Remove GET_MODE check. * config/rs6000/rs6000.md (scc patterns): Assert ccr_bit didn't return -1. * gcc.target/powerpc/pr88188-2.c: New test. Added: trunk/gcc/testsuite/gcc.target/powerpc/pr88188-2.c Modified: trunk/gcc/ChangeLog trunk/gcc/config/rs6000/rs6000.c trunk/gcc/config/rs6000/rs6000.md trunk/gcc/testsuite/ChangeLog
[Bug target/88188] ICE in print_operand, at config/rs6000/rs6000.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88188
--- Comment #4 from Jakub Jelinek ---
(In reply to Christophe Lyon from comment #3)
> (In reply to Jakub Jelinek from comment #2)
> > trunk/gcc/testsuite/gcc.dg/tree-ssa/phi-opt-11.c
>
> Is this part of the commit intended?
>
> It's not mentioned in the ChangeLog, and I see a regression:
> FAIL: gcc.dg/tree-ssa/phi-opt-11.c scan-tree-dump-times optimized "if" 0
> (used to have PASS: gcc.dg/tree-ssa/phi-opt-11.c scan-tree-dump-times
> optimized "if" 2)
>
> on arm-none-eabi --with-mode thumb --with-cpu cortex-m3
It was intended, but not as part of this commit, sorry for the screw-up.
It was meant as the PR85368 fix.
I've tested it on x86_64 as example of !logical_op_short_circuit && branch_cost
target, Jeff/Andreas on s390x as example of logical_op_short_circuit &&
branch_cost target and I've tested on powerpc64{,le} as example of
logical_op_short_circuit && !branch_cost target.
arm is a branch_cost target and cortex-m3 is logical_op_short_circuit, why
doesn't the -mbranch-cost=2 option override the cortex-m3 defaults?
Anyway, can you follow-up in PR85368 instead of here, in order not to clutter
this PR?
[Bug target/88188] ICE in print_operand, at config/rs6000/rs6000.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88188 Christophe Lyon changed: What|Removed |Added CC||clyon at gcc dot gnu.org --- Comment #3 from Christophe Lyon --- (In reply to Jakub Jelinek from comment #2) > trunk/gcc/testsuite/gcc.dg/tree-ssa/phi-opt-11.c Is this part of the commit intended? It's not mentioned in the ChangeLog, and I see a regression: FAIL: gcc.dg/tree-ssa/phi-opt-11.c scan-tree-dump-times optimized "if" 0 (used to have PASS: gcc.dg/tree-ssa/phi-opt-11.c scan-tree-dump-times optimized "if" 2) on arm-none-eabi --with-mode thumb --with-cpu cortex-m3
[Bug target/88188] ICE in print_operand, at config/rs6000/rs6000.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88188 --- Comment #2 from Jakub Jelinek --- Author: jakub Date: Tue Nov 27 15:40:57 2018 New Revision: 266515 URL: https://gcc.gnu.org/viewcvs?rev=266515&root=gcc&view=rev Log: PR target/88188 * config/rs6000/rs6000.c (print_operand) : Use output_operand_lossage instead of gcc_assert. : Likewise. : Likewise. : Use output_operand_lossage instead of gcc_unreachable. * gcc.target/powerpc/pr88188.c: New test. Added: trunk/gcc/testsuite/gcc.target/powerpc/pr88188.c Modified: trunk/gcc/ChangeLog trunk/gcc/config/rs6000/rs6000.c trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/gcc.dg/tree-ssa/phi-opt-11.c
[Bug target/88188] ICE in print_operand, at config/rs6000/rs6000.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88188 --- Comment #1 from Jakub Jelinek --- Created attachment 45090 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=45090&action=edit gcc9-pr88188.patch Untested fix (ignoring powerpcspe, because it really should be removed as unmaintained).
[Bug target/88188] ICE in print_operand, at config/rs6000/rs6000.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88188 Jakub Jelinek changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed||2018-11-26 CC||jakub at gcc dot gnu.org Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org Ever confirmed|0 |1
