[Bug target/94780] [8/9 Regression] ICE in walk_body at gcc/tree-nested.c:713 since r6-3632-gf6f69fb09c5f81df

[cvs-commit at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94780

--- Comment #14 from CVS Commits  ---
The releases/gcc-9 branch has been updated by Xi Ruoyao :

https://gcc.gnu.org/g:79184d8c57d377a242610543a2cbe4f154924be7

commit r9-9655-g79184d8c57d377a242610543a2cbe4f154924be7
Author: Xi Ruoyao 
Date:   Fri Jul 30 23:44:14 2021 +0800

mips: Fix up mips_atomic_assign_expand_fenv [PR94780]

Commit message shamelessly copied from 1777beb6b129 by jakub:

This function, because it is sometimes called even outside of function
bodies, uses create_tmp_var_raw rather than create_tmp_var.  But in order
for that to work, when first referenced, the VAR_DECLs need to appear in a
TARGET_EXPR so that during gimplification the var gets the right
DECL_CONTEXT and is added to local decls.

gcc/

PR target/94780
* config/mips/mips.c (mips_atomic_assign_expand_fenv): Use
  TARGET_EXPR instead of MODIFY_EXPR.

(cherry picked from commit 2065654435e3d97676366f82b939bc9273382dbe)

[Bug target/94780] [8/9 Regression] ICE in walk_body at gcc/tree-nested.c:713 since r6-3632-gf6f69fb09c5f81df

[cvs-commit at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94780

--- Comment #13 from CVS Commits  ---
The releases/gcc-10 branch has been updated by Xi Ruoyao :

https://gcc.gnu.org/g:613e4ebc9c6a156f9efc656a2f2620ab22fc6b52

commit r10-10016-g613e4ebc9c6a156f9efc656a2f2620ab22fc6b52
Author: Xi Ruoyao 
Date:   Fri Jul 30 23:44:14 2021 +0800

mips: Fix up mips_atomic_assign_expand_fenv [PR94780]

Commit message shamelessly copied from 1777beb6b129 by jakub:

This function, because it is sometimes called even outside of function
bodies, uses create_tmp_var_raw rather than create_tmp_var.  But in order
for that to work, when first referenced, the VAR_DECLs need to appear in a
TARGET_EXPR so that during gimplification the var gets the right
DECL_CONTEXT and is added to local decls.

gcc/

PR target/94780
* config/mips/mips.c (mips_atomic_assign_expand_fenv): Use
  TARGET_EXPR instead of MODIFY_EXPR.

(cherry picked from commit 2065654435e3d97676366f82b939bc9273382dbe)

[Bug target/94780] [8/9 Regression] ICE in walk_body at gcc/tree-nested.c:713 since r6-3632-gf6f69fb09c5f81df

[cvs-commit at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94780

--- Comment #12 from CVS Commits  ---
The master branch has been updated by Xi Ruoyao :

https://gcc.gnu.org/g:2065654435e3d97676366f82b939bc9273382dbe

commit r12-2630-g2065654435e3d97676366f82b939bc9273382dbe
Author: Xi Ruoyao 
Date:   Fri Jul 30 23:44:14 2021 +0800

mips: Fix up mips_atomic_assign_expand_fenv [PR94780]

Commit message shamelessly copied from 1777beb6b129 by jakub:

This function, because it is sometimes called even outside of function
bodies, uses create_tmp_var_raw rather than create_tmp_var.  But in order
for that to work, when first referenced, the VAR_DECLs need to appear in a
TARGET_EXPR so that during gimplification the var gets the right
DECL_CONTEXT and is added to local decls.

gcc/

PR target/94780
* config/mips/mips.c (mips_atomic_assign_expand_fenv): Use
  TARGET_EXPR instead of MODIFY_EXPR.

[Bug target/94780] [8/9 Regression] ICE in walk_body at gcc/tree-nested.c:713 since r6-3632-gf6f69fb09c5f81df

[xry111 at mengyan1223 dot wang via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94780

Xi Ruoyao  changed:

   What|Removed |Added

 CC||xry111 at mengyan1223 dot wang

--- Comment #11 from Xi Ruoyao  ---
It's still not fixed on mips after one year :(.

Patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573464.html

[Bug target/94780] [8/9 Regression] ICE in walk_body at gcc/tree-nested.c:713 since r6-3632-gf6f69fb09c5f81df

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94780

Jakub Jelinek  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Jakub Jelinek  ---
Fixed for 8.5 in r8-10493-ga8a6b29393dbc13d81fdc5d354526452bd79fb94 and by the
above commit for 9.4+ too.  Other commits were for other architectures.

[Bug target/94780] [8/9 Regression] ICE in walk_body at gcc/tree-nested.c:713 since r6-3632-gf6f69fb09c5f81df

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94780

--- Comment #9 from CVS Commits  ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
:

https://gcc.gnu.org/g:1777beb6b12983b946dae4177470a319693fc0dc

commit r9-8887-g1777beb6b12983b946dae4177470a319693fc0dc
Author: Jakub Jelinek 
Date:   Mon Apr 27 21:14:52 2020 +0200

x86: Fix up ix86_atomic_assign_expand_fenv [PR94780]

This function, because it is sometimes called even outside of function
bodies, uses create_tmp_var_raw rather than create_tmp_var.  But in order
for that to work, when first referenced, the VAR_DECLs need to appear in a
TARGET_EXPR so that during gimplification the var gets the right
DECL_CONTEXT and is added to local decls.  Without that, e.g. tree-nested.c
ICEs on those.

2020-04-27  Jakub Jelinek  

PR target/94780
* config/i386/i386.c (ix86_atomic_assign_expand_fenv): Use
TARGET_EXPR instead of MODIFY_EXPR for first assignment to
sw_var, exceptions_var, mxcsr_orig_var and mxcsr_mod_var.

* gcc.dg/pr94780.c: New test.

(cherry picked from commit 9b8e9006bb35641865358e2df4f6b3ae185b239a)

[Bug target/94780] [8/9 Regression] ICE in walk_body at gcc/tree-nested.c:713 since r6-3632-gf6f69fb09c5f81df

[paul.hua.gm at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94780

Paul Hua  changed:

   What|Removed |Added

 CC||paul.hua.gm at gmail dot com

--- Comment #8 from Paul Hua  ---
This also crashes on mips64el.

gcc/testsuite/gcc.dg/pr94780.c:8:1: internal compiler error: Segmentation fault
0x1209b7233 crash_signal
../../../gcc_git_trunk/gcc/toplev.c:328
0x120a9eb85 tree_check(tree_node*, char const*, int, char const*, tree_code)
../../../gcc_git_trunk/gcc/tree.h:3293
0x120a9eb85 convert_nonlocal_reference_op
../../../gcc_git_trunk/gcc/tree-nested.c:1064
0x120d7f81f walk_tree_1(tree_node**, tree_node* (*)(tree_node**, int*, void*),
void*, hash_set >*,
tree_node* (*)(tree_node**, int*, tree_node* (*)(tree_node**, int*, void*),
void*, hash_set >*))
../../../gcc_git_trunk/gcc/tree.c:12001
0x1205e5adb walk_gimple_op(gimple*, tree_node* (*)(tree_node**, int*, void*),
walk_stmt_info*)
../../../gcc_git_trunk/gcc/gimple-walk.c:268
0x1205e5da7 walk_gimple_stmt(gimple_stmt_iterator*, tree_node*
(*)(gimple_stmt_iterator*, bool*, walk_stmt_info*), tree_node* (*)(tree_node**,
int*, void*), walk_stmt_info*)
../../../gcc_git_trunk/gcc/gimple-walk.c:596
0x1205e610b walk_gimple_seq_mod(gimple**, tree_node* (*)(gimple_stmt_iterator*,
bool*, walk_stmt_info*), tree_node* (*)(tree_node**, int*, void*),
walk_stmt_info*)
../../../gcc_git_trunk/gcc/gimple-walk.c:51
0x1205e5f17 walk_gimple_stmt(gimple_stmt_iterator*, tree_node*
(*)(gimple_stmt_iterator*, bool*, walk_stmt_info*), tree_node* (*)(tree_node**,
int*, void*), walk_stmt_info*)
../../../gcc_git_trunk/gcc/gimple-walk.c:605
0x1205e610b walk_gimple_seq_mod(gimple**, tree_node* (*)(gimple_stmt_iterator*,
bool*, walk_stmt_info*), tree_node* (*)(tree_node**, int*, void*),
walk_stmt_info*)
../../../gcc_git_trunk/gcc/gimple-walk.c:51
0x120a972ff walk_body
../../../gcc_git_trunk/gcc/tree-nested.c:713
0x120a972ff walk_function
../../../gcc_git_trunk/gcc/tree-nested.c:724
0x120a972ff walk_all_functions
../../../gcc_git_trunk/gcc/tree-nested.c:789
0x120aa206b lower_nested_functions(tree_node*)
../../../gcc_git_trunk/gcc/tree-nested.c:3551
0x1203c55db cgraph_node::analyze()
../../../gcc_git_trunk/gcc/cgraphunit.c:676
0x1203c995f analyze_functions
../../../gcc_git_trunk/gcc/cgraphunit.c:1227
0x1203caaf3 symbol_table::finalize_compilation_unit()
../../../gcc_git_trunk/gcc/cgraphunit.c:2974
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See  for instructions.

[Bug target/94780] [8/9 Regression] ICE in walk_body at gcc/tree-nested.c:713 since r6-3632-gf6f69fb09c5f81df

[wilson at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94780
Bug 94780 depends on bug 94950, which changed state.

Bug 94950 Summary: [8/9 regression] ICE in gcc.dg/pr94780.c on riscv64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94950

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

[Bug target/94780] [8/9 Regression] ICE in walk_body at gcc/tree-nested.c:713 since r6-3632-gf6f69fb09c5f81df

[sch...@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94780

--- Comment #7 from Andreas Schwab  ---
This also crashes on riscv64:

/daten/riscv64/gcc/gcc-20200502/gcc/testsuite/gcc.dg/pr94780.c: In function
'foo':
/daten/riscv64/gcc/gcc-20200502/gcc/testsuite/gcc.dg/pr94780.c:8:1: internal
compiler error: Segmentation fault
0x74a3af crash_signal
../../gcc/toplev.c:328
0x7ea370 tree_check(tree_node*, char const*, int, char const*, tree_code)
../../gcc/tree.h:3293
0x7ea370 convert_nonlocal_reference_op
../../gcc/tree-nested.c:1064
0x9e3abb walk_tree_1(tree_node**, tree_node* (*)(tree_node**, int*, void*),
void*, hash_set >*,
tree_node* (*)(tree_node**, int*, tree_node* (*)(tree_node**, int*, void*),
void*, hash_set >*))
../../gcc/tree.c:12003
0x4be799 walk_gimple_op(gimple*, tree_node* (*)(tree_node**, int*, void*),
walk_stmt_info*)
../../gcc/gimple-walk.c:268
0x4be9e3 walk_gimple_stmt(gimple_stmt_iterator*, tree_node*
(*)(gimple_stmt_iterator*, bool*, walk_stmt_info*), tree_node* (*)(tree_node**,
int*, void*), walk_stmt_info*)
../../gcc/gimple-walk.c:596
0x4beb93 walk_gimple_seq_mod(gimple**, tree_node* (*)(gimple_stmt_iterator*,
bool*, walk_stmt_info*), tree_node* (*)(tree_node**, int*, void*),
walk_stmt_info*)
../../gcc/gimple-walk.c:51
0x4beadb walk_gimple_stmt(gimple_stmt_iterator*, tree_node*
(*)(gimple_stmt_iterator*, bool*, walk_stmt_info*), tree_node* (*)(tree_node**,
int*, void*), walk_stmt_info*)
../../gcc/gimple-walk.c:605
0x4beb93 walk_gimple_seq_mod(gimple**, tree_node* (*)(gimple_stmt_iterator*,
bool*, walk_stmt_info*), tree_node* (*)(tree_node**, int*, void*),
walk_stmt_info*)
../../gcc/gimple-walk.c:51
0x7e4801 walk_body
../../gcc/tree-nested.c:713
0x7e4801 walk_function
../../gcc/tree-nested.c:724
0x7e4801 walk_all_functions
../../gcc/tree-nested.c:789
0x7ecb2f lower_nested_functions(tree_node*)
../../gcc/tree-nested.c:3551
0x363201 cgraph_node::analyze()
../../gcc/cgraphunit.c:676
0x365df7 analyze_functions
../../gcc/cgraphunit.c:1227
0x366c45 symbol_table::finalize_compilation_unit()
../../gcc/cgraphunit.c:2974

[Bug target/94780] [8/9 Regression] ICE in walk_body at gcc/tree-nested.c:713 since r6-3632-gf6f69fb09c5f81df

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94780

Jakub Jelinek  changed:

   What|Removed |Added

Summary|[8/9/10 Regression] ICE in  |[8/9 Regression] ICE in
   |walk_body at|walk_body at
   |gcc/tree-nested.c:713 since |gcc/tree-nested.c:713 since
   |r6-3632-gf6f69fb09c5f81df   |r6-3632-gf6f69fb09c5f81df

--- Comment #6 from Jakub Jelinek  ---
Fixed for 10.1+ so far.