[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-05 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 Andrew Pinski changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-05 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 --- Comment #15 from CVS Commits --- The trunk branch has been updated by Andrew Pinski : https://gcc.gnu.org/g:2e4e899641c0c558eabf0128ee72cb8d3999c990 commit r14-489-g2e4e899641c0c558eabf0128ee72cb8d3999c990 Author: Andrew Pinski Date:

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 --- Comment #14 from Andrew Pinski --- Figured out a C testcase: ``` [[gnu::noipa]] _Bool f3(_Bool a) { if (a==0) return 0; else return a; } ``` Still need: `-fdisable-tree-fre1` though because fre is able to

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 Andrew Pinski changed: What|Removed |Added Keywords||patch URL|

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread slyfox at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 --- Comment #12 from Sergei Trofimovich --- (In reply to Andrew Pinski from comment #11) > Created attachment 54999 [details] > Patch which needs a message/changelog I confirm the patch fixes real test failures on nlohmann_json-3.11.2 as well.

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 --- Comment #11 from Andrew Pinski --- Created attachment 54999 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54999=edit Patch which needs a message/changelog

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 --- Comment #10 from Andrew Pinski --- Created attachment 54998 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54998=edit Gimple testcase that fails at runtime too -O1 -fgimple -fdisable-tree-ethread -fdisable-tree-fre1 The thing is

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread marxin at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 --- Comment #9 from Martin Liška --- I've got a C++ reduced test-case: $ cat x.ii template struct is_same; template using enable_if_t = _Tp; template struct reverse_iterator { _Iterator current; typedef _Iterator iterator_type;

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 --- Comment #8 from Andrew Pinski --- I should be able to construct a gimple one.

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread marxin at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 --- Comment #7 from Martin Liška --- @Andrew: Will you be able to construct a test-case or do you want me to reduce the provided one?

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 Andrew Pinski changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 Andrew Pinski changed: What|Removed |Added Assignee|unassigned at gcc dot gnu.org |pinskia at gcc dot gnu.org ---

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 Andrew Pinski changed: What|Removed |Added CC||pinskia at gcc dot gnu.org Target

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread marxin at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 --- Comment #5 from Martin Liška --- So (long int)(_73 == 0) is changed to (long int)(_73 != 0).

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread marxin at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 --- Comment #4 from Martin Liška --- Looking at optimized dump before and after the revision I see an obvious error: diff -u good bad --- good2023-05-04 14:12:16.160695781 +0200 +++ bad 2023-05-04 14:11:58.516230125 +0200 @@ -3399,9

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread slyfox at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 --- Comment #3 from Sergei Trofimovich --- Both -O1 and -fno-strict-aliasing remove the bug: $ g++-14 unit-t.cpp -O2 -Ijson/include -o a -O1 && ./a SUCCESS! $ g++-14 unit-t.cpp -O2 -Ijson/include -o a -fno-strict-aliasing && ./a

[Bug tree-optimization/109732] [14 regression] gcc miscompiles iterator comparison on nlohmann_json since r14-204-gf1f5cbaa3f716f

2023-05-04 Thread marxin at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109732 Martin Liška changed: What|Removed |Added Summary|[14 regression] gcc |[14 regression] gcc