[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #25 from Yvan Roux --- Author: yroux Date: Wed Oct 28 09:00:47 2015 New Revision: 229478 URL: https://gcc.gnu.org/viewcvs?rev=229478=gcc=rev Log: gcc/ 2015-10-28 Yvan Roux Sebastian Pop

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 Sebastian Pop spop at gcc dot gnu.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #23 from Sebastian Pop spop at gcc dot gnu.org --- Author: spop Date: Wed Mar 25 22:49:47 2015 New Revision: 221675 URL: https://gcc.gnu.org/viewcvs?rev=221675root=gccview=rev Log: diamonds are not valid execution threads for jump

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #21 from Jeffrey A. Law law at redhat dot com --- Isn't the real issue here that the test for redirecting the edge is wrong? If we're leaving the jump thread path, then we want those edges to reach their original targets. Thus

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #22 from Sebastian Pop spop at gcc dot gnu.org --- (In reply to Jeffrey A. Law from comment #21) Isn't the real issue here that the test for redirecting the edge is wrong? You are right, the test for redirecting edges in copy_bbs is

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #19 from Jeffrey A. Law law at redhat dot com --- I'm still getting up to speed here, but this sounds vaguely familiar to something we've run into before. https://gcc.gnu.org/ml/gcc-patches/2013-11/msg01073.html Is when the code

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #20 from Sebastian Pop spop at gcc dot gnu.org --- Created attachment 35046 -- https://gcc.gnu.org/bugzilla/attachment.cgi?id=35046action=edit fix The attached patch fixes the problem by not creating diamonds in the copied

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 Sebastian Pop spop at gcc dot gnu.org changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #16 from Sebastian Pop spop at gcc dot gnu.org --- Created attachment 35030 -- https://gcc.gnu.org/bugzilla/attachment.cgi?id=35030action=edit IR before and after for failing FSM jump thread After updating the sources of GCC, I now

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #17 from Sebastian Pop spop at gcc dot gnu.org --- Trying to figure out why we FSM jump thread this path: (13, 53) (53, 55) (55, 64) (64, 66) (66, 67) (67, 68) (68, 69) (69, 95) (95, 94) (94, 5) (94, 5) In BB_94 we have this

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #14 from Sebastian Pop spop at gcc dot gnu.org --- (In reply to Jeffrey A. Law from comment #13) But you can need updates that extend beyond the scope of the SEME I would think. That was my recollection from looking at ways to

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #15 from Jeffrey A. Law law at redhat dot com --- Basically the way this works is we record the SSA_NAMEs that are being duplicated during block copying. For any duplicated SSA_NAME, if 1 instance of it is live at a join point in

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #8 from Jeffrey A. Law law at redhat dot com --- There's not enough information in those comments to definitively say the SEME copier isn't updating the SSA graph properly. If I were looking at this, I'd want the dump as we enter VRP

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #9 from Sebastian Pop spop at gcc dot gnu.org --- I added a pass of update_ssa after each invocation of the SEME copier, and that produced 26 extra fails (on top of the failing test) in the hmmer make check. The problem with adding an

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #10 from Sebastian Pop spop at gcc dot gnu.org --- Created attachment 35005 -- https://gcc.gnu.org/bugzilla/attachment.cgi?id=35005action=edit add update_ssa to seme copier

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #12 from Sebastian Pop spop at gcc dot gnu.org --- (In reply to Jeffrey A. Law from comment #11) That is unless the SEME copier tries to update SSA internally, but that's painful. I have also tried to update the SSA only in the

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #13 from Jeffrey A. Law law at redhat dot com --- But you can need updates that extend beyond the scope of the SEME I would think. That was my recollection from looking at ways to minimize the number of blocks the renamer had to

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #11 from Jeffrey A. Law law at redhat dot com --- From a sequencing standpoint, you do your block copying wire up the new blocks. Then you have to remove unreachable blocks, rebuild dominators then update hte SSA graph. That is

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 Jakub Jelinek jakub at gcc dot gnu.org changed: What|Removed |Added CC||jakub at gcc dot

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 Marek Polacek mpolacek at gcc dot gnu.org changed: What|Removed |Added Status|UNCONFIRMED |NEW Last

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 Sebastian Pop spop at gcc dot gnu.org changed: What|Removed |Added Status|NEW |UNCONFIRMED

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 Richard Biener rguenth at gcc dot gnu.org changed: What|Removed |Added Keywords||wrong-code

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 Markus Trippelsdorf trippels at gcc dot gnu.org changed: What|Removed |Added CC|

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #2 from Martin Liška marxin at gcc dot gnu.org --- (In reply to Martin Liška from comment #0) Hello. Starting with r218451, http://hmmer.janelia.org/ started to be miscompiled. Steps to reproduce: wget

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #3 from Sebastian Pop spop at gcc dot gnu.org --- The miscompile happens when compiling src/generic_optacc.c: with -fdbg-cnt=registered_jump_thread:167 it passes, and with -fdbg-cnt=registered_jump_thread:168 it segfaults. The

[Bug tree-optimization/65177] [5 Regression]: extend jump thread for finite state automata causes miscompilation

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65177 --- Comment #4 from Sebastian Pop spop at gcc dot gnu.org --- command line: cd src gcc -g -O1 -ftree-vrp -fexpensive-optimizations -pthread -fPIC -msse2 -DHAVE_CONFIG_H -I../easel -I../libdivsufsort -I../easel -I. -I. -o generic_optacc.o -c