https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
Martin Liška changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #30 from Martin Liška ---
*** Bug 91273 has been marked as a duplicate of this bug. ***
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
Jakub Jelinek changed:
What|Removed |Added
CC||jakub at gcc dot gnu.org
--- Comment
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #28 from Jan Hubicka ---
> Thanks! That fixes the benchmark build (and the rest of SPEC builds fine with
> -flto). It also bootstraps and tests on aarch64-none-linux-gnu fine.
Thanks! My testing concluded independently so I went
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #27 from Jan Hubicka ---
Author: hubicka
Date: Wed Oct 2 12:41:36 2019
New Revision: 276454
URL: https://gcc.gnu.org/viewcvs?rev=276454=gcc=rev
Log:
PR c++/91222
* ipa-devirt.c (warn_types_mismatch): Fix conditional
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #26 from ktkachov at gcc dot gnu.org ---
(In reply to Jan Hubicka from comment #25)
> > --- Comment #24 from ktkachov at gcc dot gnu.org ---
> > Thanks. Unfortunately I still see the ICE building 507.cactuBSSN_r on
> > aarch64
> >
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #25 from Jan Hubicka ---
> --- Comment #24 from ktkachov at gcc dot gnu.org ---
> Thanks. Unfortunately I still see the ICE building 507.cactuBSSN_r on aarch64
> with -flto in the same place:
> 995 gcc_assert (TYPE_NAME (t1)
>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #24 from ktkachov at gcc dot gnu.org ---
Thanks. Unfortunately I still see the ICE building 507.cactuBSSN_r on aarch64
with -flto in the same place:
995 gcc_assert (TYPE_NAME (t1)
996 && TREE_CODE (TYPE_NAME
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
Jan Hubicka changed:
What|Removed |Added
Status|ASSIGNED|NEW
Assignee|hubicka at gcc dot
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #22 from Jan Hubicka ---
Hi,
I have commited patch that avoids the ICE while producing warning.
However I wonder why C++ FE is silent here
$ cat 2.ii
extern "C" {
struct {
} admbaserest_;
}
We probably could warn about two things
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #21 from Jan Hubicka ---
Author: hubicka
Date: Tue Oct 1 18:21:31 2019
New Revision: 276420
URL: https://gcc.gnu.org/viewcvs?rev=276420=gcc=rev
Log:
PR lto/91222
* ipa-devirt.c (warn_types_mismatch): Do not ICE when
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #20 from Jan Hubicka ---
> Still seeing this today building cactuBSSN_r with -flto
Sorry for that - I had some unexpected developments after cauldron.
I am back from vacation now and will fix it ASAP.
Honza
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
ktkachov at gcc dot gnu.org changed:
What|Removed |Added
Last reconfirmed|2019-07-22 00:00:00 |2019-10-1
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #18 from Martin Liška ---
I would like to see this also fixed. But I know Honza has some comments about
the patch. Honza?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #17 from Steve Ellcey ---
I tested Jason's patch on my Aarch64 box and it fixed the ICE. Any chance we
could check that patch in so that we could build SPEC 2017 with -flto?
I don't know if we want to allow this mismatch or not but
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #16 from Martin Liška ---
(In reply to Jason Merrill from comment #15)
> (In reply to Jason Merrill from comment #13)
> > But that still doesn't make the types the same, and the use of the variable
> > in 2.ii has undefined behavior
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #15 from Jason Merrill ---
(In reply to Jason Merrill from comment #13)
> But that still doesn't make the types the same, and the use of the variable
> in 2.ii has undefined behavior because it is accessing the value of the
> object
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
Jason Merrill changed:
What|Removed |Added
Attachment #46765|0 |1
is obsolete|
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #13 from Jason Merrill ---
Ah, I was reading the passage a bit wrong: where the extern "C" matters is not
on the type, but on the variable (ml_bssnrest_). Because it's extern "C",
declarations in different translation units
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #12 from Jan Hubicka ---
> Created attachment 46765
> --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=46765=edit
> clear TYPE_NAME in free_lang_data for anonymous types
>
> Perhaps like this?
It seems that this will disable
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #11 from Jason Merrill ---
Created attachment 46765
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=46765=edit
clear TYPE_NAME in free_lang_data for anonymous types
Perhaps like this?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #10 from Jan Hubicka ---
> >
> > They aren't in the anonymous namespace, but they are themselves anonymous,
> > so they have no linkage. The standard says,
> >
> > A type without linkage shall not be used as the type of a variable
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #9 from Martin Liška ---
(In reply to Jason Merrill from comment #8)
> (In reply to Jan Hubicka from comment #2)
> > 2.ii:62:3: warning: ‘ml_bssnrest_’ violates the C++ One Definition Rule
> > [-Wodr]
> >62 | } ml_bssnrest_;
> >
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
Jason Merrill changed:
What|Removed |Added
CC||jason at gcc dot gnu.org
--- Comment #8
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #7 from Jan Hubicka ---
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
>
> --- Comment #5 from Martin Liška ---
> (In reply to Jan Hubicka from comment #3)
> > Author: hubicka
> > Date: Mon Jul 29 08:18:38 2019
> > New
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
Martin Liška changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|unassigned
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
--- Comment #5 from Martin Liška ---
(In reply to Jan Hubicka from comment #3)
> Author: hubicka
> Date: Mon Jul 29 08:18:38 2019
> New Revision: 273866
>
> URL: https://gcc.gnu.org/viewcvs?rev=273866=gcc=rev
> Log:
>
> PR lto/91222
>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222
Jan Hubicka changed:
What|Removed |Added
Status|ASSIGNED|NEW
CC|
28 matches
Mail list logo
