[Bug c++/95517] [coroutines] suggested warning when co_return and return_void() are missing

2023-05-29 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95517

Jakub Jelinek  changed:

   What|Removed |Added

   Target Milestone|11.4|11.5

--- Comment #7 from Jakub Jelinek  ---
GCC 11.4 is being released, retargeting bugs to GCC 11.5.

[Bug c++/95517] [coroutines] suggested warning when co_return and return_void() are missing

2022-04-21 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95517

Richard Biener  changed:

   What|Removed |Added

   Target Milestone|11.3|11.4

--- Comment #6 from Richard Biener  ---
GCC 11.3 is being released, retargeting bugs to GCC 11.4.

[Bug c++/95517] [coroutines] suggested warning when co_return and return_void() are missing

2021-08-09 Thread iains at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95517

--- Comment #5 from Iain Sandoe  ---
(In reply to mengjun wei from comment #4)
> GCC 11.2 no longer allow return_value and return_void be both defined, may
> this restriction be removed? 

The restriction is part of the C++ standard (for the record, there was
discussion about allowing both to be present, but that was rejected by the
committee).

https://eel.is/c++draft/dcl.fct.def.coroutine#6

So, we cannot remove the restriction.

[Bug c++/95517] [coroutines] suggested warning when co_return and return_void() are missing

2021-08-09 Thread wei_mj at 139 dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95517

mengjun wei  changed:

   What|Removed |Added

 CC||wei_mj at 139 dot com

--- Comment #4 from mengjun wei  ---
GCC 11.2 no longer allow return_value and return_void be both defined, may this
restriction be removed? This makes the co_return statement necessary:
CTask workflow_work(CTaskScheduler::RawPtr scheduler,
co_comm_ctx::co_comm_workflow* workflow, const char* buf, int len)
{
co_comm_resp_impl::ptr response(new co_comm_resp_impl);
co_await co_comm_ctx::short_req_task::create(workflow, 1, buf, len,
response);
co_await co_comm_ctx::short_req_task::create(workflow, 2, buf, len,
response);
co_await co_comm_ctx::resp_task::create(workflow,
response->result.c_str(), response->result.length());
co_return 0;
}

[Bug c++/95517] [coroutines] suggested warning when co_return and return_void() are missing

2021-07-28 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95517

Richard Biener  changed:

   What|Removed |Added

   Target Milestone|11.2|11.3

--- Comment #3 from Richard Biener  ---
GCC 11.2 is being released, retargeting bugs to GCC 11.3

[Bug c++/95517] [coroutines] suggested warning when co_return and return_void() are missing

2021-04-27 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95517

Jakub Jelinek  changed:

   What|Removed |Added

   Target Milestone|11.0|11.2

--- Comment #2 from Jakub Jelinek  ---
GCC 11.1 has been released, retargeting bugs to GCC 11.2.

[Bug c++/95517] [coroutines] suggested warning when co_return and return_void() are missing

2020-06-04 Thread iains at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95517

Iain Sandoe  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Target Milestone|--- |11.0
   Last reconfirmed||2020-06-04
   Severity|normal  |enhancement
   Assignee|unassigned at gcc dot gnu.org  |iains at gcc dot gnu.org
 Status|UNCONFIRMED |ASSIGNED

--- Comment #1 from Iain Sandoe  ---
Generally, it's not required to diagnose UB, however I think we can do better
with the co_return/return stuff and have some ideas in mind already. So, yes
this a good idea,