https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
Andreas Krebbel changed:
What|Removed |Added
CC||krebbel at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #19 from stli at linux dot ibm.com ---
Fixed with gcc commit "S/390: Fix PR91628"
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=88e508f9f112acd07d0c49c53589160db8c85fcd
If somebody is backporting this fix, please also backport
gcc
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #18 from Iain Buclaw ---
(In reply to Iain Buclaw from comment #17)
> I have no strong preferences, if people are wanting to go with the .S file,
> then that's fine by me, feel free to commit (or I will if you'd prefer).
>
It would
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #17 from Iain Buclaw ---
I have no strong preferences, if people are wanting to go with the .S file,
then that's fine by me, feel free to commit (or I will if you'd prefer).
I'm just noting that I've seen a patch to implement musl
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
Martin Liška changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Last reconfirmed|
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #16 from Florian Weimer ---
(In reply to rdapp from comment #15)
> Any feedback on the two options I proposed? Is the .S file variant (I posted
> last) ok?
I'd prefer the patch from comment 13, but I'm not a GCC developer. You
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #15 from rdapp at linux dot ibm.com ---
Any feedback on the two options I proposed? Is the .S file variant (I posted
last) ok?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #14 from Carlos O'Donell ---
My preference for would be a distinct *.S file as Florian suggests, it's the
most robust solution.
The only other alternative I would consider is a new __builtin_get_tls_offset()
that does what you want,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #13 from rdapp at linux dot ibm.com ---
Created attachment 46859
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=46859=edit
__tls_get_offset in separate .S files
As there were no further remarks as to which version is preferred
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #12 from Jakub Jelinek ---
Though, looking at libdruntime, it already handles that and has several *.S
files.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
Jakub Jelinek changed:
What|Removed |Added
CC||jakub at gcc dot gnu.org
--- Comment
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #10 from Florian Weimer ---
(In reply to rdapp from comment #9)
> I opted for inline assembly to make sure r12 is not changed directly before
> the function call. Do you have an idea to guarantee this in another way?
Wouldn't an
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #9 from rdapp at linux dot ibm.com ---
(In reply to Florian Weimer from comment #8)
> Calling functions from inline assembly is always a bit iffy. For example,
> your code lacks clobbers for the vector registers (if present) and the
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #8 from Florian Weimer ---
(In reply to rdapp from comment #7)
> Created attachment 46817 [details]
> Proposed patch using __tls_get_offset
>
> I drafted a patch that uses __tls_get_offset instead of the internal symbol
> following
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
rdapp at linux dot ibm.com changed:
What|Removed |Added
CC||rdapp at linux dot ibm.com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #6 from Florian Weimer ---
__tls_get_offset looks like this:
__tls_get_offset:
la %r2,0(%r2,%r12)
jg __tls_get_addr
The caller should be able to prepare for the la instruction, by subtracting r12
from r2.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #5 from Iain Buclaw ---
(In reply to Florian Weimer from comment #4)
> (In reply to Iain Buclaw from comment #3)
> > The use of the function is for the garbage collector to be able to scan
> > native TLS data.
> >
> > The logic of
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #4 from Florian Weimer ---
(In reply to Iain Buclaw from comment #3)
> The use of the function is for the garbage collector to be able to scan
> native TLS data.
>
> The logic of said function pretty much matches what the glibc
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
--- Comment #3 from Iain Buclaw ---
The use of the function is for the garbage collector to be able to scan native
TLS data.
The logic of said function pretty much matches what the glibc macro
__TLS_GET_ADDR is doing.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
Florian Weimer changed:
What|Removed |Added
CC||fw at gcc dot gnu.org
--- Comment #2
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628
Carlos O'Donell changed:
What|Removed |Added
CC||carlos at redhat dot com
--- Comment
21 matches
Mail list logo
