[Bug fortran/79854] diagnostics: gfc_conv_constant_to_tree should be gfc_internal_error
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79854 Dominique d'Humieres changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #7 from Dominique d'Humieres --- Closing.
[Bug fortran/79854] diagnostics: gfc_conv_constant_to_tree should be gfc_internal_error
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79854 --- Comment #6 from dominiq at gcc dot gnu.org --- Author: dominiq Date: Sun Jun 10 12:50:03 2018 New Revision: 261387 URL: https://gcc.gnu.org/viewcvs?rev=261387=gcc=rev Log: 2018-06-10 Dominique d'Humieres PR fortran/79854 * trans-const.c: Remove include "diagnostic-core.h". (gfc_conv_constant_to_tree): Replace fatal_error with gcc_unreachable. Modified: trunk/gcc/fortran/ChangeLog trunk/gcc/fortran/trans-const.c
[Bug fortran/79854] diagnostics: gfc_conv_constant_to_tree should be gfc_internal_error
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79854 Thomas Koenig changed: What|Removed |Added CC||tkoenig at gcc dot gnu.org --- Comment #5 from Thomas Koenig --- (In reply to Dominique d'Humieres from comment #4) > Would not it be better to use > > gcc_unreachable (); > > as it is done in numerous places? Sounds like a good idea to me. Dominique, do you want to prepare a patch along these lines?
[Bug fortran/79854] diagnostics: gfc_conv_constant_to_tree should be gfc_internal_error
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79854 --- Comment #4 from Dominique d'Humieres --- > Unless someone can trigger this error or can prove that gfc_internal_error > is available when the error ought to trigger, then please leave the > code as is. Would not it be better to use gcc_unreachable (); as it is done in numerous places?
[Bug fortran/79854] diagnostics: gfc_conv_constant_to_tree should be gfc_internal_error
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79854 kargl at gcc dot gnu.org changed: What|Removed |Added Priority|P3 |P5
[Bug fortran/79854] diagnostics: gfc_conv_constant_to_tree should be gfc_internal_error
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79854 kargl at gcc dot gnu.org changed: What|Removed |Added CC||kargl at gcc dot gnu.org --- Comment #3 from kargl at gcc dot gnu.org --- (In reply to Eric Gallager from comment #2) > (In reply to Dominique d'Humieres from comment #1) > > AFAICT this internal error has never triggered. If someone can come with a > > test for it, this would be nice. > > In the meantime, though, I think it'd make sense just to change it to an > internal error anyways (even without a testcase), for translation purposes Unless someone can trigger this error or can prove that gfc_internal_error is available when the error ought to trigger, then please leave the code as is. fatal_error() is used in a number places because gfortran's error mechanism is not available. See gfc_init() and gfc_init_1().
[Bug fortran/79854] diagnostics: gfc_conv_constant_to_tree should be gfc_internal_error
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79854 Eric Gallager changed: What|Removed |Added Keywords||diagnostic CC||egallager at gcc dot gnu.org Severity|normal |trivial --- Comment #2 from Eric Gallager --- (In reply to Dominique d'Humieres from comment #1) > AFAICT this internal error has never triggered. If someone can come with a > test for it, this would be nice. In the meantime, though, I think it'd make sense just to change it to an internal error anyways (even without a testcase), for translation purposes
[Bug fortran/79854] diagnostics: gfc_conv_constant_to_tree should be gfc_internal_error
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79854 Dominique d'Humieres changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed||2017-07-26 Assignee|unassigned at gcc dot gnu.org |dominiq at lps dot ens.fr Ever confirmed|0 |1 --- Comment #1 from Dominique d'Humieres --- AFAICT this internal error has never triggered. If someone can come with a test for it, this would be nice.
