[Bug fortran/84313] [F08] reject procedure pointers in COMMON blocks

2018-02-14 Thread jakub at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84313

--- Comment #4 from Jakub Jelinek  ---
Author: jakub
Date: Wed Feb 14 12:12:15 2018
New Revision: 257654

URL: https://gcc.gnu.org/viewcvs?rev=257654&root=gcc&view=rev
Log:
PR fortran/84313
* testsuite/libgomp.fortran/threadprivate4.f90: Add
-std=f2003 -fall-intrinsics into dg-additional-options.

Modified:
trunk/libgomp/ChangeLog
trunk/libgomp/testsuite/libgomp.fortran/threadprivate4.f90

[Bug fortran/84313] [F08] reject procedure pointers in COMMON blocks

2018-02-13 Thread janus at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84313

janus at gcc dot gnu.org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
   Target Milestone|--- |8.0

--- Comment #3 from janus at gcc dot gnu.org ---
Fixed with r257636. Closing.

[Bug fortran/84313] [F08] reject procedure pointers in COMMON blocks

2018-02-13 Thread janus at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84313

--- Comment #2 from janus at gcc dot gnu.org ---
Author: janus
Date: Tue Feb 13 21:00:37 2018
New Revision: 257636

URL: https://gcc.gnu.org/viewcvs?rev=257636&root=gcc&view=rev
Log:
2018-02-13  Janus Weil  

PR fortran/84313
* symbol.c (check_conflict): Reject procedure pointers in common
blocks.


2018-02-13  Janus Weil  

PR fortran/84313
* gfortran.dg/proc_ptr_common_1.f90: Fix invalid test case,
add necessary compiler options.
* gfortran.dg/proc_ptr_common_2.f90: Add missing error message.

Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/symbol.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gfortran.dg/proc_ptr_common_1.f90
trunk/gcc/testsuite/gfortran.dg/proc_ptr_common_2.f90

[Bug fortran/84313] [F08] reject procedure pointers in COMMON blocks

2018-02-12 Thread janus at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84313

janus at gcc dot gnu.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Last reconfirmed||2018-02-12
   Assignee|unassigned at gcc dot gnu.org  |janus at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #1 from janus at gcc dot gnu.org ---
This should do it:


Index: gcc/fortran/symbol.c
===
--- gcc/fortran/symbol.c(revision 257589)
+++ gcc/fortran/symbol.c(working copy)
@@ -809,7 +809,7 @@ check_conflict (symbol_attribute *attr, const char
conf2 (threadprivate);
}

-  if (!attr->proc_pointer)
+  if (!attr->proc_pointer || (gfc_option.allow_std & GFC_STD_F2008))
conf2 (in_common);

   conf2 (omp_declare_target_link);