[Bug fortran/95544] ICE in gfc_can_put_var_on_stack, at fortran/trans-decl.c:494
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95544 anlauf at gcc dot gnu.org changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #10 from anlauf at gcc dot gnu.org --- Fixed on master for GCC-11, and backported to 10-branch along with the fix for pr93366, which is a prerequisite for this one. Backport to 9-branch would require additional work. Since this is not a regression and an ICE on invalid, not done. Closing. Thanks for the report!
[Bug fortran/95544] ICE in gfc_can_put_var_on_stack, at fortran/trans-decl.c:494
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95544 --- Comment #9 from CVS Commits --- The releases/gcc-10 branch has been updated by Harald Anlauf : https://gcc.gnu.org/g:b0feef39fe53fbc46c22ac0c745f91dbf96cdd00 commit r10-8302-gb0feef39fe53fbc46c22ac0c745f91dbf96cdd00 Author: Harald Anlauf Date: Thu Jun 11 20:29:45 2020 +0200 PR fortran/95544 - Fix ICE in NULL() argument to intrinsics Fortran 2018: An argument to an intrinsic procedure other than ASSOCIATED, NULL, or PRESENT shall be a data object. An EXPR_NULL is not a data object. Add checks for intrinsics. 2020-06-11 Steven G. Kargl Harald Anlauf gcc/fortran/ PR fortran/95544 * check.c (invalid_null_arg): Rename to gfc_invalid_null_arg. (gfc_check_associated, gfc_check_kind, gfc_check_merge) (gfc_check_shape, gfc_check_size, gfc_check_spread) (gfc_check_transfer): Adjust. (gfc_check_len_lentrim, gfc_check_trim): Check for NULL() argument. * gfortran.h: Declare gfc_invalid_null_arg (). * intrinsic.c (check_arglist): Check for NULL() argument. (cherry picked from commit 7fd614ee818983274eb5e47cbb8ec68b20994963)
[Bug fortran/95544] ICE in gfc_can_put_var_on_stack, at fortran/trans-decl.c:494
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95544 --- Comment #8 from CVS Commits --- The master branch has been updated by Harald Anlauf : https://gcc.gnu.org/g:7fd614ee818983274eb5e47cbb8ec68b20994963 commit r11-1240-g7fd614ee818983274eb5e47cbb8ec68b20994963 Author: Harald Anlauf Date: Thu Jun 11 20:29:45 2020 +0200 PR fortran/95544 - Fix ICE in NULL() argument to intrinsics Fortran 2018: An argument to an intrinsic procedure other than ASSOCIATED, NULL, or PRESENT shall be a data object. An EXPR_NULL is not a data object. Add checks for intrinsics. 2020-06-11 Steven G. Kargl Harald Anlauf gcc/fortran/ PR fortran/95544 * check.c (invalid_null_arg): Rename to gfc_invalid_null_arg. (gfc_check_associated, gfc_check_kind, gfc_check_merge) (gfc_check_shape, gfc_check_size, gfc_check_spread) (gfc_check_transfer): Adjust. (gfc_check_len_lentrim, gfc_check_trim): Check for NULL() argument. * gfortran.h: Declare gfc_invalid_null_arg (). * intrinsic.c (check_arglist): Check for NULL() argument.
[Bug fortran/95544] ICE in gfc_can_put_var_on_stack, at fortran/trans-decl.c:494
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95544 --- Comment #7 from Steve Kargl --- On Mon, Jun 08, 2020 at 08:02:48PM +, anlauf at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95544 > > anlauf at gcc dot gnu.org changed: > >What|Removed |Added > > CC||anlauf at gcc dot gnu.org > > --- Comment #5 from anlauf at gcc dot gnu.org --- > Created attachment 48708 > --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48708=edit > Cleaned up patch > > Hi Steve, > > since there is already a function invalid_null_arg(), it can be reused. > > If you do not object, I'll package it for you. > No problem. I was aware of invalid_null_arg(), but simply copied a nearby gfc_error().
[Bug fortran/95544] ICE in gfc_can_put_var_on_stack, at fortran/trans-decl.c:494
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95544 --- Comment #6 from anlauf at gcc dot gnu.org --- Submitted for review here: https://gcc.gnu.org/pipermail/fortran/2020-June/054499.html
[Bug fortran/95544] ICE in gfc_can_put_var_on_stack, at fortran/trans-decl.c:494
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95544 anlauf at gcc dot gnu.org changed: What|Removed |Added CC||anlauf at gcc dot gnu.org --- Comment #5 from anlauf at gcc dot gnu.org --- Created attachment 48708 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48708=edit Cleaned up patch Hi Steve, since there is already a function invalid_null_arg(), it can be reused. If you do not object, I'll package it for you. Regarding comment#4, please create a separate PR.
[Bug fortran/95544] ICE in gfc_can_put_var_on_stack, at fortran/trans-decl.c:494
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95544
--- Comment #4 from Steve Kargl ---
Likely, want to include this in the commit if someone ever gets
around to committing the patch(es).
Index: gcc/fortran/misc.c
===
--- gcc/fortran/misc.c (revision 280157)
+++ gcc/fortran/misc.c (working copy)
@@ -252,7 +252,8 @@ gfc_dummy_typename (gfc_typespec *ts)
has_length = ts->u.cl->length != NULL;
if (!has_length)
{
- if (ts->kind == gfc_default_character_kind)
+ if (ts->kind == gfc_default_character_kind
+ || ts->kind == 0)
sprintf(buffer, "CHARACTER(*)");
else if (ts->kind < 10)
sprintf(buffer, "CHARACTER(*,%d)", ts->kind);
[Bug fortran/95544] ICE in gfc_can_put_var_on_stack, at fortran/trans-decl.c:494
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95544
--- Comment #3 from kargl at gcc dot gnu.org ---
Updated patch to deal with comments #1.
Index: gcc/fortran/intrinsic.c
===
--- gcc/fortran/intrinsic.c (revision 280157)
+++ gcc/fortran/intrinsic.c (working copy)
@@ -4428,6 +4428,19 @@ check_arglist (gfc_actual_arglist **ap, gfc_intrinsic_
return false;
}
+ /* F2018, p. 328: An argument to an intrinsic procedure other than
+ASSOCIATED, NULL, or PRESENT shall be a data object. A EXPR_NULL
+is not a data object. */
+ if (actual->expr->expr_type == EXPR_NULL
+ && !(strcmp(gfc_current_intrinsic, "associated") == 0
+ || strcmp(gfc_current_intrinsic, "null") == 0
+ || strcmp(gfc_current_intrinsic, "present") == 0))
+ {
+ gfc_error ("NULL() at %L cannot appear as an actual argument in %qs",
+>expr->where, gfc_current_intrinsic);
+ return false;
+ }
+
/* If the formal argument is INTENT([IN]OUT), check for definability.
*/
if (formal->intent == INTENT_INOUT || formal->intent == INTENT_OUT)
{
Index: gcc/fortran/check.c
===
--- gcc/fortran/check.c (revision 280157)
+++ gcc/fortran/check.c (working copy)
@@ -3444,8 +3444,16 @@ gfc_check_len_lentrim (gfc_expr *s, gfc_expr *kind)
if (!type_check (s, 0, BT_CHARACTER))
return false;
+ if (s->expr_type == EXPR_NULL)
+{
+ gfc_error ("Intrinsic function NULL at %L cannot be an actual "
+"argument to %qs", >where, gfc_current_intrinsic);
+ return false;
+}
+
if (!kind_check (kind, 1, BT_INTEGER))
return false;
+
if (kind && !gfc_notify_std (GFC_STD_F2003, "%qs intrinsic "
"with KIND argument at %L",
gfc_current_intrinsic, >where))
@@ -6377,6 +6385,13 @@ gfc_check_trim (gfc_expr *x)
{
if (!type_check (x, 0, BT_CHARACTER))
return false;
+
+ if (x->expr_type == EXPR_NULL)
+{
+ gfc_error ("Intrinsic function NULL at %L cannot be an actual "
+"argument to %qs", >where, gfc_current_intrinsic);
+ return false;
+}
if (!scalar_check (x, 0))
return false;
[Bug fortran/95544] ICE in gfc_can_put_var_on_stack, at fortran/trans-decl.c:494
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95544
kargl at gcc dot gnu.org changed:
What|Removed |Added
Priority|P3 |P4
CC||kargl at gcc dot gnu.org
Last reconfirmed||2020-06-04
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #2 from kargl at gcc dot gnu.org ---
There may be a better (or more restrictive) test, but this cures the issues.
Index: gcc/fortran/intrinsic.c
===
--- gcc/fortran/intrinsic.c (revision 280157)
+++ gcc/fortran/intrinsic.c (working copy)
@@ -4428,6 +4428,19 @@ check_arglist (gfc_actual_arglist **ap, gfc_intrinsic_
return false;
}
+ /* F2018, p. 328: An argument to an intrinsic procedure other than
+ASSOCIATED, NULL, or PRESENT shall be a data object. A EXPR_NULL
+is not a data object. */
+ if (actual->expr->expr_type == EXPR_NULL
+ && !(strcmp(gfc_current_intrinsic, "associated") == 0
+ || strcmp(gfc_current_intrinsic, "null") == 0
+ || strcmp(gfc_current_intrinsic, "present") == 0))
+ {
+ gfc_error ("NULL() at %L cannot appear as an actual argument in %qs",
+>expr->where, gfc_current_intrinsic);
+ return false;
+ }
+
/* If the formal argument is INTENT([IN]OUT), check for definability.
*/
if (formal->intent == INTENT_INOUT || formal->intent == INTENT_OUT)
{
[Bug fortran/95544] ICE in gfc_can_put_var_on_stack, at fortran/trans-decl.c:494
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95544 G. Steinmetz changed: What|Removed |Added Keywords||ice-on-invalid-code --- Comment #1 from G. Steinmetz --- Related : $ cat za1.f90 program p character(:), allocatable :: z print *, len(null(z)) print *, len_trim(null(z)) end $ cat za2.f90 program p character(:), pointer :: z print *, len(null(z)) print *, len_trim(null(z)) end $ cat zz1.f90 program p character(:), allocatable :: z z = trim(null(z)) end
