[Bug go/89321] cross build with riscv64 gccgo compilation failed due to assert in constructor_expression

2019-02-14 Thread ian at airs dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89321

Ian Lance Taylor  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Ian Lance Taylor  ---
Should be fixed.

[Bug go/89321] cross build with riscv64 gccgo compilation failed due to assert in constructor_expression

2019-02-14 Thread ian at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89321

--- Comment #7 from ian at gcc dot gnu.org  ---
Author: ian
Date: Thu Feb 14 21:07:13 2019
New Revision: 268904

URL: https://gcc.gnu.org/viewcvs?rev=268904=gcc=rev
Log:
PR go/89321
compiler: copy has_padding field from converted struct

Test case is https://golang.org/cl/162617.

Fixes https://gcc.gnu.org/PR89321

Reviewed-on: https://go-review.googlesource.com/c/162618

Modified:
trunk/gcc/go/gofrontend/MERGE
trunk/gcc/go/gofrontend/types.cc

[Bug go/89321] cross build with riscv64 gccgo compilation failed due to assert in constructor_expression

2019-02-13 Thread ian at airs dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89321

--- Comment #6 from Ian Lance Taylor  ---
Thanks very much for reducing the test case.

I sent out the fix for review at https://golang.org/cl/162618.  It should be
committed shortly.

[Bug go/89321] cross build with riscv64 gccgo compilation failed due to assert in constructor_expression

2019-02-13 Thread sean.wang at wdc dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89321

--- Comment #5 from sean.wang at wdc dot com ---
Created attachment 45709
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=45709=edit
code sample for reproducing reported error

code sample for reproducing reported error is attached.

[Bug go/89321] cross build with riscv64 gccgo compilation failed due to assert in constructor_expression

2019-02-13 Thread sean.wang at wdc dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89321

--- Comment #4 from sean.wang at wdc dot com ---
The assert it reached was this I think:
 gcc_assert(field == NULL_TREE);

Thanks, Ian. It is helpful. I think I found a way to reproduce this issue on a
smaller set of code. Will provide an example once I have everything stubbed
out.

[Bug go/89321] cross build with riscv64 gccgo compilation failed due to assert in constructor_expression

2019-02-12 Thread ian at airs dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89321

--- Comment #3 from Ian Lance Taylor  ---
I'm not sure exactly what assert it is, because there is no assert on that line
of go-gcc.cc.  But it is most likely an assertion saying that when compiling a
struct composite literal, the number of fields in the struct does not match the
number of values in the composite literal.  That should be impossible, since
the compiler fills in zero values as needed.  So unfortunately I'm not sure
that is all that helpful.

[Bug go/89321] cross build with riscv64 gccgo compilation failed due to assert in constructor_expression

2019-02-12 Thread sean.wang at wdc dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89321

--- Comment #2 from sean.wang at wdc dot com ---
I can certainly try. Based on the backtrace, do you have an educated guess on
what type of condition in the code that I can try to isolate? For example, what
does the assert condition mean? Thank you.

[Bug go/89321] cross build with riscv64 gccgo compilation failed due to assert in constructor_expression

2019-02-12 Thread ian at airs dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89321

--- Comment #1 from Ian Lance Taylor  ---
In order to fix this problem I will most likely need some way to reproduce it. 
Can you share a cut down version of the source code that triggers the problem? 
Do you happen to know if the problem occurs when compiling for amd64?