[Bug libfortran/45723] opening /dev/null for appending writes

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45723

Janne Blomqvist  changed:

   What|Removed |Added

 CC||jb at gcc dot gnu.org

--- Comment #8 from Janne Blomqvist  2011-11-07 14:35:57 
UTC ---
For the motivations behind this revert, see
http://gcc.gnu.org/ml/fortran/2011-10/msg00289.html

For the short version: Note that seeking on /dev/null still works at least on
Linux.

[Bug libfortran/45723] opening /dev/null for appending writes

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45723

--- Comment #7 from Janne Blomqvist  2011-11-07 14:32:56 
UTC ---
Author: jb
Date: Mon Nov  7 14:32:50 2011
New Revision: 181085

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181085
Log:
Revert previous fix for PR 45723.

libgfortran ChangeLog:

2011-11-07  Janne Blomqvist  

PR libfortran/45723
* io/open.c (new_unit): Don't check file size before attempting
seek.


testsuite ChangeLog:

2011-11-07  Janne Blomqvist  

PR libfortran/45723
* gfortran.dg/open_dev_null.F90: Remove testcase.


Removed:
trunk/gcc/testsuite/gfortran.dg/open_dev_null.f90
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/libgfortran/ChangeLog
trunk/libgfortran/io/open.c

[Bug libfortran/45723] opening /dev/null for appending writes

[jvdelisle at gcc dot gnu dot org]

--- Comment #6 from jvdelisle at gcc dot gnu dot org  2010-09-22 15:07 
---
I don't see a need to backport. Closing


-- 

jvdelisle at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45723

[Bug libfortran/45723] opening /dev/null for appending writes

[Joost dot VandeVondele at pci dot uzh dot ch]

--- Comment #5 from Joost dot VandeVondele at pci dot uzh dot ch  
2010-09-22 11:31 ---
I guess this bug can be closed unless you intend backporting to earlier
versions.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45723

[Bug libfortran/45723] opening /dev/null for appending writes

[jvdelisle at gcc dot gnu dot org]

--- Comment #4 from jvdelisle at gcc dot gnu dot org  2010-09-22 03:10 
---
Subject: Bug 45723

Author: jvdelisle
Date: Wed Sep 22 03:10:24 2010
New Revision: 164507

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164507
Log:
2010-09-21  Jerry DeLisle  

PR libfortran/45723
* io/open.c (new_unit): On POSITION_APPEND don't seek if file length is
zero.

Modified:
trunk/libgfortran/ChangeLog
trunk/libgfortran/io/open.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45723

[Bug libfortran/45723] opening /dev/null for appending writes

[Joost dot VandeVondele at pci dot uzh dot ch]

--- Comment #3 from Joost dot VandeVondele at pci dot uzh dot ch  
2010-09-20 06:30 ---
(In reply to comment #2)
> Created an attachment (id=21841)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21841&action=view) [edit]
> Possible patch
> 
> This patch passes regression testing. Don't seek if filesize is zero.
> 
seems like a clean solution... thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45723

[Bug libfortran/45723] opening /dev/null for appending writes

[jvdelisle at gcc dot gnu dot org]

--- Comment #2 from jvdelisle at gcc dot gnu dot org  2010-09-20 04:46 
---
Created an attachment (id=21841)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21841&action=view)
Possible patch

This patch passes regression testing. Don't seek if filesize is zero.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45723

[Bug libfortran/45723] opening /dev/null for appending writes

[jvdelisle at gcc dot gnu dot org]

--- Comment #1 from jvdelisle at gcc dot gnu dot org  2010-09-19 20:01 
---
This is an OS specific error.  libgfortran is attempting to seek to the end of
the file to prepare for appending.  Obviously, one can not seek /dev/null.

I will see if we can detect that the file is unseekable and if that is the case
we can start appending AS-IS.


-- 

jvdelisle at gcc dot gnu dot org changed:

   What|Removed |Added

 AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
   |dot org |org
 Status|UNCONFIRMED |ASSIGNED
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2010-09-19 20:01:18
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45723

[Bug libfortran/45723] opening /dev/null for appending writes

[Joost dot VandeVondele at pci dot uzh dot ch]

-- 

Joost dot VandeVondele at pci dot uzh dot ch changed:

   What|Removed |Added

   Severity|normal  |enhancement


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45723