[Bug libgcj/51498] [4.7 regression] temporary hack to make dejagnu work in libjava
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51498 --- Comment #8 from Richard Guenther rguenth at gcc dot gnu.org 2012-01-04 13:40:19 UTC --- Oh, and why is this a regression?
[Bug libgcj/51498] [4.7 regression] temporary hack to make dejagnu work in libjava
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51498
--- Comment #6 from Jakub Jelinek jakub at gcc dot gnu.org 2011-12-15
12:41:49 UTC ---
Do you have a new enough version of dejagnu?
There is no need for any of these variables.
libjava.exp has:
if ![info exists GCJ_UNDER_TEST] {
if [info exists TOOL_EXECUTABLE] {
set GCJ_UNDER_TEST $TOOL_EXECUTABLE;
} else {
if [info exists env(GCJ)] {
set GCJ_UNDER_TEST $env(GCJ)
} else {
set GCJ_UNDER_TEST [find_gcj]
}
}
}
and my dejagnu does (in /usr/share/dejagnu/libgloss.exp):
proc find_gcj {} {
global tool_root_dir
if {![is_remote host]} {
set file [lookfor_file $tool_root_dir gcj]
if { $file == } {
set file [lookfor_file $tool_root_dir gcc/gcj]
}
if { $file != } {
set CC $file -B[file dirname $file]/
} else {
set CC [transform gcj]
}
} else {
set CC [transform gcj]
}
return $CC
}
so it should figure that out automatically. Aren't you e.g. building in source
directory (./configure ...)? Otherwise it would be good if you could debug why
in your case it isn't finding the right tool_root_dir and gcj in it (debugging
printouts in libjava.exp and libgloss.exp).
[Bug libgcj/51498] [4.7 regression] temporary hack to make dejagnu work in libjava
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51498 --- Comment #7 from gee jojelino at gmail dot com 2011-12-15 13:00:58 UTC --- (In reply to comment #6) so it should figure that out automatically. Aren't you e.g. building in source directory (./configure ...)? Otherwise it would be good if you could debug why in your case it isn't finding the right tool_root_dir and gcj in it (debugging printouts in libjava.exp and libgloss.exp). Using /usr/share/dejagnu/runtest.exp as main test driver INTERPRETER is now yes Verbose level is 1 Login name is Administrator Found /tmp/gcc/i686-pc-mingw32/libjava/testsuite/site.exp Found /tmp/gcc/i686-pc-mingw32/libjava/testsuite/site.exp Using test sources in ../../.././libjava/testsuite Using test binaries in /tmp/gcc/i686-pc-mingw32/libjava/testsuite Tool root directory is /tmp/gcc/i686-pc-mingw32 Using /usr/share/dejagnu to find libraries since i'm doing canadian-cross, it can't find gcj in /tmp/gcc/i686-pc-mingw32/gcc (which libgross.exp assumed).
[Bug libgcj/51498] [4.7 regression] temporary hack to make dejagnu work in libjava
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51498 Jakub Jelinek jakub at gcc dot gnu.org changed: What|Removed |Added CC||jakub at gcc dot gnu.org --- Comment #4 from Jakub Jelinek jakub at gcc dot gnu.org 2011-12-13 08:36:16 UTC --- None of the testsuite Makefiles for other libraries do anything similar (libgomp, libstdc++-v3, ..., so why is libjava so special that it needs it?). make check definitely works just fine for me and uses the newly built gcj etc. rather than the system gcj. So please expand on what exact errors you saw, details from the libjava.log where it shows etc.
[Bug libgcj/51498] [4.7 regression] temporary hack to make dejagnu work in libjava
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51498
--- Comment #5 from gee jojelino at gmail dot com 2011-12-13 10:48:50 UTC ---
(In reply to comment #4)
None of the testsuite Makefiles for other libraries do anything similar
(libgomp, libstdc++-v3, ..., so why is libjava so special that it needs it?).
make check definitely works just fine for me and uses the newly built gcj etc.
rather than the system gcj. So please expand on what exact errors you saw,
details from the libjava.log where it shows etc.
/usr/bin/make check-DEJAGNU
make[1]: Entering directory `/tmp/gcc/i686-pc-mingw32/libjava/testsuite'
Making a new site.exp file...
srcdir=`CDPATH=${ZSH_VERSION+.}: cd ../../.././libjava/testsuite pwd`;
export srcdir; \
EXPECT=`if [ -f ../../expect/expect ] ; then echo ../../expect/expect ; else
echo expect ; fi`; export EXPECT; \
runtest=`if [ -f ../../.././libjava/../dejagnu/runtest ] ; then echo
../../.././libjava/../dejagnu/runtest ; else echo runtest; fi`
INTERPRETER=yes; \
if /bin/sh -c $runtest --version /dev/null 21; then \
exit_status=0; l='libjava'; for tool in $l; do \
if $runtest INTERPRETER=yes --tool $tool --srcdir $srcdir ; \
then :; else exit_status=1; fi; \
done; \
else echo WARNING: could not find \`runtest' 12; :;\
fi; \
exit $exit_status
WARNING: Couldn't find the global config file.
Test Run By Administrator on Tue Dec 13 19:48:20 2011
Target is i686-pc-mingw32
Host is i686-pc-mingw32
Build is i686-pc-cygwin
=== libjava tests ===
Schedule of variations:
unix
Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /tmp/gcc/libjava/testsuite/config/default.exp as tool-and-target-specific
interface file.
WARNING: Assuming target board is the local machine (which is probably wrong).
You may need to set your DEJAGNU environment variable.
Running /tmp/gcc/libjava/testsuite/libjava.cni/cni.exp ...
couldn't execute gcj: no such file or directory
while executing
exec gcj -B/tmp/gcc/i686-pc-mingw32/libjava/testsuite/../ -v 2@ stdout
(eval body line 1)
invoked from within
eval exec $GCJ_UNDER_TEST -B$specdir -v 2@ stdout
(procedure libjava_init line 46)
invoked from within
${tool}_init $test_file_name
invoked from within
if [info exists tool] {
if { [info procs ${tool}_init] != } {
${tool}_init $test_file_name;
}
}
invoked from within
if [file exists $test_file_name] {
set timestart [timestamp];
if [info exists tool] {
if { [info procs ${tool}_init] != } {
${tool}_ini...
(procedure runtest line 14)
invoked from within
runtest $test_name
(foreach body line 42)
invoked from within
foreach test_name [lsort [find ${dir} *.exp]] {
if { ${test_name} == } {
continue
}
# Ignore this one if asked to.
if { ${ignore...
(foreach body line 54)
invoked from within
foreach dir ${test_top_dirs} {
if { ${dir} != ${srcdir} } {
# Ignore this directory if is a directory to be
# ignored.
if {[info...
(foreach body line 121)
invoked from within
foreach pass $multipass {
# multipass_name is set for `record_test' to use (see framework.exp).
if { [lindex $pass 0] != } {
set multipass_...
(foreach body line 51)
invoked from within
foreach current_target $target_list {
verbose target is $current_target;
set current_target_name $current_target;
set tlist [split $curr...
(file /usr/share/dejagnu/runtest.exp line 1623)
Makefile:385: recipe for target `check-DEJAGNU' failed
make[1]: *** [check-DEJAGNU] Error 1
make[1]: Leaving directory `/tmp/gcc/i686-pc-mingw32/libjava/testsuite'
Makefile:403: recipe for target `check-am' failed
make: *** [check-am] Error 2
[Bug libgcj/51498] [4.7 regression] temporary hack to make dejagnu work in libjava
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51498 Richard Guenther rguenth at gcc dot gnu.org changed: What|Removed |Added Status|UNCONFIRMED |WAITING Last reconfirmed||2011-12-12 Target Milestone|--- |4.7.0 Ever Confirmed|0 |1 --- Comment #1 from Richard Guenther rguenth at gcc dot gnu.org 2011-12-12 10:12:46 UTC --- What's the issue you are fixing?
[Bug libgcj/51498] [4.7 regression] temporary hack to make dejagnu work in libjava
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51498 --- Comment #2 from gee jojelino at gmail dot com 2011-12-12 10:41:04 UTC --- (In reply to comment #1) What's the issue you are fixing? i experienced the dejagnu error that gcj is not found in path. this is because of gnu make doesn't export its variable to environment implicitly. as you can see. in makefile, the EXPECT variable is exported explicitly. so, other variable that dejagnu exp file uses also need to be exported so. in my observation, GCJ SUN_JAVAC LD_LIBRARY_PATH CLASSPATH MAUVEDIR is needed to proper use of dejagnu testsuite. so i exported it.
[Bug libgcj/51498] [4.7 regression] temporary hack to make dejagnu work in libjava
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51498 --- Comment #3 from Richard Guenther rguenth at gcc dot gnu.org 2011-12-12 11:22:33 UTC --- SUN_JAVAC and MAUVEDIR are weird though, we are testing GCJ after all.
