[Bug libstdc++/29366] atomics config for sh is weird
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=29366 Eric Gallager changed: What|Removed |Added Status|WAITING |ASSIGNED Assignee|unassigned at gcc dot gnu.org |olegendo at gcc dot gnu.org --- Comment #11 from Eric Gallager --- (In reply to Oleg Endo from comment #10) > (In reply to Eric Gallager from comment #9) > > > > Did this fix things? > > No, not entirely. The whole config/cpu/sh/atomicity.h header should not be > required, but because of PR 53579, it is. > > Please do not close any SH related PR's just for the sake of reducing the > number of PR's. I keep them open because they are actual issues. Assigning to you, then, per our discussion in bug 30065 (and since you've already made a commit towards fixing this one)
[Bug libstdc++/29366] atomics config for sh is weird
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=29366 --- Comment #10 from Oleg Endo --- (In reply to Eric Gallager from comment #9) > > Did this fix things? No, not entirely. The whole config/cpu/sh/atomicity.h header should not be required, but because of PR 53579, it is. Please do not close any SH related PR's just for the sake of reducing the number of PR's. I keep them open because they are actual issues.
[Bug libstdc++/29366] atomics config for sh is weird
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=29366 Eric Gallager changed: What|Removed |Added CC||egallager at gcc dot gnu.org --- Comment #9 from Eric Gallager --- (In reply to Oleg Endo from comment #8) > Author: olegendo > Date: Sun Jan 25 16:54:33 2015 > New Revision: 220094 > > URL: https://gcc.gnu.org/viewcvs?rev=220094&root=gcc&view=rev > Log: > libstdc++-v3/ > PR target/29366 > * config/cpu/sh/atomicity.h (__exchange_and_add, __atomic_add): > Remove SH4A inline asm and lock based implementations and use the > defaults from ext/atomicity.h. > > Modified: > trunk/libstdc++-v3/ChangeLog > trunk/libstdc++-v3/config/cpu/sh/atomicity.h Did this fix things?
[Bug libstdc++/29366] atomics config for sh is weird
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=29366 --- Comment #8 from Oleg Endo --- Author: olegendo Date: Sun Jan 25 16:54:33 2015 New Revision: 220094 URL: https://gcc.gnu.org/viewcvs?rev=220094&root=gcc&view=rev Log: libstdc++-v3/ PR target/29366 * config/cpu/sh/atomicity.h (__exchange_and_add, __atomic_add): Remove SH4A inline asm and lock based implementations and use the defaults from ext/atomicity.h. Modified: trunk/libstdc++-v3/ChangeLog trunk/libstdc++-v3/config/cpu/sh/atomicity.h
[Bug libstdc++/29366] atomics config for sh is weird
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=29366 --- Comment #7 from Kazumoto Kojima --- (In reply to Oleg Endo from comment #6) > The patch works on a default sh-elf/newlib config -- it just uses the > single-thread fake atomics from libstdc++. Kaz, could you please try the > patch on sh4-linux? I've confirmed that there is no new failures on sh4-unknown-linux-gnu with it.
[Bug libstdc++/29366] atomics config for sh is weird
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=29366 --- Comment #6 from Oleg Endo --- Created attachment 34478 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34478&action=edit proposed workaround patch There hasn't been any update for PR 53579. I'd like to propose the attached patch as a work around until the CXXFLAGS_FOR_TARGET issues has been figured/sorted out. The patch works on a default sh-elf/newlib config -- it just uses the single-thread fake atomics from libstdc++. Kaz, could you please try the patch on sh4-linux?
[Bug libstdc++/29366] atomics config for sh is weird
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29366 Oleg Endo changed: What|Removed |Added Depends on||53579 --- Comment #5 from Oleg Endo 2012-06-05 00:19:41 UTC --- (In reply to comment #4) > I've just committed the essential patch for PR 52941 which should allow us to > remove config/cpu/sh/atomicity.h now. > > Is is enough to simply delete the whole config/cpu/sh dir, or is there more to > be done? Apparently there is more to be done: PR 53579 ;)
[Bug libstdc++/29366] atomics config for sh is weird
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29366 Oleg Endo changed: What|Removed |Added Depends on|52941 | --- Comment #4 from Oleg Endo 2012-05-29 21:15:27 UTC --- I've just committed the essential patch for PR 52941 which should allow us to remove config/cpu/sh/atomicity.h now. Is is enough to simply delete the whole config/cpu/sh dir, or is there more to be done?
[Bug libstdc++/29366] atomics config for sh is weird
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29366 Oleg Endo changed: What|Removed |Added Status|UNCONFIRMED |WAITING Last reconfirmed||2012-04-12 Depends on||52941 Ever Confirmed|0 |1
[Bug libstdc++/29366] atomics config for sh is weird
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29366 --- Comment #3 from Kazumoto Kojima 2012-04-12 01:20:06 UTC --- (In reply to comment #2) > I think some of the problems will disappear once PR 52941 is done. > After that, and having the new atomic builtins of 4.7, we could get rid of the > config/cpu/sh/atomicity.h file completely, if I'm not mistaken. Agreed.
[Bug libstdc++/29366] atomics config for sh is weird
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29366 Oleg Endo changed: What|Removed |Added CC||olegendo at gcc dot gnu.org --- Comment #2 from Oleg Endo 2012-04-11 23:32:27 UTC --- I think some of the problems will disappear once PR 52941 is done. After that, and having the new atomic builtins of 4.7, we could get rid of the config/cpu/sh/atomicity.h file completely, if I'm not mistaken.
[Bug libstdc++/29366] atomics config for sh is weird
--- Comment #1 from paolo dot carlini at oracle dot com 2010-01-20 18:51 --- Let's add an SH maintainer in CC... -- paolo dot carlini at oracle dot com changed: What|Removed |Added CC||kkojima at gcc dot gnu dot ||org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29366
