[Bug middle-end/77475] unnecessary or misleading context in reporting command line problems

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77475

Martin Liška  changed:

   What|Removed |Added

 CC||noloader at gmail dot com

--- Comment #9 from Martin Liška  ---
*** Bug 79974 has been marked as a duplicate of this bug. ***

[Bug middle-end/77475] unnecessary or misleading context in reporting command line problems

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77475

--- Comment #8 from Jakub Jelinek  ---
Author: jakub
Date: Fri Sep 16 08:13:51 2016
New Revision: 240175

URL: https://gcc.gnu.org/viewcvs?rev=240175=gcc=rev
Log:
PR middle-end/77475
* gcc.target/i386/pr65990.c: Adjust dg-error regexp.

Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gcc.target/i386/pr65990.c

[Bug middle-end/77475] unnecessary or misleading context in reporting command line problems

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77475

Jakub Jelinek  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Jakub Jelinek  ---
Fixed.

[Bug middle-end/77475] unnecessary or misleading context in reporting command line problems

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77475

--- Comment #6 from Jakub Jelinek  ---
Author: jakub
Date: Thu Sep 15 12:26:39 2016
New Revision: 240162

URL: https://gcc.gnu.org/viewcvs?rev=240162=gcc=rev
Log:
PR middle-end/77475
* config/i386/i386.c (ix86_parse_stringop_strategy_string): Simplify,
use %qs instead of %s where desirable, use argument instead of arg in
the diagnostic wording, add list of supported strategies and
spellcheck hint.
(ix86_option_override_internal): Emit target("m...") instead of
option("m...") in the diagnostic.  Use %qs instead of %s in invalid
-march/-mtune option diagnostic.  Add list of supported arches/tunings
and spellcheck hint.  Remove prefix, suffix and sw variables, use
main_args_p ? "..." : "..." in diagnostics to make translation
possible.

* gcc.target/i386/pr65990.c: Adjust expected diagnostics.
* gcc.dg/march-generic.c: Likewise.
* gcc.target/i386/spellcheck-options-1.c: New test.
* gcc.target/i386/spellcheck-options-2.c: New test.
* gcc.target/i386/spellcheck-options-3.c: New test.
* gcc.target/i386/spellcheck-options-4.c: New test.

Added:
trunk/gcc/testsuite/gcc.target/i386/spellcheck-options-1.c
trunk/gcc/testsuite/gcc.target/i386/spellcheck-options-2.c
trunk/gcc/testsuite/gcc.target/i386/spellcheck-options-3.c
trunk/gcc/testsuite/gcc.target/i386/spellcheck-options-4.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/i386/i386.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gcc.dg/march-generic.c
trunk/gcc/testsuite/gcc.target/i386/pr65990.c

[Bug middle-end/77475] unnecessary or misleading context in reporting command line problems

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77475

--- Comment #5 from Jakub Jelinek  ---
Author: jakub
Date: Tue Sep 13 08:45:36 2016
New Revision: 240107

URL: https://gcc.gnu.org/viewcvs?rev=240107=gcc=rev
Log:
PR middle-end/77475
* opts.h (candidates_list_and_hint): Declare.
* opts-common.c (candidates_list_and_hint): New function.
(cmdline_handle_error): Use it.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/opts-common.c
trunk/gcc/opts.h

[Bug middle-end/77475] unnecessary or misleading context in reporting command line problems

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77475

--- Comment #4 from Christophe Lyon  ---
Author: clyon
Date: Wed Sep  7 20:18:17 2016
New Revision: 240030

URL: https://gcc.gnu.org/viewcvs?rev=240030=gcc=rev
Log:
PR middle-end/77475: Fix AArch64 testcases.

2016-09-07  Jakub Jelinek  

PR middle-end/77475
* gcc.target/aarch64/arch-diagnostics-1.c: Expect error on line 0.
* gcc.target/aarch64/arch-diagnostics-2.c: Likewise.
* gcc.target/aarch64/cpu-diagnostics-1.c: Likewise.
* gcc.target/aarch64/cpu-diagnostics-2.c: Likewise.
* gcc.target/aarch64/cpu-diagnostics-3.c: Likewise.
* gcc.target/aarch64/cpu-diagnostics-4.c: Likewise.


Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gcc.target/aarch64/arch-diagnostics-1.c
trunk/gcc/testsuite/gcc.target/aarch64/arch-diagnostics-2.c
trunk/gcc/testsuite/gcc.target/aarch64/cpu-diagnostics-1.c
trunk/gcc/testsuite/gcc.target/aarch64/cpu-diagnostics-2.c
trunk/gcc/testsuite/gcc.target/aarch64/cpu-diagnostics-3.c
trunk/gcc/testsuite/gcc.target/aarch64/cpu-diagnostics-4.c

[Bug middle-end/77475] unnecessary or misleading context in reporting command line problems

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77475

--- Comment #3 from Jakub Jelinek  ---
Author: jakub
Date: Mon Sep  5 18:14:25 2016
New Revision: 239994

URL: https://gcc.gnu.org/viewcvs?rev=239994=gcc=rev
Log:
PR middle-end/77475
* toplev.c (process_options): Temporarily set input_location
to UNKNOWN_LOCATION around targetm.target_option.override () call.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/toplev.c

[Bug middle-end/77475] unnecessary or misleading context in reporting command line problems

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77475

--- Comment #2 from Jakub Jelinek  ---
Created attachment 39565
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=39565=edit
gcc7-pr77475.patch

Given the number of targets that use targetm.target_options.override hook and
the amount of error/warning/sorry calls in them and that lots of targets also
use the same functions for pragma/target attribute handling, I think it is much
better to tweak toplev.c for this.  Bet it will have significant testsuite
fallout though.