[Bug middle-end/83423] default_static_chain is sorry for non-nested functions

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83423

Andrew Pinski  changed:

   What|Removed |Added

 CC||mpoulhies at kalray dot eu

--- Comment #8 from Andrew Pinski  ---
*** Bug 89328 has been marked as a duplicate of this bug. ***

[Bug middle-end/83423] default_static_chain is sorry for non-nested functions

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83423

Tom de Vries  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Tom de Vries  ---
Patch committed, marking resolved-fixed.

[Bug middle-end/83423] default_static_chain is sorry for non-nested functions

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83423

--- Comment #6 from Tom de Vries  ---
Author: vries
Date: Wed Dec 20 00:46:38 2017
New Revision: 255849

URL: https://gcc.gnu.org/viewcvs?rev=255849=gcc=rev
Log:
Don't call targetm.calls.static_chain in non-static function

2017-12-20  Tom de Vries  

PR middle-end/83423
* config/i386/i386.c (ix86_static_chain): Move DECL_STATIC_CHAIN test
...
* calls.c (rtx_for_static_chain): ... here.  New function.
* calls.h (rtx_for_static_chain): Declare.
* builtins.c (expand_builtin_setjmp_receiver): Use rtx_for_static_chain
instead of targetm.calls.static_chain.
* df-scan.c (df_get_entry_block_def_set): Same.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/builtins.c
trunk/gcc/calls.c
trunk/gcc/calls.h
trunk/gcc/config/i386/i386.c
trunk/gcc/df-scan.c

[Bug middle-end/83423] default_static_chain is sorry for non-nested functions

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83423

Tom de Vries  changed:

   What|Removed |Added

   Keywords||patch

--- Comment #5 from Tom de Vries  ---
submitted: https://gcc.gnu.org/ml/gcc-patches/2017-12/msg01269.html

[Bug middle-end/83423] default_static_chain is sorry for non-nested functions

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83423

--- Comment #4 from Tom de Vries  ---
(In reply to Tom de Vries from comment #2)
> Created attachment 42894 [details]
> Tentative patch fixing backend call sites

I'll bootstrap and regtest this patch on x86_64 once IT brings my bootstrap
machine back up.

[Bug middle-end/83423] default_static_chain is sorry for non-nested functions

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83423

Tom de Vries  changed:

   What|Removed |Added

 Status|WAITING |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Tom de Vries  ---
> Who When   What   Removed Added
> pinskia 2017-12-15 Status UNCONFIRMED WAITING

Here ( https://gcc.gnu.org/bugs/management.html ) I read:
...
WAITING
The submitter was asked for further information, or asked to try out a
patch. 
...

I don't understand from your comments what further information you want.

Moving back to UNCONFIRMED.

[Bug middle-end/83423] default_static_chain is sorry for non-nested functions

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83423

--- Comment #2 from Tom de Vries  ---
Created attachment 42894
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=42894=edit
Tentative patch fixing backend call sites

[Bug middle-end/83423] default_static_chain is sorry for non-nested functions

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83423

Andrew Pinski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |WAITING
   Last reconfirmed||2017-12-15
 Ever confirmed|0   |1

--- Comment #1 from Andrew Pinski  ---
> However, we also call this hook when compiling normal, non-nested
> functions, so the sorry is effective for both nested and non-nested functions.

expand_builtin_setjmp_receiver
df_get_entry_block_def_set

I think those two functions should be fixed instead of fixing the default hook.

df_get_entry_block_def_set is newish and should be fixed. 
expand_builtin_setjmp_receiver is old but not normally used in general.