[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 Rainer Orth changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #17 from Rainer Orth --- Fixed for GCC 8.1.
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 --- Comment #16 from Rainer Orth --- Author: ro Date: Sat Jan 13 21:01:27 2018 New Revision: 256650 URL: https://gcc.gnu.org/viewcvs?rev=256650=gcc=rev Log: Allow for lack of VM_MEMORY_OS_ALLOC_ONCE on Mac OS X (PR sanitizer/82824) PR sanitizer/82824 * lsan/lsan_common_mac.cc: Cherry-pick upstream r322437. Modified: trunk/libsanitizer/ChangeLog trunk/libsanitizer/lsan/lsan_common_mac.cc
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 --- Comment #15 from Dominique d'Humieres --- > That's the value of VM_MEMORY_OS_ALLOC_ONCE on Mac OS X 10.9 and up. Thanks!
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 --- Comment #14 from ro at CeBiTec dot Uni-Bielefeld.DE --- That's the value of VM_MEMORY_OS_ALLOC_ONCE on Mac OS X 10.9 and up.
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 --- Comment #13 from Dominique d'Humieres --- > See the PR URL fieldd. Found, thanks! Out of curiosity, why 73 in 'kSanitizerVmMemoryOsAllocOnce = 73'?
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 --- Comment #12 from ro at CeBiTec dot Uni-Bielefeld.DE --- See the PR URL fieldd.
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 --- Comment #11 from Dominique d'Humieres --- > Revised patch posted. Where?
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 Rainer Orth changed: What|Removed |Added URL|https://gcc.gnu.org/ml/gcc- |https://gcc.gnu.org/ml/gcc- |patches/2017-11/msg01061.ht |patches/2018-01/msg01166.ht |ml |ml Assignee|unassigned at gcc dot gnu.org |ro at gcc dot gnu.org --- Comment #10 from Rainer Orth --- Revised patch posted.
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 Richard Biener changed: What|Removed |Added Priority|P3 |P1
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 Rainer Orth changed: What|Removed |Added URL||https://gcc.gnu.org/ml/gcc- ||patches/2017-11/msg01061.ht ||ml --- Comment #9 from Rainer Orth --- Patch posted.
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 --- Comment #8 from ro at CeBiTec dot Uni-Bielefeld.DE --- > --- Comment #7 from Dominique d'Humieres --- >> I've now submitted the patch upstream: https://reviews.llvm.org/D39888. > > This patch allowed to bootstrap gcc on darwin10, but running the test suite > gave me ~2500 asan failures (gcc/g++, -m32/-m64) of the kind > > dyld: Symbol not found: _strndup > Referenced from: /opt/gcc/gcc8w/lib/libasan.5.dylib > Expected in: flat namespace > in /opt/gcc/gcc8w/lib/libasan.5.dylib > Trace/BPT trap It seems there's no point in trying: compiler-rt's cmake/config-ix.cmake requires Mac OS X 10.7/Darwin 11 and up for the sanitizers. I guess all we can do is disable them (or perhaps only asan) in the gcc tree (libsanitizer/configure.tgt). Rainer
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 --- Comment #7 from Dominique d'Humieres --- > I've now submitted the patch upstream: https://reviews.llvm.org/D39888. This patch allowed to bootstrap gcc on darwin10, but running the test suite gave me ~2500 asan failures (gcc/g++, -m32/-m64) of the kind dyld: Symbol not found: _strndup Referenced from: /opt/gcc/gcc8w/lib/libasan.5.dylib Expected in: flat namespace in /opt/gcc/gcc8w/lib/libasan.5.dylib Trace/BPT trap
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 --- Comment #6 from ro at CeBiTec dot Uni-Bielefeld.DE --- I've now submitted the patch upstream: https://reviews.llvm.org/D39888. Let's see how this goes. Rainer
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 Dominique d'Humieres changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2017-11-09 Ever confirmed|0 |1
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 Andrew Pinski changed: What|Removed |Added CC||dominiq at lps dot ens.fr --- Comment #5 from Andrew Pinski --- *** Bug 82921 has been marked as a duplicate of this bug. ***
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 --- Comment #4 from ro at CeBiTec dot Uni-Bielefeld.DE --- > --- Comment #3 from Eric Gallager --- [...] > Really? It doesn't show up in the ./configure --help output: > > Local-Admins-MacBook-Pro:gcc ericgallager$ ./configure --help=recursive | grep > -i sanit > Report bugs to . Sure: check for able_lib in configure. Not everything that's not documented doesn't exist ;-) Rainer
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 --- Comment #3 from Eric Gallager --- (In reply to r...@cebitec.uni-bielefeld.de from comment #2) > > --- Comment #1 from Eric Gallager --- > [...] > > Apparently 10.6/Darwin 11 isn't supported either; see bug 82829. As I said > > I couldn't find an explicit statement of support (or non-support) for > LLVM on Darwin. However, we could either try to get patches upstream > or keep them gcc-local if they are as trivial as those two. > > > there, it'd really be nice to have a --disable-libsanitizer configure flag > > for whenever upstream breaks stuff again > > Your wish has already been granted: for most if not all target > libraries, there's already a --disable-libX/--enable-libX switch, > libsanitizer included. Really? It doesn't show up in the ./configure --help output: Local-Admins-MacBook-Pro:gcc ericgallager$ ./configure --help=recursive | grep -i sanit Report bugs to . Local-Admins-MacBook-Pro:gcc ericgallager$ > > However, this isn't the right way to handle this: if it's really > concluded that libsanitizer isn't supported on certain Darwin versions, > this should be handled in libsanitizer/configure.tgt so users don't get > failing bootstraps without non-default options. > > Rainer
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 --- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE --- > --- Comment #1 from Eric Gallager --- [...] > Apparently 10.6/Darwin 11 isn't supported either; see bug 82829. As I said I couldn't find an explicit statement of support (or non-support) for LLVM on Darwin. However, we could either try to get patches upstream or keep them gcc-local if they are as trivial as those two. > there, it'd really be nice to have a --disable-libsanitizer configure flag for > whenever upstream breaks stuff again Your wish has already been granted: for most if not all target libraries, there's already a --disable-libX/--enable-libX switch, libsanitizer included. However, this isn't the right way to handle this: if it's really concluded that libsanitizer isn't supported on certain Darwin versions, this should be handled in libsanitizer/configure.tgt so users don't get failing bootstraps without non-default options. Rainer
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 Eric Gallager changed: What|Removed |Added CC||egallager at gcc dot gnu.org --- Comment #1 from Eric Gallager --- (In reply to Rainer Orth from comment #0) > > Given that I've never had any success getting even the most trivial patches > upstream and have no idea which Darwin versions are supported there, I'm > reporting this here. > > Rainer Apparently 10.6/Darwin 11 isn't supported either; see bug 82829. As I said there, it'd really be nice to have a --disable-libsanitizer configure flag for whenever upstream breaks stuff again
[Bug sanitizer/82824] [8 regression] libsanitizer fails to build: VM_MEMORY_OS_ALLOC_ONCE undefined
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82824 Rainer Orth changed: What|Removed |Added Target Milestone|--- |8.0
