[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-15 Thread mh+gcc at glandium dot org


--- Comment #9 from mh+gcc at glandium dot org  2010-09-15 11:45 ---
Created an attachment (id=21798)
 -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21798action=view)
Reduced testcase

Both issues Taras mentioned are actually separated. One is an actual bug in ffi
(to be filed), the other one is an optimization issue with gcc. I reduced the
problematic code to the attached code, which prints foo with -O1 (and more),
and bar with -O0, with gcc 4.5.1. gcc 4.4 compiled code correctly prints
bar with any optimization level.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623



[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-15 Thread mh+gcc at glandium dot org


--- Comment #10 from mh+gcc at glandium dot org  2010-09-15 11:53 ---
Please note this actually only happens on x86. (I would change the summary and
target if I could)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623



[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-15 Thread mh+gcc at glandium dot org


--- Comment #11 from mh+gcc at glandium dot org  2010-09-15 12:05 ---
Created an attachment (id=21799)
 -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21799action=view)
Reduced testcase

Inlining JSVAL_TO_PRIVATE by hand still makes it break, and reduces the
testcase further.


-- 

mh+gcc at glandium dot org changed:

   What|Removed |Added

  Attachment #21798|0   |1
is obsolete||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623



[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-15 Thread mh+gcc at glandium dot org


--- Comment #12 from mh+gcc at glandium dot org  2010-09-15 12:11 ---
FWIW, it's still broken on a gcc trunk snapshot from the 28th of august.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623



[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-15 Thread rguenth at gcc dot gnu dot org


--- Comment #13 from rguenth at gcc dot gnu dot org  2010-09-15 12:16 
---
Confirmed and investigating.


-- 

rguenth at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|WAITING |NEW
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2010-09-15 12:16:05
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623



[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-09 Thread dwitte at mozilla dot com


--- Comment #1 from dwitte at mozilla dot com  2010-09-09 22:03 ---
FWIW our libffi is basically libffi git head: http://github.com/atgreen/libffi

Which is regularly synced to gcc libffi.


-- 

dwitte at mozilla dot com changed:

   What|Removed |Added

 CC||dwitte at mozilla dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623



[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-09 Thread pinskia at gcc dot gnu dot org


--- Comment #2 from pinskia at gcc dot gnu dot org  2010-09-09 22:17 ---
There have been no ABI changes in 4.5 that I know of for PowerPC64 or even
differences between the trunk and 4.5.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623



[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-09 Thread hjl dot tools at gmail dot com


--- Comment #3 from hjl dot tools at gmail dot com  2010-09-10 00:38 ---
Mozilla bugs say Platform: x86 Linux. But gcc bug says
powerpc64-*-linux. What is going on?


-- 

hjl dot tools at gmail dot com changed:

   What|Removed |Added

 CC||hjl dot tools at gmail dot
   ||com
 Status|UNCONFIRMED |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623



[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-09 Thread dwitte at mozilla dot com


--- Comment #4 from dwitte at mozilla dot com  2010-09-10 00:46 ---
This is on x86_64. (I can't change the field, though. Can someone else?)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623



[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-09 Thread hjl dot tools at gmail dot com


--- Comment #5 from hjl dot tools at gmail dot com  2010-09-10 00:51 ---
I am not ware any x86-64 psABI changes in gcc 4.5. Please provide
a testcase.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623



[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-09 Thread pinskia at gcc dot gnu dot org


--- Comment #6 from pinskia at gcc dot gnu dot org  2010-09-10 01:40 ---
(In reply to comment #3)
 Mozilla bugs say Platform: x86 Linux. But gcc bug says
 powerpc64-*-linux. What is going on?

I must have missed since I saw Linux64 I was thinking powerpc64 :).  Really
there have been none x86_64 ones either.  Though the normal thing here that
might happen is strict aliasing issues.  Can you try -fno-strict-aliasing. 
Also maybe look for buffer overflows which might cause issues you think are
compiler related.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623



[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-09 Thread tglek at mozilla dot com


--- Comment #7 from tglek at mozilla dot com  2010-09-10 02:37 ---
-fno-strict-aliasing makes no difference.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623



[Bug target/45623] GCC 4.5.[01] breaks our ffi on Linux64. ABI break?

2010-09-09 Thread hjl dot tools at gmail dot com


--- Comment #8 from hjl dot tools at gmail dot com  2010-09-10 02:56 ---
(In reply to comment #0)
 See https://bugzilla.mozilla.org/show_bug.cgi?id=594611 and
 https://bugzilla.mozilla.org/show_bug.cgi?id=590683
  for more details. This breaks users of Firefox Sync on GCC 4.5. 
 The bug isn't present in gcc 4.4 or trunk. What would it take to cherry-pick a
 fix for 4.5.x?
 

You either identify which checkin fixes it or find a testcase so that
I can use it to find the fix.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45623