[Bug target/81313] Bad stack realignment code with -mno-accumulate-outgoing-args

2023-03-15 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81313

Jakub Jelinek  changed:

   What|Removed |Added

 CC||jakub at gcc dot gnu.org

--- Comment #8 from Jakub Jelinek  ---
*** Bug 109147 has been marked as a duplicate of this bug. ***

[Bug target/81313] Bad stack realignment code with -mno-accumulate-outgoing-args

2017-08-11 Thread hjl.tools at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81313

H.J. Lu  changed:

   What|Removed |Added

 CC||luto at kernel dot org

--- Comment #7 from H.J. Lu  ---
*** Bug 81825 has been marked as a duplicate of this bug. ***

[Bug target/81313] Bad stack realignment code with -mno-accumulate-outgoing-args

2017-08-08 Thread hjl.tools at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81313

H.J. Lu  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from H.J. Lu  ---
Oops.  Wrong one.

[Bug target/81313] Bad stack realignment code with -mno-accumulate-outgoing-args

2017-08-08 Thread hjl.tools at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81313

H.J. Lu  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #5 from H.J. Lu  ---
The patch was reverted.

[Bug target/81313] Bad stack realignment code with -mno-accumulate-outgoing-args

2017-07-09 Thread hjl.tools at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81313

H.J. Lu  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from H.J. Lu  ---
Fixed for 8.0.

[Bug target/81313] Bad stack realignment code with -mno-accumulate-outgoing-args

2017-07-09 Thread uros at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81313

--- Comment #3 from uros at gcc dot gnu.org ---
Author: uros
Date: Sun Jul  9 21:01:42 2017
New Revision: 250086

URL: https://gcc.gnu.org/viewcvs?rev=250086&root=gcc&view=rev
Log:
PR target/81313
* gcc.dg/stack-layout-dynamic-1.c (bar): Add 4 additional
integer argumets to bypass x86_64 outgoing args optimization.


Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gcc.dg/stack-layout-dynamic-1.c

[Bug target/81313] Bad stack realignment code with -mno-accumulate-outgoing-args

2017-07-09 Thread hjl at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81313

--- Comment #2 from hjl at gcc dot gnu.org  ---
Author: hjl
Date: Sun Jul  9 18:25:49 2017
New Revision: 250084

URL: https://gcc.gnu.org/viewcvs?rev=250084&root=gcc&view=rev
Log:
x86: Use DRAP only if there are outgoing arguments on stack

Since DRAP is needed only if there are outgoing arguments on stack, we
should track outgoing arguments on stack and avoid setting need_drap to
true when there are no outgoing arguments on stack.

gcc/

PR target/81313
* config/i386/i386.c (ix86_function_arg_advance): Set
outgoing_args_on_stack to true if there are outgoing arguments
on stack.
(ix86_function_arg): Likewise.
(ix86_get_drap_rtx): Use DRAP only if there are outgoing
arguments on stack and ACCUMULATE_OUTGOING_ARGS is false.
* config/i386/i386.h (machine_function): Add
outgoing_args_on_stack.

gcc/testsuite/

PR target/81313
* gcc.target/i386/pr81313-1.c: New test.
* gcc.target/i386/pr81313-2.c: Likewise.
* gcc.target/i386/pr81313-3.c: Likewise.
* gcc.target/i386/pr81313-4.c: Likewise.
* gcc.target/i386/pr81313-5.c: Likewise.

Added:
trunk/gcc/testsuite/gcc.target/i386/pr81313-1.c
trunk/gcc/testsuite/gcc.target/i386/pr81313-2.c
trunk/gcc/testsuite/gcc.target/i386/pr81313-3.c
trunk/gcc/testsuite/gcc.target/i386/pr81313-4.c
trunk/gcc/testsuite/gcc.target/i386/pr81313-5.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/i386/i386.c
trunk/gcc/config/i386/i386.h
trunk/gcc/testsuite/ChangeLog

[Bug target/81313] Bad stack realignment code with -mno-accumulate-outgoing-args

2017-07-06 Thread hjl.tools at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81313

H.J. Lu  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2017-07-06
   Target Milestone|--- |8.0
 Ever confirmed|0   |1

--- Comment #1 from H.J. Lu  ---
A patch is posted at

https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00345.html