[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 --- Comment #15 from Tom de Vries --- (In reply to Martin Liška from comment #14) > Tom: Can you please update Known to work? This work isn't done, so I think it's valid as it is: empty. Thanks, - Tom
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 Martin Liška changed: What|Removed |Added CC||marxin at gcc dot gnu.org --- Comment #14 from Martin Liška --- Tom: Can you please update Known to work?
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 --- Comment #13 from Eric Gallager --- (In reply to Tom de Vries from comment #11) > (In reply to Eric Gallager from comment #10) > > Have all of the changes committed from this bug fixed it? > > No, I'm preparing some changes for stage1. It's stage1 now.
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 --- Comment #12 from Tom de Vries --- Author: vries Date: Thu Mar 22 10:44:51 2018 New Revision: 258760 URL: https://gcc.gnu.org/viewcvs?rev=258760&root=gcc&view=rev Log: Backport "Require effective target global_constructor for two testcases" 2017-03-27 Tom de Vries backport from trunk: 2017-03-24 Tom de Vries PR testsuite/80092 * gcc.dg/tls/emutls-2.c: Add dg-require-effective-target global_constructor. Modified: branches/gcc-6-branch/gcc/testsuite/ChangeLog
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 --- Comment #11 from Tom de Vries --- (In reply to Eric Gallager from comment #10) > Have all of the changes committed from this bug fixed it? No, I'm preparing some changes for stage1.
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 Eric Gallager changed: What|Removed |Added CC||egallager at gcc dot gnu.org --- Comment #10 from Eric Gallager --- Have all of the changes committed from this bug fixed it?
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 --- Comment #9 from Tom de Vries --- Author: vries Date: Mon Mar 27 15:02:21 2017 New Revision: 246503 URL: https://gcc.gnu.org/viewcvs?rev=246503&root=gcc&view=rev Log: Backport "Require effective target global_constructor for two testcases" 2017-03-27 Tom de Vries backport from trunk: 2017-03-24 Tom de Vries PR testsuite/80092 * gcc.dg/tls/emutls-2.c: Add dg-require-effective-target global_constructor. Modified: branches/gcc-6-branch/gcc/testsuite/ChangeLog branches/gcc-6-branch/gcc/testsuite/gcc.dg/tls/emutls-2.c
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 --- Comment #8 from Tom de Vries --- Author: vries Date: Fri Mar 24 06:46:05 2017 New Revision: 246437 URL: https://gcc.gnu.org/viewcvs?rev=246437&root=gcc&view=rev Log: Backport "Add missing dg-require-effective-target alloca in gcc testsuite" 2017-03-24 Tom de Vries backport from trunk: 2017-03-24 Tom de Vries PR testsuite/80092 * gcc.dg/torture/pr71881.c: Add dg-require-effective-target alloca. * gcc.dg/torture/pr78742.c: Same. Modified: branches/gcc-6-branch/gcc/testsuite/ChangeLog branches/gcc-6-branch/gcc/testsuite/gcc.dg/torture/pr71881.c branches/gcc-6-branch/gcc/testsuite/gcc.dg/torture/pr78742.c
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 --- Comment #7 from Tom de Vries --- Author: vries Date: Fri Mar 24 06:29:06 2017 New Revision: 246436 URL: https://gcc.gnu.org/viewcvs?rev=246436&root=gcc&view=rev Log: Require effective target global_constructor for two testcases 2017-03-24 Tom de Vries PR testsuite/80092 * gcc.dg/no_profile_instrument_function-attr-1.c: Add dg-require-effective-target global_constructor. * gcc.dg/tls/emutls-2.c: Same. Modified: trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-1.c trunk/gcc/testsuite/gcc.dg/tls/emutls-2.c
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 --- Comment #6 from Tom de Vries --- Author: vries Date: Fri Mar 24 06:28:53 2017 New Revision: 246435 URL: https://gcc.gnu.org/viewcvs?rev=246435&root=gcc&view=rev Log: Require effective target indirect_jump in Wimplicit-fallthrough-34.c 2017-03-24 Tom de Vries PR testsuite/80092 * c-c++-common/Wimplicit-fallthrough-34.c: Add dg-require-effective-target indirect_jumps. Modified: trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/c-c++-common/Wimplicit-fallthrough-34.c
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 --- Comment #5 from Tom de Vries --- Author: vries Date: Fri Mar 24 06:28:42 2017 New Revision: 246434 URL: https://gcc.gnu.org/viewcvs?rev=246434&root=gcc&view=rev Log: Require effective target nonlocal_goto in pr79244.c 2017-03-24 Tom de Vries PR testsuite/80092 * gcc.dg/torture/pr79244.c: Add dg-require-effective-target nonlocal_goto. Modified: trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/gcc.dg/torture/pr79244.c
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 --- Comment #4 from Tom de Vries --- Author: vries Date: Fri Mar 24 06:28:12 2017 New Revision: 246433 URL: https://gcc.gnu.org/viewcvs?rev=246433&root=gcc&view=rev Log: Add missing dg-require-effective-target alloca in gcc testsuite 2017-03-24 Tom de Vries PR testsuite/80092 * gcc.dg/Walloca-7.c: Add dg-require-effective-target alloca. * gcc.dg/Walloca-12.c: Same. * gcc.dg/attr-alloc_size-8.c: Same. * gcc.dg/Walloca-4.c: Same. * gcc.dg/Walloca-8.c: Same. * gcc.dg/Walloca-13.c: Same. * gcc.dg/Walloca-14.c: Same. * gcc.dg/attr-alloc_size-9.c: Same. * gcc.dg/Walloca-1.c: Same. * gcc.dg/tree-ssa/builtin-sprintf-warn-3.c: Same. * gcc.dg/Walloca-5.c: Same. * gcc.dg/Walloca-10.c: Same. * gcc.dg/Walloca-9.c: Same. * gcc.dg/attr-alloc_size-6.c: Same. * gcc.dg/Wvla-larger-than-1.c: Same. * gcc.dg/torture/pr71881.c: Same. * gcc.dg/torture/pr71901.c: Same. * gcc.dg/torture/pr78742.c: Same. * gcc.dg/builtin-alloc-size.c: Same. * gcc.dg/Walloca-2.c: Same. * gcc.dg/Walloca-6.c: Same. * gcc.dg/Walloca-11.c: Same. * gcc.dg/attr-alloc_size-7.c: Same. * gcc.dg/Wvla-larger-than-2.c: Same. * gcc.dg/Walloca-3.c: Same. * c-c++-common/Wimplicit-fallthrough-7.c: Same. * gcc.c-torture/compile/pr79413.c: Same. * gcc.c-torture/compile/pr78439.c: Same. Modified: trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/c-c++-common/Wimplicit-fallthrough-7.c trunk/gcc/testsuite/gcc.c-torture/compile/pr78439.c trunk/gcc/testsuite/gcc.c-torture/compile/pr79413.c trunk/gcc/testsuite/gcc.dg/Walloca-1.c trunk/gcc/testsuite/gcc.dg/Walloca-10.c trunk/gcc/testsuite/gcc.dg/Walloca-11.c trunk/gcc/testsuite/gcc.dg/Walloca-12.c trunk/gcc/testsuite/gcc.dg/Walloca-13.c trunk/gcc/testsuite/gcc.dg/Walloca-14.c trunk/gcc/testsuite/gcc.dg/Walloca-2.c trunk/gcc/testsuite/gcc.dg/Walloca-3.c trunk/gcc/testsuite/gcc.dg/Walloca-4.c trunk/gcc/testsuite/gcc.dg/Walloca-5.c trunk/gcc/testsuite/gcc.dg/Walloca-6.c trunk/gcc/testsuite/gcc.dg/Walloca-7.c trunk/gcc/testsuite/gcc.dg/Walloca-8.c trunk/gcc/testsuite/gcc.dg/Walloca-9.c trunk/gcc/testsuite/gcc.dg/Wvla-larger-than-1.c trunk/gcc/testsuite/gcc.dg/Wvla-larger-than-2.c trunk/gcc/testsuite/gcc.dg/attr-alloc_size-6.c trunk/gcc/testsuite/gcc.dg/attr-alloc_size-7.c trunk/gcc/testsuite/gcc.dg/attr-alloc_size-8.c trunk/gcc/testsuite/gcc.dg/attr-alloc_size-9.c trunk/gcc/testsuite/gcc.dg/builtin-alloc-size.c trunk/gcc/testsuite/gcc.dg/torture/pr71881.c trunk/gcc/testsuite/gcc.dg/torture/pr71901.c trunk/gcc/testsuite/gcc.dg/torture/pr78742.c trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-3.c
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 --- Comment #3 from Tom de Vries --- (In reply to Thomas Schwinge from comment #2) > (In reply to Tom de Vries from comment #0) > > But it's better to introduce effective-target keywords for those features, > > and mark the tests as such. That will reduce the noise rate because of > > unsupported features being used or not due to code generation changes. > > But that will be a rather huge effort to do -- and to keep up to date. Is > that really worth it? The initial amount of tests to process will be large. That would be a huge effort to do, if it would be done manually. However, I would write a script parsing gcc.log or similar to generate those changes. Keeping things up-to-date once there's a script will require little effort, I suppose.
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 Thomas Schwinge changed: What|Removed |Added Target||nvptx Status|UNCONFIRMED |NEW Last reconfirmed||2017-03-23 Ever confirmed|0 |1 --- Comment #2 from Thomas Schwinge --- (In reply to Tom de Vries from comment #0) > Atm, when running for target nvptx, we run into unsupported features in the > tests. > > F.i. in the g++ testsuite: > ... > $ grep -c "sorry, unimplemented:" g++.log > 12693 > ... ... a lot... > more in detail: > ... > $ grep "sorry, unimplemented:" g++.log | sed 's/.*sorry, unimplemented://' | > dos2unix | sort -u > converting lambda which uses '...' to function pointer > global constructors not supported on this target > global destructors not supported on this target > indirect jumps are not available on this target > mangling __underlying_type > non-trivial designated initializers not supported > passing arguments to ellipsis of inherited constructor 'B::B(int, ...) > [inherited from A]' > target cannot support alloca. > target cannot support nonlocal goto. > ... > > All those tests are FAILs, while they should be UNSUPPORTED. > > In principle, having those as FAILs is not a problem when regression > testing. We can compare tests results, and only look at changes. > > But it's better to introduce effective-target keywords for those features, > and mark the tests as such. That will reduce the noise rate because of > unsupported features being used or not due to code generation changes. But that will be a rather huge effort to do -- and to keep up to date. Is that really worth it?
[Bug testsuite/80092] Add effective-target keywords for unsupported nvptx features
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80092 --- Comment #1 from Tom de Vries --- Submitted "[testsuite] Add missing dg-require-effective-target alloca to gcc testsuite" ( https://gcc.gnu.org/ml/gcc-patches/2017-03/msg01227.html )