[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 --- Comment #16 from Aldy Hernandez --- Author: aldyh Date: Wed Sep 13 16:40:27 2017 New Revision: 252345 URL: https://gcc.gnu.org/viewcvs?rev=252345&root=gcc&view=rev Log: [gcc] 2017-08-08 Bill Schmidt PR tree-optimization/81354 * gimple-ssa-strength-reduction.c (create_add_on_incoming_edge): Insert on edges rather than explicitly creating landing pads. (analyze_candidates_and_replace): Commit edge inserts. [gcc/testsuite] 2017-08-08 Bill Schmidt PR tree-optimization/81354 * g++.dg/torture/pr81354.C: New file. Added: branches/range-gen2/gcc/testsuite/g++.dg/torture/pr81354.C Modified: branches/range-gen2/gcc/ChangeLog branches/range-gen2/gcc/gimple-ssa-strength-reduction.c branches/range-gen2/gcc/testsuite/ChangeLog
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 Bill Schmidt changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #15 from Bill Schmidt --- Now fixed everywhere.
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 --- Comment #14 from Bill Schmidt --- Author: wschmidt Date: Wed Aug 16 14:13:27 2017 New Revision: 251122 URL: https://gcc.gnu.org/viewcvs?rev=251122&root=gcc&view=rev Log: [gcc] 2017-08-16 Bill Schmidt Backport from mainline 2017-08-08 Bill Schmidt PR tree-optimization/81354 * gimple-ssa-strength-reduction.c (create_add_on_incoming_edge): Insert on edges rather than explicitly creating landing pads. (analyze_candidates_and_replace): Commit edge inserts. [gcc/testsuite] 2017-08-16 Bill Schmidt Backport from mainline 2017-08-08 Bill Schmidt PR tree-optimization/81354 * g++.dg/torture/pr81354.C: New file. Added: branches/gcc-5-branch/gcc/testsuite/g++.dg/torture/pr81354.C Modified: branches/gcc-5-branch/gcc/ChangeLog branches/gcc-5-branch/gcc/gimple-ssa-strength-reduction.c branches/gcc-5-branch/gcc/testsuite/ChangeLog
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 --- Comment #13 from Bill Schmidt --- Author: wschmidt Date: Wed Aug 16 14:11:26 2017 New Revision: 251121 URL: https://gcc.gnu.org/viewcvs?rev=251121&root=gcc&view=rev Log: [gcc] 2017-08-16 Bill Schmidt Backport from mainline 2017-08-08 Bill Schmidt PR tree-optimization/81354 * gimple-ssa-strength-reduction.c (create_add_on_incoming_edge): Insert on edges rather than explicitly creating landing pads. (analyze_candidates_and_replace): Commit edge inserts. [gcc/testsuite] 2017-08-16 Bill Schmidt Backport from mainline 2017-08-08 Bill Schmidt PR tree-optimization/81354 * g++.dg/torture/pr81354.C: New file. Added: branches/gcc-6-branch/gcc/testsuite/g++.dg/torture/pr81354.C Modified: branches/gcc-6-branch/gcc/ChangeLog branches/gcc-6-branch/gcc/gimple-ssa-strength-reduction.c branches/gcc-6-branch/gcc/testsuite/ChangeLog
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 --- Comment #12 from Bill Schmidt --- Author: wschmidt Date: Wed Aug 16 14:09:15 2017 New Revision: 251120 URL: https://gcc.gnu.org/viewcvs?rev=251120&root=gcc&view=rev Log: [gcc] 2017-08-16 Bill Schmidt Backport from mainline 2017-08-08 Bill Schmidt PR tree-optimization/81354 * gimple-ssa-strength-reduction.c (create_add_on_incoming_edge): Insert on edges rather than explicitly creating landing pads. (analyze_candidates_and_replace): Commit edge inserts. [gcc/testsuite] 2017-08-16 Bill Schmidt Backport from mainline 2017-08-08 Bill Schmidt PR tree-optimization/81354 * g++.dg/torture/pr81354.C: New file. Added: branches/gcc-7-branch/gcc/testsuite/g++.dg/torture/pr81354.C Modified: branches/gcc-7-branch/gcc/ChangeLog branches/gcc-7-branch/gcc/gimple-ssa-strength-reduction.c branches/gcc-7-branch/gcc/testsuite/ChangeLog
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 Martin Jambor changed: What|Removed |Added CC||jamborm at gcc dot gnu.org --- Comment #12 from Martin Jambor --- *** Bug 81848 has been marked as a duplicate of this bug. ***
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 --- Comment #11 from Bill Schmidt --- Fixed on trunk so far, and verified that a modified backport fixes the limited range on 5.4 where the provided test case fails. Backports to follow in about a week after burn-in.
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 --- Comment #10 from Bill Schmidt --- Author: wschmidt Date: Tue Aug 8 12:52:22 2017 New Revision: 250955 URL: https://gcc.gnu.org/viewcvs?rev=250955&root=gcc&view=rev Log: [gcc] 2017-08-08 Bill Schmidt PR tree-optimization/81354 * gimple-ssa-strength-reduction.c (create_add_on_incoming_edge): Insert on edges rather than explicitly creating landing pads. (analyze_candidates_and_replace): Commit edge inserts. [gcc/testsuite] 2017-08-08 Bill Schmidt PR tree-optimization/81354 * g++.dg/torture/pr81354.C: New file. Added: trunk/gcc/testsuite/g++.dg/torture/pr81354.C Modified: trunk/gcc/ChangeLog trunk/gcc/gimple-ssa-strength-reduction.c trunk/gcc/testsuite/ChangeLog
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 --- Comment #9 from Bill Schmidt --- OK, I've now confirmed this is the problem. I have a rough patch for trunk, and backporting it to GCC 5 r236439 verifies that this fixes it. Still verifying bootstrap/regression on trunk, and need to do some cleanup before submitting.
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 --- Comment #8 from Bill Schmidt --- This is likely the same as another problem that recently came up (not yet filed as the source is sensitive). SLSR is sensitive to addresses of PHI instructions remaining the same throughout the pass, but gimple_split_edge does not maintain this. I'm working on a patch to ensure that it does. I still need to verify this is the same issue.
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 Bill Schmidt changed: What|Removed |Added Target|x86_64-pc-linux-gnu |x86_64-pc-linux-gnu, ||powerpc64le-linux-gnu --- Comment #7 from Bill Schmidt --- (In reply to Bill Schmidt from comment #5) > Doesn't reproduce for powerpc64le. I'll have to build a cross. I didn't read carefully enough that I had to be in a window of revisions to reproduce. I see this on powerpc64le after all.
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 --- Comment #6 from Bill Schmidt --- Hm, the symptom looks very much like another issue I've been looking at on trunk. There may be an issue with the statement->candidate mapping hash table that's responsible for both. It appears to be a somewhat rare issue involving chains of phis where one of the "more recent" phis is receiving the same value from at least two different incoming edges, but I don't yet have a complete answer.
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 --- Comment #5 from Bill Schmidt --- Doesn't reproduce for powerpc64le. I'll have to build a cross.
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 Bill Schmidt changed: What|Removed |Added Assignee|unassigned at gcc dot gnu.org |wschmidt at gcc dot gnu.org --- Comment #4 from Bill Schmidt --- Yes, mine.
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 Richard Biener changed: What|Removed |Added Priority|P3 |P2 CC||wschmidt at gcc dot gnu.org Target Milestone|--- |5.5 --- Comment #3 from Richard Biener --- Program received signal SIGSEGV, Segmentation fault. 0x019c11f3 in record_phi_increments (basis=0x29dd3d0, phi= ) at /space/rguenther/src/svn/gcc-6-branch/gcc/gimple-ssa-strength-reduction.c:2559 2559 slsr_cand_t phi_cand = *stmt_cand_map->get (phi); Bill, can you have a look?
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 --- Comment #2 from rguenther at suse dot de --- On Tue, 11 Jul 2017, marxin at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 > > Martin Liška changed: > >What|Removed |Added > > Status|UNCONFIRMED |NEW >Last reconfirmed||2017-07-11 > CC||marxin at gcc dot gnu.org, >||rguenth at gcc dot gnu.org > Known to work||4.5.4, 4.6.4, 4.7.4, 4.8.5, >||4.9.4, 7.1.0, 8.0 > Summary|Segmentation fault in SSA |[5/6 Regression] >|Strength Reduction using|Segmentation fault in SSA >|-O3 |Strength Reduction using >||-O3 > Ever confirmed|0 |1 > Known to fail||5.4.0, 6.4.0 > > --- Comment #1 from Martin Liška --- > Confirmed, fixed on trunk by r236440 and was introduced by r217914. Richi is > it > a subject of backport maybe? No, I'm quite sure r236440 just made it latent and the bug still exists (try a gimple FE input directly into SLSR).
[Bug tree-optimization/81354] [5/6 Regression] Segmentation fault in SSA Strength Reduction using -O3
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81354 Martin Liška changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2017-07-11 CC||marxin at gcc dot gnu.org, ||rguenth at gcc dot gnu.org Known to work||4.5.4, 4.6.4, 4.7.4, 4.8.5, ||4.9.4, 7.1.0, 8.0 Summary|Segmentation fault in SSA |[5/6 Regression] |Strength Reduction using|Segmentation fault in SSA |-O3 |Strength Reduction using ||-O3 Ever confirmed|0 |1 Known to fail||5.4.0, 6.4.0 --- Comment #1 from Martin Liška --- Confirmed, fixed on trunk by r236440 and was introduced by r217914. Richi is it a subject of backport maybe?
