Re: Harden rs6000 offsettable_ok_by_alignment

On Sun, Mar 06, 2011 at 07:01:44PM -0500, David Edelsohn wrote: > Isn't this too conservative? Shouldn't CONSTANT_ALIGNMENT increase > the alignment of STRING_CST to word-aligned? Yes and yes. Thanks for the correction. I'll update the patch. > The only problem is structs? No, I don't think t

Ping Re: [doc, PATCH] Update the description about ENTRY_BLOCK_PTR and EXIT_BLOCK_PTR

2011/2/25 Mingjie Xing : > Hi, > > This patch updates the description about ENTRY_BLOCK_PTR and > EXIT_BLOCK_PTR, since their index numbers are no longer negative now. > > Is it OK? > > Thanks, > Mingjie > > ChangeLog, > 2011-02-25  Mingjie Xing   > >        * doc/cfg.texi (ENTRY_BLOCK_PTR, EXIT_BL

Re: [doc, PATCH] Remove redundant word "See" before @xref

2011/3/4 Gerald Pfeifer : > On Thu, 3 Mar 2011, Mingjie Xing wrote: >> 2011-03-03  Mingjie Xing   >> >>         * doc/cfg.texi: Remove "See" before @ref. >>         * doc/invoke.texi: Likewise. > > This is fine, thank you.  If you want to apply this to the GCC 4.5 > branch as well, that's fine, too

Re: [4.7] Avoid global state in pa_handle_option

> Tested building cc1 and xgcc for cross to hppa2.0w-hp-hpux11.23. Will > commit to trunk for 4.7 in the absence of target maintainer > objections. > > 2011-03-06 Joseph Myers > > * config/pa/pa-hpux.opt (flag_pa_unix): New Variable entry. > (munix=93): Use Var. > * config/p

Re: [4.7] Avoid global state in pdp11_handle_option

On Mar 6, 2011, at 8:59 PM, Joseph S. Myers wrote: > This patch, for 4.7 and relative to a tree with > applied, > stops the pdp11 handle_option hook from using global state. > > Tested building cc1 and xgcc for cross to pdp11-none. Will

[4.7] Avoid global state in pdp11_handle_option

This patch, for 4.7 and relative to a tree with applied, stops the pdp11 handle_option hook from using global state. Tested building cc1 and xgcc for cross to pdp11-none. Will commit to trunk for 4.7 in the absence of target maintainer obj

[4.7] Avoid global state in sh_handle_option

This patch, for 4.7 and relative to a tree with applied, stops the SH handle_option hook from using global state. Tested building cc1 and xgcc for cross to sh-elf. Will commit to trunk for 4.7 in the absence of target maintainer objections

[4.7] Avoid global state in pa_handle_option

This patch, for 4.7 and relative to a tree with applied, stops the PA handle_option hook from using global state. The -munix= options are converted to use Var in the .opt files, -mschedule= is made to use the Enum facility, and -mfixed-rang

[4.7] Avoid global state in mn10300_handle_option

This patch, for 4.7 and relative to a tree with applied, stops the MN10300 handle_option hook from using global state. The -mtune= option, taking a string argument and storing it in a string variable, is made to use Var to store the string

Re: [RFA] libiberty/hashtab.c, higher_prime_index: avoid array overrun

DJ Delorie wrote: Bizzare, the problem isn't the hash loop, it's the error handler at the end! It never uses [30] for the main loop, only if you give it a number between 0xfffb and 0x - and in the case where it would use [30], it's supposed to abort anyway. I couldn't figure out why

Re: PATCH: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)

On Sun, Mar 6, 2011 at 3:40 PM, H.J. Lu wrote: > On Sun, Mar 6, 2011 at 3:23 PM, Richard Guenther > wrote: >> On Sun, Mar 6, 2011 at 10:28 PM, H.J. Lu wrote: >>> On Sun, Mar 6, 2011 at 1:15 PM, Andrew Pinski wrote: On Sun, Mar 6, 2011 at 9:18 AM, H.J. Lu wrote: > Hi, > > We sh

Re: Harden rs6000 offsettable_ok_by_alignment

Isn't this too conservative? Shouldn't CONSTANT_ALIGNMENT increase the alignment of STRING_CST to word-aligned? The only problem is structs? - David On Wed, Mar 2, 2011 at 2:34 AM, Alan Modra wrote: > Prior to a fix I committed recently on the gcc-4.5-ibm branch, we used > to fail with a linke

Re: PATCH: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)

On Sun, Mar 6, 2011 at 3:23 PM, Richard Guenther wrote: > On Sun, Mar 6, 2011 at 10:28 PM, H.J. Lu wrote: >> On Sun, Mar 6, 2011 at 1:15 PM, Andrew Pinski wrote: >>> On Sun, Mar 6, 2011 at 9:18 AM, H.J. Lu wrote: Hi, We shouldn't save call frame hard registers as "void *".  This

Re: PATCH: Remove README.QMTEST

On 3/6/2011 2:57 PM, Mike Stump wrote: >> It was recently pointed out to me that we still have the >> README.QMTEST file in gcc/testsuite. That file talks about how to >> use QMTest instead of DejaGNU to test G++ > If you were to summarize the 3 most compelling features provided, I'd > be interes

[RFA] libiberty/make-relative-prefix.c, save_string, use xmalloc over malloc

I know the callers of save_string check its return value for null, but by then it's too late -- we've memcpy'd over a null pointer. OK? 2011-03-06 Michael Snyder * make-relative-prefix.c (save_string): Use xmalloc over malloc. Index: make-relative-prefix.c ==

Re: PowerPC32 .gnu.attributes

On Thu, Mar 3, 2011 at 11:35 PM, Alan Modra wrote: > Re http://gcc.gnu.org/ml/gcc-patches/2011-02/msg01525.html > > Updated patch, using cgraph to decide whether a function is visible > outside of the object file.  Bootstrapped and regression tested > powerpc-linux.  OK for 4.6? > >        * confi

Re: PATCH: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)

On Sun, Mar 6, 2011 at 10:28 PM, H.J. Lu wrote: > On Sun, Mar 6, 2011 at 1:15 PM, Andrew Pinski wrote: >> On Sun, Mar 6, 2011 at 9:18 AM, H.J. Lu wrote: >>> Hi, >>> >>> We shouldn't save call frame hard registers as "void *".  This patch >>> changes the unwind library to save call frame hard reg

Re: PATCH: Remove README.QMTEST

On Mar 6, 2011, at 1:39 PM, mitch...@codesourcery.com (Mark Mitchell) wrote: > It was recently pointed out to me that we still have the README.QMTEST > file in gcc/testsuite. That file talks about how to use QMTest > instead of DejaGNU to test G++ If you were to summarize the 3 most compelling fe

[RFA] libiberty/argv.c, expandargv, close memory leak

OK? 2011-03-06 Michael Snyder * argv.c (expandargv): Close memory leak. Index: argv.c === RCS file: /cvs/src/src/libiberty/argv.c,v retrieving revision 1.22 diff -u -p -r1.22 argv.c --- argv.c 13 Aug 2010 11:36:10 -

Re: PATCH: Remove README.QMTEST

> It was recently pointed out to me that we still have the README.QMTEST > file in gcc/testsuite. That file talks about how to use QMTest > instead of DejaGNU to test G++ -- but the information there is just > not accurate anymore. Various things have bit-rotted since the point > at which that wa

PATCH: Remove README.QMTEST

It was recently pointed out to me that we still have the README.QMTEST file in gcc/testsuite. That file talks about how to use QMTest instead of DejaGNU to test G++ -- but the information there is just not accurate anymore. Various things have bit-rotted since the point at which that was written

Re: PATCH: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)

On Sun, Mar 6, 2011 at 1:15 PM, Andrew Pinski wrote: > On Sun, Mar 6, 2011 at 9:18 AM, H.J. Lu wrote: >> Hi, >> >> We shouldn't save call frame hard registers as "void *".  This patch >> changes the unwind library to save call frame hard registers as >> _Unwind_Word.  OK for 4.7? > > I think this

Re: PATCH: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)

On Sun, Mar 6, 2011 at 9:18 AM, H.J. Lu wrote: > Hi, > > We shouldn't save call frame hard registers as "void *".  This patch > changes the unwind library to save call frame hard registers as > _Unwind_Word.  OK for 4.7? I think this will break the ABI for the MIPS N32 ABI. Not to mention the MI

Re: [Patch, fortran] PR47850 - [4.6 Regression] ICE in gfc_conv_array_initializer

Dear Jerry, I am not sure about one of the submitters reviewing the patch :-) Fortunately, Dominique d'Humieres ran it by his own tests and found that it did not break anything. Submitted as revision 170720. Thanks to you both! Paul 2011-03-06 Paul Thomas Jerry DeLisle

Re: [Patch, fortran] PR47850 - [4.6 Regression] ICE in gfc_conv_array_initializer

On 03/06/2011 10:57 AM, Paul Richard Thomas wrote: This one was exceedingly difficult to diagnose. The workings of array.c are opaque to say the least of it! However, the fix is relatively clear. The testcase in the PR failed because the argument of ANY is not a gfc_constant_ac. However, iter

[x32] PATCH: Check SUBREG_REG for parts.index and parts.base

Hi, X32 may use SUBREG_REG in parts.index and parts.base. I checked this patch into x32 branch. H.J. --- commit e2f00cf7ffb008eb4710221853d82fa1b81433e0 Author: H.J. Lu Date: Sun Mar 6 11:14:50 2011 -0800 Check SUBREG_REG for parts.index and parts.base. diff --git a/gcc/ChangeLog.x32 b

[Patch, fortran] PR47850 - [4.6 Regression] ICE in gfc_conv_array_initializer

This one was exceedingly difficult to diagnose. The workings of array.c are opaque to say the least of it! However, the fix is relatively clear. The testcase in the PR failed because the argument of ANY is not a gfc_constant_ac. However, iterating through the constructor and testing the express

[x32] PATCH: Convert function address to Pmode if needed

Hi, I checked in this patch to convert function address to Pmode if needed. H.J. --- commit b2f3e23711761c7ae4c8378ba63525dfd4030a7a Author: H.J. Lu Date: Sun Mar 6 10:52:38 2011 -0800 Convert function address to Pmode if needed. diff --git a/gcc/ChangeLog.x32 b/gcc/ChangeLog.x32 index 0

[x32] PATCH: Add initialize x32 support to GCC testsuite

Hi, I checked in this patch to add initialize x32 support to GCC testsuite. H.J. commit 8df1dc7ee66e767006353d5358be926261080c1a Author: H.J. Lu Date: Sun Mar 6 09:53:16 2011 -0800 Add initialize x32 support to GCC testsuite. diff --git a/gcc/testsuite/ChangeLog.x32 b/gcc/testsuite

PATCH: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)

Hi, We shouldn't save call frame hard registers as "void *". This patch changes the unwind library to save call frame hard registers as _Unwind_Word. OK for 4.7? Thanks. H.J. commit 4163355471bfb192fdacc5da1ceb9aec5569ff94 Author: H.J. Lu Date: Sun Mar 6 08:19:25 2011 -0800 Save