Re: [PATCH] Fix MEM_IN_STRUCT_P/MEM_SCALAR_P during expansion (PR rtl-optimization/47866)

2011-03-09 Thread Eric Botcazou
and as t isn't AGGREGATE_TYPE nor COMPLEX_TYPE and is a decl, it is marked MEM_SCALAR_P and e.g. set_mem_attributes_minus_bitpos once MEM_SCALAR_P is set doesn't change it to MEM_IN_STRUCT_P because of BIT_FIELD_REF etc. The BIT_FIELD_REF t, 32, * = 1 stores are done through store_field

Re: avoid useless if-before-free tests

2011-03-09 Thread Richard Guenther
On Tue, Mar 8, 2011 at 5:34 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/05/11 07:05, Jim Meyering wrote: Hello, Someone asked me about this yesterday, and since I've been carrying this patch series for over a year -- it's not high priority --

Re: fix for pr47837

2011-03-09 Thread Richard Guenther
On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/08/11 11:55, Diego Novillo wrote: On 03/08/2011 12:54 PM, Xinliang David Li wrote: Please review the attached patch, it does some simplification of the complicated logical or

[c++, PR 47714] Reset the addressable flag of thunk PARM_DECLs

2011-03-09 Thread Martin Jambor
Hi, the patch below fixes PR 47714. The problem is that as thunk function declarations are built, their PARM_DECLs are copied from the thunked function together with their TREE_ADDRESSABLE flags. This then means the parameters are not considered gimple registers when they are supposed to be

Re: [c++, PR 47714] Reset the addressable flag of thunk PARM_DECLs

2011-03-09 Thread Eric Botcazou
2011-03-08 Martin Jambor mjam...@suse.cz PR tree-optimization/47714 * cp/method.c (use_thunk): Clear addressable flag of thunk arguments. This should go in cp/ChangeLog without the cp/ prefix. -- Eric Botcazou

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-09 Thread Eli Zaretskii
From: Pedro Alves pe...@codesourcery.com Date: Wed, 9 Mar 2011 11:46:36 + Cc: gdb-patc...@sourceware.org, d...@redhat.com, ktiet...@googlemail.com, binut...@sourceware.org, gcc-patches@gcc.gnu.org On Wednesday 09 March 2011 05:29:09, Eli Zaretskii wrote: Actually, is there any

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-09 Thread Pedro Alves
On Wednesday 09 March 2011 12:35:00, Eli Zaretskii wrote: I meant a valid use case in the code bases. Sorry for my misunderstanding. NP. Might as well cook up a (gdb) patch. Find it pasted below. Does it look good to you? Yes, looks fine. Thanks. Thanks. I've applied it.

Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

2011-03-09 Thread Eli Zaretskii
From: Pedro Alves pe...@codesourcery.com Date: Wed, 9 Mar 2011 12:58:38 + Cc: gdb-patc...@sourceware.org, d...@redhat.com, ktiet...@googlemail.com, binut...@sourceware.org, gcc-patches@gcc.gnu.org The one's left are: 1 in a linux-native only file (never cares for other

Re: fix for pr47837

2011-03-09 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/09/11 02:45, Richard Guenther wrote: On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law l...@redhat.com wrote: True. I've been repeatedly thinking of building some on-the-side CFG with value-numbered predicates to also catch the CFG vs. scalar-code

Build regression [Re: [patch libiberty include]: Add additional helper functions for directory-separator searching]

2011-03-09 Thread Jan Kratochvil
On Wed, 09 Mar 2011 13:58:38 +0100, Pedro Alves wrote: Thanks. I've applied it. nto-tdep.c:130:8: error: assignment discards ‘const’ qualifier from pointer target type [-Werror] gcc-4.6.0-0.12.fc15.x86_64 --with-system-zlib --enable-64-bit-bfd --enable-targets=all --enable-static

Re: Build regression [Re: [patch libiberty include]: Add additional helper functions for directory-separator searching]

2011-03-09 Thread Jan Kratochvil
On Wed, 09 Mar 2011 16:02:36 +0100, Pedro Alves wrote: Thanks, had forgotten --enable-targets=all. Sorry about that. It builds now OK. Thanks, Jan

[PATCH][4.7][RFC] Fix store-sinking, make returns have a VUSE

2011-03-09 Thread Richard Guenther
This old patch of mine makes the return statement of a function have a VUSE even if it does not return a value (or does not reference memory). This is to have a virtual operand chain for values that escape the function via returns. This allows to fix store-sinking to do its job again by simply

Re: [PATCH][4.7][RFC] Fix store-sinking, make returns have a VUSE

2011-03-09 Thread Diego Novillo
On Wed, Mar 9, 2011 at 10:26, Richard Guenther rguent...@suse.de wrote: I have just forward ported this patch to trunk and don't remember whether it caused any problems back when I originally worked on this (IIRC it was during stage3 of 4.5).  So, this is just a heads-up in case you have any

[PATCH][4.7] Fix the issue in PR13954

2011-03-09 Thread Richard Guenther
This fixes PR13954, not by doing SRA as requested but instead by looking through memcpy during value-numbering (similar to what we do for aggregate copies). On its own it isn't that useful as we still do not optimize the memcpy away itself (PR16427), but that issue can be fixed in DCE with the

Re: libgo patch committed: Only run net tests if GCCGO_RUN_ALL_TESTS

2011-03-09 Thread Rainer Orth
Ian Lance Taylor i...@google.com writes: This patch to libgo only runs the networking dependent tests if GCCGO_RUN_ALL_TESTS is set in the environment. This is PR 48017. In that PR Rainer suggests having the tests drop back to UNSUPPORTED or UNRESOLVED if they fail to open a network

Re: [PATCH][ARM] Fix RVCT interoperation issue

2011-03-09 Thread Ramana Radhakrishnan
On Fri, 2011-03-04 at 11:23 +, Andrew Stubbs wrote: The attached patch, submitted on behalf of Dan Jacobowitz, fixes an unwind bug when using RealView and libgcc. It's an old patch that has been in CodeSourcery and Linaro toolchains for sometime, but somehow escaped being posted here.

Re: fix for pr47837

2011-03-09 Thread Xinliang David Li
Sounds interesting. Do you have examples to illustrate your idea? Thanks, David On Wed, Mar 9, 2011 at 1:45 AM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/08/11

Re: fix for pr47837

2011-03-09 Thread Xinliang David Li
On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/09/11 02:45, Richard Guenther wrote: On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law l...@redhat.com wrote: True.  I've been repeatedly thinking of building some on-the-side CFG

Re: fix for pr47837

2011-03-09 Thread Xinliang David Li
On Wed, Mar 9, 2011 at 8:29 AM, Richard Guenther richard.guent...@gmail.com wrote: On Wed, Mar 9, 2011 at 5:24 PM, Xinliang David Li davi...@google.com wrote: On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/09/11 02:45,

Re: fix for pr47837

2011-03-09 Thread Richard Guenther
On Wed, Mar 9, 2011 at 6:34 PM, Xinliang David Li davi...@google.com wrote: On Wed, Mar 9, 2011 at 8:29 AM, Richard Guenther richard.guent...@gmail.com wrote: On Wed, Mar 9, 2011 at 5:24 PM, Xinliang David Li davi...@google.com wrote: On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law l...@redhat.com

C++ PATCH for c++/44629 (ICE with function template as non-type template argument)

2011-03-09 Thread Jason Merrill
In this testcase, we have a function template used as an argument for a function pointer template parameter. This causes unify to abort because an OVERLOAD doesn't satisfy EXPR_P. 14.8.2.5 lists an overloaded function given as a function argument as a non-deduced context, so it seems

Re: fix for pr47837

2011-03-09 Thread Xinliang David Li
Ok. Regarding this particular patch, I hope it can be checked in to make the test clean. It is a simple enhancement to a wheel that is already there. It also serves as a case that can be referenced in the future when the more general mechanism is available. Thanks, David On Wed, Mar 9, 2011 at

[v3] libstdc++/48038

2011-03-09 Thread Paolo Carlini
Hi, tested x86_64-linux multilib + debug-mode, committed to mainline (see Audit trail for details) Thanks, Paolo. 2011-03-09 Paolo Carlini paolo.carl...@oracle.com * testsuite/util/testsuite_rvalref.h: Minor tweaks. 2011-03-09 Jonathan Wakely

libgo patch committed: Mention GCCGO_RUN_ALL_TESTS in README.gcc

2011-03-09 Thread Ian Lance Taylor
Rainer pointed out that the GCCGO_RUN_ALL_TESTS environment variable should really be documented. This patch adds a note to libgo/README.gcc. Committed to mainline. Ian diff -r 5d83cac5a1c5 libgo/README.gcc --- a/libgo/README.gcc Tue Mar 08 22:54:43 2011 -0800 +++ b/libgo/README.gcc Wed Mar 09

Re: Fix pr48032, powerpc64 -mcmodel=medium invalid ld offset

2011-03-09 Thread David Edelsohn
On Wed, Mar 9, 2011 at 1:07 AM, Alan Modra amo...@gmail.com wrote: This patch a) Moves the offsettable_ok_by_alignment call from rs6000_emit_move to   legitimate_constant_pool_address_p, and b) teaches offsettable_ok_by_alignment how to handle -fsection-anchors   addresses, and c) teaches

libgo patch committed: Pass -v to nm in gotest

2011-03-09 Thread Ian Lance Taylor
This libgo patch passes -v to nm in the gotest script. That has no effect on GNU nm (it's overridden by the -p option), and will tell Solaris nm to sort by value. With luck that will make the functions apear in the order in which they appear in the source file, which is what some of the tests

[4.7] Avoid global state in score_handle_option

2011-03-09 Thread Joseph S. Myers
This patch, for 4.7 and relative to a tree with http://gcc.gnu.org/ml/gcc-patches/2011-02/msg01709.html applied, stops the SCORE handle_option hook from using global state. The -march= option is converted to use enumerated arguments. The existing handling of this option maps arguments to bits in

[4.7] Make SPARC use PROCESSOR_NIAGARA2 for niagara2

2011-03-09 Thread Joseph S. Myers
In the course of preparing target changes to avoid global state in option handlers (and use more .opt facilities to simplify those handlers) I found that SPARC has a PROCESSOR_NIAGARA2 enumeration value but maps niagara2 in command-line options to PROCESSOR_NIAGARA for no apparent reason (at

Re: [4.7] Avoid global state in mep_handle_option

2011-03-09 Thread DJ Delorie
Tested building cc1 and xgcc for cross to mep-elf. Will commit to trunk for 4.7 in the absence of target maintainer objections. No objections from me.

[pph] Buffer overrun in preprocessor symbol replay

2011-03-09 Thread Lawrence Crowl
In my last PPH change, I eliminated the redundancy in the preprocessor identifier lookaside table by removing the name of the identifier from the head of the macro value. This later led to a buffer overrun in libcpp/symtab.c cpp_lt_replay. The buffer was allocated based on the value string size,

Re: [4.7] Avoid global state in score_handle_option

2011-03-09 Thread Liqin Chen
Hi Joseph, Joseph Myers jos...@codesourcery.com 写于 2011-03-10 08:59:52: Tested building cc1 and xgcc for cross to score-elf. Will commit to trunk for 4.7 in the absence of target maintainer objections. Thanks Joseph, please commit. We will merge it in our new update. Cheers --liqin

RFA (layout): PATCH for c++/48029 (ICE-on-valid with templates and arrays)

2011-03-09 Thread Jason Merrill
In this testcase, when we first declare the myvectypes and mytype3, vectorstring has not been instantiated, so we mark the array, and the pointer to the array, for structural equality comparison. When we actually go to instantiate mytype3, we complete vectorstring and rebuild the array and