Re: external declaration of dominance debug functions

2011-05-23 Thread Basile Starynkevitch
On Mon, 23 May 2011 22:23:01 +0200 Richard Guenther wrote: [...] > plugin header? what's that? [...] The headers made available to and installed for plugins, thru the PLUGIN_HEADERS variable of the gcc/Makefile.in near line 4572 After installation, plugin developers can access them because the

Re: Prefixes for libgcc symbols (C6X 9.5/11)

2011-05-23 Thread Ian Lance Taylor
> gcc/ > * libgcc2.h (__NW, __NDW): Define using a __gnu_ prefix if > LIBGCC2_GNU_PREFIX is defined. > (__N): New macro. > (__powisf2, __powidf2, __powitf2, __powixf2, __bswapsi2, __bswapdi2, > __mulsc3, __muldc3, __mulxc3, __multc3, __divsc3, __divdc3, __divxc3,

Re: RFA (libstdc++): C++/v3 PATCH for c++/24163 (lookup in dependent bases) and c++/29131

2011-05-23 Thread Jason Merrill
It occurred to me today that I could use current_class_name rather than TYPE_IDENTIFIER (current_class_type). Tested x86_64-pc-linux-gnu, applied to trunk. commit d40ebc9ef2be8ab9b4d71410d9797442b2c16d9a Author: Jason Merrill Date: Mon May 23 15:23:42 2011 -0400 * pt.c (tsubst_copy_and

C++ PATCH for c++/49102 (missing error with private defaulted copy ctor and ellipsis)

2011-05-23 Thread Jason Merrill
In this case, the copy constructor is trivial, so we don't complain about having a non-trivial copy constructor. But we should still be doing the lvalue-rvalue conversion, which strictly speaking involves a copy constructor call. Tested x86_64-pc-linux-gnu, applying to trunk. commit a3138b146

[PING] 3 ARM patches

2011-05-23 Thread Carrot Wei
Hi http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01973.html Use ldrd and strd to access two consecutive words http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00490.html Compute attr length for thumb2 insns http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01092.html Replace 32 bit instructions with 16 bi

[v3] Use noexcept in streambuf iterators

2011-05-23 Thread Paolo Carlini
Hi, tested x86_64-linux, committed to mainline. Paolo. // 2011-05-23 Paolo Carlini * include/bits/streambuf_iterator.h: Use noexcept per the FDIS. (istreambuf_iterator<>::istreambuf_iterator(const istreambuf_iterator&), ~istreambuf_iterator()): A

Re: __sync_swap* with acq/rel/full memory barrier semantics

2011-05-23 Thread Joseph S. Myers
On Mon, 23 May 2011, Aldy Hernandez wrote: > This is a patch implementing builtins for an atomic exchange with full, > acquire, and release memory barrier semantics. It is similar to > __sync_lock_test_and_set(), but the target does not have the option of > implementing a reduced functionality of

__sync_swap* with acq/rel/full memory barrier semantics

2011-05-23 Thread Aldy Hernandez
This is a patch implementing builtins for an atomic exchange with full, acquire, and release memory barrier semantics. It is similar to __sync_lock_test_and_set(), but the target does not have the option of implementing a reduced functionality of only implementing a store of 1. Also, unlike _

gcc-patches@gcc.gnu.org

2011-05-23 Thread Jason Merrill
The main problem in this PR was that build_const_cast_1 hadn't been updated to support rvalue references, so the first patch does that. The second patch fixes a couple of minor issues that I noticed while investigating this; neither of them should affect observable semantics, but they match th

Re: RFA PATCH to get_narrower for c++/48106 (ICE with scoped enum)

2011-05-23 Thread Jason Merrill
On 05/23/2011 11:38 AM, Jason Merrill wrote: Do you think I should change shorten_binary_op instead? Thus. Tested x86_64-pc-linux-gnu, applying to trunk. commit 683f3617b323a9d8f62fc5f002d48948eb3b457b Author: Jason Merrill Date: Mon May 23 11:57:40 2011 -0400 PR c++/48106 * c-co

Re: [RFA] [PR44618] [PowerPC] Wrong code for -frename-registers

2011-05-23 Thread edmar
I completed re-testing everything. It turns out I cannot reproduce the original error on gcc-4.4 (rev 173968) So, I am submitting only the patch that I tested for gcc-4.5/4.6/4.7 Regression tested for e500mc target on: 4.5: Revision: 173928 4.6: Revision: 173936 trunk: Revision: 173966 The patch

[Fwd: Re: [PATCH] Add powi-to-multiply expansion to cse_sincos pass]

2011-05-23 Thread William J. Schmidt
Richard, While working on the next patch, I ran into a scenario that will apply to this one as well. If the call statement that calls powi contains vdef/vuse information, it is lost by this replacement. For example, # .MEM_20 = VDEF <.MEM_19(D)> D.1980_3 = __builtin_powf (D.1979_2, 2.0e=0); is

Re: [google] initialize eof_pos (issue4553059)

2011-05-23 Thread Xinliang David Li
ok for google/main. David On Mon, May 23, 2011 at 2:06 PM, Rong Xu wrote: > Add the initializtion for eof_pos. eof_pos may not be initialized properly > when part of gcda files got merged. > > Tested with gcc bootstrap and regression tests. > > 2011-05-23  Rong Xu   > >        * gcc/libgcov.c (g

[google] initialize eof_pos (issue4553059)

2011-05-23 Thread Rong Xu
Add the initializtion for eof_pos. eof_pos may not be initialized properly when part of gcda files got merged. Tested with gcc bootstrap and regression tests. 2011-05-23 Rong Xu * gcc/libgcov.c (gcov_merge_gcda_file): initialize eof_pos for every invocation. Index: gcc/libgc

[PATCH, PR49121] [4.7 Regression] FAIL: gcc.dg/tree-ssa/ivopt_infer_2.c scan-tree-dump-times ivopts "Replacing" 0

2011-05-23 Thread Tom de Vries
Hi, This test case gcc.dg/tree-ssa/ivopt_infer_2.c started failing due to http://gcc.gnu.org/ml/gcc-cvs/2011-05/msg00837.html. test case: ... #ifndef TYPE #define TYPE char* #endif extern int a[]; /* Can not infer loop iteration from array -- exit test can not be replaced. */ void foo (int i_wi

Re: external declaration of dominance debug functions

2011-05-23 Thread Richard Guenther
On Mon, May 23, 2011 at 10:42 PM, Nathan Froyd wrote: > On 05/23/2011 04:23 PM, Richard Guenther wrote: >>> So I don't buy Richie's argument. Otherwise, someone would propose a >>> patch to remove the hundreds of debug_ declarations in public header >>> files (i.e. those visible to plugins), and i

Re: external declaration of dominance debug functions

2011-05-23 Thread Nathan Froyd
On 05/23/2011 04:23 PM, Richard Guenther wrote: >> So I don't buy Richie's argument. Otherwise, someone would propose a >> patch to remove the hundreds of debug_ declarations in public header >> files (i.e. those visible to plugins), and if he did, I hope such a >> naughty patch won't be accepted.

Re: external declaration of dominance debug functions

2011-05-23 Thread Richard Guenther
On Mon, May 23, 2011 at 8:12 PM, Basile Starynkevitch wrote: > On Mon, 23 May 2011 11:56:32 +0200 > Piervit wrote: > >> Le Mon, 23 May 2011 11:30:34 +0200, >> Richard Guenther a écrit : >> >> > On Mon, May 23, 2011 at 10:33 AM, Piervit wrote: >> > > Hello, >> > > >> > > Here is a two lines patc

Re: [4.6 PATCH] Fix pr48973-{1,2}.c testcases with LTO (PR lto/49123)

2011-05-23 Thread Richard Guenther
On Mon, May 23, 2011 at 6:56 PM, Jakub Jelinek wrote: > Hi! > > This is something I didn't notice in my testing because my ld doesn't > support plugins and thus -flto didn't act as -fwhole-file. > The bug got fixed on the trunk by changing build_int_cst, which is > too risky to backport, so this p

Re: PR 48826: NOTE_INSN_CALL_ARG_LOCATION vs. define_split

2011-05-23 Thread Eric Botcazou
> It sounded like you were more concerned with having the comments staying > in sync than the actual specifics, so I went ahead and installed the > patch below. That's fine, thanks. -- Eric Botcazou

Split up options.c

2011-05-23 Thread Joseph S. Myers
This patch splits the generated file options.c into two parts, one shared with the driver and one not, so avoiding the need to build a special gcc-options.o by defining GCC_DRIVER when compiling options.c. The GCC_DRIVER macro, being obsolete, is removed. It ought to be possible to simplify the c

[patch ada]: Fix bootstrap for Ada

2011-05-23 Thread Kai Tietz
Hi, this patch fixes an obvious bootstrap issue caused by trying to assign a constant pointer to an none-constant. Index: adaint.c === --- adaint.c(revision 174060) +++ adaint.c(working copy) @@ -3367,8 +3367,8 @@ char * __

Re: [build] Fix Solaris 2/x86 GD/LD TLS code sequences with Sun ld

2011-05-23 Thread Uros Bizjak
On Mon, May 23, 2011 at 7:22 PM, Rainer Orth wrote: > As described in > >        [testsuite] Provide TLS access model testcases >        http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01601.html > > both the 32 and 64-bit TLS GD and LD execution tests fail on Solaris 2 > with Sun ld unless you have

Re: PATCH: PR target/49128: -mtune=native generates unsupported instructions

2011-05-23 Thread H.J. Lu
On Mon, May 23, 2011 at 11:16 AM, Jakub Jelinek wrote: > On Mon, May 23, 2011 at 11:10:26AM -0700, H.J. Lu wrote: >> +      const char *sse4_2 = has_sse4_2 ? " -msse4.2" : " -msse4.2"; >> +      const char *sse4_1 = has_sse4_1 ? " -msse4.1" : " -msse4.1"; > > Missing "no-" here on both lines. > H

Re: PATCH: PR target/49128: -mtune=native generates unsupported instructions

2011-05-23 Thread Jakub Jelinek
On Mon, May 23, 2011 at 11:10:26AM -0700, H.J. Lu wrote: > + const char *sse4_2 = has_sse4_2 ? " -msse4.2" : " -msse4.2"; > + const char *sse4_1 = has_sse4_1 ? " -msse4.1" : " -msse4.1"; Missing "no-" here on both lines. Jakub

Re: external declaration of dominance debug functions

2011-05-23 Thread Basile Starynkevitch
On Mon, 23 May 2011 11:56:32 +0200 Piervit wrote: > Le Mon, 23 May 2011 11:30:34 +0200, > Richard Guenther a écrit : > > > On Mon, May 23, 2011 at 10:33 AM, Piervit wrote: > > > Hello, > > > > > > Here is a two lines patch, allowing to use debug_dominance_info and > > > debug_dominance_tree fu

PATCH: PR target/49128: -mtune=native generates unsupported instructions

2011-05-23 Thread H.J. Lu
Hi, We use processor model and family to detect processor. But some processors may have some ISAs disabled. This patch always adds -mno-XXX. OK for trunk and 4.6 if there are no regressions? Thanks. H.J. --- 2011-05-23 H.J. Lu PR target/49128 * config/i386/driver-i386.c (h

Re: [PATCH] Add powi-to-multiply expansion to cse_sincos pass

2011-05-23 Thread William J. Schmidt
Richard, thanks for the excellent comments. I really appreciate your help. I've implemented them all, and bootstrap/regtest succeeds on powerpc target. Here's the revised patch for your consideration. Thanks, Bill 2011-05-23 Bill Schmidt * tree-ssa-math-opts.c (powi_table): New.

Re: PR 48826: NOTE_INSN_CALL_ARG_LOCATION vs. define_split

2011-05-23 Thread Richard Sandiford
Eric Botcazou writes: >> PR rtl-optimization/48826 >> * emit-rtl.c (try_split): When splitting a call that is followed >> by a NOTE_INSN_CALL_ARG_LOCATION, move the note after the new call. > > OK if you move up the comment and merge it in the comment of the > block. And it would b

[build] Fix Solaris 2/x86 GD/LD TLS code sequences with Sun ld

2011-05-23 Thread Rainer Orth
As described in [testsuite] Provide TLS access model testcases http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01601.html both the 32 and 64-bit TLS GD and LD execution tests fail on Solaris 2 with Sun ld unless you have a very recent Solaris 11 version (snv_164). This happens becau

Re: Unreviewed build patches

2011-05-23 Thread DJ Delorie
> there's nothing that could affect them. Famous last words :-)

Re: [PATCH] Avoid warning about unused value with VLAs in statement expressions (PR c/49120)

2011-05-23 Thread Joseph S. Myers
On Mon, 23 May 2011, Jakub Jelinek wrote: > Hi! > > This patch shuts up a warning about VLA bounds expression being unused. > start_decl adds the (usually SAVE_EXPR) expression to statements to make > sure it is evaluated, but if that happens in statement expression where > unused value warnings

[4.6 PATCH] Fix pr48973-{1,2}.c testcases with LTO (PR lto/49123)

2011-05-23 Thread Jakub Jelinek
Hi! This is something I didn't notice in my testing because my ld doesn't support plugins and thus -flto didn't act as -fwhole-file. The bug got fixed on the trunk by changing build_int_cst, which is too risky to backport, so this patch instead just adjusts the single place relevant to this patch

[PATCH] Avoid warning about unused value with VLAs in statement expressions (PR c/49120)

2011-05-23 Thread Jakub Jelinek
Hi! This patch shuts up a warning about VLA bounds expression being unused. start_decl adds the (usually SAVE_EXPR) expression to statements to make sure it is evaluated, but if that happens in statement expression where unused value warnings are postponed until we know what is the return value, i

Re: [patch] Fix var-tracking with dynamic stack realignment on x86

2011-05-23 Thread Jakub Jelinek
On Mon, May 23, 2011 at 11:33:42AM +0200, Eric Botcazou wrote: > > Anyway, IMHO the desired outcome is that the > > parameters will have DW_OP_fbreg {0,4} as their location, so perhaps the > > DRAP register needs to be remapped somehow during adjust_insn. > > So you don't care about their locatio

Re: Patch ping

2011-05-23 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/23/11 01:48, Jakub Jelinek wrote: > > - http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00403.html > debug info improvement for unused parameters passed in memory OK. > > - http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01454.html > PR49032 f

Re: Remove obfuscation from the scheduler

2011-05-23 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/19/11 07:37, Bernd Schmidt wrote: > In the scheduler initialization code, we want to set up the h_i_d array. > So we call haifa_init_h_i_d, which has a table of function pointers > which it passes to sched_scan, which copies the function pointer

Re: [PATCH] Fix expansion of comparisons into signed type with 1-bit precision (PR middle-end/48973)

2011-05-23 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/12/11 08:36, Jakub Jelinek wrote: > Hi! > > The read from a 1-bit signed bitfield initialized by a comparison > is optimized into the comparison, which has that 1-bit signed bitfield > comparison. Unfortunately that is still expanded as setting

Re: RFC/RFA: MN10300: Fix handling of protected functions in shared libraries.

2011-05-23 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/23/11 09:21, Nick Clifton wrote: > Hi Alex, Hi Jeff, Hi Richard, > > Consider the following small test case: > > % cat test1.c > extern int g (void) __attribute__ ((visibility("protected"))); > int f (void) { return g (); } > >

Re: PATCH: PR target/47315: ICE: in extract_insn, at recog.c:2109 (unrecognizable insn) with -mvzeroupper and __attribute__((target("avx")))

2011-05-23 Thread Uros Bizjak
On Mon, May 23, 2011 at 5:59 PM, H.J. Lu wrote: > This patch fixes ICE by saving the initial options after checking > vzeroupper.  OK for trunk? > > Thanks. > > > H.J. > --- > gcc/ > > 2011-05-23  H.J. Lu   > >        PR target/47315 >        * config/i386/i386.c (ix86_option_override_internal):

Re: Remove separate tarballs (was: Re: objc patch (was Re: Problem to install GCC 4.6.0 with Objective-C language))

2011-05-23 Thread Nicola Pero
Maybe we can offer an additional compression format like lzma .xz which brings down 4.5.3 compressed size from 66MB bz2 to 52MB (with -7). But that can be decided separately. Yes ... on the other hand, this does not address the other issue, which is the amount of disk space that you need

PATCH: PR target/47315: ICE: in extract_insn, at recog.c:2109 (unrecognizable insn) with -mvzeroupper and __attribute__((target("avx")))

2011-05-23 Thread H.J. Lu
Hi, This patch fixes ICE by saving the initial options after checking vzeroupper. OK for trunk? Thanks. H.J. --- gcc/ 2011-05-23 H.J. Lu PR target/47315 * config/i386/i386.c (ix86_option_override_internal): Save the initial options after checking vzeroupper. gcc/t

Re: [ARM] fix C++ EH interoperability

2011-05-23 Thread Andrew Haley
On 05/23/2011 04:52 PM, Nathan Sidwell wrote: > This patch fixes an interoperability issue with code generated by ARM's EABI > compiler. > This patch results has been tested for arm-linux, and independently tested by > ARM with mixed RVCT-generated code confirming the defect has been fixed. > >

[ARM] fix C++ EH interoperability

2011-05-23 Thread Nathan Sidwell
This patch fixes an interoperability issue with code generated by ARM's EABI compiler. Unlike the generic C++ ABI, which always catches pointers by value, ARM's ABI only catches pointers by value when there's the possibility of derived->base conversion happening. The ARM __cxa_type_matcher ca

C++ PATCH for c++/47263 (missing eh-spec on lambda)

2011-05-23 Thread Jason Merrill
G++ was omitting code for the exception specification on the lambda because it was confusing it with an synthesized constructor. This patch fixes the test to match the comment better; not all artificial methods are [cd]tors. Tested x86_64-pc-linux-gnu, applying to trunk. commit 79adecb0b52f58

Re: RFA PATCH to get_narrower for c++/48106 (ICE with scoped enum)

2011-05-23 Thread Richard Guenther
On Mon, May 23, 2011 at 5:38 PM, Jason Merrill wrote: > On 05/23/2011 11:01 AM, Richard Guenther wrote: >> >> Ok.  Though I wonder where you enter folding before you check semantic >> validity. > > The problem is in c-common:shorten_binary_op, which uses get_narrower and > then calls common_type o

Re: [PATCH][last/n] LTO type merging cleanup

2011-05-23 Thread Richard Guenther
On Mon, May 23, 2011 at 5:34 PM, H.J. Lu wrote: > On Mon, May 23, 2011 at 8:18 AM, Richard Guenther wrote: >> >> This is the last (planned) bit for the regular type merging machinery >> (there is still some issues with TYPE_CANONICAL that I will try to >> address next).  It avoids merging types w

Re: RFA PATCH to get_narrower for c++/48106 (ICE with scoped enum)

2011-05-23 Thread Jason Merrill
On 05/23/2011 11:01 AM, Richard Guenther wrote: Ok. Though I wonder where you enter folding before you check semantic validity. The problem is in c-common:shorten_binary_op, which uses get_narrower and then calls common_type on the types of the results. There is no common type between a sco

Re: [PATCH][last/n] LTO type merging cleanup

2011-05-23 Thread H.J. Lu
On Mon, May 23, 2011 at 8:18 AM, Richard Guenther wrote: > > This is the last (planned) bit for the regular type merging machinery > (there is still some issues with TYPE_CANONICAL that I will try to > address next).  It avoids merging types which have different names > as that leads to interestin

Re: RFA: patch to fix PR48971

2011-05-23 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/13/11 10:58, Vladimir Makarov wrote: > The following patch solves the problem described on > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48971 > > The patch was successfully bootstrapped on x86-64 and checked for ppc64, > ia64, i686-linux, i686-

Re: RFA: patch to fix PR48633.

2011-05-23 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/13/11 11:13, Vladimir Makarov wrote: > The patch fixes PR48633 described on > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48633. > > The patch was successfully bootstrapped on x86-64. > > Ok to commit? > > 2011-05-13 Vladimir Makarov > >

RFC/RFA: MN10300: Fix handling of protected functions in shared libraries.

2011-05-23 Thread Nick Clifton
Hi Alex, Hi Jeff, Hi Richard, Consider the following small test case: % cat test1.c extern int g (void) __attribute__ ((visibility("protected"))); int f (void) { return g (); } % cat test2.c extern int g(void) __attribute__ ((visibility("protected"))); int i; int g

[PATCH][last/n] LTO type merging cleanup

2011-05-23 Thread Richard Guenther
This is the last (planned) bit for the regular type merging machinery (there is still some issues with TYPE_CANONICAL that I will try to address next). It avoids merging types which have different names as that leads to interesting debuginfo issues. LTO-bootstrapped and tested on x86_64-unknown-

Re: [PATCH] split tree_type, a.k.a. "tuplifying types"

2011-05-23 Thread Nathan Froyd
On 05/22/2011 02:24 PM, Tom de Vries wrote: > Now that struct tree_type does not exist anymore, 'sizeof (struct tree_type)' > generates an error in the following assert in fold_checksum_tree: > ... > gcc_assert ((sizeof (struct tree_exp) + 5 * sizeof (tree) > <= sizeof (struct tree_f

C++ PATCH for c++/49058 (different SFINAE with -pedantic)

2011-05-23 Thread Jason Merrill
Normally, we try to be somewhat permissive about overload resolution, accepting near-matches when available in order to give better diagnostics about why they aren't complete matches. But this doesn't apply in templates, since we don't actually perform the conversions that would generate the d

Re: RFA: v3 PATCH to libsupc++/exception_ptr.h for C++0x support

2011-05-23 Thread Paolo Carlini
On 05/23/2011 04:45 PM, Jason Merrill wrote: While looking at c++/47263 I noticed that eh_ptr.cc doesn't compile in C++0x mode because __safe_bool isn't defined, but is used. Is this the way you'd like to fix that? Jason, the change by itself seems indeed ok, but really I don't think we should

Re: RFA PATCH to get_narrower for c++/48106 (ICE with scoped enum)

2011-05-23 Thread Richard Guenther
On Mon, May 23, 2011 at 4:50 PM, Jason Merrill wrote: > C++0x scoped enums don't implicitly convert to an integral type, so we need > to be careful about throwing away explicit conversions.  In this case, the > static_cast(e) creates a NOP_EXPR which get_narrower throws away, but > 'e' itself is n

C++ PATCH for c++/47336 (ICE re-entering diagnostic routines)

2011-05-23 Thread Jason Merrill
In this case, we ran into an access control error trying to print the meaning of a decltype while dumping instantiation context. The simplest answer is to just disable access control during that process rather than try to push into the right context. Tested x86_64-pc-linux-gnu, applying to tr

Re: [PING][PATCH 13/18] move TS_EXP to be a substructure of TS_TYPED

2011-05-23 Thread Richard Guenther
On Mon, May 23, 2011 at 4:18 PM, Nathan Froyd wrote: > On 05/17/2011 11:31 AM, Nathan Froyd wrote: >> On 05/10/2011 04:18 PM, Nathan Froyd wrote: >>> On 03/10/2011 11:23 PM, Nathan Froyd wrote: After all that, we can finally make tree_exp inherit from typed_tree. Quite anticlimatic. >>>

Re: [PATCH] Fix extract_fixed_bit_field (PR middle-end/49029)

2011-05-23 Thread Jeff Law
On 05/18/11 06:33, Jakub Jelinek wrote: > Hi! > > The attached testcase ICEs on arm, because extract_fixed_bit_field > with tmode SImode (and SImode non-NULL target) decides to use DImode for > the signed shifts, but doesn't clear target and thus attempts to use > that SImode target for DImode shi

C++ PATCH for c++/47544 (template defaulted outside class)

2011-05-23 Thread Jason Merrill
A constructor defaulted outside the class body is considered user-provided, so we need to handle instantiating it. But functions defaulted inside the class body we still want to treat the same as implicitly declared functions, so the test checks for that as well. Tested x86_64-pc-linux-gnu, a

C++ PATCH for c++/48617 (wrong error with decltype as template type argument)

2011-05-23 Thread Jason Merrill
Just a missing case. Tested x86_64-pc-linux-gnu, applying to trunk. commit 047661c30a4c6174fc8b994fcdd3eb344d10609c Author: Jason Merrill Date: Sun May 22 15:06:19 2011 -0400 PR c++/48617 * pt.c (invalid_nontype_parm_type_p): Allow DECLTYPE_TYPE. diff --git a/gcc/cp/pt.c b/gcc/cp/p

[PATCH] Adjust and un-XFAIL gcc.dg/tree-ssa/forwprop-11.c

2011-05-23 Thread Richard Guenther
Committed. Richard. 2011-05-23 Richard Guenther * gcc.dg/tree-ssa/forwprop-11.c: Adjust and un-XFAIL. Index: gcc/testsuite/gcc.dg/tree-ssa/forwprop-11.c === --- gcc/testsuite/gcc.dg/tree-ssa/forwprop-11.c (revision 1740

RFA PATCH to get_narrower for c++/48106 (ICE with scoped enum)

2011-05-23 Thread Jason Merrill
C++0x scoped enums don't implicitly convert to an integral type, so we need to be careful about throwing away explicit conversions. In this case, the static_cast(e) creates a NOP_EXPR which get_narrower throws away, but 'e' itself is not a valid argument for &, so we need to replace the NOP_EX

RFA: v3 PATCH to libsupc++/exception_ptr.h for C++0x support

2011-05-23 Thread Jason Merrill
While looking at c++/47263 I noticed that eh_ptr.cc doesn't compile in C++0x mode because __safe_bool isn't defined, but is used. Is this the way you'd like to fix that? commit e018fa18d85e6974b3d66a12c5b7ae9f77b76683 Author: Jason Merrill Date: Sun May 22 16:31:20 2011 -0400 * libsupc+

[PATCH] Testcase for PR40874

2011-05-23 Thread Richard Guenther
Committed. 2011-05-23 Richard Guenther PR tree-optimization/40874 * g++.dg/tree-ssa/pr40874.C: New testcase. Index: gcc/testsuite/g++.dg/tree-ssa/pr40874.C === --- gcc/testsuite/g++.dg/tree-ssa/pr40874.C (rev

Re: [PATCH] get rid of some TYPE_ARG_TYPES usage by introducing nth_arg_type

2011-05-23 Thread Jason Merrill
On 05/23/2011 09:53 AM, Nathan Froyd wrote: #define DECL_CONST_MEMFUNC_P(NODE) \ (DECL_NONSTATIC_MEMBER_FUNCTION_P (NODE) \ -&& CP_TYPE_CONST_P (TREE_TYPE (TREE_VALUE \ -

Re: [patch] fix c++/18016 - warn about self-initialization in constructor init-list

2011-05-23 Thread Jason Merrill
On 05/23/2011 04:20 AM, Jonathan Wakely wrote: I still think this warning shouldn't be tied to -Winit-self. That isn't included in -Wall or -Wextra, and it implies we're saying that a self-referencing mem-initializer is a GNU extension to silence a warning, when I think it's always a mistake and

Re: [PING][PATCH 13/18] move TS_EXP to be a substructure of TS_TYPED

2011-05-23 Thread Nathan Froyd
On 05/17/2011 11:31 AM, Nathan Froyd wrote: > On 05/10/2011 04:18 PM, Nathan Froyd wrote: >> On 03/10/2011 11:23 PM, Nathan Froyd wrote: >>> After all that, we can finally make tree_exp inherit from typed_tree. >>> Quite anticlimatic. >> >> Ping. http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00559.

Re: [PATCH] get rid of some TYPE_ARG_TYPES usage by introducing nth_arg_type

2011-05-23 Thread Nathan Froyd
On 05/23/2011 10:05 AM, Richard Guenther wrote: > On Mon, May 23, 2011 at 3:53 PM, Nathan Froyd > wrote: >> +/* Return the Nth argument type from FNTYPE. */ >> + >> +tree >> +nth_arg_type (const_tree fntype, int n) >> +{ >> + function_args_iterator iter; >> + tree t; >> + int i; >> + >> + gc

Re: [PATCH] get rid of some TYPE_ARG_TYPES usage by introducing nth_arg_type

2011-05-23 Thread Richard Guenther
On Mon, May 23, 2011 at 3:53 PM, Nathan Froyd wrote: > Various places in the compiler grab TYPE_ARG_TYPES and grovel through it > when what they're really trying to do is index into the list of argument > types.  The patch below introduces nth_arg_type for such situatiosn and > changes a hodgepodg

[PATCH] get rid of some TYPE_ARG_TYPES usage by introducing nth_arg_type

2011-05-23 Thread Nathan Froyd
Various places in the compiler grab TYPE_ARG_TYPES and grovel through it when what they're really trying to do is index into the list of argument types. The patch below introduces nth_arg_type for such situatiosn and changes a hodgepodge of places to use it. You could, of course, use function_arg

Re: [PATCH] Fix expansion of comparisons into signed type with 1-bit precision (PR middle-end/48973)

2011-05-23 Thread H.J. Lu
On Mon, May 23, 2011 at 6:21 AM, Jakub Jelinek wrote: > On Mon, May 23, 2011 at 06:06:55AM -0700, H.J. Lu wrote: >> On Thu, May 12, 2011 at 7:36 AM, Jakub Jelinek wrote: >> > The read from a 1-bit signed bitfield initialized by a comparison >> > is optimized into the comparison, which has that 1-

Re: [PATCH PR45098, 7/10] Nowrap limits iterations

2011-05-23 Thread H.J. Lu
On Sat, May 21, 2011 at 5:24 AM, Zdenek Dvorak wrote: > Hi, > >> > Would it be possible to add the handling of these cases >> > to estimate_numbers_of_iterations, rather than doing it just for ivopts? >> >> Yes, I did that now. >> >> Thanks, >> - Tom >> >> 2011-05-05  Tom de Vries   >> >>       PR

Re: [PATCH] Fix expansion of comparisons into signed type with 1-bit precision (PR middle-end/48973)

2011-05-23 Thread Jakub Jelinek
On Mon, May 23, 2011 at 06:06:55AM -0700, H.J. Lu wrote: > On Thu, May 12, 2011 at 7:36 AM, Jakub Jelinek wrote: > > The read from a 1-bit signed bitfield initialized by a comparison > > is optimized into the comparison, which has that 1-bit signed bitfield > > comparison.  Unfortunately that is s

Re: [PATCH] Fix expansion of comparisons into signed type with 1-bit precision (PR middle-end/48973)

2011-05-23 Thread H.J. Lu
On Thu, May 12, 2011 at 7:36 AM, Jakub Jelinek wrote: > Hi! > > The read from a 1-bit signed bitfield initialized by a comparison > is optimized into the comparison, which has that 1-bit signed bitfield > comparison.  Unfortunately that is still expanded as setting the result > to 0 resp. 1 instea

Re: Unreviewed build patches

2011-05-23 Thread Rainer Orth
DJ Delorie writes: >> [build] More --enable-threads cleanup >> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00059.html >> >> This might well be obvious. > > Also, we usually leave those up to the target maintainers, since > they're target specific. But if it's just a correlation be

[PATCH] Fix PR49115

2011-05-23 Thread Richard Guenther
This fixes PR49115 - we cannot assume that a stmt that can throw internally is a kill. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk, queued for backporting. Richard. 2011-05-23 Richard Guenther PR tree-optimization/49115 * tree-ssa-alias.c (stmt_kill

[PATCH] Fix PR15419

2011-05-23 Thread Richard Guenther
We're confused when void * pointers enter memcpy folding. The following fixes it. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-05-23 Richard Guenther PR middle-end/15419 * builtins.c (fold_builtin_memory_op): Be less restrictive about

Re: [build, ada, doc] Remove --enable-threads=gnat support

2011-05-23 Thread Rainer Orth
Paolo Bonzini writes: > On 05/23/2011 12:33 PM, Rainer Orth wrote: >>> > Certainly looks good to me, although I probably can't officially approve >>> > it. >> I think you can since this only affects Ada. I'll wait a day or two if >> anyone objects, then install the patch. > > It's okay for me

Re: [PATCH] Add powi-to-multiply expansion to cse_sincos pass

2011-05-23 Thread Richard Guenther
On Thu, May 19, 2011 at 4:04 PM, William J. Schmidt wrote: > As Richard Guenther suggested, I'm submitting a separate patch to add > powi expansion to multiplies during the cse_sincos pass.  This was > originally submitted as part of a larger patch to fix PR46728. > > Richard noted that tree_expan

[testsuite] Provide TLS access model testcases

2011-05-23 Thread Rainer Orth
While working to improve Solaris/x86 TLS support, Uros provided me with a testcase to excercise all 4 TLS access models. Since there were different issues affecting the different models, I've split the testcase into one per access model so one can easier see what's broken. Tested with the appropr

Re: [build, ada, doc] Remove --enable-threads=gnat support

2011-05-23 Thread Paolo Bonzini
On 05/23/2011 12:33 PM, Rainer Orth wrote: > Certainly looks good to me, although I probably can't officially approve it. I think you can since this only affects Ada. I'll wait a day or two if anyone objects, then install the patch. It's okay for me too. Paolo

Re: Patch ping #2

2011-05-23 Thread Richard Guenther
On Mon, May 23, 2011 at 12:15 PM, Eric Botcazou wrote: >> > Fix annoying gcov filename handling (gcov.c, 2 lines): >> >  http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01380.html >> >> Ok. > > Thanks! > >> > Introduce -Wstack-usage: >> >  http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01992.html >> >>

Re: [build, ada, doc] Remove --enable-threads=gnat support

2011-05-23 Thread Rainer Orth
Arnaud Charlet writes: > Certainly looks good to me, although I probably can't officially approve it. I think you can since this only affects Ada. I'll wait a day or two if anyone objects, then install the patch. Thanks. Rainer -- -

Re: [build, ada, doc] Remove --enable-threads=gnat support

2011-05-23 Thread Tristan Gingold
On May 23, 2011, at 12:06 PM, Rainer Orth wrote: > As Arnaud suggested with one of my --enable-threads cleanup patches, > --enable-threads=gnat is unused and can go. The following patch > implements this. > > Bootstrapped without regressions on i386-pc-solaris2.11. > > While I didn't test the

Fwd: Re: Ping: Re: Updated^2: RFA: Fix middle-end/46500 (void * encapsulated)

2011-05-23 Thread Andrew Haley
--- Begin Message --- On 14/05/11 15:43, Tobias Burnus wrote: > Joern Rennecke wrote: >> This patch hasn't been reviewed for a week: >> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00582.html >> > > The Fortran bits are OK. As is the Java bit. Andrew. --- End Message ---

Re: [patch] Fix var-tracking with dynamic stack realignment on x86

2011-05-23 Thread Jakub Jelinek
On Mon, May 23, 2011 at 11:33:42AM +0200, Eric Botcazou wrote: > > Do you mean something like the attached one? We don't have guality > > testsuite for ada and I think ada testcases are quite unreadable for most > > people. Definitely to me. Plus it is always better to have a single > > file tes

Re: Patch ping #2

2011-05-23 Thread Eric Botcazou
> > Fix annoying gcov filename handling (gcov.c, 2 lines): > >  http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01380.html > > Ok. Thanks! > > Introduce -Wstack-usage: > >  http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01992.html > > I wonder if we can't simply use -Wframe-larger-than but with > the

[libgo] Use /usr/bin/pwd in os_test.TestStartProcess on Solaris (PR go/48502)

2011-05-23 Thread Rainer Orth
As described in the PR, the go libgo test fails on Solaris since /bin is a symlink to /usr/bin. Since there is other OS-specific code in os_test.go, I'm using the follwing patch to fix this. With that patch, libgo test results on i386-pc-solaris2.11 are clean. Rainer 2011-05-20 Rainer

Re: [build, ada, doc] Remove --enable-threads=gnat support

2011-05-23 Thread Arnaud Charlet
> As Arnaud suggested with one of my --enable-threads cleanup patches, > --enable-threads=gnat is unused and can go. The following patch > implements this. > > Bootstrapped without regressions on i386-pc-solaris2.11. > > While I didn't test the other affected configurations, I hope the > changes

[build, ada, doc] Remove --enable-threads=gnat support

2011-05-23 Thread Rainer Orth
As Arnaud suggested with one of my --enable-threads cleanup patches, --enable-threads=gnat is unused and can go. The following patch implements this. Bootstrapped without regressions on i386-pc-solaris2.11. While I didn't test the other affected configurations, I hope the changes are sufficientl

Re: external declaration of dominance debug functions

2011-05-23 Thread Piervit
Le Mon, 23 May 2011 11:30:34 +0200, Richard Guenther a écrit : > On Mon, May 23, 2011 at 10:33 AM, Piervit wrote: > > Hello, > > > > Here is a two lines patch, allowing to use debug_dominance_info and > > debug_dominance_tree functions outside of gcc/dominance.c. For the > > moment, those functi

Ping: C6X libgcc changes

2011-05-23 Thread Bernd Schmidt
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00992.html Bernd

Ping: C6X miscellaneous new hooks

2011-05-23 Thread Bernd Schmidt
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00909.html http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00757.html http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00760.html Bernd

Re: The TI C6X port

2011-05-23 Thread Bernd Schmidt
Ping: C6X scheduler changes. http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00747.html http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00749.html http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00750.html http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00753.html http://gcc.gnu.org/ml/gcc-patches/2011-05/msg

Re: [patch] Fix var-tracking with dynamic stack realignment on x86

2011-05-23 Thread Eric Botcazou
> Do you mean something like the attached one? We don't have guality > testsuite for ada and I think ada testcases are quite unreadable for most > people. Definitely to me. Plus it is always better to have a single > file testcase over 5 files. Sure. Last time I mentioned the guality testsuite

Re: external declaration of dominance debug functions

2011-05-23 Thread Richard Guenther
On Mon, May 23, 2011 at 10:33 AM, Piervit wrote: > Hello, > > Here is a two lines patch, allowing to use debug_dominance_info and > debug_dominance_tree functions outside of gcc/dominance.c. For the > moment, those functions are not declared in any gcc/*.h files (as far as > I know after trying a

Re: Patch ping #2

2011-05-23 Thread Richard Guenther
On Mon, May 23, 2011 at 9:59 AM, Eric Botcazou wrote: > Not as many as Jakub, but still. :-) > > > Fix annoying gcov filename handling (gcov.c, 2 lines): >  http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01380.html Ok. > Introduce -Wstack-usage: >  http://gcc.gnu.org/ml/gcc-patches/2011-03/msg0199

Re: Patch ping

2011-05-23 Thread Richard Guenther
On Mon, 23 May 2011, Jakub Jelinek wrote: > Hi! > > - http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00895.html > P1 PR48973 4.6/4.7 fix for expansion of comparisons with signed > 1 bit precision type Ok. I'll leave the rest to others. Thanks, Richard.

  1   2   >