Re: [Patch, Fortran] PR51514 - fix passing a CLASS to a TYPE

2012-02-06 Thread Paul Richard Thomas
Dear Tobias, On Mon, Feb 6, 2012 at 11:27 PM, Tobias Burnus wrote: > When passing a CLASS to a TYPE, the "_data" component wasn't added for > scalar variables. (Polymorphic arrays are/were handled correctly.) > > This patch adds the _data, fixing this wrong-code issue. > > Build and regtested on

Re: [PATCH] Fix sibcall argument overlap checking if pretend_args_size (PR target/52129)

2012-02-06 Thread Carrot Wei
Hi Jakub Instead of disabling the sibcall, it could also be a valid tail call optimization by moving the str after ldmia, and change the used register(It should be handled by RA automatically), as following ... add r4, r1, r4, lsl #2 ldmia r2, {r1, r2}

RE: [Patch,AVR]: Clean up hard-coded SFR addresses

2012-02-06 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay [mailto:a...@gjlay.de] > Sent: Monday, February 06, 2012 4:45 AM > To: Weddington, Eric > Cc: gcc-patches@gcc.gnu.org; Denis Chertykov > Subject: Re: [Patch,AVR]: Clean up hard-coded SFR addresses > > > Here is an updated patch without the S

[Patch, Fortran] PR51514 - fix passing a CLASS to a TYPE

2012-02-06 Thread Tobias Burnus
When passing a CLASS to a TYPE, the "_data" component wasn't added for scalar variables. (Polymorphic arrays are/were handled correctly.) This patch adds the _data, fixing this wrong-code issue. Build and regtested on x86-64-linux. OK for the trunk? Tobias 2012-02-06 Tobias Burnus PR fort

Re: libstdc++/52104 - fix linker error for non-TLS targets

2012-02-06 Thread Jonathan Wakely
And fix a linker error (which I can't reproduce) on TLS targets, which can use an explicit instantiation because it doesn't refer to an unnamed closure type. PR libstdc++/52128 * src/c++11/future.cc: Add explicit instantiation. Tested x86_64-linux, powerpc-linux, i686-linux, x86_6

Re: [PATCH 4.8, i386]: Enable post-reload compare optimization pass (PR28685)

2012-02-06 Thread Mike Stump
On Feb 6, 2012, at 12:59 PM, Richard Henderson wrote: > And, really, we ought to come up with some trick to eliminate some of the > redundancy in patterns in the md file too. :-) That'd be awesome...

Re: [PATCH 4.8, i386]: Enable post-reload compare optimization pass (PR28685)

2012-02-06 Thread Uros Bizjak
On Mon, Feb 6, 2012 at 9:59 PM, Richard Henderson wrote: > On 02/05/2012 07:27 AM, Uros Bizjak wrote: >> Hello! >> >> Attached patch enables post-reload compare optimization pass for x86 targets. > > Hmm.  Well, the only thing that's going to work for x86 is the double-compare > elimination portio

Re: Added test case for PR 32373, missed vectorization with equivalence

2012-02-06 Thread Thomas Koenig
Hi Dominique, The test fails on powerpc-apple-darwin9 because double are not vectorized. I think the following patch is required: Thanks for noticing this! I applied this patch as obvious after regression-testing. Thomas 2012-02-06 Thomas König PR fortran/32373 *

C++ PATCH for c++/52088 (ICE with template conversion op)

2012-02-06 Thread Jason Merrill
In this testcase, we ended up trying to call an uninstantiated template, and get confused as a result. This patch changes the compiler to not consider a template to be a valid candidate for a default conversion. Tested x86_64-pc-linux-gnu, applied to trunk commit 06d4f1b83e5c393fd22421bbd12135

Re: [PATCH 4.8, i386]: Enable post-reload compare optimization pass (PR28685)

2012-02-06 Thread Richard Henderson
On 02/05/2012 07:27 AM, Uros Bizjak wrote: > Hello! > > Attached patch enables post-reload compare optimization pass for x86 targets. Hmm. Well, the only thing that's going to work for x86 is the double-compare elimination portion. If we want to use this pass for x86, then for 4.8 we should als

Re: Regression on character function

2012-02-06 Thread Paul Richard Thomas
Dear All, The attached is obvious fix to this regression and I will commit tomorrow evening if there is no objection. Cheers Paul 2012-02-06 Paul Thomas * resolve.c (resolve_fl_derived0): Typebound functions support assumed character length results. 2012-02-06 Paul Thomas

[PATCH] Fix combiner with added_sets_[12] (PR rtl-optimization/52060)

2012-02-06 Thread Jakub Jelinek
Hi! combine_simplify_rtx and its helpers (called from subst) apparently modify the given RTL in-place, there are many SUBST () calls all around those functions. On the attached testcase in particular on arm when newpat = subst (newpat, i1dest, i1src, 0, 0, 0); is called, force_to_mode modifies th

Re: debug safe iterator patch

2012-02-06 Thread François Dumont
Attached patch applied 2012-02-06 François Dumont * include/debug/safe_iterator.h (_Safe_iterator::_M_before_dereferenceable): Avoid the expensive creation of a _Safe_iterator instance to do the check. François On 02/05/2012 06:30 PM, Paolo Carlini wrote: On 02/05/20

Re: [PATCH] enable fma4 for bdver2

2012-02-06 Thread Quentin Neill
On Mon, Feb 6, 2012 at 9:32 AM, Quentin Neill wrote: > On Tue, Nov 8, 2011 at 3:53 PM, Richard Henderson wrote: >> >> On 11/07/2011 07:28 PM, Quentin Neill wrote: >> > +       Add FMA4 to bdver2. >> > +       * config/i386/i386.c (ix86_option_override_internal): Add FMA4 >> > to bdver2. >> >> Ok.

Re: [committed] PR 51931: force non-MIPS16ness for long-branch tests (NOW RFA: MIPS16 Long Branch Patch)

2012-02-06 Thread Richard Sandiford
Thanks for the patch. "Moore, Catherine" writes: >> -Original Message- >> From: Chung-Lin Tang [mailto:clt...@codesourcery.com] >> Sent: Monday, January 30, 2012 4:36 AM >> To: gcc-patches@gcc.gnu.org; rdsandif...@googlemail.com >> Cc: Moore, Catherine >> Subject: Re: [committed] PR 51931

Re: [PATCH] MIPS16 TLS support for GCC

2012-02-06 Thread Richard Sandiford
[forking for different topics] "Maciej W. Rozycki" writes: > On Sat, 4 Feb 2012, Richard Sandiford wrote: >> > I don't think _mcount has ever worked for dynamic libraries, has it? -- >> > please correct me if I am wrong, but I believe `gprof' relies on memory >> > segments to be contiguous whi

Re: [PATCH] MIPS16 TLS support for GCC

2012-02-06 Thread Richard Sandiford
"Maciej W. Rozycki" writes: >> > We have only about now got MIPS16 shared libraries to work -- are you >> > sure removing code to save/restore $2/$3 in the dynamic linker is going to >> > hit anyone? >> >> Pretty sure. There are two separate points here. Support for MIPS16 >> shared librarie

Re: [PATCH] disable __size_t macro on GNU/kFreeBSD

2012-02-06 Thread Mike Stump
On Feb 4, 2012, at 11:20 AM, Robert Millan wrote: > El 1 de febrer de 2012 1:06, Mike Stump ha escrit: >> On Jan 31, 2012, at 2:29 PM, Gerald Pfeifer wrote: >>> On Sun, 29 Jan 2012, Robert Millan wrote: Please consider this patch to stddef.h. GNU/kFreeBSD has the same problem with __size

Re: Gthreads patch to disable static initializer macros

2012-02-06 Thread Mike Stump
On Feb 5, 2012, at 12:26 PM, Jonathan Wakely wrote: > PRs libstdc++/51296 and libstdc++/51906 are both caused by problems > with the Pthreads static initializer macros such as > PTHREAD_MUTEX_INITIALIZER. > On Mac OS X 10.7 the PTHREAD_RECURSIVE_MUTEX_INITIALIZER is buggy. Thanks for all you work

Re: [RS6000] Fix PR52107, TFmode constant load.

2012-02-06 Thread David Edelsohn
On Sat, Feb 4, 2012 at 12:46 AM, Alan Modra wrote: > http://gcc.gnu.org/ml/gcc-patches/2007-01/msg01835.html changed the > code I'm tweaking here to use DFmode subregs when loading a TFmode > constant into regs for e500.  This just extends that change to all > rs6000 targets, the simplest fix I fo

Re: [PATCH] MIPS16 TLS support for GCC

2012-02-06 Thread Maciej W. Rozycki
On Sat, 4 Feb 2012, Richard Sandiford wrote: > > I don't think _mcount has ever worked for dynamic libraries, has it? -- > > please correct me if I am wrong, but I believe `gprof' relies on memory > > segments to be contiguous which is certainly not the case for a dynamic > > executable where

Re: [PATCH] enable fma4 for bdver2

2012-02-06 Thread Quentin Neill
On Tue, Nov 8, 2011 at 3:53 PM, Richard Henderson wrote: > > On 11/07/2011 07:28 PM, Quentin Neill wrote: > > +       Add FMA4 to bdver2. > > +       * config/i386/i386.c (ix86_option_override_internal): Add FMA4 > > to bdver2. > > Ok. > > > r~ This patch was okay'd in stage 3 but was never commi

Re: Memory corruption due to word sharing

2012-02-06 Thread Richard Guenther
On Fri, 3 Feb 2012, Richard Guenther wrote: > On Fri, 3 Feb 2012, Richard Guenther wrote: > > > On Fri, 3 Feb 2012, Richard Guenther wrote: > > > > > On Thu, 2 Feb 2012, Aldy Hernandez wrote: > > > > > > > Linus Torvalds writes: > > > > > > > > > Seriously - is there any real argument *agains

[PATCH] Fix PR52155

2012-02-06 Thread Richard Guenther
This fixes PR 52155. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2012-02-06 Richard Guenther PR tree-optimization/52115 * tree-sra.c (access_has_replacements_p): New function. (sra_modify_assign): Use it to decide whether a use is

Re: [trans-mem, PATCH] do not dereference node if null in expand_call_tm (PR middle-end/52047)

2012-02-06 Thread Aldy Hernandez
Looks good to me. Thanks, Richard. Thanks folks. I have committed the patch, and will close the PR. Aldy

Re: [PATCH][ARM] 64-bit shifts in NEON.

2012-02-06 Thread Andrew Stubbs
On Mon 06 Feb 2012 13:18:34 GMT, Jakub Jelinek wrote: On Mon, Feb 06, 2012 at 01:13:58PM +, Andrew Stubbs wrote: Anyway, is this patch OK? Are you asking approval for 4.8, or 4.7? For the latter this doesn't seem to be a regression bugfix that would be suitable for stage4. Yes, sorry, t

[v3] Update alpha-linux baselines for GCC 4.7

2012-02-06 Thread Uros Bizjak
Hello! This patch updates baseline symbols for alpha-linux-gnu. 2012-02-06 Uros Bizjak * config/abi/post/alpha-linux-gnu/baseline_symbols.txt: Regenerated. OK for mainline? Uros. Index: config/abi/post/alpha-linux-gnu/baseline_symbols.txt

[PATCH] Fix PR50955

2012-02-06 Thread Richard Guenther
This fixes PR50955 - IVOPTs can end up expressing a pointer value using unrelated pointer bases. This confuses alias analysis. The fix is to extend the existing stop-gap we have in place to cover the case in question. Bootstrapped and tested on x86_64-unknonw-linux-gnu. I have also benchmarked

Re: [PATCH][ARM] 64-bit shifts in NEON.

2012-02-06 Thread Jakub Jelinek
On Mon, Feb 06, 2012 at 01:13:58PM +, Andrew Stubbs wrote: > Anyway, is this patch OK? Are you asking approval for 4.8, or 4.7? For the latter this doesn't seem to be a regression bugfix that would be suitable for stage4. > 2012-02-06 Andrew Stubbs > > gcc/ > * config/arm/arm

Re: [PATCH] Fix sibcall argument overlap checking if pretend_args_size (PR target/52129)

2012-02-06 Thread Richard Guenther
On Mon, Feb 6, 2012 at 2:01 PM, Jakub Jelinek wrote: > Hi! > > The attached testcase is miscompiled on arm*, by doing a sibcall when setup > of one argument overwrites incoming arguments used to setup parameters in > later insns. > The reason why > mem_overlaps_already_clobbered_arg_p/check_sibcal

[PATCH][ARM] 64-bit shifts in NEON.

2012-02-06 Thread Andrew Stubbs
This patch adds DImode shift support in NEON registers/instructions. The patch causes delays any lowering until the split2 pass, after the register allocator has chosen whether to do the shift in NEON (VFP) registers, or in core-registers. The core-registers case depends on the patch I previo

[PATCH] Fix reg-stack DEBUG_INSN adjustments (PR debug/52132)

2012-02-06 Thread Jakub Jelinek
Hi! On the following testcase we ICE in dwarf2out, because apparently reg-stack changed a (var_location:SI D#1 (subreg:SI (reg:SF 8) 0)) into (var_location:SI D#1 (reg:SF 8)) (note the subreg is gone and mismatching mode). The problem seems to be in get_true_reg function that subst_stack_regs_in_

[PATCH] Fix sibcall argument overlap checking if pretend_args_size (PR target/52129)

2012-02-06 Thread Jakub Jelinek
Hi! The attached testcase is miscompiled on arm*, by doing a sibcall when setup of one argument overwrites incoming arguments used to setup parameters in later insns. The reason why mem_overlaps_already_clobbered_arg_p/check_sibcall_argument_overlap fails to detect is that the caller has non-zero

Re: [Patch,AVR]: Clean up hard-coded SFR addresses

2012-02-06 Thread Georg-Johann Lay
Weddington, Eric wrote: > >> -Original Message- >> From: Georg-Johann Lay [mailto:a...@gjlay.de] >> Sent: Friday, February 03, 2012 12:47 PM >> To: gcc-patches@gcc.gnu.org >> Cc: Denis Chertykov; Weddington, Eric >> Subject: [Patch,AVR]: Clean up hard-coded SFR addresses >> >> This patch r

Re: [PATCH] Fix -fdump-rtl-sms (PR rtl-optimization/52095)

2012-02-06 Thread Richard Guenther
On Fri, Feb 3, 2012 at 7:07 PM, Jakub Jelinek wrote: > Hi! > > On some targets e.g. sms-7.c test fails, because fprintf is called > with %s format and NULL argument, GLIBC prints for that e.g. > SMS loop num: 1, file: (null), line: 0 > but it isn't portable.  print-rtl.c guards the locator printin

Re: [PATCH]Fix PR51867, in which gcc generates inconsistent code for same functions

2012-02-06 Thread Richard Guenther
On Sat, Feb 4, 2012 at 3:48 AM, Bin Cheng wrote: > Hi, > > Here is the patch fixing pr51867 by removing the redundant check on > DECL_ASSEMBLER_NAME_SET_P. > I also changed '-O0' to '-O1' in signbit-2.c and added a new test. > The new test case won't bite if target cpu does not support hardware sq

Re: Added test case for PR 32373, missed vectorization with equivalence

2012-02-06 Thread Dominique Dhumieres
Thomas, The test fails on powerpc-apple-darwin9 because double are not vectorized. I think the following patch is required: --- /opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/vect/vect-8.f90 2012-02-05 23:32:31.0 +0100 +++ /opt/gcc/work/gcc/testsuite/gfortran.dg/vect/vect-8.f90

[patch] [4.8] Mixed condition vect pattern for non-constants

2012-02-06 Thread Ira Rosen
Hi, This patch enhances mixed condition pattern detection to work with non-constant integral then and else clauses. It checks that 'then' and 'else' are results of type conversion from the comparison type to their current type, and generates the whole cond_epxr in comparison type (ignoring the co