Ping: PATCH RFA: Print backtrace on ICE

2012-09-20 Thread Ian Lance Taylor
Ping. The patch is the same, so I didn't attach it again. It may be found at http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01174.html . I think I've replied to all comments. Ian -- Forwarded message -- From: Ian Lance Taylor Date: Mon, Sep 17, 2012 at 10:17 AM Subject: PATCH RF

Re: [PATCH] Fix a bug that breaks go build

2012-09-20 Thread Ian Lance Taylor
On Thu, Sep 20, 2012 at 7:31 PM, Dehao Chen wrote: > This patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54649 > > The previous patch is incorrect and will cause regression to > g++.dg/debug/dwarf2/deallocator.C > > A new patch is attached. It solved the bootstrap problem for go. > Basica

[testsuite] fix to check_effective_target_arm_hard_vfp_ok

2012-09-20 Thread Janis Johnson
Tests in gcc.target/arm/aapcs check for floating-point arguments being passed correctly, but the added flag "-mfloat-abi=hard" can be overridden by another value in flags used for all tests (like multilib flags), causing the tests to fail. The tests in that directory are all gated on effective-tar

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Dehao Chen
Hi, As expected, since this patch was checked in yesterday, there are 4 bugs exposed (1 fixed, 1 patch ready, 2 TBD): 1. http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01413.html Failed targets such as arm and mips. Fixed by r191510 2. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54649 Failed Go bo

[testsuite] gcc.target/arm: skip 5 tests for flag conflicts

2012-09-20 Thread Janis Johnson
This patch adds test directives to skip 5 tests in gcc.target/arm if the flags specified for the test would be overridden by or conflict with flags used for all tests, such as multilib flags. Tested on arm-none-eabi with a variety of test flags. I'll wait a day or two before checking it in to giv

Re: [PATCH] Fix a bug that breaks go build

2012-09-20 Thread Dehao Chen
This patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54649 The previous patch is incorrect and will cause regression to g++.dg/debug/dwarf2/deallocator.C A new patch is attached. It solved the bootstrap problem for go. Basically, when we set the line number for stmts in the finally block,

[PING] Re: VxWorks Patches Back from the Dead!

2012-09-20 Thread rbmj
Ping? Just did a full pull and rebuild today and everything still works :) Robert Mason On 9/10/2012 3:46 PM, Bruce Korb wrote: Hi, On Mon, Sep 10, 2012 at 10:48 AM, rbmj wrote: On the other hand, I've read this on the website: Don't mix together changes made for different reasons. Send t

Re: [patch, mips] Fix for PR 54619, GCC aborting with -O -mips16

2012-09-20 Thread Sandra Loosemore
Re: I think tree-ssa-loop-ivopts is simply asking for the wrong thing, and needs to be changed. As I say, Sandra had some fixes in this area. This patch: http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00319.html Sadly, that patch has fallen off the bottom of my priority list (some legal wran

Re: [PATCH] rs6000: Fix nonsensical scc splitter pattern

2012-09-20 Thread David Edelsohn
On Thu, Sep 20, 2012 at 7:47 PM, Segher Boessenkool wrote: > This splitter is, erm, interesting. This patch fixes it. > > Bootstrapped and regression checked on powerpc64-linux. > Okay to apply? > > > Segher > > > 2012-09-20 Segher Boessenkool > > gcc/ > * config/rs6000/rs6000.md (defi

[PATCH, doc] Separate sections in Chapter Plugins and LTO

2012-09-20 Thread Jia Liu
Hi all, Currently the Chapter Plugins and LTO is all in one html page, the other chapters are separated into sections. So I separated them to make them easier reading. Is this patch OK? Regards, Jia 2012-09-21 Jia Liu * gcc/doc/lto.texi: Separate sections. * gcc/doc/plugins

[PATCH] rs6000: Fix nonsensical scc splitter pattern

2012-09-20 Thread Segher Boessenkool
This splitter is, erm, interesting. This patch fixes it. Bootstrapped and regression checked on powerpc64-linux. Okay to apply? Segher 2012-09-20 Segher Boessenkool gcc/ * config/rs6000/rs6000.md (define_split for plus_eqsi): Fix output pattern. --- gcc/config/rs6000/rs60

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Dehao Chen
I can reproduce the problem now. After some investigation, this error should be a bug exposed by this patch. The root cause is, in expand_omp_taskreg, it calls move_sese_region_to_fn with gimple_block(entry_stmt) as the root of the block tree. However, there is an edge inside the region that has t

Re: [Patch] PR54635: Add addr_space_t argument to mode_dependent_address_p

2012-09-20 Thread Hans-Peter Nilsson
On Thu, 20 Sep 2012, Georg-Johann Lay wrote: > Hans-Peter Nilsson wrote: > > Georg-Johann Lay wrote: > >> mode_dependent_address_p is not sensitive to the address space of the > >> passed > >> address. Thus, add an addr_space_t parameter to the hook. > > > > Borderline obvious. :) (J/k; the adde

Re: [patch] Fix PR rtl-optimization/54290

2012-09-20 Thread Eric Botcazou
> This breaks bootstrap on ARM: > > /home/rearnsha/gnusrc/gcc/gcc-fsf/gcc/reload1.c: In function `void > choose_reload_regs(insn_chain*)': > /home/rearnsha/gnusrc/gcc/gcc-fsf/gcc/reload1.c:6959:19: error: unused > variable `tem' [-Werror=unused-variable] > rtx check_reg, tem; My bad... fixed

[Patch, ARM, testsuite] improve test for builtin_bswap16 for Thumb2

2012-09-20 Thread Christophe Lyon
Hi, The attached patch make sure we test builtin_bswap16 expansion in Thumb2 mode in addition to the existing Thumb1 test (which may fail as unsupported if the compiler is also using float-abi=hard). The newly created test is the same as the existing one, except for the forced architecture versio

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Dominique Dhumieres
> This problem will be fixed by > http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01491.html Sorry, but its not (see pr54645 c#3). Dominique

Re: Scheduler: Allow breaking dependencies by modifying patterns

2012-09-20 Thread Bernd Schmidt
On 09/20/2012 07:42 PM, H.J. Lu wrote: > On Fri, Aug 3, 2012 at 5:05 AM, Bernd Schmidt wrote: >> This patch allows us to change >> >> rn++ >> rm=[rn] >> >> into >> >> rm=[rn + 4] >> rn++ >> > This caused: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54645 The jury is still out on that, but it

[Patch, ARM, testsuite]

2012-09-20 Thread Christophe Lyon
Hi, GCC for ARM does not support compiling in Thumb1 mode and float-abi=hard. But it does not fail unless the program being compiled actually contains a function with parameters and/or a return value. This is a (minor) problem in the testsuite in some configurations. For instance, if I run th

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Dehao Chen
On Thu, Sep 20, 2012 at 6:04 PM, Dominique Dhumieres wrote: > A lot of failures in the test suite have appeared between revisions > 191485 and 191494 see > http://gcc.gnu.org/ml/gcc-regression/2012-09/msg00327.html ). > I have looked at the failure of libgomp.fortran/reduction1.f90: > > [macbook]

Fix oversights in the gnat.dg testsuite

2012-09-20 Thread Eric Botcazou
The dg directives need to be put in the .adb files, otherwise they are ignored in the gnat.dg directory. Tested on x86-64/Linux, applied on all active branches. 2012-09-20 Eric Botcazou * gnat.dg/opt20.ads: Move dg directive to... * gnat.dg/opt20.adb: ...here. * gnat

Re: Use conditional casting with symtab_node

2012-09-20 Thread Lawrence Crowl
On 9/20/12, Gabriel Dos Reis wrote: > On Sep 20, 2012 Lawrence Crowl wrote: > > > > Why do you think cascading ifs is a bad idea? > > > > > > Precedent. Confusion in case of dangling else (requiring > > > more {}, and hence even more indentation). Ugly. > > > > I generally take ugly as an indic

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Dehao Chen
The PCH related failures are caused by this patch. The patch I posted earlier http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01491.html solved another problem, but not this one. The issue here is: when reading PCH data, the line_table is also read from PCH files. But the location_adhoc_data_map is n

Re: Use conditional casting with symtab_node

2012-09-20 Thread Gabriel Dos Reis
On Thu, Sep 20, 2012 at 1:53 PM, Lawrence Crowl wrote: >> > Why do you think cascading ifs is a bad idea? >> >> Precedent. Confusion in case of dangling else (requiring more {}, >> and hence even more indentation). Ugly. > > I generally take ugly as an indication that the function needs > refac

Re: [patch] pr/54508: fix incomplete debug information for class

2012-09-20 Thread Paul_Koning
Attached below is an update to the testcase file, to fix the scan-assembler regexp comment character matching. This uses the same regexp element that H-P Nilsson used in the fix to nested-3.C two days ago. By the way, I ran check-g++ for dwarf2.exp on this change, no regressions. Ok to commit?

[Patch, Fortran, committed] Fix issue in cpp.c's print_line

2012-09-20 Thread Tobias Burnus
gfortran was using loc = expand_location (src_loc); and then looked at "loc.sysp" value to decide whether it was a system header with extern C or a normal system header. However, loc.sysp is a bool! There is another "sysp" which is an integer. As in gcc/c-family/c-ppoutput.c, one has to use

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Dehao Chen
Sorry for breaking these tests. This problem is very hard to reproduce. However, I had a patch to fix another compile-time problem which may be related to this one. http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01491.html After applying the patch, the PCH related bugs are not showing any more on m

[PATCH] PR c++/53551 - -Wunused-local-typedefs misses uses

2012-09-20 Thread Dodji Seketeli
Hello, We don't record the use of a typedef when it's used through a typename. So on the example of the patch, g++ complains that the 'type' typedef is not used. Fixed thus. Tested on x86_64-unknown-linux-gnu against trunk. gcc/cp/ * decl.c (make_typename_type): Record the use of typed

[PATCH] Fix a bug that breaks go build

2012-09-20 Thread Dehao Chen
This patch fixes a bug is in tree-eh.c. IS_UNKNOWN_LOCATION is mistakenly used, thus the block info for a call stmt is cleared. Bootstrapped and gcc regression testing is on-going. Is it okay for trunk? Thanks, Dehao gcc/ChangeLog: tree-eh.c (lower_try_finally_dup_block): Use correct wa

Re: RFA: Fix COND_EXEC handling of dead_or_set_regno_p

2012-09-20 Thread Richard Henderson
On 09/19/2012 09:25 PM, Joern Rennecke wrote: > + /* If a COND_EXEC is not executed, the value survives. */ >if (GET_CODE (pattern) == COND_EXEC) > -pattern = COND_EXEC_CODE (pattern); > +return 0; Ok. r~

Re: vector comparisons in C++

2012-09-20 Thread Marc Glisse
On Sat, 1 Sep 2012, Marc Glisse wrote: I have some issues with the vector-compare-2.c torture test. It passes a vector by value (argument and return type), which is likely to warn (although for some reason it doesn't for me, with today's compiler). And it takes -Wno-psabi through a .x file, bu

Re: Top Level GCC change questions

2012-09-20 Thread Walter Lee
> Not in GCC: > > 2012-09-15 Jiong Wang > > * configure.ac (ENABLE_GOLD): support tilegx* > * configure: rebuild I pulled this into gcc. Walter

Re: Use conditional casting with symtab_node

2012-09-20 Thread Lawrence Crowl
On 9/20/12, Michael Matz wrote: > On Wed, 19 Sep 2012, Lawrence Crowl wrote: > > On 9/19/12, Eric Botcazou wrote: > > > > The language syntax would bind the conditional into the > > > > intializer, as in > > > > > > > > if (varpool_node *vnode = (node->try_variable () > > > >

Re: Top Level GCC change questions

2012-09-20 Thread Mike Stump
On Sep 20, 2012, at 12:01 AM, Georg-Johann Lay wrote: > Steve Ellcey schrieb: >> DJ Delorie wrote: Is there any automation for this or is it still up to each person checking in files to copy stuff over by hand? >>> There is no automation, as neither project was willing to cede control >>

Re: [patch, mips] Fix for PR 54619, GCC aborting with -O -mips16

2012-09-20 Thread Richard Sandiford
Steve Ellcey writes: > On Wed, 2012-09-19 at 18:42 +0100, Richard Sandiford wrote: >> But the documentation says: >> >> This hook is never called with an invalid address. >> >> Since VOIDmode MEMs aren't valid, I think that should mean it's invalid >> to call this hook (and rtlanal.c:address_c

Re: Scheduler: Allow breaking dependencies by modifying patterns

2012-09-20 Thread H.J. Lu
On Fri, Aug 3, 2012 at 5:05 AM, Bernd Schmidt wrote: > This patch allows us to change > > rn++ > rm=[rn] > > into > > rm=[rn + 4] > rn++ > > Opportunities to do this are discovered by a mini-pass over the > instructions after generating dependencies and before scheduling a > block. At that point w

Go patch committed: Keep up with main compiler

2012-09-20 Thread Ian Lance Taylor
This patch to the Go frontend is really from Martin Jambor. It adjusts the Go frontend for changes in the main body of the compiler. This code in the Go frontend is slated to move out of gcc/go/gofrontend into gcc/go, hopefully sooner rather than later. Bootstrapped and ran Go testsuite on x86_6

Re: [4.7 PATCH] Use automake no-dist everywhere

2012-09-20 Thread Jakub Jelinek
On Thu, Sep 20, 2012 at 09:12:37AM -0700, Ian Lance Taylor wrote: > On Thu, Sep 20, 2012 at 6:33 AM, Jakub Jelinek wrote: > > > > This is the 4.7 version. Not 100% sure about libgo, Ian, are you regularly > > syncing upstream libgo even into 4.7 branch, or only to trunk? I.e. are you > > find wi

[PR target/54631] Update vxworks.c to new VEC_quick_push interface

2012-09-20 Thread Diego Novillo
Tested by building stage 1 on i686-wrs-vxworks. Robert, please verify that the fix actually works for you. Thanks. Diego. 2012-09-20 Diego Novillo PR target/54631 * config/vxworks.c (vxworks_emutls_var_init): Update for new VEC_quick_push interface. diff --git a/gcc

Go 4.7 patch committed: Bring 4.7 branch up to date

2012-09-20 Thread Ian Lance Taylor
I have committed this patch to the GCC 4.7 branch to bring it up to date with the bug fixes that I have already committed to mainline. Bootstrapped 4.7 branch and ran Go testsuite on x86_64-unknown-linux-gnu. Ian 2012-09-20 Ian Lance Taylor * Make-lang.in (go/gogo.o): Depend on filen

MAINTAINERS (Write After Approval): Add myself.

2012-09-20 Thread Marek Polacek
As the subject says. 2012-09-20 Marek Polacek * MAINTAINERS (Write After Approval): Add myself. --- gcc/MAINTAINERS.mp 2012-09-20 18:39:14.496681360 +0200 +++ gcc/MAINTAINERS 2012-09-20 18:40:35.031886515 +0200 @@ -473,6 +473,7 @@ Fernando Pereira pron

Re: [patch, mips] Fix for PR 54619, GCC aborting with -O -mips16

2012-09-20 Thread Steve Ellcey
On Wed, 2012-09-19 at 18:42 +0100, Richard Sandiford wrote: > But the documentation says: > > This hook is never called with an invalid address. > > Since VOIDmode MEMs aren't valid, I think that should mean it's invalid > to call this hook (and rtlanal.c:address_cost) with VOIDmode. I never

[patch] [ARM]

2012-09-20 Thread Matthias Klose
Starting with 4.4, GCC informs about that the `va_list' mangling has changed. This makes builds a bit "noisy", and maybe it's time to remove this informational message in the trunk. Matthias 2012-09-20 Matthias Klose * gcc/config/arm/arm.c (arm_mangle_type): Don't warn anymore that

libgo patch committed: Add no-dist -Wno-portability to AM_INIT_AUTOMAKE

2012-09-20 Thread Ian Lance Taylor
This patch to libgo adds no-dist and -Wno-portability to AM_INIT_AUTOMAKE in configure.ac. Adding no-dist is consistent with other GCC libraries. Adding -Wno-portability removes some automake errors because libgo relies on GNU make. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu.

Re: [4.7 PATCH] Use automake no-dist everywhere

2012-09-20 Thread Ian Lance Taylor
On Thu, Sep 20, 2012 at 6:33 AM, Jakub Jelinek wrote: > > This is the 4.7 version. Not 100% sure about libgo, Ian, are you regularly > syncing upstream libgo even into 4.7 branch, or only to trunk? I.e. are you > find with this kind of change for libgo, or do you want to do such a change > upstr

Re: [PATCH, ARM] 64-bit shifts in NEON

2012-09-20 Thread Richard Earnshaw
On 20/09/12 16:49, Ulrich Weigand wrote: > Richard Earnshaw wrote: > >> Hmm, this is going to cause bottlenecks on Cortex-A15: writing a Neon >> single-precision register and then reading it back as a double-precision >> value will cause scheduling problems. > > Ok, that is a problem ... > >> Th

Re: [4.6 PATCH] Use automake no-dist everywhere

2012-09-20 Thread Ian Lance Taylor
On Thu, Sep 20, 2012 at 6:34 AM, Jakub Jelinek wrote: > > Similarly for 4.6 branch. Similar question for libgo, though I hope > no syncing is being performed to such old release branch anymore. Correct: I am not syncing to the 4.6 branch. Go ahead and change it as needed. Ian

Re: [PATCH, ARM] 64-bit shifts in NEON

2012-09-20 Thread Ulrich Weigand
Richard Earnshaw wrote: > Hmm, this is going to cause bottlenecks on Cortex-A15: writing a Neon > single-precision register and then reading it back as a double-precision > value will cause scheduling problems. Ok, that is a problem ... > The awkward thing here is that the shift only uses the bo

Re: [patch] Fix PR rtl-optimization/54290

2012-09-20 Thread Richard Earnshaw
On 19/09/12 14:30, Ulrich Weigand wrote: > Eric Botcazou wrote: > >> 2012-09-18 Eric Botcazou >> >> PR rtl-optimization/54290 >> * reload1.c (choose_reload_regs): Also take into account secondary MEMs >> to remove address replacements for inherited reloads. >> (replaced_subr

GCC 4.7.3 Status Report (2012-09-20)

2012-09-20 Thread Jakub Jelinek
Status == The GCC 4.7.2 release tarballs have been created and were uploaded to ftp.gnu.org. The GCC 4.7 branch is thus open again for regression and documentation fixes. Quality Data Priority # Change from Last Report --- --- P

Re: [Patch] PR54635: Add addr_space_t argument to mode_dependent_address_p

2012-09-20 Thread Georg-Johann Lay
Hans-Peter Nilsson wrote: > Georg-Johann Lay wrote: >> mode_dependent_address_p is not sensitive to the address space of the passed >> address. Thus, add an addr_space_t parameter to the hook. > > Borderline obvious. :) (J/k; the added functionality seems > obvious but the implementation may hav

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Dehao Chen
Hi, Paolo, I'll look into the ICE problems now. Thanks, Dehao On Thu, Sep 20, 2012 at 9:04 PM, Paolo Carlini wrote: > Hi, > > > On 09/19/2012 09:59 PM, Dehao Chen wrote: >> >> This patch was commited as r191494. > > I'm afraid I can't help *much* with the debugging, but on my x86_64-linux > mac

Re: [PATCH] Use automake no-dist for libatomic and libitm

2012-09-20 Thread Richard Guenther
On Thu, Sep 20, 2012 at 3:30 PM, Jakub Jelinek wrote: > Hi! > > GCC 4.7.2 upload to ftp.gnu.org has been rejected again similarly to 4.4.4 > upload 2.5 years ago, again on security issues with automake dist/distcheck > stuff that gcc never uses. From what I remember or can read in the > archives,

[PATCH] Fix PR54634

2012-09-20 Thread Richard Guenther
This fixes PR54634, data-ref analysis does not properly model "reads of global memory" done by pure functions. So just give up. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-09-20 Richard Guenther PR tree-optimization/54634 * tree-data-ref.c (g

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Jan Hubicka
> On Thu, Sep 20, 2012 at 03:26:29PM +0200, Paolo Carlini wrote: > > On 09/20/2012 03:04 PM, Paolo Carlini wrote: > > >are all ICEs like the below. Apparently PCHs are required, I can't > > >reproduce outside the testsuite, without the library PCHs. > > Take this only as a vague hint: I'm seeing ma

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Paolo Carlini
On 09/20/2012 04:05 PM, Martin Jambor wrote: On Thu, Sep 20, 2012 at 03:26:29PM +0200, Paolo Carlini wrote: On 09/20/2012 03:04 PM, Paolo Carlini wrote: are all ICEs like the below. Apparently PCHs are required, I can't reproduce outside the testsuite, without the library PCHs. Take this only

[PATCH] Use automake no-dist for libatomic and libitm

2012-09-20 Thread Jakub Jelinek
Hi! GCC 4.7.2 upload to ftp.gnu.org has been rejected again similarly to 4.4.4 upload 2.5 years ago, again on security issues with automake dist/distcheck stuff that gcc never uses. From what I remember or can read in the archives, we've resolved it at that point by making gcc owned libdirs use a

Re: Make cfun_push and cfun_pop also change current_function_decl

2012-09-20 Thread Richard Guenther
On Wed, Sep 19, 2012 at 3:15 PM, Martin Jambor wrote: > Hi, > > this is my second attempt to make push_cfun and pop_cfun save and > restore current_function_decl, so that code that wants to change the > function context does not have to do the latter manually. > > This of course enforces that cfun

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Martin Jambor
On Thu, Sep 20, 2012 at 03:26:29PM +0200, Paolo Carlini wrote: > On 09/20/2012 03:04 PM, Paolo Carlini wrote: > >are all ICEs like the below. Apparently PCHs are required, I can't > >reproduce outside the testsuite, without the library PCHs. > Take this only as a vague hint: I'm seeing many pch-rel

[PATCH] PR c++/54372 - unused attribute inactive on dependant entities

2012-09-20 Thread Dodji Seketeli
Hello, In the example of this patch, gcc/g++ invoked with -Wunused-local-typedefs warns on dependant entities even when those are decorated with the 'unused' attribute. This is because in cplus_decl_attributes, save_template_attributes makes so that the 'unused' attribute is applied to its appert

Re: [Patch] PR54635: Add addr_space_t argument to mode_dependent_address_p

2012-09-20 Thread Hans-Peter Nilsson
On Thu, 20 Sep 2012, Georg-Johann Lay wrote: > mode_dependent_address_p is not sensitive to the address space of the passed > address. Thus, add an addr_space_t parameter to the hook. Borderline obvious. :) (J/k; the added functionality seems obvious but the implementation may have non-obvious i

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Paolo Carlini
On 09/20/2012 03:04 PM, Paolo Carlini wrote: are all ICEs like the below. Apparently PCHs are required, I can't reproduce outside the testsuite, without the library PCHs. Take this only as a vague hint: I'm seeing many pch-related regressions here, between r191490 and r191501: http://gcc.g

Re: [patch] split FRAME variables back into pieces

2012-09-20 Thread Richard Guenther
On Thu, Sep 20, 2012 at 12:56 PM, Eric Botcazou wrote: >> I really don't like this to be done outside of SRA (and it is written in a >> non-MEM_REF way). > > Could you elaborate on the latter point? If it can be improved, even in its > current form... You rely on being able to see all FRAME acce

[AARCH64] [AARCH64-4.7] Use define_c_enum

2012-09-20 Thread Marcus Shawcroft
I've just committed the attached to aarch64-branch and aarch64-4.7-branch. /MarcusFrom b0ca189452f5d12f013f7163570ccf4c97c374b0 Mon Sep 17 00:00:00 2001 From: Marcus Shawcroft Date: Thu, 20 Sep 2012 14:04:54 +0100 Subject: [PATCH 01/11] Use define_c_enum --- gcc/ChangeLog.aarch64 |

Re: Use conditional casting with symtab_node

2012-09-20 Thread Michael Matz
Hi, On Wed, 19 Sep 2012, Lawrence Crowl wrote: > On 9/19/12, Eric Botcazou wrote: > > > The language syntax would bind the conditional into the > > > intializer, as in > > > > > > if (varpool_node *vnode = (node->try_variable () > > > && vnode->finalized)) > > >

Re: Use conditional casting with symtab_node

2012-09-20 Thread Michael Matz
Hi, On Wed, 19 Sep 2012, Richard Guenther wrote: > > Just write: > > > > varpool_node *vnode; > > > > if ((vnode = node->try_variable ()) && vnode->finalized) > > varpool_analyze_node (vnode); > > > > This has been the standard style for the past 2 decades and trading it for > > cascading

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Paolo Carlini
Hi, On 09/19/2012 09:59 PM, Dehao Chen wrote: This patch was commited as r191494. I'm afraid I can't help *much* with the debugging, but on my x86_64-linux machine and a very straightforward configuration (--enable-languages=c++ --disable-multilib) after r191494 I'm seeing the following libst

[Patch] PR54635: Add addr_space_t argument to mode_dependent_address_p

2012-09-20 Thread Georg-Johann Lay
mode_dependent_address_p is not sensitive to the address space of the passed address. Thus, add an addr_space_t parameter to the hook. Bootstapped without problems on x86-linux-gnu. The patch is a no-op, it just adds the passing-around of the address space information. Ok to commit? One more q

Re: [PATCH] Merge identical cases

2012-09-20 Thread Richard Guenther
On Thu, Sep 20, 2012 at 11:54 AM, Marek Polacek wrote: > In tree-ssa-operands.c in get_expr_operands we have two identical > cases, for SSA_NAME and {VAR,PARM,RESULT}_DECL. If that isn't > intentional (maybe it's clearer to split _*NAME and *_DECL--the > compiler will merge them anyway), we can m

Re: [PATCH] Don't cast XNEWVEC's result

2012-09-20 Thread Richard Guenther
On Thu, Sep 20, 2012 at 10:53 AM, Marek Polacek wrote: > While reading tree-ssa-threadupdate.c I noticed that we're casting > XNEWVEC's result. This isn't done anywhere else and the macro > does the cast internally anyway, thus there's no need to repeat that. > Also there was a typo in copyright

Re: [C++ Patch / RFC] PR 52432

2012-09-20 Thread Paolo Carlini
On 09/20/2012 12:58 PM, Paolo Carlini wrote: On 09/20/2012 06:08 AM, Jason Merrill wrote: OK. Thanks Jason. Unfortunately I can't apply the patch because apparently it triggers rather mysterious failures in the library testsuite, ICEs as Seg faults in 17_intro/headers/c++1998. Ah, ah, with t

Re: [patch] split FRAME variables back into pieces

2012-09-20 Thread Eric Botcazou
> I really don't like this to be done outside of SRA (and it is written in a > non-MEM_REF way). Could you elaborate on the latter point? If it can be improved, even in its current form... > For the testcase in question we scalarize back > 'i' in SRA (other scalars are optimized away already, b

Re: [C++ Patch / RFC] PR 52432

2012-09-20 Thread Paolo Carlini
On 09/20/2012 06:08 AM, Jason Merrill wrote: OK. Thanks Jason. Unfortunately I can't apply the patch because apparently it triggers rather mysterious failures in the library testsuite, ICEs as Seg faults in 17_intro/headers/c++1998. I have troubles debugging it because I can't reproduce out

Re: [PATCH, ARM] 64-bit shifts in NEON

2012-09-20 Thread Richard Earnshaw
On 18/09/12 18:06, Ulrich Weigand wrote: > Hello, > > a while ago Andrew Stubbs posted a patch to use NEON registers > and instructions to perform 64-bit integer shifts: > http://gcc.gnu.org/ml/gcc-patches/2012-05/msg01645.html > > As Andrew no longer works on ARM, I've now picked this up and > r

Re: [PATCH] Combine location with block using block_locations

2012-09-20 Thread Dominique Dhumieres
A lot of failures in the test suite have appeared between revisions 191485 and 191494 see http://gcc.gnu.org/ml/gcc-regression/2012-09/msg00327.html ). I have looked at the failure of libgomp.fortran/reduction1.f90: [macbook] f90/bug% gfc -O3 -g -fopenmp /opt/gcc/work/libgomp/testsuite/libgomp.f

[PATCH] Merge identical cases

2012-09-20 Thread Marek Polacek
In tree-ssa-operands.c in get_expr_operands we have two identical cases, for SSA_NAME and {VAR,PARM,RESULT}_DECL. If that isn't intentional (maybe it's clearer to split _*NAME and *_DECL--the compiler will merge them anyway), we can merge those two cases. Regtested/bootstrapped on x86_64. 2012-0

Re: [PATCH] Docs: lto.texi: Fix typo

2012-09-20 Thread Wei-Ren Chen
On Thu, Sep 20, 2012 at 09:49:27AM +0100, rearn...@arm.com wrote: > On 20 Sep 2012, at 09:27, "陳韋任 (Wei-Ren Chen)" > wrote: > > > Fix typo. The first "are" in the statement should be "and". > > > > Ok. > > R. Thanks. Would you like to commit this for me? :) Regards, chenwj -- Wei-Ren C

[PATCH] Don't cast XNEWVEC's result

2012-09-20 Thread Marek Polacek
While reading tree-ssa-threadupdate.c I noticed that we're casting XNEWVEC's result. This isn't done anywhere else and the macro does the cast internally anyway, thus there's no need to repeat that. Also there was a typo in copyright years, so I fixed that as well while at it. Regtested/bootstrap

Re: [PATCH] Docs: lto.texi: Fix typo

2012-09-20 Thread rearnsha
On 20 Sep 2012, at 09:27, "陳韋任 (Wei-Ren Chen)" wrote: > Fix typo. The first "are" in the statement should be "and". > Ok. R. > Signed-off-by: Chen Wei-Ren > --- > gcc/doc/lto.texi |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gcc/doc/lto.texi b/gcc/doc/lto.

[PATCH] PR c++/53609 - Wrong argument deduction for pack expansion in argument pack

2012-09-20 Thread Dodji Seketeli
Hello, Consider this example: 1 template struct List {}; 2 template struct Z {static const int value = T;}; 3 template using LZ = List...>; 4 5 template 6 struct F 7 { 8using N = LZ; //#1 This should amount to List...> 9 } 10 11 F,

[PATCH] Docs: lto.texi: Fix typo

2012-09-20 Thread Wei-Ren Chen
Fix typo. The first "are" in the statement should be "and". Signed-off-by: Chen Wei-Ren --- gcc/doc/lto.texi |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gcc/doc/lto.texi b/gcc/doc/lto.texi index 73fd831..68f8759 100644 --- a/gcc/doc/lto.texi +++ b/gcc/doc/lto.texi

Re: [Patch] catch builtin_bswap16 construct

2012-09-20 Thread Christophe Lyon
On 20 September 2012 09:12, Eric Botcazou wrote: >> The attached patch catches C constructs: >> (A << 8) | (A >> 8) >> where A is unsigned 16 bits >> and maps them to builtin_bswap16(A) which can provide more efficient >> implementations on some targets. > > This belongs in tree-ssa-math-opts.c:ex

[PATCH] Fix PR C++/50970 -- Function pointer dereferenced twice in if statement on Arm cpu

2012-09-20 Thread Zhenqiang Chen
Hi, PR 50970 is a general c++ front-end issue for targets which define TARGET_PTRMEMFUNC_VBIT_LOCATION ptrmemfunc_vbit_in_delta, although the reporter had issues only on ARM. Root cause: It misses a check for side effects when generating pfn and delta related expressions. In the failed case, op0

Re: [Patch] catch builtin_bswap16 construct

2012-09-20 Thread Eric Botcazou
> The attached patch catches C constructs: > (A << 8) | (A >> 8) > where A is unsigned 16 bits > and maps them to builtin_bswap16(A) which can provide more efficient > implementations on some targets. This belongs in tree-ssa-math-opts.c:execute_optimize_bswap instead. When I implemented __builti

Re: Top Level GCC change questions

2012-09-20 Thread Georg-Johann Lay
Steve Ellcey schrieb: DJ Delorie wrote: Is there any automation for this or is it still up to each person checking in files to copy stuff over by hand? There is no automation, as neither project was willing to cede control to the other. In general, any patch applied to one repo should be (and