Re: [PATCH] Fix sanitizer build on sparc64.

2012-11-21 Thread Andreas Schwab
Konstantin Serebryany konstantin.s.serebry...@gmail.com writes: On Wed, Nov 21, 2012 at 2:50 AM, Andreas Schwab sch...@linux-m68k.org wrote: David Miller da...@davemloft.net writes: +// Are we using 32-bit or 64-bit syscalls? +// x32 (which defines __x86_64__) has __WORDSIZE == 32 +// but

Re: Sparc ASAN

2012-11-21 Thread Jakub Jelinek
On Tue, Nov 20, 2012 at 11:19:33PM -0500, David Miller wrote: From: David Miller da...@davemloft.net Date: Tue, 20 Nov 2012 21:20:40 -0500 (EST) Those seem to be the only problems that need to be resolved for this feature to be fully working. FWIW, here are the changes I am using which,

Re: [PATCH, RFC] Enable libsanitizer on powerpc{,64}

2012-11-21 Thread Evgeniy Stepanov
The ARM/Android failure is due to libstdc++ in android-ndk-r8b not containing debug info. As a result, stack unwinding breaks in operator new, after exactly 2 frames. I guess we can simply tweak the assert to be OK with empty stack traces when user code stack can not be unwinded. Matching FP or

Re: [RFC] Parallel build broken on trunk.

2012-11-21 Thread Laurynas Biveinis
Folks, Parallel builds contain a race due to a missing dependency between gengtype-lex.o and $(BCONFIG_H). This was introduced by the commit: http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00926.html .. which injects an include of bconfig.h into the top of gengtype-lex.c but does not make

Re: [www-docs] Add note to gcc-4.8/changes.html that DWARF4 is now the default.

2012-11-21 Thread Jakub Jelinek
On Wed, Nov 21, 2012 at 11:13:47AM +0100, Mark Wielaard wrote: + VxWorks is still -g-dwarf2 -gstrict-dwarf. s/-g-dwarf2/-gdwarf-2/ Jakub

Re: [www-docs] Add note to gcc-4.8/changes.html that DWARF4 is now the default.

2012-11-21 Thread Mark Wielaard
On Wed, 2012-11-21 at 11:16 +0100, Jakub Jelinek wrote: On Wed, Nov 21, 2012 at 11:13:47AM +0100, Mark Wielaard wrote: + VxWorks is still -g-dwarf2 -gstrict-dwarf. s/-g-dwarf2/-gdwarf-2/ Oops. Fixed. Thanks, Mark

[PATCH] Recognize clones for all contexts in SCCs in IPA-CP

2012-11-21 Thread Martin Jambor
Hi, in IPA-CP, a few functions look at callees of cgraph edges to see if they still lead to the original node (those still need to be examined or re-examined) or to a clone (those are considered already decided and should be left alone). The problem is that currently, when looking at an SCC,

[aarch64-4.7][committed] Fix Bad backport of Refactor thunks code generation.

2012-11-21 Thread James Greenhalgh
Hi, Yesterday I committed a backport of this patch http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01398.html which prevented aarch64-4.7 building due to a difference in how many arguments plus_constant takes between trunk and 4.7. Today I have fixed that by committing, as revision 193689, the

Re: [aarch64-4.7][committed] Fix Bad backport of Refactor thunks code generation.

2012-11-21 Thread Richard Earnshaw
On 21/11/12 10:55, James Greenhalgh wrote: Hi, Yesterday I committed a backport of this patch http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01398.html which prevented aarch64-4.7 building due to a difference in how many arguments plus_constant takes between trunk and 4.7. Today I have fixed

RE: [PATCH][ARM][1/2] ARMv8 aarch32 round to integral instructions

2012-11-21 Thread Kyrylo Tkachov
Ping? Thanks, Kyrill -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of Kyrylo Tkachov Sent: 14 November 2012 13:52 To: gcc-patches@gcc.gnu.org Cc: Richard Earnshaw; Ramana Radhakrishnan Subject: [PATCH][ARM][1/2] ARMv8 aarch32

RE: [PATCH][ARM][2/2] ARMv8 aarch32 round to integral instructions

2012-11-21 Thread Kyrylo Tkachov
Ping? Thanks, Kyrill -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of Kyrylo Tkachov Sent: 14 November 2012 13:52 To: gcc-patches@gcc.gnu.org Cc: mikest...@comcast.net; Ramana Radhakrishnan; Richard Earnshaw Subject:

Re: [RFA/4.7/ARM] Backport arm-*-linux-gnueabihf triplet support to 4.7

2012-11-21 Thread Matthew Gretton-Dann
On 21 November 2012 00:05, Matthias Klose d...@ubuntu.com wrote: Am 20.11.2012 21:34, schrieb Matthew Gretton-Dann: All, This patch backports Matthais Klose's arm*-*-linux-gnueabihf triplet support patch of 2012-10-15 to 4.7. The backport was not clean as 4.8 has obsoleted various arm*-*-*

Re: [PATCH] Fix sanitizer build on sparc64.

2012-11-21 Thread Jakub Jelinek
On Wed, Nov 21, 2012 at 04:10:24PM +0400, Konstantin Serebryany wrote: it is also redefined properly for the compilers which don't have it and may not have __LP64__ ??? __WORDSIZE is only defined by glibc. __LP64__ (or _LP64) is a standard macro defined by the compiler. libsanitizer

Re: [aarch64-4.7][committed] Fix Bad backport of Refactor thunks code generation.

2012-11-21 Thread Marcus Shawcroft
Today I have fixed that by committing, as revision 193689, the patch below as obvious. On the ARM/aarch64-4.7-branch the ChangeLog entry should be in ChangeLog.aarch64 rather than ChangeLog. Please move the entry. Cheers /Marcus

Re: [PATCH] Fix sanitizer build on sparc64.

2012-11-21 Thread Konstantin Serebryany
libsanitizer is a third party library, its primary repository is not gcc. If we make such change (use __LP64__ instead of __WORDSIZE), we should make it upstream first. That is true, but it really should change, __WORDSIZE is a glibc private macro that other programs just shouldn't use.

Re: [patch] [aarch64] add multiarch definitions for aarch64-linux-gnu

2012-11-21 Thread Marcus Shawcroft
--- config/aarch64/t-aarch64-linux (revision 193639) +++ config/aarch64/t-aarch64-linux (working copy) @@ -20,3 +20,6 @@ LIB1ASMSRC = aarch64/lib1funcs.asm LIB1ASMFUNCS = _aarch64_sync_cache_range + +AARCH_BE = $(if $(findstring TARGET_BIG_ENDIAN_DEFAULT=1,

Re: [PATCH] Use working set profile info to determine hotness (issue6852069)

2012-11-21 Thread Jan Hubicka
This patch uses the new working set information from the profile to select the hot count threshold for an application instead of using a hard cutoff. Currently the threshold is set by default to the minimum counter value needed to reach 99.9% of the profiled execution time, but I have added a

Re: [PATCH] Recognize clones for all contexts in SCCs in IPA-CP

2012-11-21 Thread Jan Hubicka
Hi, in IPA-CP, a few functions look at callees of cgraph edges to see if they still lead to the original node (those still need to be examined or re-examined) or to a clone (those are considered already decided and should be left alone). The problem is that currently, when looking at an

Re: [PATCH] Fix sanitizer build on sparc64.

2012-11-21 Thread Andreas Schwab
Konstantin Serebryany konstantin.s.serebry...@gmail.com writes: libsanitizer is a third party library, its primary repository is not gcc. _LP64 is also defined by other compilers. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4

Re: [PATCH, PR 55260] Fix cgraph_edge_brings_all_agg_vals_for_node

2012-11-21 Thread Jan Hubicka
2012-11-19 Martin Jambor mjam...@suse.cz PR tree-optimization/55260 * ipa-cp.c (intersect_aggregates_with_edge): New function. (find_aggregate_values_for_callers_subset): Part moved to the function above. Call it.

Re: rfc NOP vs CONVERT (was: Simplifying Gimple Generation)

2012-11-21 Thread Michael Matz
Hi, On Tue, 20 Nov 2012, Martin Jambor wrote: +++ gcc/ipa-cp.c2009-09-29 15:29:05.0 +0200 @@ -298,7 +298,7 @@ ipcp_lattice_from_jfunc (struct ipa_node return; cst = caller_lat-constant; - if (jfunc-value.pass_through.operation != NOP_EXPR) + if (!

Re: [RFC] Parallel build broken on trunk.

2012-11-21 Thread Marcus Shawcroft
On 21/11/12 09:48, Laurynas Biveinis wrote: Probably not, but I see your patch not as papering over but rather a missing piece of what's been committed in 2010. Fixing parallel builds does not preclude a better fix for build/host separation later. diff --git a/gcc/Makefile.in

[PATCH, i386]: Simplify some SWI48x iterator uses

2012-11-21 Thread Uros Bizjak
Hello! SWI48x iterator with (SWI48x:MODEmode != DImode || TARGET_64BIT) insn constraint can be exactly represented with SWI48 mode iterator. No functional change otherwise. 2012-11-21 Uros Bizjak ubiz...@gmail.com * config/i386/i386.md

Re: Sparc ASAN

2012-11-21 Thread Konstantin Serebryany
On Wed, Nov 21, 2012 at 1:05 PM, Jakub Jelinek ja...@redhat.com wrote: On Tue, Nov 20, 2012 at 11:19:33PM -0500, David Miller wrote: From: David Miller da...@davemloft.net Date: Tue, 20 Nov 2012 21:20:40 -0500 (EST) Those seem to be the only problems that need to be resolved for this

[AARCH64-4.7, PATCH, committed] Fix race in parallel build.

2012-11-21 Thread Marcus Shawcroft
I've just committed the attached back port of: http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01775.html to the ARM/aarch64-4.7-branch. /Marcus 2012-11-21 Marcus Shawcroft marcus.shawcr...@arm.com * Makefile.in (gengtype-lex.o): Add dependency on $(BCONFIG_H). Index: gcc/Makefile.in

Re: Sparc ASAN (was Re: sparc bootstrap still broken)

2012-11-21 Thread Konstantin Serebryany
On Wed, Nov 21, 2012 at 6:20 AM, David Miller da...@davemloft.net wrote: From: David Miller da...@davemloft.net Date: Tue, 20 Nov 2012 14:59:10 -0500 (EST) From: Konstantin Serebryany konstantin.s.serebry...@gmail.com Date: Tue, 20 Nov 2012 23:52:48 +0400 Please apply whatever minimal patch

Re: Reduce complette unrolling peeling limits

2012-11-21 Thread Dominique Dhumieres
Hi Jan, this is patch I will try to test once I have chance :) It simply prevents unroller from analyzing loops when they are already too large. ... This patch breaks bootstrap with ... /opt/gcc/p_build/./prev-gcc/g++ -B/opt/gcc/p_build/./prev-gcc/

[libquadmath, patch, committed] PR55225: Add a configure check whether math.h has signgam

2012-11-21 Thread Tobias Burnus
POSIX's lgamma uses signgam – and hence has extern int signgam in math.h. However, C99's lgamma doesn't mention signgam – and systems exist where math.h doesn't include it. Solution: A configure check. Comitted as Rev. 193695. Tobias 2012-11-21 Tobias Burnus bur...@net-b.de PR

[aarch64-4.7][committed] Move misplaced ChangeLog entries to ChangeLog.aarch64

2012-11-21 Thread James Greenhalgh
On the ARM/aarch64-4.7-branch the ChangeLog entry should be in ChangeLog.aarch64 rather than ChangeLog. Please move the entry. Hi Marcus, Sorry about that. I've committed this fix moving all the ChangeLog entries I added in the past two days to their correct place as revision 193696.

Re: Reduce complette unrolling peeling limits

2012-11-21 Thread Jan Hubicka
FAIL: gcc.dg/graphite/interchange-8.c scan-tree-dump-times graphite will be interchanged 2 FAIL: gcc.dg/graphite/pr42530.c (internal compiler error) FAIL: gcc.dg/graphite/pr42530.c (test for excess errors) FAIL: gcc.dg/tree-ssa/cunroll-1.c scan-tree-dump cunrolli Unrolled loop 1 completely

[PATCH][AARCH64] Fix the name mangling of va_list

2012-11-21 Thread Yufeng Zhang
Hi, This patch updates the AArch64 port to mangle __va_list as it is in namespace std in C++. This is specified in the AArch64 AAPCS64 ABI doc. OK for the trunk? Thanks, Yufeng gcc/ChangeLog 2012-11-21 Yufeng Zhang yufeng.zh...@arm.com * config/aarch64/aarch64.c

libsanitizer/README.gcc update

2012-11-21 Thread Kostya Serebryany
Hi, This patch updates libsanitizer/README.gcc. Ok? (This is the first time I am trying to commit to gcc trunk) Index: ChangeLog === --- ChangeLog (revision 193693) +++ ChangeLog (working copy) @@ -1,3 +1,6 @@ +2012-11-21

[patch,avr] Ad PR54222: Move decimal point of signed accum one bit right.

2012-11-21 Thread Georg-Johann Lay
This patch restores the GCC default layout of HA, SA and DA mode. The original fixed point support tried to be binary compatible with fixed-point support already provided by some non-FSF ports, but that turned out to result in wrong code in some situations. Reason is that these ports adjusted

Re: libsanitizer/README.gcc update

2012-11-21 Thread Jakub Jelinek
On Wed, Nov 21, 2012 at 06:36:32PM +0400, Kostya Serebryany wrote: This patch updates libsanitizer/README.gcc. Ok? (This is the first time I am trying to commit to gcc trunk) Index: ChangeLog === --- ChangeLog (revision

[Patch AArch64] Add support for TARGET_BUILTIN_DECL

2012-11-21 Thread James Greenhalgh
Hi, This patch wires up support for TARGET_BUILTIN_DECL in the AArch64 backend. Is this OK to commit? Thanks, James Greenhalgh --- gcc/ 2012-11-21 James Greenhalgh james.greenha...@arm.com * config/aarch64/aarch64-builtins.c (aarch64_builtin_decls): New.

[committed] Fix profile.c asan failure (PR gcov-profile/55417)

2012-11-21 Thread Jakub Jelinek
Hi! I've committed as obvious a patch from Teresa from the PR. --- gcc/ChangeLog (revision 193696) +++ gcc/ChangeLog (working copy) @@ -1,3 +1,9 @@ +2012-11-21 Teresa Johnson tejohn...@google.com + + PR gcov-profile/55417 + * profile.c (compute_working_sets): Check

Re: libsanitizer/README.gcc update

2012-11-21 Thread Kostya Serebryany
Done, thanks! --kcc On Wed, Nov 21, 2012 at 6:44 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 21, 2012 at 06:36:32PM +0400, Kostya Serebryany wrote: This patch updates libsanitizer/README.gcc. Ok? (This is the first time I am trying to commit to gcc trunk) Index: ChangeLog

Re: [patch] [s390] add multiarch definitions for s390-linux-gnu

2012-11-21 Thread Ulrich Weigand
Matthias Klose wrote: 2012-11-14 Matthias Klose d...@ubuntu.com * config/s390/t-linux64: Add multiarch names in MULTILIB_OSDIRNAMES. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE ulrich.weig...@de.ibm.com

Re: Sparc ASAN

2012-11-21 Thread David Miller
From: Konstantin Serebryany konstantin.s.serebry...@gmail.com Date: Wed, 21 Nov 2012 17:39:05 +0400 Today, kPageSize is used in several places where it is expected to be a compile-time constant. Even if it seems like replacing it with GetPageSize() is safe, it would need very significant

Re: Sparc ASAN

2012-11-21 Thread Konstantin Serebryany
On Wed, Nov 21, 2012 at 7:29 PM, David Miller da...@davemloft.net wrote: From: Konstantin Serebryany konstantin.s.serebry...@gmail.com Date: Wed, 21 Nov 2012 17:39:05 +0400 Today, kPageSize is used in several places where it is expected to be a compile-time constant. Even if it seems like

Re: Sparc ASAN

2012-11-21 Thread Peter Bergner
On Wed, 2012-11-21 at 19:39 +0400, Konstantin Serebryany wrote: On Wed, Nov 21, 2012 at 7:29 PM, David Miller da...@davemloft.net wrote: From: Konstantin Serebryany konstantin.s.serebry...@gmail.com Date: Wed, 21 Nov 2012 17:39:05 +0400 Today, kPageSize is used in several places where it

Re: [PATCH, RFC] Enable libsanitizer on powerpc{,64}

2012-11-21 Thread Peter Bergner
On Wed, 2012-11-21 at 13:46 +0400, Evgeniy Stepanov wrote: Matching FP or SP also sounds good, and perhaps more reliable than just popping 2 frames from the top of the stack. Agreed. Can you try my second patch that searches for the frame address we want our backtrace to start with and see if

Re: Sparc ASAN

2012-11-21 Thread Konstantin Serebryany
On Wed, Nov 21, 2012 at 8:05 PM, Peter Bergner berg...@vnet.ibm.com wrote: On Wed, 2012-11-21 at 19:39 +0400, Konstantin Serebryany wrote: On Wed, Nov 21, 2012 at 7:29 PM, David Miller da...@davemloft.net wrote: From: Konstantin Serebryany konstantin.s.serebry...@gmail.com Date: Wed, 21 Nov

Re: [PATCH, RFC] Enable libsanitizer on powerpc{,64}

2012-11-21 Thread Konstantin Serebryany
On Wed, Nov 21, 2012 at 8:16 PM, Peter Bergner berg...@vnet.ibm.com wrote: On Wed, 2012-11-21 at 13:46 +0400, Evgeniy Stepanov wrote: Matching FP or SP also sounds good, and perhaps more reliable than just popping 2 frames from the top of the stack. Agreed. Can you try my second patch that

Re: Reduce complette unrolling peeling limits

2012-11-21 Thread Jan Hubicka
Hi, here is updated patch. It should get the bounds safe enough to not have effect on codegen of complette unrolling. There is IMO no way to cut the walk of loop body w/o affecting codegen in unrolling for size mode. The condition on unroling to happen is unrolled_size * 2 / 3 original_size

Re: Reduce complette unrolling peeling limits

2012-11-21 Thread Jan Hubicka
Did you notice that gcc.c-torture/compile/pr43186.c regressed? It now again takes a while to compile, so times out on slow machines: ... On a 2.5Ghz Core2Duo, compiling the test with revision 192891 (2012-10-28) takes a small fraction of a second, while with revision 193270 (2012-11-06)

Re: Sparc ASAN

2012-11-21 Thread Andrew Pinski
On Wed, Nov 21, 2012 at 8:21 AM, Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: On Wed, Nov 21, 2012 at 8:05 PM, Peter Bergner berg...@vnet.ibm.com wrote: On Wed, 2012-11-21 at 19:39 +0400, Konstantin Serebryany wrote: On Wed, Nov 21, 2012 at 7:29 PM, David Miller

Re: Sparc ASAN

2012-11-21 Thread Andreas Schwab
Andrew Pinski pins...@gmail.com writes: Just to follow up, MIPS64 have the following (selectable at kernel compile time) page sizes: 4k, 8k, 16k, 32k and 64k. So is another target where the page size is not constant just like PPC. As does ia64 (common page sizes are 16k and 64k). Andreas.

Re: Sparc ASAN

2012-11-21 Thread David Miller
From: Konstantin Serebryany konstantin.s.serebry...@gmail.com Date: Wed, 21 Nov 2012 19:39:52 +0400 There are various other things that asan library does not support. I'm trying to understand why making the page size variable is such a difficult endeavour.

Re: [PATCH, RFC] PR 55415 : Pessimistic misalignment from eipa_sra pass

2012-11-21 Thread Martin Jambor
Hi, On Tue, Nov 20, 2012 at 09:24:20AM -0800, Richard Henderson wrote: The get_pointer_alignment function can indicate that it does not know what the alignment should be, and it always fills in worst-case values for that case. We should not use these worst-case values to optimize the

Re: Sparc ASAN

2012-11-21 Thread Konstantin Serebryany
On Wed, Nov 21, 2012 at 8:40 PM, David Miller da...@davemloft.net wrote: From: Konstantin Serebryany konstantin.s.serebry...@gmail.com Date: Wed, 21 Nov 2012 19:39:52 +0400 There are various other things that asan library does not support. I'm trying to understand why making the page size

Re: Sparc ASAN

2012-11-21 Thread Ramana Radhakrishnan
On 11/21/12 16:27, Andrew Pinski wrote: On Wed, Nov 21, 2012 at 8:21 AM, Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: On Wed, Nov 21, 2012 at 8:05 PM, Peter Bergner berg...@vnet.ibm.com wrote: On Wed, 2012-11-21 at 19:39 +0400, Konstantin Serebryany wrote: On Wed, Nov 21,

Re: [PATCH, RFC] Enable libsanitizer on powerpc{,64}

2012-11-21 Thread Peter Bergner
On Wed, 2012-11-21 at 20:22 +0400, Konstantin Serebryany wrote: On Wed, Nov 21, 2012 at 8:16 PM, Peter Bergner berg...@vnet.ibm.com wrote: On Wed, 2012-11-21 at 13:46 +0400, Evgeniy Stepanov wrote: Matching FP or SP also sounds good, and perhaps more reliable than just popping 2 frames from

Re: Sparc ASAN

2012-11-21 Thread Konstantin Serebryany
On Wed, Nov 21, 2012 at 9:13 PM, Ramana Radhakrishnan ramra...@arm.com wrote: On 11/21/12 16:27, Andrew Pinski wrote: On Wed, Nov 21, 2012 at 8:21 AM, Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: On Wed, Nov 21, 2012 at 8:05 PM, Peter Bergner berg...@vnet.ibm.com wrote:

Re: Sparc ASAN

2012-11-21 Thread Peter Bergner
On Tue, 2012-11-20 at 23:19 -0500, David Miller wrote: The address violation detection seems to work properly and the only thing that seems to be left are some backtrace/unwind issues. These are perhaps similar to the unwind bits that the powerpc folks ran into. David, does the following

Re: [Patch, Fortran] PR 55352: [4.7/4.8 Regression] Erroneous gfortran warning of unused module variable when variable is only used in namelist

2012-11-21 Thread Paul Richard Thomas
Dear Janus, Thanks for the patch - it's OK for trunk and 4.7. Cheers Paul On 19 November 2012 21:39, Janus Weil ja...@gcc.gnu.org wrote: Hi all, here is another contribution in trying to reduce the still too large number of regressions in the Fortran front end (which used to be basically

Re: [patch] [m68k] add multiarch definitions for m68k-linux-gnu

2012-11-21 Thread Andreas Schwab
Matthias Klose d...@ubuntu.com writes: 2012-11-14 Matthias Klose d...@ubuntu.com * config/m68k/t-linux: Define MULTIARCH_DIRNAME for classic m68k. Ok, thanks. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5

Re: [PATCH] Change -faddress-sanitizer to -fsanitize=address

2012-11-21 Thread Wei Mi
Thanks! Done. Committed revision 193702. Regards, Wei. On Tue, Nov 20, 2012 at 11:57 PM, Jakub Jelinek ja...@redhat.com wrote: On Tue, Nov 20, 2012 at 11:14:27PM -0800, Wei Mi wrote: 2012-11-21 Wei Mi w...@google.com * common.opt: Change faddress-sanitizer to fsanitize=address.

Re: Sparc ASAN

2012-11-21 Thread David Miller
From: Peter Bergner berg...@vnet.ibm.com Date: Wed, 21 Nov 2012 11:28:51 -0600 On Tue, 2012-11-20 at 23:19 -0500, David Miller wrote: The address violation detection seems to work properly and the only thing that seems to be left are some backtrace/unwind issues. These are perhaps similar to

[libsanitizer] a script to help merging asan from upstream

2012-11-21 Thread Kostya Serebryany
Hi, A dummy script to help merging asan from upstream. Not 100% complete, but should be enough to complete the current merge. You suggestions on how to improve it (or how to do w/o it) are welcome, but I really wish to do the first merge tomorrow to unblock other folks. Thanks, --kcc

[ARM, PATCH] TARGET_LDRD reject Thumb1 targets

2012-11-21 Thread Greta Yorsh
This patch adjusts the definition of TARGET_LDRD to false on Thumb1 targets, as suggested here: http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02048.html No regression on qemu for arm none-eabi with arch=armv5t/armv7-a mode=thumb/arm. Ok for trunk? Thanks, Greta ChangeLog 2012-11-21 Greta

What CPP macro should -fsanitize=address define?

2012-11-21 Thread H.J. Lu
Hi, I am working on ASAN bootstrap support. I need a CPP macro for -fsanitize=address. I am learning toward __SANITIZE_ADDRESS__. Any comments? Thanks. -- H.J.

[patch, pch] Fix pch failure on mips-mti-linux-gnu

2012-11-21 Thread Steve Ellcey
While working on PR 55399 (pch broken on mips-mti-linux-gnu) I traced through the execution of test gcc.dg/pch/common-1.c and in comparing r192714 and r192715 I found that in the earlier version the compiler gets to pch_open_file (with common-1.h) and does this check: if (pfile-all_files

[PATCH][Revisedx4] Enable libsanitizer on darwin

2012-11-21 Thread Jack Howarth
The attached patch imports the missing mach_override/mach_override.h and mach_override/mach_override.c files from llvm.org's compiler-rt at r168032 | glider | 2012-11-15 03:32:16 -0500 (Thu, 15 Nov 2012) | 3 lines [ASan] Add the lea $imm(%rip),%rax instruction to mach_override.c The need for

Re: What CPP macro should -fsanitize=address define?

2012-11-21 Thread Konstantin Serebryany
On Wed, Nov 21, 2012 at 10:42 PM, H.J. Lu hjl.to...@gmail.com wrote: Hi, I am working on ASAN bootstrap support. I need a CPP macro for -fsanitize=address. I am learning toward __SANITIZE_ADDRESS__. That would be a reasonable option (some background:

Re: [libsanitizer] a script to help merging asan from upstream

2012-11-21 Thread Xinliang David Li
Suggestions: 1) make sure current local dir is libsanitizer -- exit if it is not 2) clean up the upstream directory after the merge is done. David On Wed, Nov 21, 2012 at 10:25 AM, Kostya Serebryany k...@google.com wrote: Hi, A dummy script to help merging asan from upstream. Not 100%

Re: ping - Re: [patch] [ia64] add multiarch definitions for ia64-linux-gnu

2012-11-21 Thread Steve Ellcey
On Wed, 2012-11-21 at 03:44 +0100, Matthias Klose wrote: ping, re-sending to the port maintainers Am 15.11.2012 11:57, schrieb Matthias Klose: Am 15.11.2012 09:51, schrieb Alexander Monakov: The attached patch includes t-glibc instead of t-linux in config.gcc. thanks for the pointer.

Re: [libsanitizer] a script to help merging asan from upstream

2012-11-21 Thread Kostya Serebryany
Done both. +fatal() { + echo $1 + exit 1; +} + +pwd | grep 'libsanitizer$' || \ + fatal Run this script from libsanitizer dir +rm -rf upstream On Wed, Nov 21, 2012 at 10:49 PM, Xinliang David Li davi...@google.com wrote: Suggestions: 1) make sure current local dir is libsanitizer --

Re: [libsanitizer] a script to help merging asan from upstream

2012-11-21 Thread Xinliang David Li
How about also documenting this in README.gcc? David On Wed, Nov 21, 2012 at 10:56 AM, Kostya Serebryany k...@google.com wrote: Done both. +fatal() { + echo $1 + exit 1; +} + +pwd | grep 'libsanitizer$' || \ + fatal Run this script from libsanitizer dir +rm -rf upstream On

Re: Sparc ASAN

2012-11-21 Thread Ramana Radhakrishnan
While trying to add support for ARM (AArch32 GNU / Linux) implementation for GCC after-hours but still keep seeing failures on my chromebook running an ubuntu fs on a ChrOS kernel, because the shadow memory apparently overlaps with normal memory. Has anyone else hit this while porting ? I've

Re: What CPP macro should -fsanitize=address define?

2012-11-21 Thread H.J. Lu
On Wed, Nov 21, 2012 at 10:47 AM, Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: On Wed, Nov 21, 2012 at 10:42 PM, H.J. Lu hjl.to...@gmail.com wrote: Hi, I am working on ASAN bootstrap support. I need a CPP macro for -fsanitize=address. I am learning toward

[RFA/ARM] Fix PR54974: Thumb literal pools don't handle PC rounding

2012-11-21 Thread Matthew Gretton-Dann
All, The attached patch fixes PR54974. In Thumb when calculating the PC value for a literal load the value used is the current PC rounded down to the nearest multiple of 4. The ARM backend currently does not take this into account when calculating literal pool placement. The fix is to

Re: What CPP macro should -fsanitize=address define?

2012-11-21 Thread Jakub Jelinek
On Wed, Nov 21, 2012 at 11:25:35AM -0800, H.J. Lu wrote: 2012-11-21 H.J. Lu hongjiu...@intel.com PR c/55397 * cppbuiltin.c (define_builtin_macros_for_compilation_flags): Define __SANITIZE_ADDRESS__ for flag_asan. Ok, thanks. --- a/gcc/cppbuiltin.c +++

Re: What CPP macro should -fsanitize=address define?

2012-11-21 Thread H.J. Lu
On Wed, Nov 21, 2012 at 12:12 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 21, 2012 at 11:25:35AM -0800, H.J. Lu wrote: 2012-11-21 H.J. Lu hongjiu...@intel.com PR c/55397 * cppbuiltin.c (define_builtin_macros_for_compilation_flags): Define __SANITIZE_ADDRESS__

Re: What CPP macro should -fsanitize=address define?

2012-11-21 Thread Jakub Jelinek
On Wed, Nov 21, 2012 at 12:21:55PM -0800, H.J. Lu wrote: Here is a doc patch. OK to install? Yes. 2012-11-21 H.J. Lu hongjiu...@intel.com * doc/cpp.texi: Document __SANITIZE_ADDRESS__. diff --git a/gcc/doc/cpp.texi b/gcc/doc/cpp.texi index c463e7c..682ee9f 100644 ---

Re: Sparc ASAN

2012-11-21 Thread David Miller
From: David Miller da...@davemloft.net Date: Wed, 21 Nov 2012 12:54:17 -0500 (EST) From: Peter Bergner berg...@vnet.ibm.com Date: Wed, 21 Nov 2012 11:28:51 -0600 On Tue, 2012-11-20 at 23:19 -0500, David Miller wrote: The address violation detection seems to work properly and the only thing

Re: Sparc ASAN

2012-11-21 Thread Jakub Jelinek
On Wed, Nov 21, 2012 at 03:27:16PM -0500, David Miller wrote: Actually I looked more closely at this, and the trigger is hit one stack frame too late on sparc. Are you testing with -fno-builtin-memcmp? Without it the check is done directly in main... Jakub

Re: Sparc ASAN

2012-11-21 Thread David Miller
From: Jakub Jelinek ja...@redhat.com Date: Wed, 21 Nov 2012 21:30:37 +0100 On Wed, Nov 21, 2012 at 03:27:16PM -0500, David Miller wrote: Actually I looked more closely at this, and the trigger is hit one stack frame too late on sparc. Are you testing with -fno-builtin-memcmp? Without it

[committed] Update gomp_managed_threads in gomp_free_thread (PR libgomp/55411)

2012-11-21 Thread Jakub Jelinek
Hi! gomp_free_thread wasn't updating gomp_managed_threads count, so if a thread that executed #pragma omp parallel terminated, we might be still using throttled spin count instead of normal one unnecessarily. Tested on x86_64-linux and i686-linux, committed to trunk and 4.7. 2012-11-21 Jakub

[PATCH] Fix VRP MULT_EXPR handling (PR tree-optimization/54471)

2012-11-21 Thread Jakub Jelinek
Hi! If a type has 2 * HWI precision, sizem1 is maximum double_int (all ones) and thus size = sizem1 + double_int_one overflows into 0. If either min0 or min1 is also zero, we might wrongly canonicalize the range into a signed one. Fixed thusly, bootstrapped/regtested on x86_64-linux and

[PATCH] Use ATTRIBUTE_PACKED in ree.c

2012-11-21 Thread Jakub Jelinek
Hi! The PR55430 miscompilation of ree.c by LRA lead me to look at this structure, which was really meant to be just 2 byte long, but is unnecessarily 4 byte long. As it only contains 8, 2 and 1 bit bitfields, it can always (except old alphas) be accessed by 1 byte loads/stores, so packed

Re: [patch, pch] Fix pch failure on mips-mti-linux-gnu

2012-11-21 Thread Joseph S. Myers
On Wed, 21 Nov 2012, Steve Ellcey wrote: 2012-11-21 Steve Ellcey sell...@mips.com PR pch/55399 * files.c (pch_open_file): Fix check for implicit_preinclude. OK. I had the extra check in a previous version of my implicit preincludes patch, but took it out as it didn't seem

[PATCH]: Fix compiler segfault failure in cd_dce pass

2012-11-21 Thread Xinliang David Li
In compiling one of the very large C++ source, the compiler hit a segfault in cddce -- the ssa_name of a vuse operand has a null def stmt. The def stmt was a PHI node, and later got removed by the phicprop pass (in eliminate_degenerated_phis because it seems to have zero uses) bb 17: .MEM_343 =

patch to fix PR55414

2012-11-21 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55414 The patch was successfully bootstrapped on x86/x86-64. Committed as rev. 193712. 2012-11-21 Vladimir Makarov vmaka...@redhat.com PR rtl-optimization/55414 * lra-constraints.c (Index): New

Re: [Patch, Fortran] PR 55352: [4.7/4.8 Regression] Erroneous gfortran warning of unused module variable when variable is only used in namelist

2012-11-21 Thread Janus Weil
Thanks for the patch - it's OK for trunk and 4.7. Thanks, Paul. Committed to trunk as r193711. I will apply it to the 4.7 branch soon. Cheers, Janus On 19 November 2012 21:39, Janus Weil ja...@gcc.gnu.org wrote: Hi all, here is another contribution in trying to reduce the still too

[alpha] Update to new extv/insv patterns

2012-11-21 Thread Richard Henderson
I wrote and tested this before Richard S posted an optabs.c patch that more or less fixes the problem generically. But since this is the way we want to go in the long term, and I've already done the testing, I figured I might as well commit it now. r~ * config/alpha/alpha.md

Re: ping - Re: [patch] [alpha] add multiarch definitions for alpha-linux-gnu

2012-11-21 Thread Richard Henderson
On 11/21/2012 02:52 PM, Matthias Klose wrote: http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01172.html Ok. r~

Re: [PATCH] Use ATTRIBUTE_PACKED in ree.c

2012-11-21 Thread Eric Botcazou
2012-11-21 Jakub Jelinek ja...@redhat.com * ree.c (struct ext_modified): Add ATTRIBUTE_PACKED. Are you sure that this will compile with non-GCC compilers? -- Eric Botcazou

Re: Sparc ASAN

2012-11-21 Thread Peter Bergner
On Wed, 2012-11-21 at 15:27 -0500, David Miller wrote: Actually I looked more closely at this, and the trigger is hit one stack frame too late on sparc. The BP computed in the memcmp() interceptor is the frame pointer %fp, but on sparc that's the CFA of the caller, main() in the case of the

RFC: Add --with-build-config=bootstrap-asan support

2012-11-21 Thread H.J. Lu
Hi, I added --with-build-config=bootstrap-asan support on hjl/asan branch: http://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/hjl/asan Any comments? Thanks. -- H.J.

[patch, libquadmath, committed] Another GLIBC update of libquadmath

2012-11-21 Thread Tobias Burnus
Committed as Rev. 193716. (I still have to update I/O and rounding, taking Joseph's comment into account.) Tobias

Re: Fwd: [libatomic][patch] Handle -mx32 like -m64

2012-11-21 Thread Richard Henderson
On 11/21/2012 03:23 PM, Matthias Klose wrote: * configure.tgt (i[3456]86): Handle -mx32 like -m64. Ok. r~

[Patch Ping] Fix problem that hardreg_cprop opportunities are missed on thumb1GCC

2012-11-21 Thread Bin Cheng
-Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of Bin Cheng Sent: Wednesday, October 10, 2012 5:58 PM To: gcc-patches@gcc.gnu.org Cc: Ramana Radhakrishnan; Richard Earnshaw; 'Richard Sandiford' Subject: RE: [PING Updated]:

Re: [libsanitizer] a script to help merging asan from upstream

2012-11-21 Thread Konstantin Serebryany
Added to README.gcc: The merges from upstream should be done with the aid of the merge.sh script; it will also update the file MERGE to contain the upstream revision we merged with. On Wed, Nov 21, 2012 at 11:03 PM, Xinliang David Li davi...@google.com wrote: How about also documenting this in

Re: [PATCH][Revisedx4] Enable libsanitizer on darwin

2012-11-21 Thread Konstantin Serebryany
Looks good, but I guess we also need to copy the file LICENSE.TXT --kcc On Wed, Nov 21, 2012 at 10:44 PM, Jack Howarth howa...@bromo.med.uc.edu wrote: The attached patch imports the missing mach_override/mach_override.h and mach_override/mach_override.c files from llvm.org's compiler-rt at

Re: Sparc ASAN

2012-11-21 Thread David Miller
From: Peter Bergner berg...@vnet.ibm.com Date: Wed, 21 Nov 2012 17:46:57 -0600 If you have a suggested change/patch that does that, let me know and I can try it out on powerpc to make sure it works for us too. I will try to do so, but I am pretty sure at this point that it will end up being

Re: [patch,avr] Ad PR54222: Move decimal point of signed accum one bit right.

2012-11-21 Thread Denis Chertykov
2012/11/21 Georg-Johann Lay a...@gjlay.de: This patch restores the GCC default layout of HA, SA and DA mode. The original fixed point support tried to be binary compatible with fixed-point support already provided by some non-FSF ports, but that turned out to result in wrong code in some

Re: [Patch Ping] Fix problem that hardreg_cprop opportunities are missed on thumb1GCC

2012-11-21 Thread Jeff Law
On 11/21/2012 06:46 PM, Bin Cheng wrote: -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of Bin Cheng Sent: Wednesday, October 10, 2012 5:58 PM To: gcc-patches@gcc.gnu.org Cc: Ramana Radhakrishnan; Richard Earnshaw; 'Richard

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-21 Thread Xinliang David Li
On Wed, Nov 21, 2012 at 11:35 PM, Dmitry Vyukov dvyu...@google.com wrote: What percent of the memory accesses the following can skip? I just don't know what exactly they mean. ADDR_EXPR/COMPONENT_REF look like it can skip a lot. It does not skip a lot. + /* TODO: handle other cases +

Re: [PATCH] Use ATTRIBUTE_PACKED in ree.c

2012-11-21 Thread Jakub Jelinek
On Thu, Nov 22, 2012 at 12:26:01AM +0100, Eric Botcazou wrote: 2012-11-21 Jakub Jelinek ja...@redhat.com * ree.c (struct ext_modified): Add ATTRIBUTE_PACKED. Are you sure that this will compile with non-GCC compilers? I'm not sure, but I hope it will. ansidecl.h has #ifndef

  1   2   >