Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-12-19 Thread Tobias Burnus
Jakub Jelinek wrote: On Tue, Dec 18, 2012 at 10:38:06PM +0100, Tobias Burnus wrote: Updated patch attached. Build and regtested on x86-64-gnu-linux. OK for the trunk? Looks ok to me, thanks. I have now committed it as Rev. 194604. For what it is worth, I have also successfully tested the

Re: [fortran, patch] Allow displaying backtraces from user code

2012-12-19 Thread Janne Blomqvist
On Sun, Dec 16, 2012 at 12:50 AM, Janus Weil ja...@gcc.gnu.org wrote: Hi, So, in principle I'm fine with all your BACKTRACE_* variants (except for _splurge, maybe ;) Or, why not just (plain and simple) BACKTRACE? The name is the same as backtrace() in glibc, but otherwise, sure why not.

[PING] Bugfix: Additional parameter for canonicalize comparison

2012-12-19 Thread Andreas Krebbel
Hi, are the ARM parts of the patch below ok for mainline? I did a compile test with a cross. Bye, -Andreas- Original Message Subject: [PATCH] Bugfix: Additional parameter for canonicalize comparison Date: Wed, 12 Dec 2012 12:23:14 +0100 From: Andreas Krebbel

Fix ipa-inline-transform ICE

2012-12-19 Thread Jan Hubicka
Hi, the ipa-inline-transform ICE is caused by fact that devirt_benefit in ipa-inline-analysis is able to determine devirtualiation oppurtunity of call to b3, while the ipa-prop responsible for updating function body after inlining is not. This is because the later is missing code turning known

Re: [PING] Bugfix: Additional parameter for canonicalize comparison

2012-12-19 Thread Richard Earnshaw
On 19/12/12 09:53, Andreas Krebbel wrote: Hi, are the ARM parts of the patch below ok for mainline? Yes. Sorry for the delay. R. I did a compile test with a cross. Bye, -Andreas- Original Message Subject: [PATCH] Bugfix: Additional parameter for canonicalize

[PATCH] Fix PR55736

2012-12-19 Thread Richard Biener
Switch conversion currently makes no effort to hide BLOCKs from locations of expressions it puts into the static constructors built. This causes issues at least for LTO where dead references to BLOCKs end up being produced for the varpool global initializers. But I can very well imagine that

Re: [PATCH] Add gen_lowpart_for_debug (PR debug/55730)

2012-12-19 Thread Richard Biener
On Tue, Dec 18, 2012 at 8:03 PM, Jakub Jelinek ja...@redhat.com wrote: Hi! On Tue, Dec 18, 2012 at 09:25:14AM +0100, Paolo Bonzini wrote: Il 17/12/2012 22:33, Jakub Jelinek ha scritto: If gen_lowpart_if_possible returns NULL, the default rtl_hooks.gen_lowpart_no_emit hook returns the

[asan] Never use memset for clearing of shadow mem in epilogues (PR fortran/55341)

2012-12-19 Thread Jakub Jelinek
Hi! clear_storage sometimes emits a library call instead of clearing storage by pieces, rep stos* and similar, unfortunately if it is a call that libasan intercepts (memset), it fails because it doesn't allow writes into shadow mem. Fixed by scanning the clear_storage sequence if there are any

[asan] Use -fno-shrink-wrap for null-deref-1.c test

2012-12-19 Thread Jakub Jelinek
Hi! Weirdly this test fails just on some boxes and others succeeds (x86_64-linux, -Os only). The problem seems to be in the libasan fast unwinder, if the routine is shrink-wrapped, even when it is compiled with -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer, if the memory dereference which

Re: [fortran, patch] Allow displaying backtraces from user code

2012-12-19 Thread Janus Weil
Hi, first off: Some more words on the naming issue. I actually still prefer the most simple and straightforward variant (i.e. BACKTRACE, which can easily be found and does not sound 'clumsy') ... Or, why not just (plain and simple) BACKTRACE? The name is the same as backtrace() in glibc, but

Re: libgo patch committed: Update to current library

2012-12-19 Thread Rainer Orth
Hi Ian, Sorry about that. This patch should fix the build. I have not yet it does, thanks. tested whether it passes the tests. Bootstrapped on x86_64-unknown-linux-gnu, which proves nothing since the file is not used on GNU/Linux. Committed to mainline. I've tried it on

Re: [PING] Bugfix: Additional parameter for canonicalize comparison

2012-12-19 Thread Richard Biener
On Wed, Dec 19, 2012 at 12:34 PM, Richard Earnshaw rearn...@arm.com wrote: On 19/12/12 09:53, Andreas Krebbel wrote: Hi, are the ARM parts of the patch below ok for mainline? Yes. Sorry for the delay. I think this broke bootstrap on x86_64:

RE: [PATCH][ARM] AArch32 vmaxnm, vminnm support

2012-12-19 Thread Kyrylo Tkachov
Ping. http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02097.html Thanks, Kyrill -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Kyrylo Tkachov Sent: 26 November 2012 14:40 To: gcc-patches@gcc.gnu.org Cc: Ramana

Re: [PING] Bugfix: Additional parameter for canonicalize comparison

2012-12-19 Thread Richard Biener
On Wed, Dec 19, 2012 at 3:04 PM, Richard Biener richard.guent...@gmail.com wrote: On Wed, Dec 19, 2012 at 12:34 PM, Richard Earnshaw rearn...@arm.com wrote: On 19/12/12 09:53, Andreas Krebbel wrote: Hi, are the ARM parts of the patch below ok for mainline? Yes. Sorry for the delay. I

Re: [fortran, patch] Allow displaying backtraces from user code

2012-12-19 Thread Tobias Burnus
Janus Weil wrote: Attached is a new patch, which expands the documentation according to your proposal, and uses the name BACKTRACE. I hope that both Janne and Tobias can agree with this naming decision ... Looks fine from my side. Can you also add a quip to

[PATCH] Unbreak bootstrap

2012-12-19 Thread Richard Biener
I'll check in the following once it survived stage1. Richard. 2012-12-19 Richard Biener rguent...@suse.de * targhooks.h (default_canonicalize_comparison): Fix prototype. * targhooks.c (default_canonicalize_comparison): Define. Index: gcc/targhooks.h

[Patch, AArch64]: Fix test harness to for unaligned vector mem access.

2012-12-19 Thread Tejas Belagod
Hi, Currently on the trunk, we have many vect tests that fail for aarch64-*-* because check_effective_target_vect_no_align () in target-supports.exp returns true for aarch64 where in fact it should be returning false. This causes the tests that check for vect_no_align and expect messages for

Re: [Patch, AArch64]: Fix test harness to for unaligned vector mem access.

2012-12-19 Thread Richard Earnshaw
On 19/12/12 14:47, Tejas Belagod wrote: Hi, Currently on the trunk, we have many vect tests that fail for aarch64-*-* because check_effective_target_vect_no_align () in target-supports.exp returns true for aarch64 where in fact it should be returning false. This causes the tests that check for

[Patch, Fortran/GOMP, committed] Moved test case from testsuite/gfortran.dg/gomp to libgomp/

2012-12-19 Thread Tobias Burnus
Commited as obvious (Rev. 194611). The test case accesses the .mod file which is generated in libgomp. For some reasons, it works when GCC is installed (i.e. it works for most developers?) but it fails otherwise (e.g. for HJ's builds). Tobias Index: libgomp/ChangeLog

Re: [fortran, patch] Allow displaying backtraces from user code

2012-12-19 Thread Janus Weil
Attached is a new patch, which expands the documentation according to your proposal, and uses the name BACKTRACE. I hope that both Janne and Tobias can agree with this naming decision ... Looks fine from my side. Great, thanks. Janne? Can you also add a quip to

Re: PATCH RFA: PR go/55201: Create libatomic convenience library

2012-12-19 Thread Matthias Klose
Am 19.12.2012 01:28, schrieb Ian Lance Taylor: On Tue, Dec 18, 2012 at 3:15 PM, Richard Henderson r...@redhat.com wrote: On 12/18/2012 02:52 PM, Ian Lance Taylor wrote: Argh. But why? Wouldn't that only apply to cases where the lock was sometimes locked by one library and sometimes locked by

[Patch, libgomp] libgomp.fortran/fortran.exp - add -fintrinsic-modules-path ${blddir}

2012-12-19 Thread Tobias Burnus
The attached patch adds -fintrinsic-modules-path ${blddir} otherwise, the compiler might have trouble finding the libraries using use, INTRINSIC :: omp_lib. Without intrinsic it searches the -I directories. (The compiler supports multiple -fintrinsic-modules-path, cf.

Re: [PATCH][ARM] AArch32 vmaxnm, vminnm support

2012-12-19 Thread Richard Earnshaw
On 26/11/12 14:40, Kyrylo Tkachov wrote: Hi all, This patch adds support for the AArch32 vmaxnm and vminnm VFP instructions in that can be used to implement the smax[sf,df]3 and smin[sf,df]3 RTL patterns. The patterns are only used by gcc when unsafe math optimisations are turned on. Two new

Re: [Patch, libgomp] libgomp.fortran/fortran.exp - add -fintrinsic-modules-path ${blddir}

2012-12-19 Thread Jakub Jelinek
On Wed, Dec 19, 2012 at 04:38:41PM +0100, Tobias Burnus wrote: 2012-12-19 Tobias Burnus bur...@net-b.de * testsuite/libgomp.fortran/fortran.exp: Set -fintrinsic-modules-path. Okay. Jakub

Re: PATCH RFA: PR go/55201: Create libatomic convenience library

2012-12-19 Thread Ian Lance Taylor
On Wed, Dec 19, 2012 at 7:38 AM, Matthias Klose d...@ubuntu.com wrote: The following patch fixes this for me, maybe other target library dependencies should be added too. that would be for libgfortran on libquadmath, libgcc libsanitizer on libstdc++ libstdc++ on libgomp, libgcc

Re: [ARM] Turning off 64bits ops in Neon and gfortran/modulo-scheduling problem

2012-12-19 Thread Christophe Lyon
On 17 December 2012 16:12, Richard Earnshaw rearn...@arm.com wrote: On 29/11/12 17:16, Christophe Lyon wrote: On trunk I have noticed a regression in gfortran when using modulo scheduling: sms-1.f90 now fails, but I suspect it's not because of this patch since forcing compilation for armv5t

Re: [PATCH,x86] Fix combine for condditional instructions.

2012-12-19 Thread Uros Bizjak
On Fri, Dec 14, 2012 at 11:47 AM, Yuri Rumyantsev ysrum...@gmail.com wrote: With your new fix that add if-then-else splitting for memory operand I got expected performance speed-up - +6.7% for Atom and +8.4% for SNB. We need to do all testing this weekend and I will get you our final feedback

[patch] Fix typo in multiarch definition for kfreebsd

2012-12-19 Thread Matthias Klose
Fixes a typo in the multiarch definition for kfreebsd. Committed as obvious. Matthias 2012-12-19 Matthias Klose d...@ubuntu.com * config/i386/t-kfreebsd (MULTIARCH_DIRNAME): Add comma to separate arguments in make function. Index: config/i386/t-kfreebsd

[patch] fix multiarch definition for powerpcspe-linux-gnu

2012-12-19 Thread Matthias Klose
The definition of the multiarch tuple for powerpcspe-linux-gnu was wrong. The t-spe fragment isn't included for the powerpc*-linux* case, so move it to t-linux, and use tm_file_list (tm_file is only used in config.gcc). Ok for the trunk? Matthias 2012-12-19 Roland Stigge sti...@debian.org

Re: [C PATCH] Don't perform function array conversions on inline asm m constrainted inputs (PR c++/55619)

2012-12-19 Thread Joseph S. Myers
On Wed, 12 Dec 2012, Jakub Jelinek wrote: 2012-12-12 Jakub Jelinek ja...@redhat.com PR c++/55619 * c-parser.c (c_parser_asm_operands): Remove CONVERT_P argument, don't call default_function_array_conversion nor c_fully_fold here. (c_parser_asm_statement):

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2012-12-19 Thread Joseph S. Myers
On Thu, 13 Dec 2012, Alexander Ivchenko wrote: Could you please take a look at the attached patch that implements the target libc_has_function hook? I didn't change so far the default presence of c99, but rather tried to preserve the current behaviour of TARGET_C99_FUNCTIONS. It looks like a

Re: [doc] extend.texi copy-editing, 3/N (hyphenated phrases)

2012-12-19 Thread Sandra Loosemore
On 12/18/2012 10:42 PM, Gerald Pfeifer wrote: Hi Sandra, On Sat, 10 Nov 2012, Sandra Loosemore wrote: 2012-11-10 Sandra Loosemoresan...@codesourcery.com gcc/ * doc/extend.texi: Copy-edit to fix incorrect hyphenation phrases involving bit, byte, word, precision, and

Re: [PATCH] PR c++/53609 - Wrong argument deduction for pack expansion in argument pack

2012-12-19 Thread Dodji Seketeli
How about the below? gcc/cp/ * pt.c (argument_pack_element_is_expansion_p) (make_argument_pack_select, use_pack_expansion_extra_args_p) (gen_elem_of_pack_expansion_instantiation): New static functions. (has_bare_parameter_packs): Factorized out of ...

[Patch, Fortran] PR54818 - Fix ICE with TRANSFER to char

2012-12-19 Thread Tobias Burnus
TRANSFER(..., string) created on x86-64 an integer(8) string length; that lead to a tree-checking ICE but also might pass the wrong type in 'call sub(transfer(233, )'. Build and regtested on x86-64-gnu-linux. OK for the trunk? Tobias 2012-12-20 Tobias Burnus bur...@net-b.de PR

Re: [Patch, Fortran] PR54818 - Fix ICE with TRANSFER to char

2012-12-19 Thread Paul Richard Thomas
Dear Tobias, OK for trunk, apart from: s/the string length if of type gfc_charlen_type_node/the string length is of type gfc_charlen_type_node/ Thanks for the patch Paul On 20 December 2012 00:29, Tobias Burnus bur...@net-b.de wrote: TRANSFER(..., string) created on x86-64 an integer(8)

Re: [google 4.7] atomic update of profile counters (issue6965050)

2012-12-19 Thread Xinliang David Li
This looks good to me for google branches. Useful for trunk too. David On Wed, Dec 19, 2012 at 12:08 PM, Rong Xu x...@google.com wrote: Hi, This patch adds the supprot of atomic update the profile counters. Tested with google internal benchmarks and fdo kernel build. Thanks, -Rong

Re: Patch to enable unlimited polymorphism to gfortran

2012-12-19 Thread Paul Richard Thomas
Dear All, Committed as revision 194622 and corrigendum 194626 (removes one test from unlimited_polymorphic_2.f03). Thanks to one and all for the help. Paul On 19 December 2012 07:17, Paul Richard Thomas paul.richard.tho...@gmail.com wrote: Thanks Tobias and Dominique, I'll make the

Re: [google 4.7] atomic update of profile counters (issue6965050)

2012-12-19 Thread Andrew Pinski
On Wed, Dec 19, 2012 at 12:08 PM, Rong Xu x...@google.com wrote: Hi, This patch adds the supprot of atomic update the profile counters. Tested with google internal benchmarks and fdo kernel build. I think you should use the __atomic_ functions instead of __sync_ functions as they allow better

Re: [google 4.7] atomic update of profile counters (issue6965050)

2012-12-19 Thread Rong Xu
On Wed, Dec 19, 2012 at 4:29 PM, Andrew Pinski pins...@gmail.com wrote: On Wed, Dec 19, 2012 at 12:08 PM, Rong Xu x...@google.com wrote: Hi, This patch adds the supprot of atomic update the profile counters. Tested with google internal benchmarks and fdo kernel build. I think you

Re: [google 4.7] fdo build for linux kernel (issue 6968046)

2012-12-19 Thread davidxl
The change in gcov-io.h is from a different patch. David https://codereview.appspot.com/6968046/diff/1/gcc/gcov-io.c File gcc/gcov-io.c (right): https://codereview.appspot.com/6968046/diff/1/gcc/gcov-io.c#newcode688 gcc/gcov-io.c:688: Have you compared this with this impl: while (x) {

Re: [PATCH] Fix PR gcov-profile/55734 for bootstrapping with older compilers (issue6980044)

2012-12-19 Thread Jakub Jelinek
On Wed, Dec 19, 2012 at 01:34:34PM -0800, Teresa Johnson wrote: +#if IN_LIBGCOV + /* When building libgcov we don't include system.h, which includes + hwint.h (where floor_log2 is declared). However, libgcov.a + is built by the bootstrapped compiler and therefore the

Re: [google 4.7] fdo build for linux kernel (issue 6968046)

2012-12-19 Thread Rong Xu
On Wed, Dec 19, 2012 at 5:04 PM, davi...@google.com wrote: The change in gcov-io.h is from a different patch. sorry. here is the patch for gcov-io.h: Index: gcov-io.h === --- gcov-io.h (revision 194562) +++ gcov-io.h (working

Re: Follow-up to PR bootstrap/54820

2012-12-19 Thread Cary Coutant
Two test cases, debug_msg_so.err and debug_msg_ndebug.err, are still broken by the original patch, because (a) debug_msg.so has a DT_NEEDED entry for libstdc++.so, (b) the use of -static-libstdc++ means that that DT_NEEDED entry is unknown when we link the executable, and (c) the undefined symbols

Re: [patch] fix multiarch definition for powerpcspe-linux-gnu

2012-12-19 Thread David Edelsohn
On Wed, Dec 19, 2012 at 11:47 AM, Matthias Klose d...@ubuntu.com wrote: The definition of the multiarch tuple for powerpcspe-linux-gnu was wrong. The t-spe fragment isn't included for the powerpc*-linux* case, so move it to t-linux, and use tm_file_list (tm_file is only used in config.gcc).

Re: Follow-up to PR bootstrap/54820

2012-12-19 Thread Ian Lance Taylor
On Wed, Dec 19, 2012 at 6:13 PM, Cary Coutant ccout...@google.com wrote: Two test cases, debug_msg_so.err and debug_msg_ndebug.err, are still broken by the original patch, because (a) debug_msg.so has a DT_NEEDED entry for libstdc++.so, (b) the use of -static-libstdc++ means that that

[PATCH][ARM][thumb1] Reduce lr save for leaf function with non-far jump

2012-12-19 Thread Joey Ye
Current GCC thumb1 has an annoying problem that always assuming far branch. So it forces to save lr, even when unnecessarily. The most extreme case complained by partner is: // compiled with -mthumb -mcpu=cortex-m0 -Os. void foo() { for (;;); } = foo: push{lr} // Crazy!!! .L2: