Re: all_ones vs minus_one (was: [PATCH] Loop distribution improvements)

2013-05-06 Thread Marc Glisse
On Tue, 7 May 2013, Marc Glisse wrote: On Thu, 2 May 2013, Richard Biener wrote: Can you followup with a patch to do s/integer_all_onesp/integer_minus_onep/ where it makes sense? This passes bootstrap+testsuite on x86_64-linux-gnu. I kept all_ones for bitmask type of operations (BIT_*_EXPR,

Re: [gomp4] #pragma omp declare simd (aka OpenMP elemental functions) parsing

2013-05-06 Thread Jakub Jelinek
On Mon, May 06, 2013 at 03:25:43PM -0400, Jason Merrill wrote: > On 05/06/2013 02:25 PM, Jakub Jelinek wrote: > >I did it that way because if I understand the code well, often > >grokdeclarator/start_decl/start_function/grokmethod/grokfield > >is called with a chain of declarators, not just a singl

all_ones vs minus_one (was: [PATCH] Loop distribution improvements)

2013-05-06 Thread Marc Glisse
On Thu, 2 May 2013, Richard Biener wrote: Can you followup with a patch to do s/integer_all_onesp/integer_minus_onep/ where it makes sense? This passes bootstrap+testsuite on x86_64-linux-gnu. I kept all_ones for bitmask type of operations (BIT_*_EXPR, VEC_COND_EXPR) and used minus_one for t

Re: [PATCH] Use indentation in gtype.state to show nested structure

2013-05-06 Thread Laurynas Biveinis
2013/5/6 Jeff Law : > On 05/03/2013 06:48 PM, David Malcolm wrote: > >> >> +static int indent_amount = 0; >> +static int had_recent_newline = 0; > > Any clean way to do this without the global state? I have to ask given > you're generally working on removing global state. Seems to take a tiny > s

RFA: PATCH to add variadic version of build_constructor

2013-05-06 Thread Jason Merrill
Most build_* functions have variadic versions, but build_constructor doesn't as of yet, and it would be convenient for a patch I'm working on. I decided to call it build_constructor_va, but am open to other naming ideas. Tested x86_64-pc-linux-gnu. OK for trunk? commit 7cab86001c233a8cac209e

Re: [google][4.7] Move the building of gcov constructor function after initialization of gcov_info_var

2013-05-06 Thread Xinliang David Li
ok. David On Mon, May 6, 2013 at 6:03 PM, Carrot Wei wrote: > After the refactoring has been checked in, the bug fixing part is simply > a moving a function call. > > Tested by running ./buildit with both x86-64 and power64 targets. > The last time regression of tls-tests.c disappeared. So it is

[patch] top-level configure for Nios II

2013-05-06 Thread Sandra Loosemore
The newlib support for Nios II ELF has just been approved and checked in. However, there's no libgloss support; it's assumed that folks will link with a BSP (like Altera's HAL) to provide the target-specific startup code and I/O stubs. So, this patch adds libgloss to the top-level noconfigdir

Re: [PATCH] Fix thinko in SLSR that caused x86 bootstrap failure

2013-05-06 Thread Bill Schmidt
On Mon, 2013-05-06 at 17:28 -0700, H.J. Lu wrote: > On Mon, May 6, 2013 at 12:29 PM, Bill Schmidt > wrote: > > On Mon, 2013-05-06 at 21:25 +0200, Jakub Jelinek wrote: > >> On Sun, May 05, 2013 at 03:45:17PM -0500, Bill Schmidt wrote: > >> > 2013-05-05 Bill Schmidt > >> > > >> > * gimple-ssa

Re: [google][4.7] Move the building of gcov constructor function after initialization of gcov_info_var

2013-05-06 Thread Carrot Wei
After the refactoring has been checked in, the bug fixing part is simply a moving a function call. Tested by running ./buildit with both x86-64 and power64 targets. The last time regression of tls-tests.c disappeared. So it is really flaky in our testing environment. thanks Carrot 2013-05-02 Gu

powerpc64le configure fix

2013-05-06 Thread Alan Modra
Applying under the obvious rule. 2013-05-07 Anton Blanchard * configure.ac (HAVE_LD_LARGE_TOC): Use correct linker emulation for powerpc64 little endian. * configure: Regenerate. diff --git a/gcc/configure.ac b/gcc/configure.ac index a859d99..a289cf7 100644 --- a/g

Re: RFC: PATCH to avoid linking multiple front ends at once with parallel make

2013-05-06 Thread Dave Korn
On 06/05/2013 17:41, Jason Merrill wrote: > On 05/05/2013 09:57 AM, Dave Korn wrote: >> This sounds like a bad idea to me, and not just because the locking >> mechanism is dodgy. Is the problem more widespread than just your laptop? >> Does it affect other host OSs? Linking multiple frontends at

Re: [PATCH] Fix thinko in SLSR that caused x86 bootstrap failure

2013-05-06 Thread H.J. Lu
On Mon, May 6, 2013 at 12:29 PM, Bill Schmidt wrote: > On Mon, 2013-05-06 at 21:25 +0200, Jakub Jelinek wrote: >> On Sun, May 05, 2013 at 03:45:17PM -0500, Bill Schmidt wrote: >> > 2013-05-05 Bill Schmidt >> > >> > * gimple-ssa-strength-reduction.c (slsr_process_phi): Re-enable. >> > (f

[PATCH] Fix SLSR conditional candidate bug with commuted operands

2013-05-06 Thread Bill Schmidt
This fixes the following bug: On Mon, 2013-05-06 at 21:25 +0200, Jakub Jelinek wrote: > On Sun, May 05, 2013 at 03:45:17PM -0500, Bill Schmidt wrote: > > 2013-05-05 Bill Schmidt > > > > * gimple-ssa-strength-reduction.c (slsr_process_phi): Re-enable. > > (find_candidates_in_block): Re-

Re: RFA: RL78: Improve interrupt function generation

2013-05-06 Thread DJ Delorie
> * Uses register bank 3 instead of register bank 0 inside the > handler. I wonder if nested interrupts will cause problems, since the second interrupt will occur with RB3 already selected. Also, there are some hand-coded routines in libgloss/libgcc that manually swap banks, they'd hav

Re: [PATCH] Use indentation in gtype.state to show nested structure

2013-05-06 Thread David Malcolm
On Mon, 2013-05-06 at 17:05 -0400, David Malcolm wrote: [...snip...] > Thanks for review; see attached rewrite of patch. Sorry, I messed up the macro for generating the ChangeLog in the last patch; version with fixed ChangeLog attached. commit 566185b94449a90dc3213ea11643bfb3924a751d Author: David

Re: [PATCH] Use indentation in gtype.state to show nested structure

2013-05-06 Thread David Malcolm
On Mon, 2013-05-06 at 12:22 -0600, Jeff Law wrote: > On 05/03/2013 06:48 PM, David Malcolm wrote: > > > > +static int indent_amount = 0; > > +static int had_recent_newline = 0; > Any clean way to do this without the global state? I have to ask given > you're generally working on removing global s

Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output

2013-05-06 Thread Maksim Kuznetsov
> I checked it in for him with a small change in document. It > should be `|' instead of '@|'. Thanks a lot! -- Maxim Kuznetsov

unordered profile mode patch

2013-05-06 Thread François Dumont
Hi Here is the patch to fix the unordered containers profile mode. There are a number of enhancements/fixes: - Use inheritance to play code on instantiation/destruction. This way some constructors and assignment operators can be defaulted like in the normal implementation and then be delet

[PATCH 2/n, i386]: Merge *sse4_1_pextrq and *sse4_1_pextrd with base vec_select patterns.

2013-05-06 Thread Uros Bizjak
Hello! Attached patch merges *sse4_1_pextrq and *sse4_1_pextrd with base vec_select patterns. The patch splits instruction with zero selector to plain movdi and movsi patterns. Please note that pextr $0,... should only be generated for !TARGET_INTER_UNIT_MOVES_FROM_VEC targets when -msse4 is used.

Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output

2013-05-06 Thread H.J. Lu
On Mon, May 6, 2013 at 12:01 PM, Jakub Jelinek wrote: > On Mon, Apr 29, 2013 at 01:42:55PM +0200, Jakub Jelinek wrote: >> On Mon, Apr 29, 2013 at 03:39:58PM +0400, Maksim Kuznetsov wrote: >> > 2013/4/29 Jakub Jelinek : >> > > Also, why are you handling just %{ and %}, and >> > > not also %| ? I m

Re: [PATCH] Fix thinko in SLSR that caused x86 bootstrap failure

2013-05-06 Thread Bill Schmidt
On Mon, 2013-05-06 at 21:25 +0200, Jakub Jelinek wrote: > On Sun, May 05, 2013 at 03:45:17PM -0500, Bill Schmidt wrote: > > 2013-05-05 Bill Schmidt > > > > * gimple-ssa-strength-reduction.c (slsr_process_phi): Re-enable. > > (find_candidates_in_block): Re-enable slsr_process_phi. > >

Re: [gomp4] #pragma omp declare simd (aka OpenMP elemental functions) parsing

2013-05-06 Thread Jason Merrill
On 05/06/2013 02:25 PM, Jakub Jelinek wrote: I did it that way because if I understand the code well, often grokdeclarator/start_decl/start_function/grokmethod/grokfield is called with a chain of declarators, not just a single one. True, perhaps adding it to declspecs->attributes would be simpl

Re: [PATCH] Fix thinko in SLSR that caused x86 bootstrap failure

2013-05-06 Thread Jakub Jelinek
On Sun, May 05, 2013 at 03:45:17PM -0500, Bill Schmidt wrote: > 2013-05-05 Bill Schmidt > > * gimple-ssa-strength-reduction.c (slsr_process_phi): Re-enable. > (find_candidates_in_block): Re-enable slsr_process_phi. > (create_phi_basis): Fix double counting of candidate adjustm

Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output

2013-05-06 Thread Jakub Jelinek
On Mon, Apr 29, 2013 at 01:42:55PM +0200, Jakub Jelinek wrote: > On Mon, Apr 29, 2013 at 03:39:58PM +0400, Maksim Kuznetsov wrote: > > 2013/4/29 Jakub Jelinek : > > > Also, why are you handling just %{ and %}, and > > > not also %| ? I mean, if you want to print say {|} into assembly for both > >

[PATCH] Error out on -fsanitize=thread -fsanitize=address

2013-05-06 Thread Jakub Jelinek
Hi! While these two sanitizing modes don't conflict on the compiler side, the runtimes are incompatible with each other (each assumes different memory layout). We'd need a special runtime library that would handle both at the same time, probably not worth the hassle. Ok for trunk/4.8? 2013-05-0

[PATCH] Fix -g ICE with COMPOUND_LITERAL_EXPR (PR debug/57184)

2013-05-06 Thread Jakub Jelinek
Hi! We ICE on the following testcase, because DECL_INITIAL contains COMPOUND_LITERAL_EXPR, which expr.c assumes has been gimplified, but initializers aren't gimplified. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/4.8? 2013-05-06 Jakub Jelinek PR

[Patch, ARM, v2] Enable libsanitizer

2013-05-06 Thread Christophe Lyon
Hi, Here is a 2nd attempt at enabling libsanitizer on ARM. Compared with the previous version, this patch is more intrusive to workaround some limitations with qemu: * qemu does not work well with threads, so I chose to disable clone-test-1.c and rlimit-mmap-test-1.c when running on a simulator.

Re: [gomp4] #pragma omp declare simd (aka OpenMP elemental functions) parsing

2013-05-06 Thread Jakub Jelinek
On Mon, May 06, 2013 at 12:23:07PM -0400, Jason Merrill wrote: > On 05/06/2013 11:04 AM, Jakub Jelinek wrote: > >isn't it too invasive to the C++ FE? > > It is pretty invasive. Why not put the information in > cp_declarator, as you suggested in your earlier email? You could > even put it in the

Re: [PATCH] Use indentation in gtype.state to show nested structure

2013-05-06 Thread Jeff Law
On 05/03/2013 06:48 PM, David Malcolm wrote: +static int indent_amount = 0; +static int had_recent_newline = 0; Any clean way to do this without the global state? I have to ask given you're generally working on removing global state. Seems to take a tiny step backwards. + +static void +

Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-06 Thread Jeff Law
On 05/03/2013 07:10 AM, Julian Brown wrote: Hi, This is a patch which fixes a latent bug in RTL GCSE/PRE, described more fully in: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57159 I haven't been able to reproduce the problem on mainline (nor on a supported target). Maybe someone more familiar

Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-06 Thread Jeff Law
On 05/06/2013 10:27 AM, Steven Bosscher wrote: On Mon, May 6, 2013 at 5:28 PM, Jeff Law wrote: On 05/05/2013 04:18 AM, Steven Bosscher wrote: On Fri, May 3, 2013 at 3:10 PM, Julian Brown wrote: gcc/ * gcse.c (compute_ld_motion_mems): Invalidate non-simple mem refs in REG_EQ

[patch] Support .eh_frame in crt1 x86_64 glibc (PR libc/15407)

2013-05-06 Thread Jan Kratochvil
Hi, since [patch] x86_64: CFI unwinding stop in _start http://sourceware.org/ml/libc-alpha/2012-03/msg00573.html there is a regression reproducible with gold: http://sourceware.org/bugzilla/show_bug.cgi?id=15407 as .eh_frame is created before the __EH_FRAME_BEGIN__ marker

Re: RFC: PATCH to avoid linking multiple front ends at once with parallel make

2013-05-06 Thread Jason Merrill
On 05/05/2013 09:57 AM, Dave Korn wrote: This sounds like a bad idea to me, and not just because the locking mechanism is dodgy. Is the problem more widespread than just your laptop? Does it affect other host OSs? Linking multiple frontends at once doesn't lock up my desktop PC, so I'd rathe

Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-06 Thread Steven Bosscher
On Mon, May 6, 2013 at 5:28 PM, Jeff Law wrote: > On 05/05/2013 04:18 AM, Steven Bosscher wrote: >> >> On Fri, May 3, 2013 at 3:10 PM, Julian Brown wrote: >>> >>> gcc/ >>> * gcse.c (compute_ld_motion_mems): Invalidate non-simple mem refs >>> in REG_EQUAL notes. >> >> >> Makes sense t

Re: [C++] Missing save_expr in vector-scalar ops

2013-05-06 Thread Jason Merrill
On 05/06/2013 07:46 AM, Marc Glisse wrote: I added it after convert while the C front-end has it before convert, I can put it before if you prefer. Let's be consistent. OK for trunk and 4.8. Jason

Re: [C++ Patch] PR 57183

2013-05-06 Thread Jason Merrill
OK. Jason

Re: [gomp4] #pragma omp declare simd (aka OpenMP elemental functions) parsing

2013-05-06 Thread Jason Merrill
On 05/06/2013 11:04 AM, Jakub Jelinek wrote: isn't it too invasive to the C++ FE? It is pretty invasive. Why not put the information in cp_declarator, as you suggested in your earlier email? You could even put it in the attributes field. Jason

Re: PATCH: contrib/repro_fail: filter out "-ignore SIGHUP" from spawn line

2013-05-06 Thread David Malcolm
On Thu, 2013-04-25 at 14:10 -0400, David Malcolm wrote: > On Thu, 2013-04-25 at 13:43 -0400, Diego Novillo wrote: > > On 2013-04-25 12:30 , David Malcolm wrote: > > > > > diff --git a/contrib/ChangeLog b/contrib/ChangeLog > > > index 9f4505b..01afcb5 100644 > > > --- a/contrib/ChangeLog > > > +++

Re: C++/v3 PATCH to add/throw std::bad_array_new_length

2013-05-06 Thread Jason Merrill
On 05/06/2013 08:46 AM, Florian Weimer wrote: On 05/06/2013 02:39 PM, Jason Merrill wrote: On 05/06/2013 05:46 AM, Florian Weimer wrote: Nice, this is simpler than expected. However, it makes the call sites even more bloated. Hmm, perhaps the checking should be wrapped in an inline function,

[PATCH] Use anonymous SSA name support in SLSR

2013-05-06 Thread Bill Schmidt
This removes lazy_create_slsr_reg and replaces uses of make_ssa_name with make_temp_ssa_name, removing the need for a bunch of unnecessary vars. Bootstrapped and tested on powerpc64-unknown-linux-gnu with no new regressions. Ok for trunk? Thanks, Bill 2013-05-06 Bill Schmidt * gimp

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-06 Thread Jakub Jelinek
On Mon, May 06, 2013 at 09:24:28AM -0600, Jeff Law wrote: > On 05/03/2013 04:46 PM, Teresa Johnson wrote: > >On Fri, May 3, 2013 at 12:48 PM, Teresa Johnson wrote: > >>Yes it will ICE on failure. What is the guideline on c.torture vs gcc.dg? > I don't think there's any general guidelines. > > c-t

Re: [PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-06 Thread Jeff Law
On 05/05/2013 04:18 AM, Steven Bosscher wrote: On Fri, May 3, 2013 at 3:10 PM, Julian Brown wrote: gcc/ * gcse.c (compute_ld_motion_mems): Invalidate non-simple mem refs in REG_EQUAL notes. Makes sense to me. Looking at REG_EQUAL notes in hash_scan_set is something relatively ne

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-06 Thread Jeff Law
On 05/03/2013 04:46 PM, Teresa Johnson wrote: On Fri, May 3, 2013 at 12:48 PM, Teresa Johnson wrote: Yes it will ICE on failure. What is the guideline on c.torture vs gcc.dg? I don't think there's any general guidelines. c-torture was an older framework that was considerably less expressive

[PATCH] Fix PR57185

2013-05-06 Thread Richard Biener
This fixes an anonymous SSA name issue. Bootstrapped and tested on x86_64-unknonw-linux-gnu, applied. Richard. 2013-05-06 Richard Biener PR tree-optimization/57185 * tree-parloops.c (add_field_for_reduction): Handle anonymous SSA names properly. * gcc.dg/aut

[gomp4] #pragma omp declare simd (aka OpenMP elemental functions) parsing

2013-05-06 Thread Jakub Jelinek
On Tue, Apr 30, 2013 at 10:35:21AM -0400, Jason Merrill wrote: > On 04/29/2013 02:32 PM, Jakub Jelinek wrote: > >Should I copy the parser->omp_declare_simd_clauses vector pointer > >say into cp_declarator structure so that grokfndecl could grab it from > >there? > > That sounds good. > > >Also, f

Re: [PATCH] Fix array sizes created by Java FE (PR libgcj/57074)

2013-05-06 Thread Tom Tromey
> "Jakub" == Jakub Jelinek writes: Jakub> 2013-05-04 Jakub Jelinek Jakub> PR libgcj/57074 Jakub> * class.c (emit_symbol_table): Use array type of the Jakub> right size for the_syms_decl and its DECL_INITIAL, instead Jakub> of symbols_array_type. Set TREE_TYPE (the_syms_decl) to it. Ja

Re: [PATCH] Use indentation in gtype.state to show nested structure

2013-05-06 Thread David Malcolm
On Mon, 2013-05-06 at 07:56 +0300, Laurynas Biveinis wrote: [...snip...] > The patch is OK with some minor formatting errors fixed: [...snip...] Thanks for reviewing this. BTW, is there an automated tool for checking for formatting issues like this in patches? (contrib/check_GNU_style.sh didn'

[C++ Patch] PR 57183

2013-05-06 Thread Paolo Carlini
Hi, the issue is that we -Wunused-variable warn for: const auto PI_3 = 3.1415926F; The reason is that TREE_READONLY is not set ("d" instead "r" in the .o). In turn, that's because the first and only time cp_apply_type_quals_to_decl is called, at the end of grokdeclarator, nothing happens bec

Re: C++/v3 PATCH to add/throw std::bad_array_new_length

2013-05-06 Thread Florian Weimer
On 05/06/2013 02:39 PM, Jason Merrill wrote: On 05/06/2013 05:46 AM, Florian Weimer wrote: Nice, this is simpler than expected. However, it makes the call sites even more bloated. Hmm, perhaps the checking should be wrapped in an inline function, so that the inliner can decide whether or not

Re: C++/v3 PATCH to add/throw std::bad_array_new_length

2013-05-06 Thread Jason Merrill
On 05/06/2013 05:46 AM, Florian Weimer wrote: Nice, this is simpler than expected. However, it makes the call sites even more bloated. Hmm, perhaps the checking should be wrapped in an inline function, so that the inliner can decide whether or not to expand it at the call site... This patc

[Patch: RL78] Fix interrupt handling for G10 target

2013-05-06 Thread Vinay Kumar. G
Hi, This patch fixes G10 target support for interrupt functions in the recently submitted patch, "Improve interrupt function generation" http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00011.html The G10 target does not support the "sel rbn" insn as it has only bank 0. Conditions have been added t

[C++] Missing save_expr in vector-scalar ops

2013-05-06 Thread Marc Glisse
Hello, this patch is extracted from http://gcc.gnu.org/ml/gcc-patches/2013-04/msg00783.html When I copied this code from the C front-end and removed c_fully_fold, I apparently also removed the save_expr, so I am putting it back in. I added it after convert while the C front-end has it before c

Re: [PATCH] Fix thinko in SLSR that caused x86 bootstrap failure

2013-05-06 Thread Richard Biener
On Sun, May 5, 2013 at 10:45 PM, Bill Schmidt wrote: > When creating a phi-adjustment along an incoming edge, where the related > argument should use the "hidden basis" directly, I created a situation > where we double-count the subsequent adjustment based on the candidate's > index. The candidat

Re: [RFA][PATCH] Fix tree-optimization/57124

2013-05-06 Thread Richard Biener
On Fri, May 3, 2013 at 10:46 PM, Jeff Law wrote: > On 05/02/2013 01:55 AM, Richard Biener wrote: >> >> On Wed, May 1, 2013 at 10:26 PM, Jeff Law wrote: >>> >>> >>> range_fits_type_p erroneously returns true in cases where the range has >>> overflowed. So for example, we might have a range [0, +I

Re: [PATCH, wwwdocs] Fix PR 50642

2013-05-06 Thread Shakthi Kannan
Hi, I am re-submitting the patch to use html.css from the update_web_docs_svn script present in the maintainer-scripts folder. The smallexample attributes are defined to use a medium font size with a light blue background for readability and clarity. 2013-05-06 Shakthi Kannan PR wwwdocs/

[ping] Introduce #pragma GCC diagnostic off

2013-05-06 Thread Eric Botcazou
It's at http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01149.html Thanks in advance. -- Eric Botcazou

Re: C++/v3 PATCH to add/throw std::bad_array_new_length

2013-05-06 Thread Florian Weimer
On 05/03/2013 10:24 PM, Jason Merrill wrote: Last year Florian fixed the compiler to detect overflow in array new size calculations and pass (size_t)-1 in that case. But C++11 specifies that in case of overflow the program throws std::bad_array_new_length (http://www.open-std.org/jtc1/sc22/wg21/

Re: [PATCH, i386]: Fix PR 57106, -fcompare-debug failure with -O2 -fschedule-insns -funroll-all-loops

2013-05-06 Thread Yuri Rumyantsev
Uros, The fix looks good to me. Best regards. Yuri. 2013/5/3 Uros Bizjak : > Hello! > > Apparently, the wrong insn is used when adding insn dependencies. The > "last" index gets updated to the found !NONDEBUG_INSN. Use "first_arg" > that points to the right insn instead. > > 2013-05-03 Uros Biz

Re: [Fortran-Dev] Update SIZE/SHAPE and extent handling

2013-05-06 Thread Tobias Burnus
Tobias Burnus wrote: Build and regtested on x86-64-gnu-linux. I intent to commit the patch soon. Committed as Rev. 198623 + merged trunk into the branch (Rev. 198624). Tobias