Re: Symtab cleanups 2/17 - merge alias code

2013-06-08 Thread Marcus Shawcroft
On 7 June 2013 20:58, Jan Hubicka hubi...@ucw.cz wrote: Hi, I have comitted the following. Does it solve your problem? Honza Index: ChangeLog === --- ChangeLog (revision 199834) +++ ChangeLog (working copy) @@ -1,3

[C++ docs patch] PR 56544

2013-06-08 Thread Paolo Carlini
Hi, the bug reminds us to update the documentation about the value of __cplusplus. I tentatively prepared the below, is it clear enough? We could probably apply something to the branch too, without the -std=c++1y bits, thus end simply like '; or @code{201103L}, per the 2011 C++ standard' or

Re: [Patch, Fortran] PR57553 - fix two STORAGE_SIZE bugs

2013-06-08 Thread Mikael Morin
Le 07/06/2013 18:11, Tobias Burnus a écrit : This patch fixes two issues: * storage_size('aa') was rejected as constant expression - as ts.u.cl-length == 0. * In trans*.c, there was a fold_convert missing (- ICE). Additionally, I have replaced the detour to generate a tree containing the

Re: *PING* / Re: [Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-06-08 Thread Mikael Morin
Hello, Le 06/06/2013 10:35, Tobias Burnus a écrit : * PING * Attached is a rediff - including the later posted additional test case (http://gcc.gnu.org/ml/fortran/2013-05/msg00141.html) On May 31, 2013 18:39, Tobias Burnus wrote: This patch adds finalization support for INTENT(out) for

Re: *PING* / Re: [Patch, Fortran] Finalize nonallocatables with INTENT(out)

2013-06-08 Thread Tobias Burnus
Hello Mikael, thanks for your patch reviews! Regarding your question: Mikael Morin worte: Le 06/06/2013 10:35, Tobias Burnus a écrit : On May 31, 2013 18:39, Tobias Burnus wrote: This patch adds finalization support for INTENT(out) for nonallocatable dummy arguments. Additionally, it

Re: [c++-concepts] code review

2013-06-08 Thread Andrew Sutton
+C++ ObjC++ Var(flag_concepts, true) This line declares flag_concepts implicitly. Ah... I see. Fixed. That's the long and short of it. Gaby suggested writing constraints here so that, for any instantiation, you would have easy access to the constraints for that declaration. I'm not sure

Re: [PATCH] DATA_ALIGNMENT vs. DATA_ABI_ALIGNMENT (PR target/56564)

2013-06-08 Thread Jakub Jelinek
On Fri, Jun 07, 2013 at 06:56:34PM -0400, Hans-Peter Nilsson wrote: criscompiler options for alignment -- systemwide or local? No, DATA_ALIGNMENT in cris.h is not intended as an ABI indication, but as an optimization when emitting data. (This was the way to do it at the time. Has

Re: [PATCH] DATA_ALIGNMENT vs. DATA_ABI_ALIGNMENT (PR target/56564)

2013-06-08 Thread Jakub Jelinek
On Fri, Jun 07, 2013 at 11:14:19PM +0200, Jakub Jelinek wrote: This structure would seem to do the wrong thing if DATA_ABI_ALIGNMENT is defined, but DATA_ALIGNMENT isn't. And while I realize you documented it, I don't like the restriction that D_A /must/ return something larger than

Re: PR57548 - Call to multiversioned function from global namespace

2013-06-08 Thread Eric Botcazou
The ICE here is because of a multi-versioned function called from global namespace and has no caller. This ICEs in target hook ix86_can_inline_p as caller is 0x0. The following simple patch attached fixes this problem. * cp/call.c (build_over_call): Check if current_function_decl

Tidy up output_constructor_bitfield

2013-06-08 Thread Eric Botcazou
The main point is to simplify the interface between output_constructor and output_constructor_bitfield, i.e. to avoid passing the outer state from the former to the latter given that only one field is read and none of them are written to. No functional changes whatsoever.

Re: [libstdc++-v3][C++14] Implement N3654 - Quoted Strings

2013-06-08 Thread Jonathan Wakely
On 6 June 2013 15:55, Ed Smith-Rowland wrote: On 06/05/2013 04:01 PM, Jonathan Wakely wrote: _Quoted_string appears to do two copies of the string, one for the constructor argument and one for the member variable, do they definitely get elided? I looks that way. But all used of the

Re: [libstdc++-v3][C++14] Implement N3654 - Quoted Strings

2013-06-08 Thread Jonathan Wakely
On 8 June 2013 04:44, Ed Smith-Rowland wrote: OK, I added a static_assert to check that _String is only reference or pointer. I also added a tests that check the case where _String is 'const basic_string'. Built and tested on x86_64-linux. OK? This is OK to commit to trunk. Thanks, Ed!

[patch] N3545 change to std::integral_constant

2013-06-08 Thread Jonathan Wakely
Another C++14 feature. * include/std/type-traits (integral_constant::operator()): Implement N3545. * testsuite/20_util/integral_constant/call_operator.cc: New. * testsuite/20_util/declval/requirements/1_neg.cc: Adjust dg-error line numbers. *

[patch] C++14: N3671 Making non-modifying sequence operations more robust

2013-06-08 Thread Jonathan Wakely
Another C++14 feature. * include/bits/stl_algo.h (is_permutation): Add overloads from N3671. * include/bits/stl_algobase.h (equal, mismatch): Likewise. * testsuite/25_algorithms/equal/1.cc: Remove duplicate test case. * testsuite/25_algorithms/equal/2.cc: New.

Re: Clean up after standard literals patch.

2013-06-08 Thread Jonathan Wakely
On 7 June 2013 15:45, Ed Smith-Rowland wrote: Greetings, Jonathan had asked if I could make some simplifications to the organization of C++ versioning macros and namespaces in my standard literals patch. I plum forgot to do it before I put in the patch. Also, I noticed I had picked up some

Re: [RFC] Implement Undefined Behavior Sanitizer (take 2)

2013-06-08 Thread Marek Polacek
Thanks for the reviews, here is another version. I haven't touched the division by zero instrumentation, but the shift instrumentation is revamped; what it should instrument now is, as Jakub wrote: 1) if ((unsigned) y precm1) ub plus for signed x y: 2) for C99/C11 if ((unsigned) x (precm1 -

[patch] Add noexcept to allocator_traits::max_size()

2013-06-08 Thread Jonathan Wakely
* include/bits/alloc_traits.h (allocator_traits::max_size()): LWG 2162: Add noexcept. Tested x86_64-linux, committed to trunk commit 10087221105c7f621a06137189c16886213c68b2 Author: Jonathan Wakely jwakely@gmail.com Date: Sat Jun 8 18:31:18 2013 +0100 *

Re: [RFC] Implement Undefined Behavior Sanitizer (take 2)

2013-06-08 Thread Marc Glisse
Hello, thanks for working on this. Just a few questions inline: On Sat, 8 Jun 2013, Marek Polacek wrote: +/* Instrument division by zero and INT_MIN / -1. */ + +tree +ubsan_instrument_division (location_t loc, enum tree_code code, + tree op0, tree op1) +{ + tree t,

Re: [RFC] Implement Undefined Behavior Sanitizer (take 2)

2013-06-08 Thread Jakub Jelinek
On Sat, Jun 08, 2013 at 07:48:27PM +0200, Marc Glisse wrote: +/* Instrument division by zero and INT_MIN / -1. */ + +tree +ubsan_instrument_division (location_t loc, enum tree_code code, + tree op0, tree op1) +{ + tree t, tt; + tree orig = build2 (code, TREE_TYPE

patch to fix PR57559 for s390

2013-06-08 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57559 The problem was in systematic discouraging reload symbol address in memory. The patch actually reverts a fix for a x86/x86-64 PR for -fpie. The patch implements another solution for this problem (see changes for

Re: RFA: Switching LRA on for s390

2013-06-08 Thread Vladimir Makarov
On 13-06-07 11:12 AM, Vladimir Makarov wrote: On 13-06-07 10:57 AM, Andreas Krebbel wrote: I've applied the attached patch. This helps me getting a little further when bootstrapping with lra and --with-arch=zEC12. 2013-06-07 Andreas Krebbel andreas.kreb...@de.ibm.com *

Re: PR57548 - Call to multiversioned function from global namespace

2013-06-08 Thread David Edelsohn
FYI, gcc/cp has it's own ChangeLog file. Yes, it is confusing that some directories have their own and others do not. - David

[committed] TILEPro atomics.[c,h] fixes

2013-06-08 Thread Walter Lee
This patch cleans up a few issues with atomic.h and atomic.c: remove a few glibc include files to facilitate bootstrapping, but include config.h in atomic.c. Add __extension__ where appropriate, and replace int64_t with long long. * config/tilepro/atomic.h: Don't include stdint.h or

[PATCH] Fix for PR c/57563

2013-06-08 Thread Iyer, Balaji V
Hello Everyone, Attached, please find a patch that will fix the bug reported in PR 57563. There are a couple issues that went wrong. First, in the test case, we have a double multiplied to a double. When -std=c99 flag is used, they get converted to long double. The way to fix this is to

[GOOGLE] Avoid emitting duplicated weakref

2013-06-08 Thread Dehao Chen
This patch fixes a bug when two weakref symbols are mapped to a same assembler name. Testing on going. OK for google branches if test is fine? Thanks, Dehao Index: gcc/varasm.c === --- gcc/varasm.c (revision 199844) +++

Re: [GOOGLE] Avoid emitting duplicated weakref

2013-06-08 Thread Xinliang David Li
Guard also with L_IPO_COMP_MODE as this is lipo specific. David On Sat, Jun 8, 2013 at 8:29 PM, Dehao Chen de...@google.com wrote: This patch fixes a bug when two weakref symbols are mapped to a same assembler name. Testing on going. OK for google branches if test is fine? Thanks, Dehao