Re: [C++ Patch] for c++/54537

2013-07-12 Thread Fabien Chêne
Hi, 2013/5/23 Jason Merrill ja...@redhat.com On 05/22/2013 04:53 PM, Fabien Chêne wrote: Ah, I see, it works. Then we end up with three solutions: 1) remove the pow(double,double) overload 2) add a specialization template pow(double,double) 3) add an extern C declaration to refer to the C

[Patch, AArch64] Support AdvSIMD MOVI / MVNI shifting ones variant.

2013-07-12 Thread Tejas Belagod
Hi, This patch adds support for AdvSIMD MOVI/MVNI Vd.T, #imm8, MSL, #amount. OK? Thanks, Tejas Belagod ARM. Changelog: 2013-07-12 Tejas Belagod tejas.bela...@arm.com gcc/ * config/aarch64/aarch64-protos.h (aarch64_simd_immediate_valid_for_move): Remove. *

Re: [Patch, AArch64] Support AdvSIMD MOVI / MVNI shifting ones variant.

2013-07-12 Thread Marcus Shawcroft
On 12/07/13 11:25, Tejas Belagod wrote: Hi, This patch adds support for AdvSIMD MOVI/MVNI Vd.T, #imm8, MSL, #amount. OK? Thanks, Tejas Belagod ARM. Changelog: 2013-07-12 Tejas Belagod tejas.bela...@arm.com gcc/ * config/aarch64/aarch64-protos.h

Re: [testsuite, android] Disabling thread_local4.C and thread_local4g.C for Android.

2013-07-12 Thread Alexander Ivchenko
*ping* Thank you, Alexander 2013/6/20 Alexander Ivchenko aivch...@gmail.com: Hi, for Android: FAIL: g++.dg/tls/thread_local4.C -std=gnu++11 (test for excess errors) Excess errors: /gcc/testsuite/g++.dg/tls/thread_local4.C:31:26: error: 'pthread_testcancel' was not declared in this scope

Fix PR57886, invalid folding of conversion

2013-07-12 Thread Michael Matz
Hi, GCC happily transforms (float)-z into -(float)z, even when z is of unsigned type (when it's larger than float). That's wrong (the result should always be positive, because -z is). It seems to me that this bug exists in all reasonably recent GCC versions. The checking in convert_to_real

Re: Fix PR57886, invalid folding of conversion

2013-07-12 Thread Michael Matz
Hi, On Fri, 12 Jul 2013, Michael Matz wrote: Hi, GCC happily transforms (float)-z into -(float)z, even when z is of unsigned type (when it's larger than float). That's wrong (the result should always be positive, because -z is). It seems to me that this bug exists in all reasonably

Re: Fix PR57886, invalid folding of conversion

2013-07-12 Thread Jakub Jelinek
On Fri, Jul 12, 2013 at 03:37:44PM +0200, Michael Matz wrote: So, this is a dup of PR55771, I'm now proposing to add a test for FLOAT_TYPE_P, not TYPE_UNSIGNED. Restarted the regstrap. Ok if it passes bootstrap/regtest. I'd say we should apply it to 4.8 too, while it might not be a

Re: Fix PR57886, invalid folding of conversion

2013-07-12 Thread Marc Glisse
On Fri, 12 Jul 2013, Michael Matz wrote: GCC happily transforms (float)-z into -(float)z, even when z is of unsigned type (when it's larger than float). That's wrong (the result should always be positive, because -z is). It seems to me that this bug exists in all reasonably recent GCC

Call GNU ld with -O*

2013-07-12 Thread Marc Glisse
Hello, this patch makes the driver pass -O2 to GNU ld if gcc was called with -O3 (or more), -Ofast or -Os. Is there a cleaner way to test (optimize 2 || optimize_size) in the driver? I did a bootstrap on x86_64-unknown-linux-gnu and then manually tested by looking at the -v output. I

Re: Fix PR middle-end/57370

2013-07-12 Thread Easwaran Raman
Ping. On Thu, Jun 27, 2013 at 10:15 AM, Easwaran Raman era...@google.com wrote: A newly generated statement in build_and_add_sum function of tree-ssa-reassoc.c has to be assigned the UID of its adjacent statement. In one instance, it was assigned the wrong uid (of an earlier phi statement)

Re: Call GNU ld with -O*

2013-07-12 Thread Jakub Jelinek
On Fri, Jul 12, 2013 at 04:54:21PM +0200, Marc Glisse wrote: +/* GNU ld has -O1 and gold -O2, but we only pass it with -O3, -Os or -Ofast. */ +#ifndef LINK_OPT_SPEC +#if HAVE_GNU_LD +#define LINK_OPT_SPEC %{O*:%{!O0:%{!O1:%{!O2:%{!Og:%{!O:-O2}} Wouldn't something like

Re: FW: [PATCH GCC]Relax the probability condition in CE pass when optimizing for code size

2013-07-12 Thread Eric Botcazou
2013-07-12 Bin Cheng bin.ch...@arm.com * ifcvt.c (ifcvt_after_combine): New static variable. (cheap_bb_rtx_cost_p): Set scale to REG_BR_PROB_BASE when optimizing for size. (if_convert): New parameter after_combine. Set ifcvt_after_combine.

Re: Fix PR57886, invalid folding of conversion

2013-07-12 Thread Michael Matz
Hi, On Fri, 12 Jul 2013, Marc Glisse wrote: If you want to handle integers, shouldn't you test TYPE_OVERFLOW_UNDEFINED (for LONG_MIN)? Right, ... FLOAT_TYPE_P does seem safer indeed. ... hence this is it now. I'd replace TREE_TYPE (expr) with itype on the next line, it is confusing to

Re: Call GNU ld with -O*

2013-07-12 Thread Marc Glisse
On Fri, 12 Jul 2013, Jakub Jelinek wrote: On Fri, Jul 12, 2013 at 04:54:21PM +0200, Marc Glisse wrote: +/* GNU ld has -O1 and gold -O2, but we only pass it with -O3, -Os or -Ofast. */ +#ifndef LINK_OPT_SPEC +#if HAVE_GNU_LD +#define LINK_OPT_SPEC %{O*:%{!O0:%{!O1:%{!O2:%{!Og:%{!O:-O2}}

Re: Call GNU ld with -O*

2013-07-12 Thread Jakub Jelinek
On Fri, Jul 12, 2013 at 06:12:26PM +0200, Marc Glisse wrote: On Fri, 12 Jul 2013, Jakub Jelinek wrote: On Fri, Jul 12, 2013 at 04:54:21PM +0200, Marc Glisse wrote: +/* GNU ld has -O1 and gold -O2, but we only pass it with -O3, -Os or -Ofast. */ +#ifndef LINK_OPT_SPEC +#if HAVE_GNU_LD

Re: Call GNU ld with -O*

2013-07-12 Thread Thomas Schwinge
Hi! On Fri, 12 Jul 2013 16:54:21 +0200 (CEST), Marc Glisse marc.gli...@inria.fr wrote: this patch makes the driver pass -O2 to GNU ld if gcc was called with -O3 (or more), -Ofast or -Os. I wondered about this before: why are no -O flags are passed to the (GNU) linker. What's the rationale

Re: Call GNU ld with -O*

2013-07-12 Thread Jakub Jelinek
On Fri, Jul 12, 2013 at 09:49:28AM -0700, Thomas Schwinge wrote: Hi! On Fri, 12 Jul 2013 16:54:21 +0200 (CEST), Marc Glisse marc.gli...@inria.fr wrote: this patch makes the driver pass -O2 to GNU ld if gcc was called with -O3 (or more), -Ofast or -Os. I wondered about this before:

Re: Call GNU ld with -O*

2013-07-12 Thread Marc Glisse
On Fri, 12 Jul 2013, Jakub Jelinek wrote: gcc.c has a huge comment that describes the syntax. I know, my first reflex after reading your email was to re-read that comment to understand what you had written ;-) Is the new version ok? Any tests I should do that would be more useful than

Re: Call GNU ld with -O*

2013-07-12 Thread Thomas Schwinge
Hi! On Fri, 12 Jul 2013 18:53:58 +0200, Jakub Jelinek ja...@redhat.com wrote: On Fri, Jul 12, 2013 at 09:49:28AM -0700, Thomas Schwinge wrote: On Fri, 12 Jul 2013 16:54:21 +0200 (CEST), Marc Glisse marc.gli...@inria.fr wrote: this patch makes the driver pass -O2 to GNU ld if gcc was

Re: Call GNU ld with -O*

2013-07-12 Thread Ian Lance Taylor
On Fri, Jul 12, 2013 at 7:54 AM, Marc Glisse marc.gli...@inria.fr wrote: this patch makes the driver pass -O2 to GNU ld if gcc was called with -O3 (or more), -Ofast or -Os. I don't understand why that is a good idea. The linker -O option is only distantly related to the compiler -O option.

Re: Call GNU ld with -O*

2013-07-12 Thread Marc Glisse
On Fri, 12 Jul 2013, Ian Lance Taylor wrote: On Fri, Jul 12, 2013 at 7:54 AM, Marc Glisse marc.gli...@inria.fr wrote: this patch makes the driver pass -O2 to GNU ld if gcc was called with -O3 (or more), -Ofast or -Os. I don't understand why that is a good idea. Well, you thought it was 3

[PATCH, AArch64] Add vabs_s64 intrinsic

2013-07-12 Thread Ian Bolton
This patch implements the following intrinsic: int64x1_t vabs_s64 (int64x1 a) It uses __builtin_llabs(), which will lead to abs Dn, Dm being generated for this now that my other patch has been committed. Test case added to scalar_intrinsics.c. OK for trunk? Cheers, Ian 2013-07-12 Ian

Re: RFC: Add of type-demotion pass

2013-07-12 Thread Marc Glisse
On Tue, 9 Jul 2013, Kai Tietz wrote: I would be glad if you could give me a couple hints. I try. Thanks :-) I wonder why you implemented this as a separate pass instead of adding it to tree-ssa-forwprop. demote_cast is (or should be) a special case of combine_conversions, so it would be

Re: [c++-concepts] requires expressions

2013-07-12 Thread Jason Merrill
On 07/11/2013 02:59 PM, Andrew Sutton wrote: pp_cxx_requirement_parameter_list (cxx_pretty_printer *pp, tree t) This should be merged with pp_cxx_parameter_declaration_clause. +reqparms_to_string (tree p) And this should have a more generic name. + // requries clause. requires +

Re: Call GNU ld with -O*

2013-07-12 Thread Ian Lance Taylor
On Fri, Jul 12, 2013 at 11:21 AM, Marc Glisse marc.gli...@inria.fr wrote: On Fri, 12 Jul 2013, Ian Lance Taylor wrote: On Fri, Jul 12, 2013 at 7:54 AM, Marc Glisse marc.gli...@inria.fr wrote: this patch makes the driver pass -O2 to GNU ld if gcc was called with -O3 (or more), -Ofast or -Os.

Re: Call GNU ld with -O*

2013-07-12 Thread Jakub Jelinek
On Fri, Jul 12, 2013 at 12:25:16PM -0700, Ian Lance Taylor wrote: For gold I think it has two effects. If you use compressed debug sections, it will compress them with zlib level 9 rather than 1. If Marc's patch enabled it only for -O3/-Ofast (which are already compile time expensive options,

Re: Call GNU ld with -O*

2013-07-12 Thread Ian Lance Taylor
On Fri, Jul 12, 2013 at 12:30 PM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Jul 12, 2013 at 12:25:16PM -0700, Ian Lance Taylor wrote: For gold I think it has two effects. If you use compressed debug sections, it will compress them with zlib level 9 rather than 1. If Marc's patch enabled

Re: [C++ Patch] for c++/54537

2013-07-12 Thread Paolo Carlini
Hi, Fabien Chêne fabien.ch...@gmail.com ha scritto: Then, It seems to me that such a change should ideally go in a separate patch. Yes. Frankly I thought it was already clear that for the purpose of fixing this c++ issue we weren't inventing anything new in the library. Just in case isn't

Re: Call GNU ld with -O*

2013-07-12 Thread Marc Glisse
On Fri, 12 Jul 2013, Ian Lance Taylor wrote: On Fri, Jul 12, 2013 at 12:30 PM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Jul 12, 2013 at 12:25:16PM -0700, Ian Lance Taylor wrote: For gold I think it has two effects. If you use compressed debug sections, it will compress them with zlib

[patch, fortran] PR 52669, warn about unused PRIVATE module variables

2013-07-12 Thread Thomas Koenig
Hello world, here is a rather self-evident patch for PR 52669. Regression-tested. OK for trunk? Thomas 2013-07-12 Thomas Koenig tkoe...@gcc.gnu.org PR fortran/52669 * trans-decl.c (gfc_create_module_variable): Optionally warn about private module variable

[committed] mips_expand_call: Remove empty statement

2013-07-12 Thread Maciej W. Rozycki
Hi, Committed as obvious. 2013-07-12 Maciej W. Rozycki ma...@codesourcery.com gcc/ * config/mips/mips.c (mips_expand_call): Remove empty statement. Maciej gcc-mips-expand-call-syntax.patch Index: gcc-fsf-trunk-quilt/gcc/config/mips/mips.c

[sso] Merge from trunk @200927

2013-07-12 Thread Eric Botcazou
Bootstrapped/regtested on x86_64-suse-linux, applied on the branch. -- Eric Botcazou

Fix GCC bug causing bootstrap failure with vectorizer turned on

2013-07-12 Thread Cong Hou
GCC bootstrap failed with loop vectorizer turned on by default at O2. The symptom is that the comparison between stage23 compilers fails. The root cause is a bug in the file tree-vect-data-refs.c, where a qsort() function call is used to sort a group of data references using a comparison function

[PATCH] Fix for PR57698

2013-07-12 Thread Sriraman Tallam
Patch attached to fix this: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57698 Here is what is going on. In rev. 200179, this change to tree-inline.c Index: tree-inline.c === --- tree-inline.c (revision 200178) +++

Re: RFA: Fix rtl-optimization/57425 (SPEC perl problem on MIPS)

2013-07-12 Thread Steve Ellcey
Joern, Has anyone reported any problems to you about this patch? I am running into a problem running the perl benchmark from SPEC2006 and I have tracked it down to this June 16 patch (SVN 200133, GIT ddba76b84c757d93b4247713d558724776149b62). I am building a GCC cross compiler running on x86

Re: [testsuite, android] Disabling thread_local4.C and thread_local4g.C for Android.

2013-07-12 Thread Mike Stump
On Jun 20, 2013, at 4:30 AM, Alexander Ivchenko aivch...@gmail.com wrote: for Android: +2013-06-19 Alexander Ivchenko alexander.ivche...@intel.com + + * g++.dg/tls/thread_local4.C: Disable test for Android. + * g++.dg/tls/thread_local4g.C: Ditto. is it ok for trunk? Ok.

Re: [Patch, microblaze]: Add TARGET_ASM_OUTPUT_MI_THUNK to support varargs thunk

2013-07-12 Thread Michael Eager
On 03/18/13 05:49, David Holsgrove wrote: Changelog 2013-03-18 David Holsgrove david.holsgr...@xilinx.com * gcc/config/microblaze/microblaze.c: Add microblaze_asm_output_mi_thunk and define TARGET_ASM_OUTPUT_MI_THUNK and TARGET_ASM_CAN_OUTPUT_MI_THUNK Sorry it has taken so long to

Re: [patch, fortran] PR 52669, warn about unused PRIVATE module variables

2013-07-12 Thread Tobias Burnus
Am 12.07.2013 23:07, Thomas Koenig wrote: here is a rather self-evident patch for PR 52669. Regression-tested. OK for trunk? I think you should also handle: module m private integer :: k end module m and module m2 integer :: ll end module m2 when compiled with