Re: [patch, mips] Fix for loongson prefetching and -mabi=32

2013-08-13 Thread Richard Sandiford
Steve Ellcey sell...@mips.com writes: diff --git a/gcc/config/mips/mips.md b/gcc/config/mips/mips.md index 397c40a..ad03040 100644 --- a/gcc/config/mips/mips.md +++ b/gcc/config/mips/mips.md @@ -6674,7 +6674,10 @@ { if (TARGET_LOONGSON_2EF || TARGET_LOONGSON_3A) /* Loongson 2[ef]

[PATCH] Fix asan ICE with strlen instrumentation (PR sanitizer/56417)

2013-08-13 Thread Jakub Jelinek
Hi! On the following (nonsensical) testcase we ICE because of pointer type mismatch. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/4.8? 2013-08-13 Jakub Jelinek ja...@redhat.com PR sanitizer/56417 * asan.c (instrument_strlen_call): Fix typo

[PATCH] Fix ICE with MEM_REF clobbers with anonymous SSA_NAME (PR tree-optimization/57661)

2013-08-13 Thread Jakub Jelinek
Hi! On the following testcase we ICE because we have an indirect (MEM_REF) clobber stmt that uses anonymous SSA_NAME. ipa-split.c (intentionally) ignores clobber stmts because they don't result in executable code, but that can lead into clobber stmts mentioning SSA_NAMEs that aren't initialized.

Re: [PATCH] Possible fix for PR57717 (PowerPC E500v2)

2013-08-13 Thread Julian Brown
On Mon, 12 Aug 2013 12:04:45 -0400 David Edelsohn dje@gmail.com wrote: * config/rs6000/rs6000.c (rs6000_legitimize_reload_address): Don't perform invalid legitimization on greater-than-word-size modes for TARGET_E500_DOUBLE. Disabling greater-than-word-size for E500v2

Re: [PATCH] Fix PR57980

2013-08-13 Thread Jakub Jelinek
On Mon, Aug 12, 2013 at 10:56:44AM +0200, Marek Polacek wrote: On Fri, Aug 09, 2013 at 08:40:00PM +0200, Richard Biener wrote: Marek Polacek pola...@redhat.com wrote: In this PR the problem was that when dealing with the gimple assign in the tailcall optimization, we, when the rhs operand

[Ada] Fix wrong code generated for packed array and pragma Shared

2013-08-13 Thread Eric Botcazou
This is a rather unusual situation where a pragma Shared is put on a packed array. In this case, we generate wrong code for array accesses on BE targets. Tested on x86_64-suse-linux, applied on the mainline. 2013-08-13 Eric Botcazou ebotca...@adacore.com * gcc-interface/utils2.c

Re: [PATCH] Fix PR57980

2013-08-13 Thread Jakub Jelinek
On Tue, Aug 13, 2013 at 12:24:59PM +0200, Jakub Jelinek wrote: On Mon, Aug 12, 2013 at 10:56:44AM +0200, Marek Polacek wrote: On Fri, Aug 09, 2013 at 08:40:00PM +0200, Richard Biener wrote: Marek Polacek pola...@redhat.com wrote: In this PR the problem was that when dealing with the

Re: [PATCH] Fix asan ICE with strlen instrumentation (PR sanitizer/56417)

2013-08-13 Thread Dodji Seketeli
Jakub Jelinek ja...@redhat.com writes: Hi! On the following (nonsensical) testcase we ICE because of pointer type mismatch. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/4.8? 2013-08-13 Jakub Jelinek ja...@redhat.com PR sanitizer/56417

Re: [PATCH] Fix for PR c/57490

2013-08-13 Thread Rainer Orth
Hi Iyer, First off, my sincerest apologies for letting this bug slip the cracks. I am attaching a patch that seem to work fine with the .i file that you have submitted in bugzilla for both C and C++. Please let me know if this fix works for you and if it is OK for trunk. thanks for the

Re: [PATCH] Fix PR57980

2013-08-13 Thread Marek Polacek
On Tue, Aug 13, 2013 at 12:24:59PM +0200, Jakub Jelinek wrote: On Mon, Aug 12, 2013 at 10:56:44AM +0200, Marek Polacek wrote: On Fri, Aug 09, 2013 at 08:40:00PM +0200, Richard Biener wrote: Marek Polacek pola...@redhat.com wrote: In this PR the problem was that when dealing with the

Re: [PATCH] Fix PR57980

2013-08-13 Thread Jakub Jelinek
On Tue, Aug 13, 2013 at 01:51:27PM +0200, Marek Polacek wrote: Sure. Ok to apply this one if it passes regtesting? Yes, thanks. 2013-08-13 Marek Polacek pola...@redhat.com Jakub Jelinek ja...@redhat.com PR tree-optimization/57980 * tree-tailcall.c

Re: [PATCH] Fix PR57980

2013-08-13 Thread Marek Polacek
On Tue, Aug 13, 2013 at 12:27:26PM +0200, Jakub Jelinek wrote: Also, for the testcase, typedef int V __attribute__ ((vector_size (sizeof (int; looks weird, that is one element vector, can you use 2 * sizeof (int) instead and add -w to dg-options (for the various -Wpsabi warnings)? Ok,

[PATCH] Quash undefined behavior in ipa-inline-analysis.c

2013-08-13 Thread Marek Polacek
When doing bootstrap with -fsanitize=undefined, I noticed undefined behavior in this file. We basically do 1 32, since NUM_CONDITIONS is #defined to 32, which is not defined. I admit I didn't followed the algorithm at all, but this patch passed bootstrap + regtesting on x86_64-linux. So, ok

Re: [PATCH] [ARM] Fix PR57909 : ICE with internal memcpy and -mno-unaligned-access

2013-08-13 Thread Yvan Roux
Ping. On 23 July 2013 16:18, Yvan Roux yvan.r...@linaro.org wrote: Hi, I forgot to add the test case with the PR fix, the attached patch add it. Thanks, Yvan ChangeLog gcc/testsuite 2013-07-23 Yvan Roux yvan.r...@linaro.org PR target/57909 *

Re: [PATCH 1/3] Support lambda templates.

2013-08-13 Thread Jason Merrill
On 08/12/2013 07:52 PM, Adam Butcher wrote: Presumably with pedwarn it would need to be relaxed to simply accepted with -std=c++1y or -std=gnu++1y for all? Yes. flag_iso was the only thing I could find to discriminate between gnu++1y and c++1y? Right, we don't make that distinction for

Re: Backport from trune:

2013-08-13 Thread Jakub Jelinek
On Mon, Aug 12, 2013 at 01:01:46PM +0100, Andrew Haley wrote: I think this one is obvious/trivial, but I'll ask anyway. OK? To 4.8? Sure. 2013-08-12 Andrew Haley a...@redhat.com Backport from mainline: * 2013-07-11 Andreas Schwab sch...@suse.de *

RE: [PATCH] Fix for PR c/57490

2013-08-13 Thread Iyer, Balaji V
-Original Message- From: Rainer Orth [mailto:r...@cebitec.uni-bielefeld.de] Sent: Tuesday, August 13, 2013 7:18 AM To: Iyer, Balaji V Cc: Jakub Jelinek; gcc-patches@gcc.gnu.org; Marek Polacek (pola...@redhat.com) Subject: Re: [PATCH] Fix for PR c/57490 Hi Iyer, First

[PATCH] MIPS: IEEE 754-2008 feature testing escape fixes

2013-08-13 Thread Maciej W. Rozycki
Hi, I have realised a double escape is required in scan-assembler patterns for special characters to match literally. Additionally I've noticed a couple escapes missing altogether. There are no regressions with the mips-linux-gnu target and the change below. OK to apply? 2013-08-13

Re: MIPS tests (nan-legacy.c and nans-legacy.c) failing

2013-08-13 Thread Maciej W. Rozycki
On Wed, 7 Aug 2013, Richard Sandiford wrote: When I run two of your new tests in gcc.target/mips (nan-legacy.c and nans-legacy.c), they are failing because my GCC is putting out .word 4294967295 instead of .word -1 like the test is expecting. I believe they

Re: [PATCH] Fix for PR c/57490

2013-08-13 Thread Rainer Orth
Hi Iyer, thanks for the patch. I've just bootstrapped it on i386-pc-solaris2.10 and all an- if.c failures are gone. That said, I wonder why we need the separate pr57490.c testcase, which is practically a preprocessed version of an-if.c with the HAVE_IO code removed. Well, it has assert

RE: [PATCH] Fix for PR c/57490

2013-08-13 Thread Iyer, Balaji V
-Original Message- From: Rainer Orth [mailto:r...@cebitec.uni-bielefeld.de] Sent: Tuesday, August 13, 2013 9:38 AM To: Iyer, Balaji V Cc: Jakub Jelinek; gcc-patches@gcc.gnu.org; Marek Polacek (pola...@redhat.com) Subject: Re: [PATCH] Fix for PR c/57490 Hi Iyer, thanks for

[RFC] MULTILIB_COMPATIBLE option support in multilib

2013-08-13 Thread Ilya Enkovich
Hi, I'm trying to have a possibility to dynamically choose between compatible multilibs (see thread http://gcc.gnu.org/ml/gcc/2013-08/msg00114.html) if preferred one is missing. It would allow me to configure MPX binaries to link with MPX library if such library exists and use non-MPX library

Re: [wwwdocs] Add link to @gnutools on Twitter

2013-08-13 Thread David Edelsohn
On Mon, Aug 12, 2013 at 8:49 PM, Gerald Pfeifer ger...@pfeifer.com wrote: Does this also deserve a news post? I certainly found it to be interesting news! Sure. Want to add one, David? I am adding the following to News: diff -c -p -r1.888 index.html *** index.html 12 Aug 2013 00:01:45

Re: [PATCH] MIPS/libgcc: Avoid the PLT in MIPS16 stub calls

2013-08-13 Thread Maciej W. Rozycki
On Wed, 7 Aug 2013, Richard Sandiford wrote: BTW, what's the Check for MicroMIPS support. note seen in the config.host piece of the patch referring to? No idea, please remove it. I have committed the change below. 2013-08-13 Maciej W. Rozycki ma...@codesourcery.com libgcc/

RE: [PATCH][ARM] FAIL: gcc.target/arm/pr58041.c scan-assembler ldrb

2013-08-13 Thread Kyrylo Tkachov
On 08/09/13 11:01, Julian Brown wrote: On Thu, 8 Aug 2013 15:44:17 +0100 Kyrylo Tkachov kyrylo.tkac...@arm.com wrote: Hi all, The recently added gcc.target/arm/pr58041.c test exposed a bug in the backend. When compiling for NEON and with -mno-unaligned-access we end up

Re: [PATCH] Fix ICE with MEM_REF clobbers with anonymous SSA_NAME (PR tree-optimization/57661)

2013-08-13 Thread Richard Biener
Jakub Jelinek ja...@redhat.com wrote: Hi! On the following testcase we ICE because we have an indirect (MEM_REF) clobber stmt that uses anonymous SSA_NAME. ipa-split.c (intentionally) ignores clobber stmts because they don't result in executable code, but that can lead into clobber stmts

Re: [PATCH][ARM] FAIL: gcc.target/arm/pr58041.c scan-assembler ldrb

2013-08-13 Thread Ramana Radhakrishnan
On 08/13/13 15:57, Kyrylo Tkachov wrote: On 08/09/13 11:01, Julian Brown wrote: On Thu, 8 Aug 2013 15:44:17 +0100 Kyrylo Tkachov kyrylo.tkac...@arm.com wrote: Hi all, The recently added gcc.target/arm/pr58041.c test exposed a bug in the backend. When compiling for NEON and with

[Ada] Fix wrong number of iterations for specific loop

2013-08-13 Thread Eric Botcazou
This is a regression present on all the active branches. The compiler generates code that doesn't execute the expected number of iterations for a loop with a dynamic upper bound whose value is exactly the upper bound of the base index type and is obtained through a narrowing conversion.

Re: [PATCH] Fix the bug to check if lookup_stmt_eh_lp returns positive instead of non-zero

2013-08-13 Thread Dehao Chen
ping ^3 Thanks, Dehao On Fri, Jul 26, 2013 at 6:15 PM, Dehao Chen de...@google.com wrote: ping^2 Thanks, Dehao On Tue, Jul 16, 2013 at 5:40 PM, Dehao Chen de...@google.com wrote: ping... Thanks, Dehao On Mon, Jul 8, 2013 at 5:55 PM, Dehao Chen de...@google.com wrote: In

Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv

2013-08-13 Thread Caroline Tice
On Mon, Aug 12, 2013 at 10:07 AM, Caroline Tice cmt...@google.com wrote: On Mon, Aug 12, 2013 at 4:15 AM, Florian Weimer fwei...@redhat.com wrote: On 08/12/2013 12:39 AM, Caroline Tice wrote: On Sun, Aug 11, 2013 at 1:04 PM, Florian Weimer fwei...@redhat.com wrote: On 08/11/2013 01:08 AM,

backported patch for PR57459 into gcc-4_8-branch

2013-08-13 Thread Vladimir Makarov
The following patch has been backported into gcc-4_8-branch. The patch was successfully tested and bootstrapped on x86/x86-64. Committed as rev. 201695. 2013-08-13 Vladimir Makarov vmaka...@redhat.com Backport from mainline 2013-06-06 Vladimir Makarov vmaka...@redhat.com

Vtable verification - configure enable flags

2013-08-13 Thread Caroline Tice
Starting a new thread, based on the discussion from [PATCH/Merge Request] Vtable Verification feature I would like to start a new thread to discuss some of the issues here (see snip from old thread below). On Thu, Aug 8, 2013 at 4:01 PM, Joseph S. Myers jos...@codesourcery.com wrote: On Thu, 8

Re: MIPS tests (nan-legacy.c and nans-legacy.c) failing

2013-08-13 Thread Steve Ellcey
On Tue, 2013-08-13 at 14:28 +0100, Maciej W. Rozycki wrote: This has passed mips-linux-gnu regression testing on a 32-bit host, but I can't regression-test a 64-bit host easily -- Steve, can you please verify that this change indeed works for you? Richard, OK to apply assuming that it

Re: [PATCH] MIPS: IEEE 754-2008 feature testing escape fixes

2013-08-13 Thread Richard Sandiford
Maciej W. Rozycki ma...@codesourcery.com writes: 2013-08-13 Maciej W. Rozycki ma...@codesourcery.com gcc/testsuite/ * gcc.target/mips/fabs-2008.c: Correct scan-assembler pattern escapes. * gcc.target/mips/fabs-legacy.c: Likewise. *

Re: MIPS tests (nan-legacy.c and nans-legacy.c) failing

2013-08-13 Thread Richard Sandiford
Maciej W. Rozycki ma...@codesourcery.com writes: I've had a look now and that is related to the width of `long' on the host -- encode_ieee_double returns its output 32-bit bit patterns in a buffer of signed longs. The arithmetic value of these patterns therefore depends on whether the

Re: [PATCH] S/390: Hardware transactional memory support

2013-08-13 Thread Jakub Jelinek
On Fri, Aug 02, 2013 at 11:05:33AM -1000, Richard Henderson wrote: On 08/02/2013 04:45 AM, Andreas Krebbel wrote: ! XCFLAGS=${XCFLAGS} -mzarch -mhtm -msoft-float Not good, since _ITM_R{F,D,E,CF,CD,CE} should return values in floating point registers; similarly for the write accessors.

patch to fix a typo in ira.c

2013-08-13 Thread Vladimir Makarov
Xingxing Pan found a typo in IRA code. Here is the patch to fix it. The patch was bootstrapped on x86/x86-64. I did not find code generation difference on x86/x86-64, s390, ppc, and arm on variety tests. The code might make some small difference on other targets though. Committed as rev.

Re: [PATCH] S/390: Hardware transactional memory support

2013-08-13 Thread Richard Henderson
On 08/13/2013 11:26 AM, Jakub Jelinek wrote: On Fri, Aug 02, 2013 at 11:05:33AM -1000, Richard Henderson wrote: On 08/02/2013 04:45 AM, Andreas Krebbel wrote: ! XCFLAGS=${XCFLAGS} -mzarch -mhtm -msoft-float Not good, since _ITM_R{F,D,E,CF,CD,CE} should return values in floating point

[Ada] Fix ICE on VMS valued procedure

2013-08-13 Thread Eric Botcazou
This fixes an ICE on a call to a valued procedure that takes a converted integer as actual parameter passed by reference. Tested on x86_64-suse-linux, applied on the mainline. 2013-08-13 Eric Botcazou ebotca...@adacore.com * gcc-interface/trans.c (Call_to_gnu): Deal with specific

[PATCH] -mcmodel=large -fpic TLS GD and LD support gcc + binutils (PR target/58067)

2013-08-13 Thread Jakub Jelinek
Hi! We right now ICE with -mcmodel=large -fpic on x86_64 on TLS GD and LD sequences, because obviously we can't call __tls_get_addr@plt there from code potentially more than 2GB away from the PLT slot. The attached patches add support for that in gcc and also teaches linker about those, because

[Ada] Clear column information on EH cleanup cond branch instructions

2013-08-13 Thread Eric Botcazou
This change ensures that conditional branch instructions that are generated as part of the exception handling circuitry for cleanup actions are marked specially, more precisely by clearing the column number. This makes it possible for coverage analysis tools to properly ignore them, and ensures

[PATCH] x86_64 -mcmodel={medium,large} -fpic address delegitimization

2013-08-13 Thread Jakub Jelinek
Hi! On x86_64 with -mcmodel=large -fpic -g -O2 we get tons of notes about non-delegitimized unspecs like UNSPEC_GOTOFF, UNSPEC_PLTOFF or UNSPEC_GOT. Seems we already handle most of those properly for -m32 code, so the issue is just that we wouldn't fall back into the -m32 handling code which

[Ada] Minor cleanup

2013-08-13 Thread Eric Botcazou
Tested on x86_64-suse-linux, applied on the mainline. 2013-08-13 Eric Botcazou ebotca...@adacore.com * gcc-interface/decl.c (gnat_to_gnu_entity): Replace True with true. (is_cplusplus_method): Likewise, and False with false. (components_need_strict_alignment):

[Ada] Fix ICE in ASIS mode

2013-08-13 Thread Eric Botcazou
This disconnects a good chunk of the alias set circuitry in ASIS mode because it was bypassing kludges put in place for this mode specifically. Tested on x86_64-suse-linux, applied on the mainline. 2013-08-13 Eric Botcazou ebotca...@adacore.com * gcc-interface/decl.c

RE: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C

2013-08-13 Thread Iyer, Balaji V
Hi Joseph, The fixed patch and the changelogs are attached in this email(http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00758.html). I have addressed your concerns below: Thanks, Balaji V. Iyer. -Original Message- From: Joseph Myers [mailto:jos...@codesourcery.com] Sent:

[PATCH, i386]: Correct sse3_monitor and sse2_maskmovdqu patterns for Pmode != word_mode

2013-08-13 Thread Uros Bizjak
Hello! These two insns have implicit address operands, so when Pmode != word_mode (x32 with -maddress-mode=short) we have to instruct the linker to emit 0x67 address override prefix. The patch also changes *sse3_monitor pattern to emit mnemonic with implicit operands, to avoid duplicating

wide-int branch now up for public comment and review

2013-08-13 Thread Kenneth Zadeck
Richi and everyone else who may be interested, Congrats on your first child. They are a lot of fun, but are very high maintenence. Today we put up the wide-int branch for all to see and play with. See svn+ssh://gcc.gnu.org/svn/gcc/branches/wide-int At this point, we have completed testing it

Re: [PATCH] MIPS: IEEE 754-2008 feature testing escape fixes

2013-08-13 Thread Maciej W. Rozycki
On Tue, 13 Aug 2013, Richard Sandiford wrote: gcc/testsuite/ * gcc.target/mips/fabs-2008.c: Correct scan-assembler pattern escapes. * gcc.target/mips/fabs-legacy.c: Likewise. * gcc.target/mips/fabsf-2008.c: Likewise. * gcc.target/mips/fabsf-legacy.c: Likewise.

Re: MIPS tests (nan-legacy.c and nans-legacy.c) failing

2013-08-13 Thread Maciej W. Rozycki
On Tue, 13 Aug 2013, Richard Sandiford wrote: I've had a look now and that is related to the width of `long' on the host -- encode_ieee_double returns its output 32-bit bit patterns in a buffer of signed longs. The arithmetic value of these patterns therefore depends on whether the

Re: [PATCH] Quash undefined behavior in ipa-inline-analysis.c

2013-08-13 Thread Jan Hubicka
When doing bootstrap with -fsanitize=undefined, I noticed undefined behavior in this file. We basically do 1 32, since NUM_CONDITIONS is #defined to 32, which is not defined. I admit I didn't followed the algorithm at all, but this patch passed bootstrap + regtesting on x86_64-linux. So,

Re: [RFC] Bare bones of virtual call tracking

2013-08-13 Thread Jan Hubicka
It might be more flexible to represent the analysis results as a type/inheritance graph -- i.e. explicitly introduce inheritance edge class to capture the interitence relationship (offset, etc) between two class nodes. The 'method' should probably be augmented to include Yep, that is general

Re: [RFC] Bare bones of virtual call tracking

2013-08-13 Thread Jan Hubicka
Jason, I introduced an warning on ODR violations (i.e. when I hot two types that are equivalent by my ODR code and have different canonical types). Unforutnately this hits a false positives on template instantiations. Here my ODR code apparently never sees the types of template parameters; just

[patch] Fix non-determinism problem with DWARF output.

2013-08-13 Thread Cary Coutant
This patch fixes a problem with -fdebug-types-section and with -gsplit-dwarf where the hash computation for the type signature and for the DW_AT_dwo_id attribute may produce results that differ from run to run. For dw_val_class_vec values (e.g., the const value of a small struct), both hash

[google] Backport fix for non-deterministic DWARF output

2013-08-13 Thread Cary Coutant
This patch is for the google/gcc-4_7 and google/gcc-4_8 branches. It fixes a problem with -fdebug-types-section and with -gsplit-dwarf where the hash computation for the type signature and for the DW_AT_dwo_id attribute may produce results that differ from run to run. For dw_val_class_vec values

[PATCH][i386]Fix PR 57756

2013-08-13 Thread Sriraman Tallam
Hi, I have attached a patch to fix PR57756. Description: The following program, __attribute__((always_inline,target(sse4.2))) __inline int callee () { return 0; } __attribute__((target(sse))) __inline int caller () { return callee(); } does not generate an error and callee is inlined

[PATCH,i386] PR58105 wrong code generation with multi-versioned functions

2013-08-13 Thread Bernd Edlinger
this patch fixes a wrong code generation issue in the i386 target, PR58105. The i386 target has a feature that is called multi-versioned functions. That is a function may have different implementations which are chosen based on the cpuid information at runtime. That is done by a resolver function

FW: [PATCH,i386] PR58105 wrong code generation with multi-versioned functions

2013-08-13 Thread Bernd Edlinger
Sorry, forgot to mention: This patch has been bootstrapped and regression tested on i686-pc-linux-gnu. this patch fixes a wrong code generation issue in the i386 target, PR58105. The i386 target has a feature that is called multi-versioned functions. That is a function may have different

[Google 4.8 dwarf] Forward port r191163 from Google 4.7

2013-08-13 Thread Sterling Augustine
I have committed the following change from Google 4.7 (which is a typo-fix) as obvious. saugustine@sterling: ~/gcc-google-4_8/gcc/gcc $ svn diff dwarf2out.c Index: dwarf2out.c === --- dwarf2out.c (revision 201717) +++ dwarf2out.c

Re: [PATCH] Update MAINTAINERS file

2013-08-13 Thread Jeff Law
On 08/10/2013 02:16 PM, Caroline Tice wrote: I would like to make the following changes to the MAINTAINERS file. May I commit this? -- Caroline Tice cmt...@google.com 2013-08-10 Caroline Tice cmt...@google.com * MAINTAINERS: Add myself as libvtv maintainer. Correct my email address in the